@sapui5/sap.fe.core 1.98.0 → 1.99.0

package/src/sap/fe/core/converters/controls/Common/table/StandardActions.ts

@@ -55,7 +55,7 @@ export type StandardActionsContext = {
 };
 
 /**
- * Generates context for the standard actions.
+ * Generates the context for the standard actions.
  *
  * @param {ConverterContext} converterContext
  * @param {NavigationSettingsConfiguration} navigationSettings
@@ -100,17 +100,13 @@ export function isExternalCreateConfigured(navigationSettings: NavigationSetting
 }
 
 /**
- * Checks if sticky or draft is supported.
+ * Checks if draft is supported.
  *
  * @param {ConverterContext} converterContext
  * @returns {boolean}
  */
-export function isDraftOrStickySupported(converterContext: ConverterContext): boolean {
+export function isDraftSupported(converterContext: ConverterContext): boolean {
 	const currentEntitySet = converterContext.getEntitySet();
-	const bIsStickySessionSupported = converterContext.getDataModelObjectPath().startingEntitySet?.annotations?.Session
-		?.StickySessionSupported
-		? true
-		: false;
 	const bIsDraftRoot = currentEntitySet && currentEntitySet.annotations?.Common?.DraftRoot ? true : false;
 	const bIsDraftNode = currentEntitySet && currentEntitySet.annotations?.Common?.DraftNode ? true : false;
 	const bIsDraftParentEntityForContainment =
@@ -120,12 +116,23 @@ export function isDraftOrStickySupported(converterContext: ConverterContext): bo
 			? true
 			: false;
 
-	return (
-		bIsDraftRoot ||
-		bIsDraftNode ||
-		bIsStickySessionSupported ||
-		(!converterContext.getEntitySet() && bIsDraftParentEntityForContainment)
-	);
+	return bIsDraftRoot || bIsDraftNode || (!converterContext.getEntitySet() && bIsDraftParentEntityForContainment);
+}
+
+/**
+ * Checks if sticky or draft is supported.
+ *
+ * @param {ConverterContext} converterContext
+ * @returns {boolean}
+ */
+export function isDraftOrStickySupported(converterContext: ConverterContext): boolean {
+	const bIsDraftSupported = isDraftSupported(converterContext);
+	const bIsStickySessionSupported = converterContext.getDataModelObjectPath().startingEntitySet?.annotations?.Session
+		?.StickySessionSupported
+		? true
+		: false;
+
+	return bIsDraftSupported || bIsStickySessionSupported;
 }
 
 /**
@@ -152,7 +159,7 @@ export function getNewAction(converterContext: ConverterContext): any {
 }
 
 /**
- * Gets binding expression for the action visibility configured into annotation.
+ * Gets the binding expression for the action visibility configured into annotation.
  *
  * @param {ConverterContext} converterContext
  * @param {string} sAnnotationTerm
@@ -177,7 +184,7 @@ export function isActionAnnotatedHidden(converterContext: ConverterContext, sAnn
 }
 
 /**
- * Gets annotated restrictions for actions.
+ * Gets the annotated restrictions for the actions.
  *
  * @param {ConverterContext} converterContext
  * @returns {StandardActionsRestrictionsType}
@@ -214,20 +221,20 @@ export function getRestrictions(converterContext: ConverterContext): StandardAct
  * Checks if templating for insert/update actions is mandatory.
  *
  * @param {StandardActionsContext} standardActionsContext
- * @param {boolean} isDraftOrStickySupported
+ * @param {boolean} isDraftOrSticky
  * @param {boolean} isCreateAlwaysHidden
  * @returns {boolean}
  */
 export function getInsertUpdateActionsTemplating(
 	standardActionsContext: StandardActionsContext,
-	isDraftOrStickySupported: boolean,
+	isDraftOrSticky: boolean,
 	isCreateAlwaysHidden: boolean
 ): boolean {
-	return (isDraftOrStickySupported || standardActionsContext.isExternalCreateConfigured) && !isCreateAlwaysHidden;
+	return (isDraftOrSticky || standardActionsContext.isExternalCreateConfigured) && !isCreateAlwaysHidden;
 }
 
 /**
- * Gets binding expressions for the properties of the action Create.
+ * Gets the binding expressions for the properties of the action Create.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -246,7 +253,7 @@ export function getStandardActionCreate(
 }
 
 /**
- * Gets binding expressions for the properties of the action Delete.
+ * Gets the binding expressions for the properties of the action Delete.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -266,50 +273,49 @@ export function getStandardActionDelete(
 }
 
 /**
- * Gets binding expressions for the properties of the action Paste.
+ * Gets the binding expressions for the properties of the action Paste.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
+ * @param {boolean} isInsertUpdateActionsTemplated
  * @returns {StandardActionConfigType}
  */
 export function getStandardActionPaste(
 	converterContext: ConverterContext,
-	standardActionsContext: StandardActionsContext
+	standardActionsContext: StandardActionsContext,
+	isInsertUpdateActionsTemplated: boolean
 ): StandardActionConfigType {
 	const createVisibility = getCreateVisibility(converterContext, standardActionsContext);
-	const pasteVisibility = getPasteVisibility(converterContext, standardActionsContext, createVisibility);
-
+	const createEnablement = getCreateEnablement(converterContext, standardActionsContext, createVisibility);
+	const pasteVisibility = getPasteVisibility(converterContext, standardActionsContext, createVisibility, isInsertUpdateActionsTemplated);
 	return {
-		isTemplated: compileBinding(getDefaultTemplating(pasteVisibility)),
 		visible: compileBinding(pasteVisibility),
-		enabled: compileBinding(pasteVisibility)
+		enabled: compileBinding(getPasteEnablement(pasteVisibility, createEnablement))
 	};
 }
 
 /**
- * Gets binding expressions for the properties of the action MassEdit.
+ * Gets the binding expressions for the properties of the action MassEdit.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
- * @param {string | undefined} selectionMode
  * @returns {StandardActionConfigType}
  */
 export function getStandardActionMassEdit(
 	converterContext: ConverterContext,
-	standardActionsContext: StandardActionsContext,
-	selectionMode: string | undefined
+	standardActionsContext: StandardActionsContext
 ): StandardActionConfigType {
-	const massEditVisibility = getMassEditVisibility(converterContext, standardActionsContext, selectionMode);
+	const massEditVisibility = getMassEditVisibility(converterContext, standardActionsContext);
 
 	return {
 		isTemplated: compileBinding(getDefaultTemplating(massEditVisibility)),
 		visible: compileBinding(massEditVisibility),
-		enabled: compileBinding(getMassEditEnablement(standardActionsContext, massEditVisibility))
+		enabled: compileBinding(getMassEditEnablement(converterContext, standardActionsContext, massEditVisibility))
 	};
 }
 
 /**
- * Gets binding expressions for the templating of the action Create.
+ * Gets the binding expression for the templating of the action Create.
  *
  * @param {StandardActionsContext} standardActionsContext
  * @param {Expression<boolean>} createVisibility
@@ -350,7 +356,7 @@ export function getCreateTemplating(
 }
 
 /**
- * Gets binding expressions for the templating of the non-Create actions.
+ * Gets the binding expression for the templating of the non-Create actions.
  *
  * @param {Expression<boolean>} actionVisibility
  * @returns {Expression<boolean> }
@@ -360,7 +366,7 @@ export function getDefaultTemplating(actionVisibility: Expression<boolean>): Exp
 }
 
 /**
- * Gets binding expressions for the property visible of the action Create.
+ * Gets the binding expression for the property visible of the action Create.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -410,7 +416,7 @@ export function getCreateVisibility(
 }
 
 /**
- * Gets binding expressions for the property visible of the action Delete.
+ * Gets the binding expression for the property visible of the action Delete.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -421,7 +427,7 @@ export function getDeleteVisibility(
 	standardActionsContext: StandardActionsContext
 ): Expression<boolean> {
 	const isDeleteHidden = standardActionsContext.hiddenAnnotation.delete;
-	const isPathDeletable = standardActionsContext.restrictions.isDeletable.expression;
+	const pathDeletableExpression = standardActionsContext.restrictions.isDeletable.expression;
 
 	//Delete Button is visible:
 	// 	 Prerequisites:
@@ -440,7 +446,7 @@ export function getDeleteVisibility(
 		or(standardActionsContext.isViewWithMultipleVisualizations, converterContext.getTemplateType() === TemplateType.AnalyticalListPage),
 		false,
 		ifElse(
-			and(isConstant(isPathDeletable), equal(isPathDeletable, false)),
+			and(isConstant(pathDeletableExpression), equal(pathDeletableExpression, false)),
 			false,
 			ifElse(
 				and(isConstant(isDeleteHidden), equal(isDeleteHidden, constant(true))),
@@ -456,22 +462,29 @@ export function getDeleteVisibility(
 }
 
 /**
- * Gets binding expressions for the property visible of the action Paste.
+ * Gets the binding expression for the property visible of the action Paste.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
  * @param {Expression<boolean>} createVisibility
+ * @param {boolean} isInsertUpdateActionsTemplated
  * @returns {Expression<boolean> }
  */
 export function getPasteVisibility(
 	converterContext: ConverterContext,
 	standardActionsContext: StandardActionsContext,
-	createVisibility: Expression<boolean>
+	createVisibility: Expression<boolean>,
+	isInsertUpdateActionsTemplated: boolean
 ): Expression<boolean> {
-	// If Create is visible, enablePaste is not disabled into manifest and we are on OP/blocks outside Fiori elements templates, button will be visible according to insertable restrictions and create visibility
+	// If Create is visible, enablePaste is not disabled into manifest and we are on OP/blocks outside Fiori elements templates
+	// Then button will be visible according to insertable restrictions and create visibility
 	// Otherwise it's not visible
 	return ifElse(
-		and(notEqual(standardActionsContext.tableManifestConfiguration.enablePaste, false), equal(createVisibility, true)),
+		and(
+			notEqual(standardActionsContext.tableManifestConfiguration.enablePaste, false),
+			createVisibility,
+			isInsertUpdateActionsTemplated
+		),
 		[TemplateType.ListReport, TemplateType.AnalyticalListPage].indexOf(converterContext.getTemplateType()) === -1 &&
 			standardActionsContext.restrictions.isInsertable.expression,
 		false
@@ -479,24 +492,23 @@ export function getPasteVisibility(
 }
 
 /**
- * Gets binding expressions for the property visible of the action MassEdit.
+ * Gets the binding expression for the property visible of the action MassEdit.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
- * @param {string | undefined} selectionMode
  * @returns {Expression<boolean> }
  */
 export function getMassEditVisibility(
 	converterContext: ConverterContext,
-	standardActionsContext: StandardActionsContext,
-	selectionMode: string | undefined
+	standardActionsContext: StandardActionsContext
 ): Expression<boolean> {
 	const isUpdateHidden = standardActionsContext.hiddenAnnotation.update,
-		isPathUpdatable = standardActionsContext.restrictions.isUpdatable.expression,
-		bMassEditEnabledInManifest: boolean = standardActionsContext.tableManifestConfiguration?.enableMassEdit || false,
-		iSelectionLimit: number = standardActionsContext.tableManifestConfiguration?.selectionLimit;
-	const bIsRelevantSelectionMode: boolean = !((selectionMode && selectionMode === "Single") || (iSelectionLimit && iSelectionLimit < 2));
-
+		pathUpdatableExpression = standardActionsContext.restrictions.isUpdatable.expression,
+		bMassEditEnabledInManifest: boolean = standardActionsContext.tableManifestConfiguration?.enableMassEdit || false;
+	const templateBindingExpression =
+		converterContext.getTemplateType() === TemplateType.ObjectPage
+			? equal(UI.IsEditable, true)
+			: converterContext.getTemplateType() === TemplateType.ListReport;
 	//MassEdit is visible
 	// If
 	//		- there is no static restrictions set to false
@@ -505,18 +517,14 @@ export function getMassEditVisibility(
 	//	Then MassEdit is always visible in LR or dynamically visible in OP according to ui>Editable and hiddenAnnotation
 	//  Button is hidden for all other cases
 	return ifElse(
-		and(not(and(isConstant(isPathUpdatable), equal(isPathUpdatable, false))), bIsRelevantSelectionMode, bMassEditEnabledInManifest),
-		ifElse(
-			converterContext.getTemplateType() === TemplateType.ObjectPage,
-			and(equal(UI.IsEditable, true), not(isUpdateHidden)),
-			converterContext.getTemplateType() === TemplateType.ListReport
-		),
+		and(not(and(isConstant(pathUpdatableExpression), equal(pathUpdatableExpression, false))), bMassEditEnabledInManifest),
+		and(templateBindingExpression, not(isUpdateHidden)),
 		false
 	);
 }
 
 /**
- * Gets binding expressions for the property enabled of the action Create.
+ * Gets the binding expression for the property enabled of the action Create.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -531,7 +539,7 @@ export function getCreateEnablement(
 	const isInsertable = standardActionsContext.restrictions.isInsertable.expression;
 	const CollectionType = converterContext.resolveAbsolutePath<any>(standardActionsContext.collectionPath).target?._type;
 	return and(
-		not(equal(createVisibility, constant(false))),
+		createVisibility,
 		ifElse(
 			CollectionType === "EntitySet",
 			true,
@@ -545,7 +553,7 @@ export function getCreateEnablement(
 }
 
 /**
- * Gets binding expressions for the property enabled of the action Delete.
+ * Gets the binding expression for the property enabled of the action Delete.
  *
  * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
@@ -565,7 +573,7 @@ export function getDeleteEnablement(
 	const numberOfUnSavedContexts = bindingExpression("unSavedContexts", "internal");
 
 	return and(
-		not(equal(deleteVisibility, constant(false))),
+		deleteVisibility,
 		ifElse(
 			or(converterContext.getTemplateType() !== TemplateType.ObjectPage, isOnlyDynamicOnCurrentEntity),
 			ifElse(
@@ -582,28 +590,66 @@ export function getDeleteEnablement(
 }
 
 /**
- * Gets binding expressions for the property enabled of the action MassEdit.
+ * Gets the binding expression for the property enabled of the action Paste.
+ *
+ * @param {Expression<boolean>} pasteVisibility
+ * @param {Expression<boolean>} createEnablement
+ * @returns {Expression<boolean> }
+ */
+export function getPasteEnablement(pasteVisibility: Expression<boolean>, createEnablement: Expression<boolean>): Expression<boolean> {
+	return and(pasteVisibility, createEnablement);
+}
+
+/**
+ * Gets the binding expression for the property enabled of the action MassEdit.
  *
+ * @param {ConverterContext} converterContext
  * @param {StandardActionsContext} standardActionsContext
  * @param {Expression<boolean>} massEditVisibility
  * @returns {Expression<boolean> }
  */
 export function getMassEditEnablement(
+	converterContext: ConverterContext,
 	standardActionsContext: StandardActionsContext,
 	massEditVisibility: Expression<boolean>
 ): Expression<boolean> {
-	const isPathUpdatable = standardActionsContext.restrictions.isUpdatable.expression;
+	const pathUpdatableExpression = standardActionsContext.restrictions.isUpdatable.expression;
 	const isOnlyDynamicOnCurrentEntity: any =
-		standardActionsContext.restrictions.isUpdatable.isOnlyCurrentEntityExpression && !isConstant(isPathUpdatable);
-	const numberOfSelectedContexts = greaterOrEqual(bindingExpression("numberOfSelectedContexts", "internal"), 2);
-	const numberOfUpdatableContexts = greaterOrEqual(length(bindingExpression("updatableContexts", "internal")), 2);
-
-	return and(
-		not(equal(massEditVisibility, constant(false))),
-		ifElse(
-			isOnlyDynamicOnCurrentEntity,
-			and(numberOfSelectedContexts, numberOfUpdatableContexts),
-			and(numberOfSelectedContexts, isPathUpdatable)
-		)
+		standardActionsContext.restrictions.isUpdatable.isOnlyCurrentEntityExpression && !isConstant(pathUpdatableExpression);
+	const numberOfSelectedContexts = greaterOrEqual(bindingExpression("numberOfSelectedContexts", "internal"), 1);
+	const numberOfUpdatableContexts = greaterOrEqual(length(bindingExpression("updatableContexts", "internal")), 1);
+	const bIsDraftSupported = isDraftSupported(converterContext);
+	const bDisplayMode = isInDisplayMode(converterContext);
+
+	// numberOfUpdatableContexts needs to be added to the binding in case
+	// 1. Update is dependent on current entity property (isOnlyDynamicOnCurrentEntity is true).
+	// 2. The table is read only and draft enabled(like LR), in this case only active contexts can be mass edited.
+	//    So, update depends on 'IsActiveEntity' value which needs to be checked runtime.
+	const runtimeBinding = ifElse(
+		or(and(bDisplayMode, bIsDraftSupported), isOnlyDynamicOnCurrentEntity),
+		and(numberOfSelectedContexts, numberOfUpdatableContexts),
+		and(numberOfSelectedContexts)
 	);
+
+	return and(massEditVisibility, ifElse(isOnlyDynamicOnCurrentEntity, runtimeBinding, and(runtimeBinding, pathUpdatableExpression)));
+}
+
+/**
+ * Tells if the table in template is in display mode.
+ *
+ * @param {ConverterContext} converterContext
+ * @param {ViewPathConfiguration} viewConfiguration
+ * @returns {boolean}
+ */
+export function isInDisplayMode(converterContext: ConverterContext, viewConfiguration?: ViewPathConfiguration): boolean {
+	const templateType = converterContext.getTemplateType();
+	if (
+		templateType === TemplateType.ListReport ||
+		templateType === TemplateType.AnalyticalListPage ||
+		(viewConfiguration && converterContext.getManifestWrapper().hasMultipleVisualizations(viewConfiguration))
+	) {
+		return true;
+	}
+	// updatable will be handled at the property level
+	return false;
 }