@sapui5/sap.fe.core 1.96.0 → 1.96.2

package/src/sap/fe/core/converters/controls/Common/Table.ts

@@ -265,18 +265,16 @@ export type VisualSettings = {
 	widthCalculation?: WidthCalculation;
 };
 
-export type WidthCalculation =
-	| null
-	| {
-			minWidth?: number;
-			maxWidth?: number;
-			defaultWidth?: number;
-			includeLabel?: boolean;
-			gap?: number;
-			// only relevant for complex types
-			excludeProperties?: string | string[];
-			verticalArrangement?: boolean;
-	  };
+export type WidthCalculation = null | {
+	minWidth?: number;
+	maxWidth?: number;
+	defaultWidth?: number;
+	includeLabel?: boolean;
+	gap?: number;
+	// only relevant for complex types
+	excludeProperties?: string | string[];
+	verticalArrangement?: boolean;
+};
 
 export type TableColumn = CustomTableColumn | AnnotationTableColumn;
 
@@ -2177,33 +2175,34 @@ export function getCreateVisible(
 				(path: string) => singletonPathVisitor(path, converterContext, [])
 		  )
 		: undefined;
-	// - If it's statically not insertable -> create is not visible
-	// - If create is statically hidden -> create is not visible
-	// - If it's an ALP template -> create is not visible
-	// -
-	// - Otherwise
-	// 	 - If the create mode is external -> create is visible
-	// 	 - If we're on the list report ->
-	// 	 	- If UI.CreateHidden points to a property path -> provide a negated binding to this path
-	// 	 	- Otherwise, create is visible
-	// 	 - Otherwise
-	// 	   - This depends on the value of the the UI.IsEditable
+	//Create Button is visible:
+
+	// 	 - If the creation mode is external
+	//      - If we're on the list report and create is not hidden
+	//		- Otherwise this depends on the value of the the UI.IsEditable
+	//   - Otherwise
+	// 	 	- If we're on the list report ->
+	// 	 		- If UI.CreateHidden points to a property path -> provide a negated binding to this path
+	// 	 		- Otherwise, create is visible
+	// 	 	- Otherwise
+	// 	  	 - This depends on the value of the the UI.IsEditable
+
 	return ifElse(
-		or(
+		creationMode === "External",
+		ifElse(
+			converterContext.getTemplateType() === TemplateType.ListReport,
+			not(isCreateHidden),
+			and(not(isCreateHidden), UI.IsEditable)
+		),
+		ifElse(
 			or(
 				equal(showCreateForNewAction, false),
-				and(isConstant(isInsertable), equal(isInsertable, false), equal(showCreateForNewAction, undefined))
-			),
-			isConstant(isCreateHidden) && equal(isCreateHidden, true),
-			or(
+				and(isConstant(isInsertable), equal(isInsertable, false), equal(showCreateForNewAction, undefined)),
+				and(isConstant(isCreateHidden), equal(isCreateHidden, true)),
 				viewConfiguration ? converterContext.getManifestWrapper().hasMultipleVisualizations(viewConfiguration) : false,
 				converterContext.getTemplateType() === TemplateType.AnalyticalListPage
-			)
-		),
-		false,
-		ifElse(
-			creationMode === "External",
-			true,
+			),
+			false,
 			ifElse(
 				converterContext.getTemplateType() === TemplateType.ListReport,
 				ifElse(isBinding(isCreateHidden), not(isCreateHidden), true),

package/src/sap/fe/core/library.js

@@ -106,7 +106,7 @@ sap.ui.define(
 			interfaces: [],
 			controls: [],
 			elements: [],
-			version: "1.96.0",
+			version: "1.96.2",
 			noLibraryCSS: true,
 			extensions: {
 				//Configuration used for rule loading of Support Assistant

package/src/sap/fe/core/messagebundle_en_US_saprigi.properties

@@ -86,8 +86,12 @@ T_MESSAGE_GROUP_TITLE_TABLE_DENOMINATOR=\u206A\u206A\u206A\u200D\u200C\u200D\u20
 
 T_MESSAGE_BUTTON_SAPFE_MESSAGE_GROUP_LAST_ACTION=\u206A\u206A\u206A\u200C\u200B\u200B\u200B\u200C\u200C\u200D\u200C\u200D\u200B\u200C\u200C\u200B\u200D\u200D\u200B\u200D\u200B\u200B\u200C\u200C\u200C\u200C\u200D\u200B\u200C\u200C\u200B\u200D\u200B\u200C\u200B\u200C\u200D\u200D\u200C\u200C\u200B\u200D\u200C\u200D\u206ALast Action\u206A\u206A
 
+T_MESSAGE_ITEM_SUBTITLE_CREATION_ROW_INDICATOR=\u206A\u206A\u206A\u200C\u200B\u200D\u200D\u200C\u200C\u200D\u200B\u200C\u200C\u200D\u200D\u200D\u200B\u200D\u200D\u200B\u200B\u200B\u200B\u200C\u200C\u200C\u200C\u200B\u200D\u200C\u200C\u200B\u200D\u200B\u200D\u200B\u200B\u200D\u200D\u200B\u200B\u200D\u200C\u200C\u206A<New>\u206A\u206A
+
 T_MESSAGE_ITEM_SUBTITLE_INDICATOR_UNKNOWN=\u206A\u206A\u206A\u200D\u200D\u200C\u200D\u200D\u200C\u200C\u200B\u200B\u200D\u200B\u200B\u200D\u200B\u200C\u200D\u200B\u200C\u200B\u200C\u200B\u200B\u200D\u200B\u200C\u200C\u200C\u200B\u200D\u200C\u200B\u200D\u200C\u200D\u200D\u200C\u200C\u200C\u200C\u200D\u206AUnknown\u206A\u206A
 
+T_COLUMN_INDICATOR_IN_TABLE_DEFINITION=\u206A\u206A\u206A\u200C\u200B\u200B\u200B\u200D\u200B\u200D\u200D\u200B\u200C\u200B\u200D\u200B\u200C\u200C\u200D\u200C\u200C\u200B\u200D\u200C\u200B\u200C\u200B\u200C\u200C\u200D\u200D\u200D\u200D\u200D\u200C\u200D\u200D\u200C\u200D\u200D\u200D\u200C\u206AHidden\u206A\u206A
+
 T_MESSAGE_ITEM_SUBTITLE=\u206A\u206A\u206A\u200D\u200D\u200C\u200D\u200B\u200D\u200B\u200B\u200D\u200B\u200B\u200B\u200D\u200B\u200B\u200B\u200B\u200B\u200C\u200D\u200C\u200B\u200C\u200D\u200D\u200C\u200D\u200D\u200D\u200D\u200D\u200B\u200D\u200C\u200D\u200D\u200C\u200D\u200C\u200D\u206ARow\: \u200B\u200B\u200B{0}\u200C\u200C\u200C, Column\: \u200B\u200B\u200B{1}\u200C\u200C\u200C\u206A\u206A
 
 C_COMMON_SAPFE_ERROR=\u206A\u206A\u206A\u200D\u200C\u200B\u200D\u200D\u200B\u200D\u200B\u200B\u200B\u200B\u200B\u200C\u200D\u200B\u200B\u200D\u200B\u200C\u200D\u200D\u200D\u200D\u200D\u200B\u200D\u200B\u200B\u200D\u200D\u200B\u200B\u200C\u200C\u200D\u200D\u200C\u200C\u206AError\u206A\u206A
@@ -221,6 +225,8 @@ C_DRAFT_EDIT_STATE_DRAFT_LOCKED_FILTER=\u206A\u206A\u206A\u200D\u200D\u200C\u200
 
 C_DRAFT_EDIT_STATE_DRAFT_UNSAVED_CHANGES_FILTER=\u206A\u206A\u206A\u200D\u200C\u200C\u200C\u200D\u200B\u200D\u200B\u200D\u200B\u200C\u200C\u200C\u200C\u200C\u200C\u200D\u200B\u200D\u200D\u200C\u200C\u200D\u200C\u200B\u200D\u200D\u200D\u200B\u200B\u200B\u200C\u200B\u200C\u200D\u200B\u200D\u200B\u200C\u200B\u206AUnsaved Changes by Another User\u206A\u206A
 
+C_DRAFT_EDIT_STATE_DRAFT_ALL_HIDING_DRAFTS_FILTER=\u206A\u206A\u206A\u200C\u200D\u200D\u200D\u200D\u200C\u200C\u200B\u200B\u200C\u200B\u200C\u200D\u200B\u200C\u200D\u200B\u200D\u200C\u200B\u200B\u200B\u200B\u200C\u200B\u200B\u200C\u200D\u200D\u200B\u200B\u200C\u200C\u200B\u200B\u200B\u200C\u200C\u200C\u200B\u206AAll (Hiding Drafts)\u206A\u206A
+
 T_COMMON_SAPFE_ACTION_SHARE=\u206A\u206A\u206A\u200C\u200D\u200C\u200D\u200D\u200C\u200B\u200B\u200D\u200D\u200D\u200B\u200D\u200B\u200D\u200D\u200B\u200B\u200B\u200C\u200D\u200B\u200C\u200B\u200C\u200C\u200D\u200C\u200B\u200B\u200D\u200D\u200B\u200B\u200C\u200B\u200D\u200C\u200C\u200D\u206AShare\u206A\u206A
 
 

package/src/sap/fe/core/services/RoutingServiceFactory.js

@@ -71,10 +71,11 @@ sap.ui.define(
 
 				this.initPromise = Promise.resolve(that);
 			},
-
-			exit: function() {
+			beforeExit: function() {
 				this.oRouter.detachRouteMatched(this._fnOnRouteMatched);
 				this.eventProvider.fireEvent("routeMatched", {});
+			},
+			exit: function() {
 				this.eventProvider.destroy();
 			},
 
@@ -113,7 +114,7 @@ sap.ui.define(
 
 					// Check route pattern: all patterns need to end with ':?query:', that we use for parameters
 					if (sRoutePattern.length < 8 || sRoutePattern.indexOf(":?query:") !== sRoutePattern.length - 8) {
-						Log.error("Pattern for route " + sRouteName + " doesn't end with ':?query:' : " + sRoutePattern);
+						Log.warning("Pattern for route " + sRouteName + " doesn't end with ':?query:' : " + sRoutePattern);
 					}
 					var iRouteLevel = that._getViewLevelFromPattern(sRoutePattern, 0);
 					that._mRoutes[sRouteName] = {
@@ -857,6 +858,31 @@ sap.ui.define(
 					});
 			},
 
+			_requestObjectsFromParameters: function(oStartUpParameters, aExternallyNavigablePages) {
+				var that = this;
+
+				// Load the respective objects for all object pages found in aExternallyNavigablePages
+				var aContextPromises = aExternallyNavigablePages.map(function(oPage) {
+					var oCompleteFilter, oListBind;
+					if (oPage.isSemanticKeyNavigation) {
+						oCompleteFilter = that._createFilter(oPage.draft, oPage.semanticKeys, oStartUpParameters);
+					} else {
+						oCompleteFilter = that._createFilter(oPage.draft, oPage.technicalKeys, oStartUpParameters);
+					}
+					// only request a minimum of fields to boost backend performance since this is only used to check if an object exists
+					oListBind = that.oModel.bindList(oPage.contextPath, undefined, undefined, oCompleteFilter, {
+						"$select": oPage.isSemanticKeyNavigation
+							? oPage.semanticKeys.map(function(key) {
+									return key.$PropertyPath;
+							  })
+							: oPage.technicalKeys
+					});
+					return oListBind.requestContexts(0, 2);
+				});
+
+				return Promise.all(aContextPromises);
+			},
+
 			_manageDeeplinkStartup: function(oStartUpParameters) {
 				var that = this,
 					aExternallyNavigablePages;
@@ -870,19 +896,7 @@ sap.ui.define(
 
 						aExternallyNavigablePages = that._findTargetPagesFromStartupParams(oLevelOfObjectPages, oStartUpParameters);
 
-						// Load the respective objects for all object pages found in the previous step
-						var aContextPromises = aExternallyNavigablePages.map(function(oPage) {
-							var oCompleteFilter, oListBind;
-							if (oPage.isSemanticKeyNavigation) {
-								oCompleteFilter = that._createFilter(oPage.draft, oPage.semanticKeys, oStartUpParameters);
-							} else {
-								oCompleteFilter = that._createFilter(oPage.draft, oPage.technicalKeys, oStartUpParameters);
-							}
-							oListBind = that.oModel.bindList(oPage.contextPath, undefined, undefined, oCompleteFilter);
-							return oListBind.requestContexts(0, 2);
-						});
-
-						return Promise.all(aContextPromises);
+						return that._requestObjectsFromParameters(oStartUpParameters, aExternallyNavigablePages);
 					})
 					.then(function(aValues) {
 						if (aValues.length) {