@sapui5/sap.fe.core 1.141.2 → 1.142.1

package/src/sap/fe/core/services/TemplatedViewServiceFactory.ts

@@ -6,6 +6,7 @@ import { resolveBindingString } from "sap/fe/base/BindingToolkit";
 import type { EnhanceWithUI5 } from "sap/fe/base/ClassSupport";
 import type AppComponent from "sap/fe/core/AppComponent";
 import type { ComponentData } from "sap/fe/core/AppComponent";
+import type { FEView } from "sap/fe/core/BaseController";
 import type { SemanticObject } from "sap/fe/core/CommonUtils";
 import CommonUtils from "sap/fe/core/CommonUtils";
 import type ResourceModel from "sap/fe/core/ResourceModel";
@@ -37,6 +38,7 @@ import { type HierachyMode as BreadcrumbsHierachyMode } from "sap/fe/macros/Brea
 import type { OverflowToolbarPriority } from "sap/m/library";
 import Device from "sap/ui/Device";
 import VersionInfo from "sap/ui/VersionInfo";
+import type Control from "sap/ui/core/Control";
 import Core from "sap/ui/core/Core";
 import type { ManifestContent, ManifestOutboundEntry, ShareOptions } from "sap/ui/core/Manifest";
 import View from "sap/ui/core/mvc/View";
@@ -102,7 +104,7 @@ export type ViewData = {
 export class TemplatedViewService extends Service<TemplatedViewServiceSettings> {
 	initPromise!: Promise<void>;
 
-	oView!: View;
+	oView!: FEView;
 
 	oResourceModelService!: ResourceModelService;
 
@@ -148,13 +150,17 @@ export class TemplatedViewService extends Service<TemplatedViewServiceSettings>
 			}
 		}
 		const sCacheIdentifier = `${oAppComponent.getMetadata().getName()}_${sStableId}_${Localization.getLanguageTag()}`;
+		const bundlesToLoad = ["sap.fe.core.messagebundle", "sap.fe.macros.messagebundle", "sap.fe.templates.messagebundle"];
+		if (oComponent._getAdditionalI18nBundles) {
+			bundlesToLoad.push(...oComponent._getAdditionalI18nBundles());
+		}
 		aServiceDependencies.push(
 			ServiceFactoryRegistry.get("sap.fe.core.services.ResourceModelService")
 				.createInstance({
 					scopeType: "component",
 					scopeObject: oComponent,
 					settings: {
-						bundles: ["sap.fe.core.messagebundle", "sap.fe.macros.messagebundle", "sap.fe.templates.messagebundle"],
+						bundles: bundlesToLoad,
 						enhanceI18n: aEnhanceI18n,
 						modelName: "sap.fe.i18n"
 					}
@@ -301,10 +307,14 @@ export class TemplatedViewService extends Service<TemplatedViewServiceSettings>
 		if (oViewSettings.preprocessors) {
 			(oViewSettings.preprocessors as Record<string, { models: Record<string, Model> }>).xml.models["error"] = new JSONModel(reason);
 		}
+		delete oViewSettings.cache;
+		oViewSettings.id += "-Error";
+		oViewSettings.viewData.stableId += "-Error";
+		delete oViewSettings.controller;
 
 		return oComponent.runAsOwner(async () => {
 			return View.create(oViewSettings).then((oView: View) => {
-				this.oView = oView;
+				this.oView = oView as FEView;
 				this.oView.setModel(new JSONModel(this.oView), "$view");
 				oComponent.setAggregation("rootControl", this.oView);
 				oComponent.getAppComponent().getRootControl().getController().getPlaceholder().hideRootPlaceholder();
@@ -333,7 +343,10 @@ export class TemplatedViewService extends Service<TemplatedViewServiceSettings>
 			oAppComponent.getRoutingService().getTargetInformationFor(oComponent)?.options?.settings?.fullContextPath ?? "";
 		if (!sFullContextPath) {
 			// if the context path couldn't be retrieved from the routing service, try to get it from the component itself
-			sFullContextPath = oComponent.getContextPath() ?? "";
+			const componentContextPath = oComponent.getContextPath();
+			if (componentContextPath) {
+				sFullContextPath = componentContextPath.endsWith("/") ? componentContextPath : `${componentContextPath}/`;
+			}
 		}
 		const oMetaModel = oAppComponent.getMetaModel();
 		const oManifestContent = oAppComponent.getManifest();
@@ -476,28 +489,78 @@ export class TemplatedViewService extends Service<TemplatedViewServiceSettings>
 				);
 			// Setting the pageModel on the component for potential reuse
 			oComponent.setModel(oPageModel as unknown as JSONModel, "_pageModel");
+			oComponent.setModel(oViewDataModel, "viewData");
+			const uiModel = oAppComponent.getModel("ui");
+			const internalModel = oAppComponent.getModel("internal") as JSONModel;
+			oComponent.setModel(uiModel, "ui");
+			oComponent.setModel(internalModel, "internal");
+			oComponent.setModel(internalModel, "pageInternal");
+			const path = `/pages/${oViewSettings.id}`;
+			uiModel.setProperty(path, {
+				controls: {}
+			});
+			internalModel.setProperty(path, {
+				controls: {},
+				collaboration: {}
+			});
+			let targetUIModelContext = "/";
+			if (oComponent.isA<Control>("sap.fe.templates.ListReport.Component")) {
+				targetUIModelContext = `/${oViewSettings.id}`;
+			}
+			oComponent.setBindingContext(uiModel.createBindingContext(targetUIModelContext), "ui");
+			oComponent.setBindingContext(internalModel.createBindingContext(path), "internal");
+
+			// for the time being provide it also pageInternal as some macros access it - to be removed
+			oComponent.setBindingContext(internalModel.createBindingContext(path), "pageInternal");
 			oComponent.setPreprocessorContext(preprocessorContext);
 			return oComponent.runAsOwner(async () => {
 				return View.create(oViewSettings)
 
 					.then((oView: View) => {
-						this.oView = oView;
+						this.oView = oView as FEView;
+
 						const viewJSONModel = new JSONModel(this.oView);
 						ModelHelper.enhanceViewJSONModel(viewJSONModel as JSONModel & { _getObject: Function });
-						this.oView.setModel(viewJSONModel, "$view");
-						this.oView.setModel(oViewDataModel, "viewData");
+						oComponent.setModel(viewJSONModel, "$view");
+
+						if (oAppComponent.hideViewDuringCreation && oComponent.isA<Control>("sap.fe.templates.ObjectPage.Component")) {
+							this.oView.setVisible(false);
+						}
+
 						oComponent.setAggregation("rootControl", this.oView);
+						if (oAppComponent.eagerViewCreation) {
+							setTimeout(() => {
+								for (const navName in mNavigation) {
+									const routingTargets = oAppComponent
+										.getRoutingService()
+										._getRouteInformation(mNavigation[navName].detail.route)?.targetsWithInfo;
+									if (routingTargets) {
+										for (const routingTarget of routingTargets) {
+											const routingTargetName =
+												typeof routingTarget === "string" ? routingTarget : routingTarget.name;
+											const routerTarget = oAppComponent.getRouter().getTarget(routingTargetName);
+											if (routerTarget && !Array.isArray(routerTarget)) {
+												(routerTarget as unknown as { load: Function }).load(routingTarget);
+											}
+										}
+									}
+								}
+							}, 2000); // Delay a bit to not block the initial rendering
+						}
+
 						return sCacheKey;
 					})
-					.catch(async (reason: Error) =>
-						this._createErrorPage(
+					.catch(async (reason: Error) => {
+						oComponent.getRootController()?.destroy();
+						oComponent.setRootController();
+						return this._createErrorPage(
 							reason,
 							oViewSettings,
 							mServiceSettings.errorViewName || "sap.fe.core.services.view.TemplatingErrorPage",
 							oComponent,
 							sCacheKey
-						)
-					)
+						);
+					})
 					.catch((e) => Log.error(e.message, e));
 			});
 		} catch (error: unknown) {