@sapui5/sap.fe.core 1.111.1 → 1.113.0

package/src/sap/fe/core/converters/controls/Common/table/StandardActions.ts

@@ -1,4 +1,5 @@
 import type { EntitySet, PropertyAnnotationValue } from "@sap-ux/vocabularies-types";
+import type { EntitySetAnnotations_UI } from "@sap-ux/vocabularies-types/vocabularies/UI_Edm";
 import tableFormatters from "sap/fe/core/formatters/TableFormatter";
 import type { BindingToolkitExpression, CompiledBindingToolkitExpression } from "sap/fe/core/helpers/BindingToolkit";
 import {
@@ -20,6 +21,7 @@ import {
 	pathInModel
 } from "sap/fe/core/helpers/BindingToolkit";
 import ModelHelper from "sap/fe/core/helpers/ModelHelper";
+import { isEntitySet, isNavigationProperty } from "sap/fe/core/helpers/TypeGuards";
 import { getTargetObjectPath, isPathDeletable, isPathInsertable, isPathUpdatable } from "sap/fe/core/templating/DataModelPathHelper";
 import type ConverterContext from "../../../ConverterContext";
 import { singletonPathVisitor, UI } from "../../../helpers/BindingHelper";
@@ -56,8 +58,8 @@ export type StandardActionsContext = {
 	isDraftOrStickySupported: boolean;
 	isViewWithMultipleVisualizations: boolean;
 	newAction?: {
-		name?: string;
-		available?: BindingToolkitExpression<boolean>;
+		name: string;
+		available: BindingToolkitExpression<boolean>;
 	};
 	tableManifestConfiguration: TableControlConfiguration;
 	restrictions: StandardActionsRestrictionsType;
@@ -118,19 +120,19 @@ export function isDraftOrStickySupported(converterContext: ConverterContext): bo
  * @param converterContext
  * @returns The new action info
  */
-export function getNewAction(converterContext: ConverterContext): any {
+export function getNewAction(converterContext: ConverterContext) {
 	const currentEntitySet = converterContext.getEntitySet();
-	const newAction = !ModelHelper.isSingleton(currentEntitySet)
-		? (currentEntitySet as EntitySet)?.annotations?.Common?.DraftRoot?.NewAction ||
-		  (currentEntitySet as EntitySet)?.annotations?.Session?.StickySessionSupported?.NewAction
+	const newAction = isEntitySet(currentEntitySet)
+		? currentEntitySet.annotations.Common?.DraftRoot?.NewAction ??
+		  currentEntitySet.annotations.Session?.StickySessionSupported?.NewAction
 		: undefined;
 	const newActionName: CompiledBindingToolkitExpression = newAction?.toString();
 	if (newActionName) {
-		let availableProperty: any = converterContext?.getEntityType().actions[newActionName]?.annotations?.Core?.OperationAvailable;
+		let availableProperty = converterContext?.getEntityType().actions[newActionName]?.annotations?.Core?.OperationAvailable?.valueOf();
 		availableProperty = availableProperty !== undefined ? availableProperty : true;
 		return {
 			name: newActionName,
-			available: getExpressionFromAnnotation(availableProperty)
+			available: getExpressionFromAnnotation<boolean>(availableProperty as unknown as PropertyAnnotationValue<boolean>)
 		};
 	}
 	return undefined;
@@ -146,7 +148,7 @@ export function getNewAction(converterContext: ConverterContext): any {
  */
 export function isActionAnnotatedHidden(
 	converterContext: ConverterContext,
-	sAnnotationTerm: string,
+	sAnnotationTerm: keyof EntitySetAnnotations_UI,
 	bWithNavigationPath = true
 ): BindingToolkitExpression<boolean> {
 	const currentEntitySet = converterContext.getEntitySet();
@@ -157,7 +159,7 @@ export function isActionAnnotatedHidden(
 			? [dataModelObjectPath.navigationProperties[dataModelObjectPath.navigationProperties.length - 1].name]
 			: [];
 	const actionAnnotationValue =
-		((currentEntitySet?.annotations.UI as any)?.[sAnnotationTerm] as PropertyAnnotationValue<boolean>) || false;
+		((currentEntitySet?.annotations.UI as EntitySetAnnotations_UI)?.[sAnnotationTerm] as PropertyAnnotationValue<boolean>) || false;
 
 	return currentEntitySet
 		? getExpressionFromAnnotation(actionAnnotationValue, visitedNavigationPaths, undefined, (path: string) =>
@@ -218,15 +220,10 @@ export function getRestrictions(converterContext: ConverterContext): StandardAct
  *
  * @param standardActionsContext
  * @param isDraftOrSticky
- * @param isCreateAlwaysHidden
- * @returns The
+ * @returns True if we need to template insert or update actions, false otherwise
  */
-export function getInsertUpdateActionsTemplating(
-	standardActionsContext: StandardActionsContext,
-	isDraftOrSticky: boolean,
-	isCreateAlwaysHidden: boolean
-): boolean {
-	return (isDraftOrSticky || standardActionsContext.creationMode === CreationMode.External) && !isCreateAlwaysHidden;
+export function getInsertUpdateActionsTemplating(standardActionsContext: StandardActionsContext, isDraftOrSticky: boolean): boolean {
+	return isDraftOrSticky || standardActionsContext.creationMode === CreationMode.External;
 }
 
 /**
@@ -559,7 +556,7 @@ export function getCreationRowEnablement(
 			const navigationProperties = converterContext.getDataModelObjectPath().navigationProperties;
 			if (navigationProperties) {
 				const lastNav = navigationProperties[navigationProperties.length - 1];
-				const partner = lastNav._type === "NavigationProperty" && lastNav.partner;
+				const partner = isNavigationProperty(lastNav) && lastNav.partner;
 				if (partner) {
 					path = `${partner}/${path}`;
 				}
@@ -597,12 +594,19 @@ export function getCreateEnablement(
 	standardActionsContext: StandardActionsContext,
 	createVisibility: BindingToolkitExpression<boolean>
 ): BindingToolkitExpression<boolean> {
+	let condition;
+	if (standardActionsContext.creationMode === CreationMode.InlineCreationRows) {
+		// for Inline creation rows create can be hidden via manifest and this should not impact its enablement
+		condition = not(standardActionsContext.hiddenAnnotation.create);
+	} else {
+		condition = createVisibility;
+	}
 	const isInsertable = standardActionsContext.restrictions.isInsertable.expression;
-	const CollectionType = converterContext.resolveAbsolutePath<any>(standardActionsContext.collectionPath).target?._type;
+	const CollectionType = converterContext.resolveAbsolutePath<EntitySet>(standardActionsContext.collectionPath).target;
 	return and(
-		createVisibility,
+		condition,
 		or(
-			CollectionType === "EntitySet",
+			isEntitySet(CollectionType),
 			and(isInsertable, or(converterContext.getTemplateType() !== TemplateType.ObjectPage, UI.IsEditable))
 		)
 	);
@@ -674,7 +678,7 @@ export function getMassEditEnablement(
 	massEditVisibility: BindingToolkitExpression<boolean>
 ): BindingToolkitExpression<boolean> {
 	const pathUpdatableExpression = standardActionsContext.restrictions.isUpdatable.expression;
-	const isOnlyDynamicOnCurrentEntity: any =
+	const isOnlyDynamicOnCurrentEntity =
 		!isConstant(pathUpdatableExpression) &&
 		standardActionsContext.restrictions.isUpdatable.navigationExpression._type === "Unresolvable";
 	const numberOfSelectedContexts = greaterOrEqual(pathInModel("numberOfSelectedContexts", "internal"), 1);