@sapui5/sap.fe.core 1.101.0 → 1.103.0

package/src/sap/fe/core/controllerextensions/KPIManagement.ts

@@ -1,23 +1,23 @@
-import ControllerExtension from "sap/ui/core/mvc/ControllerExtension";
-import { defineUI5Class, methodOverride, publicExtension } from "../helpers/ClassSupport";
-import JSONModel from "sap/ui/model/json/JSONModel";
-import ODataModel from "sap/ui/model/odata/v4/ODataModel";
-import Context from "sap/ui/model/odata/v4/Context";
 import Log from "sap/base/Log";
-import { KPIChartDefinition, KPIDefinition, NavigationInfo } from "sap/fe/core/converters/controls/Common/KPI";
-import BaseController from "sap/fe/core/BaseController";
+import type BaseController from "sap/fe/core/BaseController";
+import type { KPIChartDefinition, KPIDefinition, NavigationInfo } from "sap/fe/core/converters/controls/Common/KPI";
+import type { FilterDefinition, RangeDefinition } from "sap/fe/core/converters/helpers/SelectionVariantHelper";
 import { MessageType } from "sap/fe/core/formatters/TableFormatterTypes";
-import { FilterDefinition, RangeDefinition } from "sap/fe/core/converters/helpers/SelectionVariantHelper";
-import NumberFormat from "sap/ui/core/format/NumberFormat";
+import type GenericTag from "sap/m/GenericTag";
+import Popover from "sap/m/Popover";
+import Core from "sap/ui/core/Core";
 import DateFormat from "sap/ui/core/format/DateFormat";
+import NumberFormat from "sap/ui/core/format/NumberFormat";
 import Locale from "sap/ui/core/Locale";
+import ControllerExtension from "sap/ui/core/mvc/ControllerExtension";
 import Filter from "sap/ui/model/Filter";
-import FilterOperator from "sap/ui/model/FilterOperator";
+import type FilterOperator from "sap/ui/model/FilterOperator";
+import JSONModel from "sap/ui/model/json/JSONModel";
+import type Context from "sap/ui/model/odata/v4/Context";
+import type ODataModel from "sap/ui/model/odata/v4/ODataModel";
 import Sorter from "sap/ui/model/Sorter";
-import GenericTag from "sap/m/GenericTag";
-import Popover from "sap/m/Popover";
-import { CoreEx } from "types/extension_types";
-import Core from "sap/ui/core/Core";
+import type { CoreEx } from "types/extension_types";
+import { defineUI5Class, methodOverride, publicExtension } from "../helpers/ClassSupport";
 
 const MessageTypeFromCriticality: Record<string, MessageType> = {
 	"1": MessageType.Error,
@@ -37,9 +37,9 @@ const ValueColorFromMessageType: Record<MessageType, string> = {
 /**
  * Function to get a message state from a calculated criticality of type 'Target'.
  *
- * @param {number} kpiValue The value of the KPI to be tested against.
- * @param {number[]} aThresholds Thresholds to be used [DeviationRangeLowValue,ToleranceRangeLowValue,AcceptanceRangeLowValue,AcceptanceRangeHighValue,ToleranceRangeHighValue,DeviationRangeHighValue].
- * @returns {MessageType} Returns the corresponding MessageType
+ * @param kpiValue The value of the KPI to be tested against.
+ * @param aThresholds Thresholds to be used [DeviationRangeLowValue,ToleranceRangeLowValue,AcceptanceRangeLowValue,AcceptanceRangeHighValue,ToleranceRangeHighValue,DeviationRangeHighValue].
+ * @returns Returns the corresponding MessageType
  */
 function messageTypeFromTargetCalculation(kpiValue: number, aThresholds: (number | undefined | null)[]): MessageType {
 	let criticalityProperty: MessageType;
@@ -66,9 +66,9 @@ function messageTypeFromTargetCalculation(kpiValue: number, aThresholds: (number
 /**
  * Function to get a message state from a calculated criticality of type 'Minimize'.
  *
- * @param {number} kpiValue The value of the KPI to be tested against.
- * @param {number[]} aThresholds Thresholds to be used [AcceptanceRangeHighValue,ToleranceRangeHighValue,DeviationRangeHighValue].
- * @returns {MessageType} Returns the corresponding MessageType
+ * @param kpiValue The value of the KPI to be tested against.
+ * @param aThresholds Thresholds to be used [AcceptanceRangeHighValue,ToleranceRangeHighValue,DeviationRangeHighValue].
+ * @returns Returns the corresponding MessageType
  */
 function messageTypeFromMinimizeCalculation(kpiValue: number, aThresholds: (number | undefined | null)[]): MessageType {
 	let criticalityProperty: MessageType;
@@ -89,9 +89,9 @@ function messageTypeFromMinimizeCalculation(kpiValue: number, aThresholds: (numb
 /**
  * Function to get a message state from a calculated criticality of type 'Maximize'.
  *
- * @param {number} kpiValue The value of the KPI to be tested against.
- * @param {number[]} aThresholds Thresholds to be used [DeviationRangeLowValue,ToleranceRangeLowValue,AcceptanceRangeLowValue].
- * @returns {MessageType} Returns the corresponding MessageType
+ * @param kpiValue The value of the KPI to be tested against.
+ * @param aThresholds Thresholds to be used [DeviationRangeLowValue,ToleranceRangeLowValue,AcceptanceRangeLowValue].
+ * @returns Returns the corresponding MessageType
  */
 function messageTypeFromMaximizeCalculation(kpiValue: number, aThresholds: (number | undefined | null)[]): MessageType {
 	let criticalityProperty: MessageType;
@@ -112,8 +112,8 @@ function messageTypeFromMaximizeCalculation(kpiValue: number, aThresholds: (numb
 /**
  * Function to calculate a DeviationIndicator value from a trend value.
  *
- * @param {number|string} trendValue The criticality values.
- * @returns {string} Returns the corresponding DeviationIndicator value
+ * @param trendValue The criticality values.
+ * @returns Returns the corresponding DeviationIndicator value
  */
 function deviationIndicatorFromTrendType(trendValue: number | string): string {
 	let deviationIndicator: string;
@@ -147,7 +147,7 @@ function deviationIndicatorFromTrendType(trendValue: number | string): string {
  * @param referenceValue The reference value to compare with
  * @param isRelative True is the comparison is relative
  * @param aThresholds Array of thresholds [StrongDownDifference, DownDifference, UpDifference, StrongUpDifference]
- * @returns {sap.m.DeviationIndicator} Returns the corresponding DeviationIndicator value
+ * @returns Returns the corresponding DeviationIndicator value
  */
 function deviationIndicatorFromCalculation(
 	kpiValue: number,
@@ -200,7 +200,7 @@ function createFilterFromDefinition(filterDefinition: FilterDefinition): Filter
 			filterDefinition.ranges[0].rangeHigh
 		);
 	} else {
-		const aRangeFilters = filterDefinition.ranges.map(range => {
+		const aRangeFilters = filterDefinition.ranges.map((range) => {
 			return new Filter(filterDefinition.propertyPath, range.operator as FilterOperator, range.rangeLow, range.rangeHigh);
 		});
 		return new Filter({
@@ -211,12 +211,7 @@ function createFilterFromDefinition(filterDefinition: FilterDefinition): Filter
 }
 
 function getFilterStringFromDefinition(filterDefinition: FilterDefinition): string {
-	const currentLocale = new Locale(
-		sap.ui
-			.getCore()
-			.getConfiguration()
-			.getLanguage()
-	);
+	const currentLocale = new Locale(sap.ui.getCore().getConfiguration().getLanguage());
 	const resBundle = (Core as CoreEx).getLibraryResourceBundle("sap.fe.core");
 	const dateFormat = DateFormat.getDateInstance({ style: "medium" }, currentLocale);
 
@@ -228,31 +223,31 @@ function getFilterStringFromDefinition(filterDefinition: FilterDefinition): stri
 
 		switch (range.operator) {
 			case "BT":
-				return "[" + valueLow + " - " + valueHigh + "]";
+				return `[${valueLow} - ${valueHigh}]`;
 
 			case "Contains":
-				return "*" + valueLow + "*";
+				return `*${valueLow}*`;
 
 			case "GE":
-				return "\u2265" + valueLow;
+				return `\u2265${valueLow}`;
 
 			case "GT":
-				return ">" + valueLow;
+				return `>${valueLow}`;
 
 			case "LE":
-				return "\u2264" + valueLow;
+				return `\u2264${valueLow}`;
 
 			case "LT":
-				return "<" + valueLow;
+				return `<${valueLow}`;
 
 			case "NB":
-				return resBundle.getText("C_KPICARD_FILTERSTRING_NOT", ["[" + valueLow + " - " + valueHigh + "]"]);
+				return resBundle.getText("C_KPICARD_FILTERSTRING_NOT", [`[${valueLow} - ${valueHigh}]`]);
 
 			case "NE":
-				return "\u2260" + valueLow;
+				return `\u2260${valueLow}`;
 
 			case "NotContains":
-				return resBundle.getText("C_KPICARD_FILTERSTRING_NOT", ["*" + valueLow + "*"]);
+				return resBundle.getText("C_KPICARD_FILTERSTRING_NOT", [`*${valueLow}*`]);
 
 			case "EQ":
 			default:
@@ -264,7 +259,7 @@ function getFilterStringFromDefinition(filterDefinition: FilterDefinition): stri
 	} else if (filterDefinition.ranges.length === 1) {
 		return formatRange(filterDefinition.ranges[0]);
 	} else {
-		return "(" + filterDefinition.ranges.map(formatRange).join(",") + ")";
+		return `(${filterDefinition.ranges.map(formatRange).join(",")})`;
 	}
 }
 
@@ -279,7 +274,7 @@ function formatChartTitle(kpiDef: KPIDefinition): string {
 		} else {
 			let res = items[0].label;
 			for (let I = 1; I < items.length - 1; I++) {
-				res += ", " + items[I].label;
+				res += `, ${items[I].label}`;
 			}
 
 			return resBundle.getText("C_KPICARD_ITEMSLIST", [res, items[items.length - 1].label]);
@@ -385,14 +380,14 @@ function updateChartLabelSettings(chartDefinition: KPIChartDefinition, oChartPro
 function filterMap(aObjects: { name: string; label: string; role?: string }[], aRoles?: (string | undefined)[]): string[] {
 	if (aRoles && aRoles.length) {
 		return aObjects
-			.filter(dimension => {
+			.filter((dimension) => {
 				return aRoles.indexOf(dimension.role) >= 0;
 			})
-			.map(dimension => {
+			.map((dimension) => {
 				return dimension.label;
 			});
 	} else {
-		return aObjects.map(dimension => {
+		return aObjects.map((dimension) => {
 			return dimension.label;
 		});
 	}
@@ -406,7 +401,7 @@ function getScatterBubbleChartFeeds(chartDefinition: KPIChartDefinition): { uid:
 	const seriesDimensions = filterMap(chartDefinition.dimensions, ["Series"]);
 
 	// Get the first dimension with role "Category" for the shape
-	const shapeDimension = chartDefinition.dimensions.find(dimension => {
+	const shapeDimension = chartDefinition.dimensions.find((dimension) => {
 		return dimension.role === "Category";
 	});
 
@@ -561,10 +556,8 @@ function getNavigationParameters(
 
 /**
  * @class A controller extension for managing the KPIs in an analytical list page
- *
  * @name sap.fe.core.controllerextensions.KPIManagement
  * @hideconstructor
- *
  * @private
  * @since 1.93.0
  */
@@ -642,7 +635,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 		// Details of the card: filter descriptions
 		if (kpiDefinition.selectionVariantFilterDefinitions?.length) {
 			const aDescriptions: string[] = [];
-			kpiDefinition.selectionVariantFilterDefinitions.forEach(filterDefinition => {
+			kpiDefinition.selectionVariantFilterDefinitions.forEach((filterDefinition) => {
 				const desc = getFilterStringFromDefinition(filterDefinition);
 				if (desc) {
 					aDescriptions.push(desc);
@@ -658,15 +651,15 @@ class KPIManagementControllerExtension extends ControllerExtension {
 		oCardManifest["sap.card"].content.chartType = kpiDefinition.chart.chartType;
 		updateChartLabelSettings(kpiDefinition.chart, oCardManifest["sap.card"].content.chartProperties);
 		oCardManifest["sap.card"].content.chartProperties.title.text = formatChartTitle(kpiDefinition);
-		oCardManifest["sap.card"].content.dimensions = kpiDefinition.chart.dimensions.map(dimension => {
-			return { label: dimension.label, value: "{" + dimension.name + "}" };
+		oCardManifest["sap.card"].content.dimensions = kpiDefinition.chart.dimensions.map((dimension) => {
+			return { label: dimension.label, value: `{${dimension.name}}` };
 		});
-		oCardManifest["sap.card"].content.measures = kpiDefinition.chart.measures.map(measure => {
-			return { label: measure.label, value: "{" + measure.name + "}" };
+		oCardManifest["sap.card"].content.measures = kpiDefinition.chart.measures.map((measure) => {
+			return { label: measure.label, value: `{${measure.name}}` };
 		});
 		oCardManifest["sap.card"].content.feeds = getChartFeeds(kpiDefinition.chart);
 
-		oKPIModel.setProperty("/" + kpiDefinition.id, {
+		oKPIModel.setProperty(`/${kpiDefinition.id}`, {
 			manifest: oCardManifest
 		});
 	}
@@ -674,9 +667,9 @@ class KPIManagementControllerExtension extends ControllerExtension {
 	protected initNavigationInfo(kpiDefinition: KPIDefinition, oKPIModel: JSONModel, oShellService: any): Promise<void> {
 		// Add navigation
 		if (kpiDefinition.navigation) {
-			return getNavigationParameters(kpiDefinition.navigation, oShellService).then(oNavInfo => {
+			return getNavigationParameters(kpiDefinition.navigation, oShellService).then((oNavInfo) => {
 				if (oNavInfo) {
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/header/actions", [
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/header/actions`, [
 						{
 							type: "Navigation",
 							parameters: oNavInfo
@@ -701,17 +694,17 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			const oKPIModel = new JSONModel();
 			oView.setModel(oKPIModel, "kpiModel");
 
-			this.aKPIDefinitions.forEach(kpiDefinition => {
+			this.aKPIDefinitions.forEach((kpiDefinition) => {
 				// Create the manifest for the KPI card and store it in the KPI model
 				this.initCardManifest(kpiDefinition, oKPIModel);
 
 				// Set the navigation information in the manifest
-				this.initNavigationInfo(kpiDefinition, oKPIModel, oAppComponent.getShellServices()).catch(function(err: any) {
+				this.initNavigationInfo(kpiDefinition, oKPIModel, oAppComponent.getShellServices()).catch(function (err: any) {
 					Log.error(err);
 				});
 
 				// Load tag data for the KPI
-				this.loadKPITagData(kpiDefinition, oAppComponent.getModel() as ODataModel, oKPIModel).catch(function(err: any) {
+				this.loadKPITagData(kpiDefinition, oAppComponent.getModel() as ODataModel, oKPIModel).catch(function (err: any) {
 					Log.error(err);
 				});
 			});
@@ -744,12 +737,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 	}
 
 	private updateDatapointValueAndCurrency(kpiDefinition: KPIDefinition, kpiContext: Context, oKPIModel: JSONModel) {
-		const currentLocale = new Locale(
-			sap.ui
-				.getCore()
-				.getConfiguration()
-				.getLanguage()
-		);
+		const currentLocale = new Locale(sap.ui.getCore().getConfiguration().getLanguage());
 		const rawUnit = kpiDefinition.datapoint.unit?.isPath
 			? kpiContext.getProperty(kpiDefinition.datapoint.unit.value)
 			: kpiDefinition.datapoint.unit?.value;
@@ -770,7 +758,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			},
 			currentLocale
 		).format(rawValue);
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValue", kpiValue);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValue`, kpiValue);
 
 		// Value without a scale
 		const kpiValueUnscaled = NumberFormat.getFloatInstance(
@@ -781,7 +769,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			},
 			currentLocale
 		).format(rawValue);
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueUnscaled", kpiValueUnscaled);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueUnscaled`, kpiValueUnscaled);
 
 		// Value formatted with the scale omitted
 		const kpiValueNoScale = NumberFormat.getFloatInstance(
@@ -793,7 +781,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			},
 			currentLocale
 		).format(rawValue);
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueNoScale", kpiValueNoScale);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueNoScale`, kpiValueNoScale);
 
 		// Scale of the value
 		const kpiValueScale = NumberFormat.getFloatInstance(
@@ -805,17 +793,17 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			},
 			currentLocale
 		).format(rawValue);
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueScale", kpiValueScale);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueScale`, kpiValueScale);
 
 		// /////////////////////
 		// Unit or currency
 		if (kpiDefinition.datapoint.unit && rawUnit) {
 			if (kpiDefinition.datapoint.unit.isCurrency) {
-				oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainUnit", rawUnit);
+				oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainUnit`, rawUnit);
 			} else {
 				// In case of unit of measure, we have to format it properly
 				const kpiUnit = NumberFormat.getUnitInstance({ showNumber: false }, currentLocale).format(rawValue, rawUnit);
-				oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainUnit", kpiUnit);
+				oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainUnit`, kpiUnit);
 			}
 		}
 	}
@@ -855,9 +843,9 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			}
 		}
 
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainCriticality", criticalityValue);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainCriticality`, criticalityValue);
 		oKPIModel.setProperty(
-			"/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainState",
+			`/${kpiDefinition.id}/manifest/sap.card/data/json/mainState`,
 			ValueColorFromMessageType[criticalityValue] || "None"
 		);
 	}
@@ -894,7 +882,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			);
 		}
 
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/trend", trendValue);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/trend`, trendValue);
 	}
 
 	private updateTargetValue(kpiDefinition: KPIDefinition, kpiContext: Context, oKPIModel: JSONModel) {
@@ -902,12 +890,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			return; // No target set for the KPI
 		}
 		const rawValue = Number.parseFloat(kpiContext.getProperty(kpiDefinition.datapoint.propertyPath));
-		const currentLocale = new Locale(
-			sap.ui
-				.getCore()
-				.getConfiguration()
-				.getLanguage()
-		);
+		const currentLocale = new Locale(sap.ui.getCore().getConfiguration().getLanguage());
 
 		let targetRawValue: number;
 		if (kpiDefinition.datapoint.targetValue !== undefined) {
@@ -937,8 +920,8 @@ class KPIManagementControllerExtension extends ControllerExtension {
 			currentLocale
 		).format(targetRawValue);
 
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/targetNumber", targetValue);
-		oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/targetUnit", targetScale);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/targetNumber`, targetValue);
+		oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/targetUnit`, targetScale);
 
 		if (deviationRawValue !== undefined) {
 			const deviationValue = NumberFormat.getFloatInstance(
@@ -949,27 +932,27 @@ class KPIManagementControllerExtension extends ControllerExtension {
 				},
 				currentLocale
 			).format(deviationRawValue);
-			oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/deviationNumber", deviationValue);
+			oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/deviationNumber`, deviationValue);
 		} else {
-			oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/deviationNumber", "N/A");
+			oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/deviationNumber`, "N/A");
 		}
 	}
 
 	/**
 	 * Loads tag data for a KPI, and stores it in the JSON KPI model.
 	 *
-	 * @param {KPIDefinition} kpiDefinition The definition of the KPI.
-	 * @param {ODataModel} oMainModel The model used to load the data.
-	 * @param {JSONModel} oKPIModel The JSON model where the data will be stored
+	 * @param kpiDefinition The definition of the KPI.
+	 * @param oMainModel The model used to load the data.
+	 * @param oKPIModel The JSON model where the data will be stored
 	 * @param loadFull If not true, loads only data for the KPI tag
-	 * @returns {Promise} Returns the promise that is resolved when data is loaded.
+	 * @returns Returns the promise that is resolved when data is loaded.
 	 */
 	protected loadKPITagData(kpiDefinition: KPIDefinition, oMainModel: ODataModel, oKPIModel: JSONModel, loadFull?: boolean): any {
 		// If loadFull=false, then we're just loading data for the tag and we use the "$auto.LongRunners" groupID
 		// If loadFull=true, we're loading data for the whole KPI (tag + card) and we use the default ("$auto") groupID
 		const oListBinding = loadFull
-			? oMainModel.bindList("/" + kpiDefinition.entitySet)
-			: oMainModel.bindList("/" + kpiDefinition.entitySet, undefined, undefined, undefined, { $$groupId: "$auto.LongRunners" });
+			? oMainModel.bindList(`/${kpiDefinition.entitySet}`)
+			: oMainModel.bindList(`/${kpiDefinition.entitySet}`, undefined, undefined, undefined, { $$groupId: "$auto.LongRunners" });
 		const oAggregate: Record<string, { unit?: string }> = {};
 
 		// Main value + currency/unit
@@ -1001,7 +984,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 
 		// Manage SelectionVariant filters
 		if (kpiDefinition.selectionVariantFilterDefinitions?.length) {
-			const aFilters = kpiDefinition.selectionVariantFilterDefinitions.map(createFilterFromDefinition).filter(filter => {
+			const aFilters = kpiDefinition.selectionVariantFilterDefinitions.map(createFilterFromDefinition).filter((filter) => {
 				return filter !== undefined;
 			}) as Filter[];
 			oListBinding.filter(aFilters);
@@ -1015,17 +998,17 @@ class KPIManagementControllerExtension extends ControllerExtension {
 
 				if (kpiDefinition.datapoint.unit && !rawUnit) {
 					// A unit/currency is defined, but its value is undefined --> multi-unit situation
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValue", "*");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueUnscaled", "*");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueNoScale", "*");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainValueScale", "");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainUnit", undefined);
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainCriticality", MessageType.None);
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/mainState", "None");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/trend", "None");
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/targetNumber", undefined);
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/targetUnit", undefined);
-					oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/deviationNumber", undefined);
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValue`, "*");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueUnscaled`, "*");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueNoScale`, "*");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainValueScale`, "");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainUnit`, undefined);
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainCriticality`, MessageType.None);
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/mainState`, "None");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/trend`, "None");
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/targetNumber`, undefined);
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/targetUnit`, undefined);
+					oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/deviationNumber`, undefined);
 				} else {
 					this.updateDatapointValueAndCurrency(kpiDefinition, aContexts[0], oKPIModel);
 					this.updateDatapointCriticality(kpiDefinition, aContexts[0], oKPIModel);
@@ -1042,20 +1025,20 @@ class KPIManagementControllerExtension extends ControllerExtension {
 	/**
 	 * Loads card data for a KPI, and stores it in the JSON KPI model.
 	 *
-	 * @param {KPIDefinition} kpiDefinition The definition of the KPI.
-	 * @param {ODataModel} oMainModel The model used to load the data.
-	 * @param {JSONModel} oKPIModel The JSON model where the data will be stored
-	 * @returns {Promise} Returns the promise that is resolved when data is loaded.
+	 * @param kpiDefinition The definition of the KPI.
+	 * @param oMainModel The model used to load the data.
+	 * @param oKPIModel The JSON model where the data will be stored
+	 * @returns Returns the promise that is resolved when data is loaded.
 	 */
 	protected loadKPICardData(kpiDefinition: KPIDefinition, oMainModel: ODataModel, oKPIModel: JSONModel): any {
-		const oListBinding = oMainModel.bindList("/" + kpiDefinition.entitySet);
+		const oListBinding = oMainModel.bindList(`/${kpiDefinition.entitySet}`);
 		const oGroup: Record<string, Object> = {};
 		const oAggregate: Record<string, Object> = {};
 
-		kpiDefinition.chart.dimensions.forEach(dimension => {
+		kpiDefinition.chart.dimensions.forEach((dimension) => {
 			oGroup[dimension.name] = {};
 		});
-		kpiDefinition.chart.measures.forEach(measure => {
+		kpiDefinition.chart.measures.forEach((measure) => {
 			oAggregate[measure.name] = {};
 		});
 		oListBinding.setAggregation({
@@ -1065,7 +1048,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 
 		// Manage SelectionVariant filters
 		if (kpiDefinition.selectionVariantFilterDefinitions?.length) {
-			const aFilters = kpiDefinition.selectionVariantFilterDefinitions.map(createFilterFromDefinition).filter(filter => {
+			const aFilters = kpiDefinition.selectionVariantFilterDefinitions.map(createFilterFromDefinition).filter((filter) => {
 				return filter !== undefined;
 			}) as Filter[];
 			oListBinding.filter(aFilters);
@@ -1074,26 +1057,26 @@ class KPIManagementControllerExtension extends ControllerExtension {
 		// Sorting
 		if (kpiDefinition.chart.sortOrder) {
 			oListBinding.sort(
-				kpiDefinition.chart.sortOrder.map(sortInfo => {
+				kpiDefinition.chart.sortOrder.map((sortInfo) => {
 					return new Sorter(sortInfo.name, sortInfo.descending);
 				})
 			);
 		}
 
 		return oListBinding.requestContexts(0, kpiDefinition.chart.maxItems).then((aContexts: Context[]) => {
-			const chartData = aContexts.map(function(oContext) {
+			const chartData = aContexts.map(function (oContext) {
 				const oData: Record<string, any> = {};
-				kpiDefinition.chart.dimensions.forEach(dimension => {
+				kpiDefinition.chart.dimensions.forEach((dimension) => {
 					oData[dimension.name] = oContext.getProperty(dimension.name);
 				});
-				kpiDefinition.chart.measures.forEach(measure => {
+				kpiDefinition.chart.measures.forEach((measure) => {
 					oData[measure.name] = oContext.getProperty(measure.name);
 				});
 
 				return oData;
 			});
 
-			oKPIModel.setProperty("/" + kpiDefinition.id + "/manifest/sap.card/data/json/chartData", chartData);
+			oKPIModel.setProperty(`/${kpiDefinition.id}/manifest/sap.card/data/json/chartData`, chartData);
 		});
 	}
 
@@ -1134,7 +1117,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 								width: "25rem",
 								height: "auto"
 							});
-							this.oCard.setHost(oHost as any);
+							this.oCard.setHost(oHost);
 
 							this.oPopover = new Popover("kpi-Popover", {
 								showHeader: false,
@@ -1147,7 +1130,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 							resolve(this.oPopover);
 						});
 					})
-					.catch(function() {
+					.catch(function () {
 						reject();
 					});
 			});
@@ -1161,7 +1144,7 @@ class KPIManagementControllerExtension extends ControllerExtension {
 		const oKPIModel = oKPITag.getModel("kpiModel") as JSONModel;
 
 		if (this.aKPIDefinitions && this.aKPIDefinitions.length) {
-			const kpiDefinition = this.aKPIDefinitions.find(function(oDef) {
+			const kpiDefinition = this.aKPIDefinitions.find(function (oDef) {
 				return oDef.id === kpiID;
 			});
 
@@ -1174,14 +1157,14 @@ class KPIManagementControllerExtension extends ControllerExtension {
 				];
 
 				Promise.all(aPromises)
-					.then(aResults => {
-						this.oCard.setManifest(oKPIModel.getProperty("/" + kpiID + "/manifest"));
+					.then((aResults) => {
+						this.oCard.setManifest(oKPIModel.getProperty(`/${kpiID}/manifest`));
 						this.oCard.refresh();
 
 						const oPopover = aResults[2];
 						oPopover.openBy(oKPITag, false);
 					})
-					.catch(err => {
+					.catch((err) => {
 						Log.error(err);
 					});
 			}