@sapui5/sap.cux.home 1.138.0 → 1.140.0

package/src/sap/cux/home/TaskPanel.ts

@@ -140,8 +140,8 @@ function splitCards(cards: Task[], maxLength: number): Task[][] {
  * @version 0.0.1
  * @since 1.121
  *
- * @internal
- * @public
+ * @private
+ * @ui5-restricted ux.eng.s4producthomes1
  *
  * @alias sap.cux.home.TaskPanel
  */
@@ -206,6 +206,10 @@ export default class TaskPanel extends ToDoPanel {
 		});
 		this.insertAggregation("menuItems", this._viewAllTasksMenuItem, 0);
 		addFESRId(this._viewAllTasksMenuItem, "goToTaskSitution");
+
+		//Add custom styles
+		const [contentWrapper] = this.getContent() || [];
+		contentWrapper?.addStyleClass("sapUiGridTaskLayout");
 	}
 
 	/**
@@ -838,15 +842,6 @@ export default class TaskPanel extends ToDoPanel {
 			this._isGridLayoutAllowed() ? Constants.GRID_VIEW_TWO_COL_MIN_WIDTH : Constants.GRID_VIEW_MIN_WIDTH
 		);
 		this.setProperty("maxCardWidth", Constants.GRID_VIEW_MAX_WIDTH);
-
-		/**
-		 * sapUiGridTaskLayout class is only required in case of Loading view of Desktop & Tablet and Content View of all devices.
-		 * Hence initially skip adding it for Mobile and later add the class once contents are loaded.
-		 * */
-		const toDosWrapper = this._getContent()?.[0];
-		if (toDosWrapper && !toDosWrapper.hasStyleClass("sapUiGridTaskLayout") && calculateDeviceType() !== DeviceType.Mobile) {
-			toDosWrapper.addStyleClass("sapUiGridTaskLayout");
-		}
 	}
 
 	/**

package/src/sap/cux/home/TilesPanel.d.ts

@@ -45,8 +45,8 @@ declare module "sap/cux/home/TilesPanel" {
      * @version 0.0.1
      * @since 1.122.0
      *
-     * @internal
-     * @public
+     * @private
+     * @ui5-restricted ux.eng.s4producthomes1
      *
      * @alias sap.cux.home.TilesPanel
      */
@@ -222,7 +222,6 @@ declare module "sap/cux/home/TilesPanel" {
          * Navigates to the App Finder with optional group Id.
          * @async
          * @private
-         * @param {string} [groupId] - Optional group Id
          */
         private navigateToAppFinder;
         /**

package/src/sap/cux/home/TilesPanel.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"TilesPanel.d.ts","sourceRoot":"../../../../..","sources":["src/sap/cux/home/TilesPanel.ts"],"names":[],"mappings":"AAAA,OAAO,QAAQ,yBAAyB,CAAC;IASzC,OAAO,MAAM,MAAM,cAAc,CAAC;IAkBlC,OAAO,OAAO,MAAM,qBAAqB,CAAC;IAC1C,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAC;IAC3D,OAAO,UAAU,MAAM,qBAAqB,CAAC;IAa7C,OAAO,SAAS,MAAM,wBAAwB,CAAC;IAE/C,OAAO,QAAQ,MAAM,uBAAuB,CAAC;IAC7C,OAAO,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;IAW9D,KAAY,cAAc;QACzB,OAAO,kBAAkB;QACzB,QAAQ,uBAAuB;QAC/B,UAAU,oBAAoB;KAC9B;IAED,KAAY,uBAAuB;QAClC,OAAO,4BAA4B;QACnC,QAAQ,iCAAiC;QACzC,UAAU,8BAA8B;QACxC,SAAS,qCAAqC;KAC9C;IAED,KAAY,kBAAkB;QAC7B,SAAS,yBAAyB;KAClC;IAED,KAAY,2BAA2B;QACtC,SAAS,mCAAmC;QAC5C,SAAS,wCAAwC;KACjD;IAED,KAAY,aAAa;QACxB,QAAQ,aAAa;QACrB,YAAY,iBAAiB;KAC7B;IAED,MAAM,eAAe,EAAE,MAAmC,CAAC;IAC3D,MAAM,kBAAkB,EAAE,MAAqC,CAAC;IAEhE,MAAM,eAAe,EAAE,CAAC,cAAc,GAAG,MAAM,CAAC,EAM/C,CAAC;IAEF,MAAM,YAAY,QACoF,OACrG,CAAC;IAEF,MAAM,iBAAiB,MAAM,CAAC;IAC9B,MAAM,qBAAqB,MAAM,CAAC;IAClC,MAAM,GAAG,KAAK,CAAC;IAEf;;;;;;;;;;;;;;OAcG;IAEH,MAAM,CAAC,OAAO,OAAO,UAAW,SAAQ,SAAS;oBACpC,YAAY,CAAC,EAAE,MAAM,GAAG,mBAAmB;oBAC3C,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,mBAAmB;QAUvD,OAAO,CAAC,MAAM,CAA2B;QACzC,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAA0D;QAChG,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAA8C;QAClF,OAAO,CAAC,kBAAkB,CAAc;QACxC,OAAO,CAAC,uBAAuB,CAA8B;QAC7D,OAAO,CAAC,cAAc,CAAiB;QACvC,OAAO,CAAC,oBAAoB,CAAmB;QAC/C,OAAO,CAAC,aAAa,CAAQ;QAC7B,OAAO,CAAC,aAAa,CAA0C;QAC/D,OAAO,CAAC,aAAa,CAAa;QAC3B,WAAW,EAAG,GAAG,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,GAAG,UAAU,CAAC,CAAC;QACjE,OAAO,CAAC,mBAAmB,CAAc;QACzC,OAAO,CAAC,uBAAuB,CAAY;QAC3C,OAAO,CAAC,SAAS,CAAY;QAC7B,OAAO,CAAC,iBAAiB,CAAqB;QAC9C,OAAO,CAAC,YAAY,CAAW;QAC/B,OAAO,CAAC,cAAc,CAAkB;QACxC,MAAM,CAAC,QAAQ,CAAC,QAAQ,EAAE,eAAe,CA+BvC;QAEF;;;;;WAKG;QACH,IAAI;QAsDJ;;;;;WAKG;QACH,OAAO,CAAC,mBAAmB;QAqB3B;;;;;WAKG;QACH,OAAO,CAAC,cAAc;QActB;;;;;WAKG;QACH,OAAO,CAAC,WAAW;QAKnB;;;;;WAKG;QACH,OAAO,CAAC,iBAAiB;QAqBzB;;;;;WAKG;QACH,OAAO,CAAC,kBAAkB;QAI1B;;;;;WAKG;QACU,WAAW,IAAI,OAAO,CAAC,IAAI,CAAC;QAkBzC;;;;;WAKG;QACH,OAAO,CAAC,cAAc;QAOtB;;;;;;WAMG;QACU,WAAW,CAAC,YAAY,GAAE,OAAe;QA8BtD;;;;;;WAMG;QACH,OAAO,CAAC,uBAAuB;QAa/B;;;;WAIG;QAEH,OAAO,CAAC,wBAAwB;QAoBhC;;;;WAIG;QAEH,OAAO,CAAC,qBAAqB;QAc7B;;;;;;WAMG;QACH,OAAO,CAAC,oBAAoB;QAQ5B;;;;;;;WAOG;QACH,OAAO,CAAC,6BAA6B;QA6BrC;;;;;WAKG;QACH,OAAO,CAAC,wBAAwB;QAmBhC;;;;;WAKG;QACH,OAAO,CAAC,eAAe;QAkBvB;;;;;;;;WAQG;gBACW,eAAe;QAyB7B;;;;WAIG;QACH,OAAO,CAAC,eAAe;QAUvB;;;WAGG;QACI,gBAAgB;QAMvB;;;WAGG;QACI,eAAe;QAStB;;;;WAIG;QACH,OAAO,CAAC,sBAAsB;QAM9B;;;;;WAKG;gBACW,mBAAmB;QAgBjC;;;;;WAKG;QACH,OAAO,CAAC,eAAe;QAIvB;;;;WAIG;gBACW,qBAAqB;QAQnC;;;;;;WAMG;gBACW,YAAY;QAqB1B;;;;WAIG;QACH,OAAO,CAAC,oBAAoB;QAK5B;;;;;WAKG;QACH,OAAO,CAAC,gCAAgC;QA2CxC;;;;;WAKG;QACH,OAAO,CAAC,6BAA6B;QAmGrC;;;;;;WAMG;gBACW,eAAe;QAqC7B;;;;;;WAMG;QACH,OAAO,CAAC,0BAA0B;QA4BlC,OAAO,CAAC,8BAA8B;QAetC;;;;;WAKG;QACI,aAAa;QA2CpB;;;;;WAKG;QACH,OAAO,CAAC,qBAAqB;QAO7B;;;;;WAKG;QACI,qBAAqB,IAAI,QAAQ,EAAE;QAgB1C;;;;;WAKG;QACI,yBAAyB,IAAI,MAAM,EAAE;QAoB5C;;;;;;;WAOG;QACH,OAAO,CAAC,sBAAsB;QAe9B;;;;;;;WAOG;QACH,OAAO,CAAC,yBAAyB;QAgBjC;;;;;;;WAOG;QACH,OAAO,CAAC,wBAAwB;QAehC;;;;;;;WAOG;QACH,OAAO,CAAC,qBAAqB;QAuB7B;;;;;WAKG;QACH,OAAO,CAAC,oBAAoB;KAQ5B;CAEA"}
+{"version":3,"file":"TilesPanel.d.ts","sourceRoot":"../../../../..","sources":["src/sap/cux/home/TilesPanel.ts"],"names":[],"mappings":"AAAA,OAAO,QAAQ,yBAAyB,CAAC;IASzC,OAAO,MAAM,MAAM,cAAc,CAAC;IAkBlC,OAAO,OAAO,MAAM,qBAAqB,CAAC;IAC1C,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAC;IAC3D,OAAO,UAAU,MAAM,qBAAqB,CAAC;IAa7C,OAAO,SAAS,MAAM,wBAAwB,CAAC;IAE/C,OAAO,QAAQ,MAAM,uBAAuB,CAAC;IAC7C,OAAO,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;IAW9D,KAAY,cAAc;QACzB,OAAO,kBAAkB;QACzB,QAAQ,uBAAuB;QAC/B,UAAU,oBAAoB;KAC9B;IAED,KAAY,uBAAuB;QAClC,OAAO,4BAA4B;QACnC,QAAQ,iCAAiC;QACzC,UAAU,8BAA8B;QACxC,SAAS,qCAAqC;KAC9C;IAED,KAAY,kBAAkB;QAC7B,SAAS,yBAAyB;KAClC;IAED,KAAY,2BAA2B;QACtC,SAAS,mCAAmC;QAC5C,SAAS,wCAAwC;KACjD;IAED,KAAY,aAAa;QACxB,QAAQ,aAAa;QACrB,YAAY,iBAAiB;KAC7B;IAED,MAAM,eAAe,EAAE,MAAmC,CAAC;IAC3D,MAAM,kBAAkB,EAAE,MAAqC,CAAC;IAEhE,MAAM,eAAe,EAAE,CAAC,cAAc,GAAG,MAAM,CAAC,EAM/C,CAAC;IAEF,MAAM,YAAY,QACoF,OACrG,CAAC;IAEF,MAAM,iBAAiB,MAAM,CAAC;IAC9B,MAAM,qBAAqB,MAAM,CAAC;IAClC,MAAM,GAAG,KAAK,CAAC;IAEf;;;;;;;;;;;;;;OAcG;IAEH,MAAM,CAAC,OAAO,OAAO,UAAW,SAAQ,SAAS;oBACpC,YAAY,CAAC,EAAE,MAAM,GAAG,mBAAmB;oBAC3C,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,mBAAmB;QAUvD,OAAO,CAAC,MAAM,CAA2B;QACzC,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAA0D;QAChG,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAA8C;QAClF,OAAO,CAAC,kBAAkB,CAAc;QACxC,OAAO,CAAC,uBAAuB,CAA8B;QAC7D,OAAO,CAAC,cAAc,CAAiB;QACvC,OAAO,CAAC,oBAAoB,CAAmB;QAC/C,OAAO,CAAC,aAAa,CAAQ;QAC7B,OAAO,CAAC,aAAa,CAA8C;QACnE,OAAO,CAAC,aAAa,CAAa;QAC3B,WAAW,EAAG,GAAG,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,GAAG,UAAU,CAAC,CAAC;QACjE,OAAO,CAAC,mBAAmB,CAAc;QACzC,OAAO,CAAC,uBAAuB,CAAY;QAC3C,OAAO,CAAC,SAAS,CAAY;QAC7B,OAAO,CAAC,iBAAiB,CAAqB;QAC9C,OAAO,CAAC,YAAY,CAAW;QAC/B,OAAO,CAAC,cAAc,CAAkB;QACxC,MAAM,CAAC,QAAQ,CAAC,QAAQ,EAAE,eAAe,CAmCvC;QAEF;;;;;WAKG;QACH,IAAI;QAsDJ;;;;;WAKG;QACH,OAAO,CAAC,mBAAmB;QAqB3B;;;;;WAKG;QACH,OAAO,CAAC,cAAc;QActB;;;;;WAKG;QACH,OAAO,CAAC,WAAW;QAKnB;;;;;WAKG;QACH,OAAO,CAAC,iBAAiB;QAqBzB;;;;;WAKG;QACH,OAAO,CAAC,kBAAkB;QAI1B;;;;;WAKG;QACU,WAAW,IAAI,OAAO,CAAC,IAAI,CAAC;QAmBzC;;;;;WAKG;QACH,OAAO,CAAC,cAAc;QAOtB;;;;;;WAMG;QACU,WAAW,CAAC,YAAY,GAAE,OAAe;QA2BtD;;;;;;WAMG;QACH,OAAO,CAAC,uBAAuB;QAY/B;;;;WAIG;QAEH,OAAO,CAAC,wBAAwB;QAoBhC;;;;WAIG;QAEH,OAAO,CAAC,qBAAqB;QAc7B;;;;;;WAMG;QACH,OAAO,CAAC,oBAAoB;QAQ5B;;;;;;;WAOG;QACH,OAAO,CAAC,6BAA6B;QA6BrC;;;;;WAKG;QACH,OAAO,CAAC,wBAAwB;QAuBhC;;;;;WAKG;QACH,OAAO,CAAC,eAAe;QAkBvB;;;;;;;;WAQG;gBACW,eAAe;QAyB7B;;;;WAIG;QACH,OAAO,CAAC,eAAe;QAUvB;;;WAGG;QACI,gBAAgB;QAMvB;;;WAGG;QACI,eAAe;QAMtB;;;;WAIG;QACH,OAAO,CAAC,sBAAsB;QAM9B;;;;WAIG;gBACW,mBAAmB;QAajC;;;;;WAKG;QACH,OAAO,CAAC,eAAe;QAIvB;;;;WAIG;gBACW,qBAAqB;QAQnC;;;;;;WAMG;gBACW,YAAY;QAqB1B;;;;WAIG;QACH,OAAO,CAAC,oBAAoB;QAK5B;;;;;WAKG;QACH,OAAO,CAAC,gCAAgC;QA2CxC;;;;;WAKG;QACH,OAAO,CAAC,6BAA6B;QAkGrC;;;;;;WAMG;gBACW,eAAe;QAyD7B;;;;;;WAMG;QACH,OAAO,CAAC,0BAA0B;QA4BlC,OAAO,CAAC,8BAA8B;QAetC;;;;;WAKG;QACI,aAAa;QA2CpB;;;;;WAKG;QACH,OAAO,CAAC,qBAAqB;QAO7B;;;;;WAKG;QACI,qBAAqB,IAAI,QAAQ,EAAE;QAgB1C;;;;;WAKG;QACI,yBAAyB,IAAI,MAAM,EAAE;QAoB5C;;;;;;;WAOG;QACH,OAAO,CAAC,sBAAsB;QAe9B;;;;;;;WAOG;QACH,OAAO,CAAC,yBAAyB;QAgBjC;;;;;;;WAOG;QACH,OAAO,CAAC,wBAAwB;QAehC;;;;;;;WAOG;QACH,OAAO,CAAC,qBAAqB;QAuB7B;;;;;WAKG;QACH,OAAO,CAAC,oBAAoB;KAQ5B;CAEA"}

package/src/sap/cux/home/TilesPanel.js

@@ -99,8 +99,8 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
    * @version 0.0.1
    * @since 1.122.0
    *
-   * @internal
-   * @public
+   * @private
+   * @ui5-restricted ux.eng.s4producthomes1
    *
    * @alias sap.cux.home.TilesPanel
    */
@@ -138,6 +138,14 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
       },
       defaultAggregation: "tiles",
       aggregations: {
+        /**
+         * Specifies the content aggregation of the panel.
+         */
+        content: {
+          multiple: true,
+          singularName: "content",
+          visibility: "hidden"
+        },
         /**
          * Aggregation of tiles available within the tiles Panel
          */
@@ -167,6 +175,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
       BasePanel.prototype.constructor.call(this, id, settings);
       this._insightsSectionTitle = this._i18nBundle.getText("insights");
       this._addFromFavDialogId = `${this.getId()}-addFromFavDialog`;
+      this.aInsightsApps = [];
       this._headerVisible = false;
     },
     /**
@@ -312,7 +321,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
           columns: 2
         }));
       });
-      this._controlModel.setProperty("/tiles", this.aInsightsApps);
+      this._controlModel.setProperty("/tiles", this.aInsightsApps, undefined, true);
     },
     /**
      * Clears the placeholder tiles.
@@ -339,6 +348,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
         const _temp3 = _finallyRethrows(function () {
           return _catch(function () {
             const container = _this3.getParent();
+            _this3._showPlaceHolders();
             if (checkPanelExists(container, appsConatinerlName, favAppPanelName)) {
               const addFromFavAppMenuItem = _this3._createAddFromFavMenuItem(tilesMenuItems.ADD_APPS, "smartAppsDialog");
               _this3.addAggregation("menuItems", addFromFavAppMenuItem);
@@ -397,9 +407,9 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
                 const dynamicTiles = container.getAggregation(sDefaultAggreName) || [];
                 dynamicTiles.forEach(tiles => tiles.refresh?.());
               }
-              _this4._getInsightsContainer().updatePanelsItemCount(_this4.aInsightsApps.length, panelName);
+              _this4._getInsightsContainer()?.updatePanelsItemCount(_this4.aInsightsApps.length, panelName);
               if (_this4._headerVisible) {
-                _this4.setProperty("title", `${_this4._i18nBundle?.getText("insights")} ${_this4._i18nBundle.getText("insightsTilesTitle")} (${_this4.aInsightsApps.length})`);
+                _this4.setProperty("title", `${_this4._i18nBundle?.getText("insightsTiles")} (${_this4.aInsightsApps.length})`);
               }
             } else {
               _this4.fireHandleHidePanel();
@@ -434,9 +444,8 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
           width: "100%",
           items: [this._createMobileFlexWrapper(), this._createWrapperFlexBox()]
         });
-        this._showPlaceHolders();
         this._tilesWrapper.setModel(this._controlModel);
-        this._addContent(this._tilesWrapper);
+        this.addContent(this._tilesWrapper);
       }
     },
     /**
@@ -455,7 +464,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
           scrollTime: 1000,
           showDividers: false,
           visible: "{/isPhone}"
-        }).addStyleClass("sectionMarginTopTilesInsight sapMHeaderContainerAlign sapMHeaderContainerMarginBottom tilesBoxShadow");
+        }).addStyleClass("sectionMarginTopTilesInsight sapMHeaderContainerMarginBottom");
 
         // Attach aggregation to the container
         this._attachAggregationToContainer(this.tilesMobileContainer);
@@ -535,21 +544,24 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
      */
     _setDropAreaRectFunction: function _setDropAreaRectFunction(oVisualization) {
       const tilesDropAreaOffset = 8;
-      Object.defineProperty(oVisualization, "getDropAreaRect", {
-        value: function () {
-          const domRef = this.getDomRef();
-          if (!domRef) return null;
-          const mDropRect = domRef.getBoundingClientRect();
-          return {
-            left: mDropRect.left - tilesDropAreaOffset,
-            right: mDropRect.right + tilesDropAreaOffset,
-            top: mDropRect.top,
-            bottom: mDropRect.bottom,
-            width: mDropRect.width,
-            height: mDropRect.height
-          };
-        }
-      });
+      const vizObj = oVisualization;
+      if (typeof vizObj.getDropAreaRect !== "function") {
+        Object.defineProperty(oVisualization, "getDropAreaRect", {
+          value: function () {
+            const domRef = this.getDomRef();
+            if (!domRef) return null;
+            const mDropRect = domRef.getBoundingClientRect();
+            return {
+              left: mDropRect.left - tilesDropAreaOffset,
+              right: mDropRect.right + tilesDropAreaOffset,
+              top: mDropRect.top,
+              bottom: mDropRect.bottom,
+              width: mDropRect.width,
+              height: mDropRect.height
+            };
+          }
+        });
+      }
     },
     /**
      * Handles the drag and drop of tiles.
@@ -641,7 +653,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
      */
     handleAddHeader: function _handleAddHeader() {
       this._headerVisible = true;
-      this.setProperty("title", `${this._i18nBundle?.getText("insights")} ${this._i18nBundle.getText("insightsTilesTitle")} (${this.aInsightsApps.length})`);
+      this.setProperty("title", `${this._i18nBundle?.getText("insightsTiles")} (${this.aInsightsApps.length})`);
       this._toggleHeaderActions(true);
     },
     /**
@@ -658,18 +670,14 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
      * Navigates to the App Finder with optional group Id.
      * @async
      * @private
-     * @param {string} [groupId] - Optional group Id
      */
-    navigateToAppFinder: function _navigateToAppFinder(groupId) {
+    navigateToAppFinder: function _navigateToAppFinder() {
       try {
         return Promise.resolve(Container.getServiceAsync("Navigation")).then(function (navigationService) {
           const navigationObject = {
             pageID: MYHOME_PAGE_ID,
             sectionID: MYINSIGHT_SECTION_ID
           };
-          if (groupId) {
-            navigationObject.sectionID = groupId;
-          }
           return Promise.resolve(navigationService.navigate({
             target: {
               shellHash: `Shell-appfinder?&/catalog/${JSON.stringify(navigationObject)}`
@@ -829,7 +837,7 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
           description: this._i18nBundle.getText("tilesSectionNoDataDescription"),
           visible: true
         }).addStyleClass("sapUiLargeMarginTop"));
-        this._controlMap.set(id, new Dialog(id, {
+        const dialog = new Dialog(id, {
           title: this._i18nBundle.getText("addSmartApps"),
           content: [new Label({
             id: `${id}-label`,
@@ -857,7 +865,9 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
             text: this._i18nBundle.getText("cancelBtn"),
             press: this._closeAddFromFavDialog.bind(this)
           })]
-        }).addStyleClass("sapContrastPlus sapCuxAddFromInsightsDialog"));
+        }).addStyleClass("sapContrastPlus sapCuxAddFromInsightsDialog");
+        this.addDependent(dialog);
+        this._controlMap.set(id, dialog);
       }
       setAddBtnEnabled();
       return this._controlMap.get(id);
@@ -875,40 +885,60 @@ sap.ui.define(["sap/base/Log", "sap/f/GridContainer", "sap/f/GridContainerItemLa
         const dialog = _this8._controlMap.get(_this8._addFromFavDialogId);
         dialog.setBusy(true);
         const selectedItems = _this8._getSelectedInsights();
-        return Promise.resolve(selectedItems.reduce(function (promise, oApp) {
-          return Promise.resolve(promise).then(function () {
-            const app = oApp.data("app");
-            const oMovingConfig = {
-              pageId: MYHOME_PAGE_ID,
-              sourceSectionIndex: app.persConfig?.sectionIndex,
-              sourceVisualizationIndex: app.persConfig?.visualizationIndex,
-              targetSectionIndex: _this8.appManagerInstance.insightsSectionIndex,
-              targetVisualizationIndex: -1
-            };
-            if (app.visualization?.displayFormatHint !== "standard" && app.visualization?.displayFormatHint !== "standardWide") {
-              if (app.visualization?.supportedDisplayFormats?.includes("standard")) {
-                app.visualization.displayFormatHint = "standard";
-              } else if (app.visualization?.supportedDisplayFormats?.includes("standardWide")) {
-                app.visualization.displayFormatHint = "standardWide";
+        return Promise.resolve(_this8.appManagerInstance._getSections()).then(function (sections) {
+          return Promise.resolve(selectedItems.reduce(function (promise, oApp) {
+            return Promise.resolve(promise).then(function () {
+              const app = oApp.data("app");
+              const oMovingConfig = {
+                pageId: MYHOME_PAGE_ID,
+                sourceSectionIndex: app.persConfig?.sectionIndex,
+                sourceVisualizationIndex: app.persConfig?.visualizationIndex,
+                targetSectionIndex: _this8.appManagerInstance.insightsSectionIndex,
+                targetVisualizationIndex: -1
+              };
+
+              /**
+               * If the app is a bookmark, we need to update the source and target section indices accordingly.
+               * This is because bookmarks are added to the "Recent Apps" section,
+               * which is always at the top of the list, and the insights section index is shifted by one.
+               */
+              // Add Selected App to Insights Section
+              if (app.visualization?.isBookmark) {
+                const recentAppSectionIndex = sections.findIndex(section => section.default);
+                if (recentAppSectionIndex === -1) {
+                  oMovingConfig.sourceSectionIndex = 0;
+                  oMovingConfig.sourceVisualizationIndex = 0;
+                  oMovingConfig.targetSectionIndex = _this8.appManagerInstance.insightsSectionIndex + 1;
+                } else {
+                  oMovingConfig.sourceSectionIndex = recentAppSectionIndex;
+                  oMovingConfig.sourceVisualizationIndex = sections[recentAppSectionIndex]?.visualizations?.length || 0;
+                  oMovingConfig.targetSectionIndex = _this8.appManagerInstance.insightsSectionIndex;
+                }
               }
-            }
-            // Add Selected App to Insights Section
-            if (!app.visualization?.vizId) {
-              app.visualization.vizId = app.visualization?.targetURL ?? "";
-            }
-            const _temp7 = function () {
-              if (app.visualization?.isBookmark === true) {
-                return Promise.resolve(_this8.appManagerInstance.addBookMark(app.visualization, oMovingConfig)).then(function () {});
-              } else {
-                return Promise.resolve(_this8.appManagerInstance.addVisualization(app.visualization?.vizId, MYINSIGHT_SECTION_ID)).then(function () {});
+              if (app.visualization?.displayFormatHint !== "standard" && app.visualization?.displayFormatHint !== "standardWide") {
+                if (app.visualization?.supportedDisplayFormats === "standard") {
+                  app.visualization.displayFormatHint = "standard";
+                } else if (app.visualization?.supportedDisplayFormats === "standardWide") {
+                  app.visualization.displayFormatHint = "standardWide";
+                }
               }
-            }();
-            if (_temp7 && _temp7.then) return _temp7.then(function () {});
-          });
-        }, Promise.resolve())).then(function () {
-          return Promise.resolve(_this8.refreshData()).then(function () {
-            dialog.setBusy(false);
-            dialog.close();
+              if (!app.visualization?.vizId) {
+                app.visualization.vizId = app.visualization?.targetURL ?? "";
+              }
+              const _temp7 = function () {
+                if (app.visualization?.isBookmark === true) {
+                  return Promise.resolve(_this8.appManagerInstance.addBookMark(app.visualization, oMovingConfig)).then(function () {});
+                } else {
+                  return Promise.resolve(_this8.appManagerInstance.addVisualization(app.visualization?.vizId, MYINSIGHT_SECTION_ID)).then(function () {});
+                }
+              }();
+              if (_temp7 && _temp7.then) return _temp7.then(function () {});
+            });
+          }, Promise.resolve())).then(function () {
+            return Promise.resolve(_this8.refreshData()).then(function () {
+              dialog.setBusy(false);
+              dialog.close();
+            });
           });
         });
       } catch (e) {