@saptools/service-flow 0.1.67 → 0.1.68

package/dist/index.d.ts

@@ -1,6 +1,7 @@
 import ts from 'typescript';
 
 type CallType = 'remote_action' | 'remote_query' | 'remote_entity_read' | 'remote_entity_mutation' | 'remote_entity_delete' | 'remote_entity_media' | 'remote_entity_candidate' | 'local_db_query' | 'external_http' | 'async_emit' | 'async_subscribe' | 'local_service_call' | 'unknown';
+type EdgeType = 'REPO_HAS_SERVICE' | 'SERVICE_HAS_OPERATION' | 'OPERATION_IMPLEMENTED_BY_HANDLER' | 'HANDLER_REGISTERED_BY_SERVER' | 'HANDLER_CALLS_LOCAL_FUNCTION' | 'HANDLER_USES_SERVICE_ALIAS' | 'HANDLER_CALLS_REMOTE_OPERATION' | 'REMOTE_CALL_RESOLVES_TO_OPERATION' | 'LOCAL_CALL_RESOLVES_TO_OPERATION' | 'HANDLER_RUNS_DB_QUERY' | 'HANDLER_RUNS_REMOTE_QUERY' | 'HANDLER_ACCESSES_REMOTE_ENTITY' | 'HANDLER_CALLS_EXTERNAL_HTTP' | 'HANDLER_CALLS_TRANSPORT_METHOD' | 'HANDLER_EMITS_EVENT' | 'EVENT_CONSUMED_BY_HANDLER' | 'EVENT_SUBSCRIPTION_HANDLED_BY' | 'REPO_IMPORTS_HELPER_PACKAGE' | 'HELPER_PACKAGE_PROVIDES_HANDLER' | 'DYNAMIC_EDGE_CANDIDATE' | 'UNRESOLVED_EDGE';
 interface DiscoveredRepository {
     name: string;
     absolutePath: string;
@@ -109,8 +110,34 @@ interface ServiceBindingFact {
     placeholders: string[];
     sourceFile: string;
     sourceLine: number;
+    bindingSiteStartOffset?: number;
+    bindingSiteEndOffset?: number;
+    sourceSymbolQualifiedName?: string;
+    ownerResolution?: ServiceBindingOwnerResolution;
     helperChain?: Array<Record<string, unknown>>;
 }
+type ServiceBindingOwnerResolution = 'owned_exact' | 'ownerless_file_scope' | 'legacy_unknown';
+type ServiceBindingReferenceStatus = 'resolved_exact' | 'ambiguous' | 'unresolved' | 'not_applicable';
+type ServiceBindingReferenceReason = 'binding_not_found' | 'binding_declared_after_call' | 'binding_scope_ambiguous' | 'scope_chain_limit_exceeded' | 'unsupported_reaching_assignment' | 'unsupported_var_binding' | 'binding_flow_unsupported';
+interface LexicalScopeFact {
+    kind: 'source_file' | 'module_block' | 'function' | 'class' | 'loop' | 'case_block' | 'block' | 'catch';
+    startOffset: number;
+    endOffset: number;
+}
+interface ServiceBindingReference {
+    status: ServiceBindingReferenceStatus;
+    variableName?: string;
+    bindingSourceFile?: string;
+    bindingSiteStartOffset?: number;
+    bindingSiteEndOffset?: number;
+    resolutionStrategy?: 'lexical_declaration' | 'lexical_alias_declaration' | 'deterministic_reaching_assignment';
+    lexicalScopeChain?: LexicalScopeFact[];
+    bindingScopeIndex?: number;
+    scopeChainTotal: number;
+    scopeChainShown: number;
+    scopeChainOmitted: number;
+    reason?: ServiceBindingReferenceReason;
+}
 interface OutboundCallFact {
     callType: CallType;
     sourceSymbolQualifiedName?: string;
@@ -127,6 +154,7 @@ interface OutboundCallFact {
     sourceLine: number;
     callSiteStartOffset?: number;
     callSiteEndOffset?: number;
+    serviceBindingReference?: ServiceBindingReference;
     confidence: number;
     unresolvedReason?: string;
     evidence?: Record<string, unknown>;
@@ -137,6 +165,33 @@ interface OutboundCallFact {
         dynamic: boolean;
     };
 }
+interface ExecutableSymbolFact {
+    kind: string;
+    localName: string;
+    exportedName?: string;
+    qualifiedName: string;
+    sourceFile: string;
+    startLine: number;
+    endLine: number;
+    startOffset: number;
+    endOffset: number;
+    exported: boolean;
+    importExportEvidence?: Record<string, unknown>;
+}
+type SymbolCallRole = 'ordinary_call' | 'event_subscribe_handler' | 'legacy_unknown';
+interface SymbolCallFact {
+    callerQualifiedName: string;
+    calleeExpression: string;
+    calleeLocalName?: string;
+    receiverLocalName?: string;
+    importSource?: string;
+    sourceFile: string;
+    sourceLine: number;
+    callSiteStartOffset?: number;
+    callSiteEndOffset?: number;
+    callRole: Exclude<SymbolCallRole, 'legacy_unknown'>;
+    evidence: Record<string, unknown>;
+}
 interface GeneratedConstantFact {
     name: string;
     value: string;
@@ -215,7 +270,11 @@ declare function parseHandlerRegistrations(repoPath: string, filePath: string, c
 
 declare function parseServiceBindings(repoPath: string, filePath: string, context?: RepositorySourceContext): Promise<ServiceBindingFact[]>;
 
-declare function parseOutboundCalls(repoPath: string, filePath: string, context?: RepositorySourceContext): Promise<OutboundCallFact[]>;
+interface ClassifiedOutboundCall {
+    fact: OutboundCallFact;
+    node: ts.CallExpression;
+}
+declare function parseOutboundCalls(repoPath: string, filePath: string, context?: RepositorySourceContext, classified?: readonly ClassifiedOutboundCall[], preparedBindings?: readonly ServiceBindingFact[]): Promise<OutboundCallFact[]>;
 
 declare function parseGeneratedConstants(repoPath: string, filePath: string): Promise<GeneratedConstantFact[]>;
 
@@ -465,4 +524,4 @@ declare function parseImplementationHint(value: string): ImplementationHint;
 declare function redactText(text: string): string;
 declare function redactValue(value: unknown): unknown;
 
-export { type CompactDecisionV1, type CompactDiagnosticDetailsV1, type CompactDiagnosticRowV1, type CompactEdgeDetailsV1, type CompactEdgeRowV1, type CompactGraphV1, type CompactHintV1, type CompactNodeRowV1, type CompactQueryV1, type CompactReferenceGroupV1, type CompactReferencesV1, type CompactSourceContext, type CompactStartV1, type CompactStatus, type CompactStatusCountsV1, type CompactTraceExecution, type DynamicMode, type ImplementationHint, type RuntimeSubstitution, type TraceOptions, applyVariables, compactTrace, discoverRepositories, extractPlaceholders, linkWorkspace, parseCdsFile, parseDecorators, parseGeneratedConstants, parseHandlerRegistrations, parseImplementationHint, parseOutboundCalls, parsePackageJson, parseServiceBindings, redactText, redactValue, substituteVariables, trace, traceAndCompact };
+export { type CallType, type CompactDecisionV1, type CompactDiagnosticDetailsV1, type CompactDiagnosticRowV1, type CompactEdgeDetailsV1, type CompactEdgeRowV1, type CompactGraphV1, type CompactHintV1, type CompactNodeRowV1, type CompactQueryV1, type CompactReferenceGroupV1, type CompactReferencesV1, type CompactSourceContext, type CompactStartV1, type CompactStatus, type CompactStatusCountsV1, type CompactTraceExecution, type Db, type DynamicMode, type EdgeType, type ExecutableSymbolFact, type ImplementationHint, type OutboundCallFact, type RuntimeSubstitution, type SymbolCallFact, type SymbolCallRole, type TraceEdge, type TraceOptions, type TraceResult, type TraceStart, applyVariables, compactTrace, discoverRepositories, extractPlaceholders, linkWorkspace, parseCdsFile, parseDecorators, parseGeneratedConstants, parseHandlerRegistrations, parseImplementationHint, parseOutboundCalls, parsePackageJson, parseServiceBindings, redactText, redactValue, substituteVariables, trace, traceAndCompact };

package/dist/index.js

@@ -19,7 +19,7 @@ import {
   substituteVariables,
   trace,
   traceAndCompact
-} from "./chunk-ZQABU7MR.js";
+} from "./chunk-AEM4JY22.js";
 
 // src/parsers/generated-constants-parser.ts
 import fs from "fs/promises";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saptools/service-flow",
-  "version": "0.1.67",
+  "version": "0.1.68",
   "description": "Trace SAP CAP service-to-service flows across multi-repository workspaces with runtime-aware graph resolution",
   "type": "module",
   "publishConfig": {

package/src/cli/003-doctor-package-resolution.ts

@@ -0,0 +1,68 @@
+import type { Db } from '../db/connection.js';
+
+type Diagnostic = Record<string, unknown>;
+
+function pendingPredicate(alias: string): string {
+  return `${alias}.status='unresolved'
+    AND ${alias}.callee_symbol_id IS NULL
+    AND ${alias}.unresolved_reason='package_resolution_pending'
+    AND json_extract(${alias}.evidence_json,'$.relation')='package_import'
+    AND json_extract(${alias}.evidence_json,
+      '$.importBinding.moduleKind')='package'
+    AND json_extract(${alias}.evidence_json,
+      '$.candidateStrategy')='package_import_pending'
+    AND json_extract(${alias}.evidence_json,'$.candidateCount')=0
+    AND json_extract(${alias}.evidence_json,'$.eligibleCandidateCount')=0
+    AND json_extract(${alias}.evidence_json,'$.selectedCandidateCount')=0
+    AND json_extract(${alias}.evidence_json,'$.candidateSetComplete')=0`;
+}
+
+function count(db: Db, sql: string): number {
+  return Number(db.prepare(sql).get()?.count ?? 0);
+}
+
+export function packagePendingDiagnostics(db: Db): Diagnostic[] {
+  const pending = count(db, `SELECT COUNT(*) count FROM symbol_calls sc
+    WHERE ${pendingPredicate('sc')}`);
+  if (pending === 0) return [];
+  const stale = count(db, `SELECT COUNT(*) count FROM repositories
+    WHERE graph_stale_reason IS NOT NULL`);
+  return [{
+    severity: 'warning',
+    code: 'package_import_resolution_pending',
+    message: 'Package-import facts await workspace linking; terminal package-resolution quality is deferred.',
+    packageResolutionState: 'pre_link_pending',
+    pendingPackageImportCount: pending,
+    graphState: 'stale',
+    staleRepositoryCount: stale,
+    requiredAction: 'relink',
+    remediation: 'service-flow link --workspace /workspace --force',
+  }];
+}
+
+export function symbolCallQuality(db: Db): Diagnostic {
+  const terminal = `NOT (${pendingPredicate('sc')})`;
+  const row = db.prepare(`SELECT COUNT(*) total,
+    SUM(CASE WHEN sc.status='resolved' THEN 1 ELSE 0 END) resolved,
+    SUM(CASE WHEN sc.status='unresolved' THEN 1 ELSE 0 END) unresolved
+    FROM symbol_calls sc WHERE ${terminal}`).get();
+  const top = db.prepare(`SELECT sc.callee_expression calleeExpression,
+    COUNT(*) count FROM symbol_calls sc
+    WHERE sc.status='unresolved' AND ${terminal}
+    GROUP BY sc.callee_expression
+    ORDER BY count DESC,sc.callee_expression COLLATE BINARY LIMIT 5`).all();
+  const total = Number(row?.total ?? 0);
+  const unresolved = Number(row?.unresolved ?? 0);
+  const ratio = total === 0 ? 0 : Number((unresolved / total).toFixed(4));
+  return {
+    severity: ratio > 0.05 ? 'warning' : 'info',
+    code: 'strict_symbol_call_quality',
+    message: 'Terminal symbol-call quality aggregate',
+    total,
+    resolved: Number(row?.resolved ?? 0),
+    unresolved,
+    unresolvedRatio: ratio,
+    unresolvedRatioThreshold: 0.05,
+    topUnresolvedCallees: top,
+  };
+}

package/src/cli/doctor.ts

@@ -7,6 +7,10 @@ import {
   analyzerVersionDiagnostics,
   schemaDriftDiagnostics,
 } from './002-doctor-lifecycle.js';
+import {
+  packagePendingDiagnostics,
+  symbolCallQuality,
+} from './003-doctor-package-resolution.js';
 export { linkUpgradeWarnings } from './002-doctor-lifecycle.js';
 
 type Diagnostic = Record<string, unknown>;
@@ -17,13 +21,23 @@ interface DoctorOptions {
 
 export function doctorDiagnostics(db: Db, strict: boolean, options: DoctorOptions = {}): Diagnostic[] {
   const lifecycle = factLifecycleDiagnostic(db, options.workspaceId);
-  if (lifecycle?.code === 'schema_upgrade_required'
-    || lifecycle?.code === 'unsupported_future_schema')
-    return boundDoctorDiagnostics([lifecycle]);
+  if (lifecycle) return boundDoctorDiagnostics([lifecycle]);
+  const globalLifecycle = options.workspaceId === undefined
+    ? undefined : factLifecycleDiagnostic(db);
+  if (globalLifecycle) return boundDoctorDiagnostics([
+    ...schemaDriftDiagnostics(db, strict, options.workspaceId),
+    ...analyzerVersionDiagnostics(db, strict, options.workspaceId),
+    {
+      severity: 'warning',
+      code: 'workspace_detail_checks_deferred',
+      message: 'Selected-workspace lifecycle is valid, but JSON-dependent global detail checks were deferred because another workspace requires reindexing.',
+      remediation: 'Run doctor for the affected workspace after force index and link.',
+    },
+  ]);
   const diagnostics = db.prepare('SELECT severity,code,message,source_file sourceFile,source_line sourceLine FROM diagnostics ORDER BY id').all() as Diagnostic[];
   return boundDoctorDiagnostics([
-    ...(lifecycle ? [lifecycle] : []),
     ...diagnostics,
+    ...packagePendingDiagnostics(db),
     ...healthDiagnostics(db, strict),
     ...remoteTargetWithoutImplementationDiagnostics(db, strict, Boolean(options.detail)),
     ...localServiceDiagnostics(db, strict),
@@ -170,15 +184,6 @@ function jsonEvidenceQuality(db: Db): Diagnostic[] {
   ];
 }
 
-function symbolCallQuality(db: Db): Diagnostic {
-  const row = db.prepare("SELECT COUNT(*) total, SUM(CASE WHEN status='resolved' THEN 1 ELSE 0 END) resolved, SUM(CASE WHEN status='unresolved' THEN 1 ELSE 0 END) unresolved FROM symbol_calls").get() as Record<string, unknown>;
-  const top = db.prepare("SELECT callee_expression calleeExpression,COUNT(*) count FROM symbol_calls WHERE status='unresolved' GROUP BY callee_expression ORDER BY count DESC,callee_expression LIMIT 5").all() as Diagnostic[];
-  const total = Number(row.total ?? 0);
-  const unresolved = Number(row.unresolved ?? 0);
-  const ratio = total === 0 ? 0 : Number((unresolved / total).toFixed(4));
-  return { severity: ratio > 0.05 ? 'warning' : 'info', code: 'strict_symbol_call_quality', message: 'Symbol-call quality aggregate', total, resolved: Number(row.resolved ?? 0), unresolved, unresolvedRatio: ratio, unresolvedRatioThreshold: 0.05, topUnresolvedCallees: top };
-}
-
 function dbQueryQuality(db: Db): Diagnostic {
   const row = db.prepare("SELECT COUNT(*) total, SUM(CASE WHEN query_entity IS NOT NULL THEN 1 ELSE 0 END) known, SUM(CASE WHEN query_entity IS NULL THEN 1 ELSE 0 END) unknown FROM outbound_calls WHERE call_type='local_db_query'").get() as Record<string, unknown>;
   const total = Number(row.total ?? 0);
@@ -418,8 +423,13 @@ function serviceBindingQuality(db: Db, detail: boolean): Diagnostic {
 function bindingCategory(row: Diagnostic): string {
   const evidence = parseObject(row.evidenceJson);
   const resolution = parseObject(evidence.serviceBindingResolution);
+  const reference = parseObject(evidence.serviceBindingReference);
   if (resolution.status === 'rejected_future_binding') return 'direct_binding_missing';
-  if (resolution.status === 'ambiguous') return 'ambiguous_binding_candidates';
+  if (reference.reason === 'binding_declared_after_call')
+    return 'direct_binding_missing';
+  if (resolution.status === 'ambiguous' || reference.status === 'ambiguous'
+    || reference.reason === 'unsupported_reaching_assignment')
+    return 'ambiguous_binding_candidates';
   const receiver = evidence.receiver;
   const symbolEvidence = parseObject(row.symbolEvidenceJson);
   if (symbolHasReceiverParameter(symbolEvidence, receiver))
@@ -448,6 +458,7 @@ function bindingExample(row: Diagnostic): Diagnostic {
     receiver: evidence.receiver,
     unresolvedReason: row.unresolvedReason,
     bindingResolution: evidence.serviceBindingResolution,
+    bindingReference: evidence.serviceBindingReference,
   };
 }