@saptools/service-flow 0.1.56 → 0.1.58

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 0.1.58
+
+- Completed RC5 with a deterministic link-phase workspace pass that resolves package-import symbol calls to uniquely matching exported symbols in uniquely identified indexed sibling packages, including package subpath imports and receiver-qualified member calls.
+- Kept external packages, same-repository imports, missing or non-exported names, unsafe aliases/default imports, deeper member chains, duplicate package mappings, and duplicate exported targets fail-closed as unresolved or ambiguous.
+- Recomputed owned package-import rows on every link without a schema, edge, trace-engine, or CLI output change, preserving bounded evidence and cross-package `local_symbol_call` trace descent across repeated link and force-index/relink runs.
+
+## 0.1.57
+
+- Made local executable symbol-call resolution import-binding-aware: relative helper shadowing now bypasses same-file methods (RC1), namespace members resolve within their imported module (RC2), duplicate exports use fail-closed path disambiguation while barrels remain ambiguous (RC3), and singleton-accessor chains reach non-exported instance methods in the imported class module (RC4).
+- Recorded non-relative package-import calls with `package_import` evidence instead of silently dropping them (RC5 minimal-safe); they remain deterministically unresolved until a post-publication workspace pass can resolve sibling-package symbols without index-order or stale-ID risk.
+- Persisted bounded module-path and candidate-strategy evidence without a schema migration or trace/rendering shape change, with neutral parser, SQLite, trace-edge, and repeated force-index/relink coverage.
+
 ## 0.1.56
 
 - Completed direct CAP query-builder execution-context indexing for builders returned by async or syntactically guaranteed-Promise callables and for static builder elements in awaited `Promise.all(...)`, while retaining one fact per logical statement and the existing conservative unknown-entity behavior.

package/dist/{chunk-Y7H7ZU5B.js → chunk-CRSSXWQ2.js}

@@ -1,5 +1,8 @@
 #!/usr/bin/env node
 
+// src/db/repositories.ts
+import { posix } from "path";
+
 // src/utils/000-bounded-projection.ts
 var DEFAULT_EVIDENCE_CANDIDATE_LIMIT = 5;
 function projectBounded(values, compare, limit = DEFAULT_EVIDENCE_CANDIDATE_LIMIT) {
@@ -387,34 +390,86 @@ function insertSymbolCalls(db, repoId, rows2) {
   for (const r of rows2) {
     const caller = callerStmt.get(repoId, r.sourceFile, r.callerQualifiedName);
     const target = resolveSymbolCallTarget(db, repoId, r);
-    insertStmt.run(repoId, caller?.id, target.id, r.calleeExpression, r.importSource, r.sourceFile, r.sourceLine, target.status, 0.8, JSON.stringify({ ...r.evidence, candidateStrategy: target.strategy, candidateCount: target.candidateCount }), target.reason);
+    insertStmt.run(repoId, caller?.id, target.id, r.calleeExpression, r.importSource, r.sourceFile, r.sourceLine, target.status, 0.8, JSON.stringify({ ...r.evidence, candidateStrategy: target.strategy, candidateCount: target.candidateCount, resolvedModulePath: target.resolvedModulePath }), target.reason);
   }
 }
+var stripExt = (value) => value.replace(/\.(ts|tsx|js|jsx|cds)$/, "");
+function symbolTargetRows(rows2) {
+  return rows2.flatMap((row) => typeof row.id === "number" ? [{ id: row.id, kind: typeof row.kind === "string" ? row.kind : void 0, sourceFile: nullableString(row.sourceFile), evidenceJson: nullableString(row.evidenceJson) }] : []);
+}
+function relativeModuleTargets(callerSourceFile, importSource) {
+  const base = posix.dirname(callerSourceFile);
+  const joined = stripExt(posix.normalize(posix.join(base, importSource)));
+  return /* @__PURE__ */ new Set([joined, `${joined}/index`]);
+}
+function moduleRows(rows2, r) {
+  if (!r.importSource) return [];
+  const targets = relativeModuleTargets(r.sourceFile, r.importSource);
+  return rows2.filter((row) => typeof row.sourceFile === "string" && targets.has(stripExt(row.sourceFile)));
+}
+function resolvedSymbol(row, strategy, candidateCount, moduleScoped = false) {
+  return { id: row.id, status: "resolved", reason: null, strategy, candidateCount, resolvedModulePath: moduleScoped && row.sourceFile ? stripExt(row.sourceFile) : void 0 };
+}
+function exportedSymbolRows(db, repoId, r) {
+  return symbolTargetRows(db.prepare("SELECT id,kind,source_file sourceFile,evidence_json evidenceJson FROM symbols WHERE repo_id=? AND source_file<>? AND exported=1 AND (exported_name=? OR name=? OR qualified_name=?) ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.calleeLocalName));
+}
 function isRelativeImportedSymbolCall(r) {
   return Boolean(r.importSource?.startsWith("."));
 }
+function sameFileResolution(db, repoId, r, relation) {
+  const bareImport = relation === "relative_import" && isRelativeImportedSymbolCall(r) && !String(r.calleeLocalName).includes(".");
+  if (bareImport || relation === "relative_import_namespace_member" || relation === "package_import") return void 0;
+  const rows2 = symbolTargetRows(db.prepare("SELECT id FROM symbols WHERE repo_id=? AND source_file=? AND (name=? OR qualified_name=?) ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName));
+  if (rows2.length === 1 && rows2[0]) return resolvedSymbol(rows2[0], "same_file_exact", 1);
+  return rows2.length > 1 ? { id: null, status: "ambiguous", reason: "Multiple same-file symbol targets matched exactly", strategy: "same_file_exact", candidateCount: rows2.length } : void 0;
+}
+function classInstanceResolution(db, repoId, r, relation) {
+  if (relation !== "class_instance_method" || !isRelativeImportedSymbolCall(r)) return void 0;
+  const rows2 = symbolTargetRows(db.prepare("SELECT id FROM symbols WHERE repo_id=? AND source_file<>? AND qualified_name=? ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName));
+  if (rows2.length === 1 && rows2[0]) return resolvedSymbol(rows2[0], "relative_import_class_instance_method", 1);
+  return rows2.length > 1 ? { id: null, status: "ambiguous", reason: "Multiple relative class instance method targets matched exactly", strategy: "relative_import_class_instance_method", candidateCount: rows2.length } : void 0;
+}
+function namespaceResolution(db, repoId, r, relation) {
+  if (relation !== "relative_import_namespace_member" || !isRelativeImportedSymbolCall(r)) return void 0;
+  const rows2 = moduleRows(exportedSymbolRows(db, repoId, r), r);
+  if (rows2.length === 1 && rows2[0]) return resolvedSymbol(rows2[0], "relative_import_namespace_member", 1, true);
+  if (rows2.length > 1) return { id: null, status: "ambiguous", reason: "Multiple namespace member targets matched the imported module", strategy: "relative_import_namespace_member", candidateCount: rows2.length };
+  return { id: null, status: "unresolved", reason: "No namespace member target matched the imported module", strategy: "relative_import_namespace_member", candidateCount: 0 };
+}
+function proxyResolution(rows2, r, relation) {
+  if (relation !== "relative_import_proxy_member" || rows2.length <= 1) return void 0;
+  const mapped = rows2.filter((row) => String(row.evidenceJson ?? "").includes("exported_object_shorthand") || String(row.evidenceJson ?? "").includes("exported_object_literal"));
+  if (mapped.length > 0) {
+    const concrete = rows2.find((row) => row.kind !== "object_alias") ?? mapped[0];
+    return { id: concrete?.id ?? null, status: "resolved", reason: null, strategy: "proxy_member_exported_object_map", candidateCount: rows2.length };
+  }
+  const scoped = moduleRows(rows2, r);
+  if (scoped.length === 1 && scoped[0]) return resolvedSymbol(scoped[0], "relative_import_path_disambiguated", rows2.length, true);
+  return { id: null, status: "ambiguous", reason: "Proxy member target requires explicit factory/module/type evidence; global member name is ambiguous", strategy: "proxy_member_no_global_name_fallback", candidateCount: rows2.length };
+}
+function exportedResolution(rows2, r, relation) {
+  if (rows2.length === 1 && rows2[0]) return resolvedSymbol(rows2[0], relation === "relative_import_proxy_member" ? "proxy_member_unique_exported_candidate" : "relative_import_exported_exact", 1, moduleRows(rows2, r).length === 1);
+  if (rows2.length <= 1) return void 0;
+  const scoped = isRelativeImportedSymbolCall(r) ? moduleRows(rows2, r) : [];
+  if (scoped.length === 1 && scoped[0]) return resolvedSymbol(scoped[0], "relative_import_path_disambiguated", rows2.length, true);
+  return { id: null, status: "ambiguous", reason: "Multiple exported symbol targets matched exactly", strategy: "exported_exact", candidateCount: rows2.length };
+}
+function accessorResolution(db, repoId, r, relation) {
+  if (relation !== "relative_import" || !isRelativeImportedSymbolCall(r) || !/^[^.]+\.[^.]+$/.test(String(r.calleeLocalName))) return void 0;
+  const methodRows = symbolTargetRows(db.prepare("SELECT id,kind,source_file sourceFile FROM symbols WHERE repo_id=? AND source_file<>? AND kind='method' AND qualified_name=? ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName));
+  const scoped = moduleRows(methodRows, r);
+  if (scoped.length === 1 && scoped[0]) return resolvedSymbol(scoped[0], "relative_import_static_accessor_instance_method", 1, true);
+  return scoped.length > 1 ? { id: null, status: "ambiguous", reason: "Multiple static-accessor instance method targets matched the imported module", strategy: "relative_import_static_accessor_instance_method", candidateCount: scoped.length } : void 0;
+}
 function resolveSymbolCallTarget(db, repoId, r) {
-  const evidence = r.evidence;
-  const localRows = db.prepare("SELECT id FROM symbols WHERE repo_id=? AND source_file=? AND (name=? OR qualified_name=?) ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName);
-  if (localRows.length === 1) return { id: localRows[0]?.id ?? null, status: "resolved", reason: null, strategy: "same_file_exact", candidateCount: 1 };
-  if (localRows.length > 1) return { id: null, status: "ambiguous", reason: "Multiple same-file symbol targets matched exactly", strategy: "same_file_exact", candidateCount: localRows.length };
-  if (evidence.relation === "class_instance_method" && isRelativeImportedSymbolCall(r)) {
-    const classRows = db.prepare("SELECT id FROM symbols WHERE repo_id=? AND source_file<>? AND qualified_name=? ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName);
-    if (classRows.length === 1) return { id: classRows[0]?.id ?? null, status: "resolved", reason: null, strategy: "relative_import_class_instance_method", candidateCount: 1 };
-    if (classRows.length > 1) return { id: null, status: "ambiguous", reason: "Multiple relative class instance method targets matched exactly", strategy: "relative_import_class_instance_method", candidateCount: classRows.length };
-  }
-  const rows2 = db.prepare("SELECT id,kind,evidence_json evidenceJson FROM symbols WHERE repo_id=? AND source_file<>? AND exported=1 AND (exported_name=? OR name=? OR qualified_name=?) ORDER BY id").all(repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.calleeLocalName);
-  if (evidence.relation === "relative_import_proxy_member" && rows2.length > 1) {
-    const objectMapRows = rows2.filter((row) => String(row.evidenceJson ?? "").includes("exported_object_shorthand") || String(row.evidenceJson ?? "").includes("exported_object_literal"));
-    if (objectMapRows.length > 0) {
-      const concrete = rows2.find((row) => row.kind !== "object_alias") ?? objectMapRows[0];
-      return { id: concrete?.id ?? null, status: "resolved", reason: null, strategy: "proxy_member_exported_object_map", candidateCount: rows2.length };
-    }
-    return { id: null, status: "ambiguous", reason: "Proxy member target requires explicit factory/module/type evidence; global member name is ambiguous", strategy: "proxy_member_no_global_name_fallback", candidateCount: rows2.length };
-  }
-  if (rows2.length === 1) return { id: rows2[0]?.id ?? null, status: "resolved", reason: null, strategy: evidence.relation === "relative_import_proxy_member" ? "proxy_member_unique_exported_candidate" : "relative_import_exported_exact", candidateCount: 1 };
-  if (rows2.length > 1) return { id: null, status: "ambiguous", reason: "Multiple exported symbol targets matched exactly", strategy: "exported_exact", candidateCount: rows2.length };
-  return { id: null, status: "unresolved", reason: "No local symbol target matched exactly", strategy: evidence.relation === "relative_import_proxy_member" ? "proxy_member_no_global_name_fallback" : "exact_symbol_match", candidateCount: 0 };
+  const relation = r.evidence.relation;
+  const early = sameFileResolution(db, repoId, r, relation) ?? classInstanceResolution(db, repoId, r, relation) ?? namespaceResolution(db, repoId, r, relation);
+  if (early) return early;
+  const rows2 = relation === "package_import" ? [] : exportedSymbolRows(db, repoId, r);
+  const matched = proxyResolution(rows2, r, relation) ?? exportedResolution(rows2, r, relation) ?? accessorResolution(db, repoId, r, relation);
+  if (matched) return matched;
+  if (relation === "package_import") return { id: null, status: "unresolved", reason: "Package import target resolution requires a post-publication workspace pass", strategy: "package_import_unresolved", candidateCount: 0 };
+  return { id: null, status: "unresolved", reason: "No local symbol target matched exactly", strategy: relation === "relative_import_proxy_member" ? "proxy_member_no_global_name_fallback" : "exact_symbol_match", candidateCount: 0 };
 }
 function insertCalls(db, repoId, rows2) {
   const stmt = db.prepare(
@@ -5222,12 +5277,160 @@ function isRecord3(value) {
   return Boolean(value && typeof value === "object" && !Array.isArray(value));
 }
 
+// src/linker/003-package-import-symbol-resolver.ts
+var unresolvedRepositoryReason = "Package import target resolution requires a post-publication workspace pass";
+var unresolvedSymbolReason = "Sibling package indexed but no matching exported symbol; the target may be a re-export, barrel, type-only export, or unindexed Receiver.member";
+var ambiguousSymbolReason = "Multiple exported sibling-package symbol targets matched exactly";
+var stripExt2 = (value) => value.replace(/\.(ts|tsx|js|jsx|cds)$/, "");
+function push(map, key, id) {
+  const existing = map.get(key);
+  if (existing) existing.push(id);
+  else map.set(key, [id]);
+}
+function nullableString2(value) {
+  return typeof value === "string" ? value : void 0;
+}
+function evidenceObject(value) {
+  if (typeof value !== "string" || value.length === 0) return {};
+  try {
+    const parsed = JSON.parse(value);
+    return parsed && typeof parsed === "object" && !Array.isArray(parsed) ? parsed : {};
+  } catch {
+    return {};
+  }
+}
+function repoByPackageName(db, workspaceId) {
+  const result = /* @__PURE__ */ new Map();
+  const rows2 = db.prepare(`SELECT id,package_name packageName FROM repositories
+    WHERE workspace_id=? AND package_name IS NOT NULL ORDER BY package_name,id`).all(workspaceId);
+  for (const row of rows2) {
+    const packageName = nullableString2(row.packageName);
+    if (!packageName || typeof row.id !== "number") continue;
+    result.set(packageName, result.has(packageName) ? null : row.id);
+  }
+  return result;
+}
+function packagePrefix(importSource) {
+  const parts = importSource.split("/");
+  if (importSource.startsWith("@")) return parts.length >= 2 ? parts.slice(0, 2).join("/") : importSource;
+  return parts[0] ?? importSource;
+}
+function packageRepoId(repos, importSource) {
+  const packageName = repos.has(importSource) ? importSource : packagePrefix(importSource);
+  return repos.get(packageName) ?? null;
+}
+function emptyRepoExports() {
+  return { publicName: /* @__PURE__ */ new Map(), qualified: /* @__PURE__ */ new Map(), fileById: /* @__PURE__ */ new Map() };
+}
+function exportsByRepo(db, workspaceId) {
+  const result = /* @__PURE__ */ new Map();
+  const rows2 = db.prepare(`SELECT s.id,s.repo_id repoId,s.name,s.exported_name exportedName,
+      s.qualified_name qualifiedName,s.source_file sourceFile
+    FROM symbols s JOIN repositories r ON r.id=s.repo_id
+    WHERE r.workspace_id=? AND s.exported=1 ORDER BY s.repo_id,s.id`).all(workspaceId);
+  for (const row of rows2) addExportRow(result, row);
+  return result;
+}
+function addExportRow(result, row) {
+  if (typeof row.id !== "number" || typeof row.repoId !== "number") return;
+  const exports = result.get(row.repoId) ?? emptyRepoExports();
+  result.set(row.repoId, exports);
+  const publicName = nullableString2(row.exportedName) ?? nullableString2(row.name);
+  const qualifiedName = nullableString2(row.qualifiedName);
+  const sourceFile = nullableString2(row.sourceFile);
+  if (publicName) push(exports.publicName, publicName, row.id);
+  if (qualifiedName) push(exports.qualified, qualifiedName, row.id);
+  if (sourceFile) exports.fileById.set(row.id, stripExt2(sourceFile));
+}
+function packageCallRows(db, workspaceId) {
+  const rows2 = db.prepare(`SELECT sc.id,sc.repo_id callerRepoId,
+      sc.callee_expression calleeExpression,sc.import_source importSource,
+      sc.evidence_json evidenceJson
+    FROM symbol_calls sc JOIN repositories r ON r.id=sc.repo_id
+    WHERE r.workspace_id=? AND sc.import_source IS NOT NULL
+      AND sc.import_source NOT LIKE './%' AND sc.import_source NOT LIKE '../%'
+      AND json_extract(sc.evidence_json,'$.relation')='package_import'
+      AND json_extract(sc.evidence_json,'$.candidateStrategy') IN
+        ('package_import_unresolved','package_import_workspace_resolved','package_import_ambiguous')
+    ORDER BY sc.id`).all(workspaceId);
+  return rows2.flatMap((row) => packageCallRow(row));
+}
+function packageCallRow(row) {
+  const calleeExpression = nullableString2(row.calleeExpression);
+  const importSource = nullableString2(row.importSource);
+  if (typeof row.id !== "number" || typeof row.callerRepoId !== "number" || !calleeExpression || !importSource) return [];
+  return [{
+    id: row.id,
+    callerRepoId: row.callerRepoId,
+    calleeExpression,
+    importSource,
+    evidence: evidenceObject(row.evidenceJson)
+  }];
+}
+function candidatesForCall(call, exports) {
+  if (!exports) return [];
+  const dotCount = [...call.calleeExpression].filter((character) => character === ".").length;
+  if (dotCount === 0) {
+    const targetName = nullableString2(call.evidence.targetName);
+    return targetName ? exports.publicName.get(targetName) ?? [] : [];
+  }
+  return dotCount === 1 ? exports.qualified.get(call.calleeExpression) ?? [] : [];
+}
+function resolvePackageCall(call, repos, exports) {
+  const targetRepoId = packageRepoId(repos, call.importSource);
+  if (targetRepoId === null || targetRepoId === call.callerRepoId) return unresolvedResolution(unresolvedRepositoryReason);
+  const repoExports = exports.get(targetRepoId);
+  const candidates2 = candidatesForCall(call, repoExports);
+  const [id] = candidates2;
+  if (candidates2.length === 1 && id !== void 0) {
+    return {
+      id,
+      status: "resolved",
+      reason: null,
+      strategy: "package_import_workspace_resolved",
+      candidateCount: 1,
+      resolvedModulePath: repoExports?.fileById.get(id)
+    };
+  }
+  if (candidates2.length > 1) {
+    return { id: null, status: "ambiguous", reason: ambiguousSymbolReason, strategy: "package_import_ambiguous", candidateCount: candidates2.length };
+  }
+  return unresolvedResolution(unresolvedSymbolReason);
+}
+function unresolvedResolution(reason) {
+  return { id: null, status: "unresolved", reason, strategy: "package_import_unresolved", candidateCount: 0 };
+}
+function resolutionEvidence(call, resolution) {
+  const evidence = {
+    ...call.evidence,
+    candidateStrategy: resolution.strategy,
+    candidateCount: resolution.candidateCount
+  };
+  if (resolution.resolvedModulePath) evidence.resolvedModulePath = resolution.resolvedModulePath;
+  else delete evidence.resolvedModulePath;
+  return JSON.stringify(evidence);
+}
+function linkPackageImportSymbolCalls(db, workspaceId) {
+  const repos = repoByPackageName(db, workspaceId);
+  const exports = exportsByRepo(db, workspaceId);
+  const update = db.prepare(`UPDATE symbol_calls SET callee_symbol_id=?,status=?,
+    unresolved_reason=?,evidence_json=? WHERE id=?`);
+  const summary = { resolved: 0, ambiguous: 0, unresolved: 0 };
+  for (const call of packageCallRows(db, workspaceId)) {
+    const resolution = resolvePackageCall(call, repos, exports);
+    update.run(resolution.id, resolution.status, resolution.reason, resolutionEvidence(call, resolution), call.id);
+    summary[resolution.status] += 1;
+  }
+  return summary;
+}
+
 // src/linker/cross-repo-linker.ts
 function linkWorkspace(db, workspaceId, vars = {}) {
   return db.transaction(() => {
     const generation = nextGraphGeneration(db, workspaceId);
     db.prepare("DELETE FROM graph_edges WHERE workspace_id=?").run(workspaceId);
     const deps = linkHelperPackages(db, workspaceId, generation);
+    linkPackageImportSymbolCalls(db, workspaceId);
     const impl = linkImplementations(db, workspaceId, generation);
     const callSummary = linkCalls(db, workspaceId, vars, generation);
     db.prepare("UPDATE repositories SET graph_generation=?, graph_stale_reason=NULL, graph_stale_at=NULL WHERE workspace_id=?").run(generation, workspaceId);
@@ -8489,4 +8692,4 @@ export {
   selectorRepoAmbiguousDiagnostic,
   trace
 };
-//# sourceMappingURL=chunk-Y7H7ZU5B.js.map
+//# sourceMappingURL=chunk-CRSSXWQ2.js.map