@saptools/service-flow 0.1.47 → 0.1.48

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saptools/service-flow",
-  "version": "0.1.47",
+  "version": "0.1.48",
   "description": "Trace SAP CAP service-to-service flows across multi-repository workspaces with runtime-aware graph resolution",
   "type": "module",
   "publishConfig": {

package/src/cli/doctor.ts

@@ -18,6 +18,7 @@ export function doctorDiagnostics(db: Db, strict: boolean, options: DoctorOption
   return [
     ...diagnostics,
     ...healthDiagnostics(db, strict),
+    ...remoteTargetWithoutImplementationDiagnostics(db, strict, Boolean(options.detail)),
     ...localServiceDiagnostics(db, strict),
     ...schemaDriftDiagnostics(db, strict),
     ...analyzerVersionDiagnostics(db, strict),
@@ -46,10 +47,6 @@ function healthDiagnostics(db: Db, strict: boolean): Diagnostic[] {
      SELECT 'warning','legacy_schema_weaker_foreign_keys','Legacy table lacks fresh-schema foreign-key metadata; rebuild the database or re-run init/index in a new database',NULL,NULL
      WHERE (SELECT COUNT(*) FROM pragma_foreign_key_list('graph_edges'))=0 OR (SELECT COUNT(*) FROM pragma_foreign_key_list('index_runs'))=0 OR (SELECT COUNT(*) FROM pragma_foreign_key_list('diagnostics'))=0
      UNION ALL
-     SELECT 'warning','remote_target_without_implementation','Remote target operation has no implementation edge: ' || s.service_path || o.operation_path,o.source_file,o.source_line
-     FROM graph_edges remote JOIN cds_operations o ON o.id=CAST(remote.to_id AS INTEGER) JOIN cds_services s ON s.id=o.service_id
-     WHERE remote.edge_type='REMOTE_CALL_RESOLVES_TO_OPERATION' AND remote.to_kind='operation' AND NOT EXISTS (SELECT 1 FROM graph_edges impl WHERE impl.edge_type='OPERATION_IMPLEMENTED_BY_HANDLER' AND impl.from_kind='operation' AND impl.from_id=remote.to_id) AND ?
-     UNION ALL
      SELECT CASE WHEN ? THEN 'warning' ELSE 'error' END,'local_service_calls_all_unresolved','All local service calls are unresolved; verify local service alias parsing and linking',NULL,NULL
      WHERE EXISTS (SELECT 1 FROM outbound_calls WHERE call_type='local_service_call') AND NOT EXISTS (SELECT 1 FROM graph_edges e JOIN outbound_calls c ON e.from_kind='call' AND c.id=CAST(e.from_id AS INTEGER) WHERE c.call_type='local_service_call' AND e.status='resolved')
      UNION ALL
@@ -67,7 +64,44 @@ function healthDiagnostics(db: Db, strict: boolean): Diagnostic[] {
      UNION ALL
      SELECT 'warning','index_run_abandoned','Index run ' || id || ' started at ' || started_at || ' is still running after the 60 minute abandonment threshold',NULL,NULL
      FROM index_runs WHERE status='running' AND datetime(started_at) < datetime('now','-60 minutes')`,
-  ).all(strict, strict, strict, strict, strict, strict, strict) as Diagnostic[];
+  ).all(strict, strict, strict, strict, strict, strict) as Diagnostic[];
+}
+
+
+function remoteTargetWithoutImplementationDiagnostics(db: Db, strict: boolean, detail: boolean): Diagnostic[] {
+  if (!strict) return [];
+  const groups = db.prepare(`SELECT s.service_path servicePath,o.operation_path operationPath,o.source_file sourceFile,o.source_line sourceLine,COUNT(*) callSiteCount
+    FROM graph_edges remote JOIN cds_operations o ON o.id=CAST(remote.to_id AS INTEGER) JOIN cds_services s ON s.id=o.service_id
+    WHERE remote.edge_type='REMOTE_CALL_RESOLVES_TO_OPERATION' AND remote.to_kind='operation'
+      AND NOT EXISTS (SELECT 1 FROM graph_edges impl WHERE impl.edge_type='OPERATION_IMPLEMENTED_BY_HANDLER' AND impl.from_kind='operation' AND impl.from_id=remote.to_id)
+    GROUP BY s.service_path,o.operation_path,o.source_file,o.source_line
+    ORDER BY s.service_path,o.operation_path`).all() as Array<{ servicePath?: string; operationPath?: string; sourceFile?: string | null; sourceLine?: number | null; callSiteCount?: number }>;
+  return groups.map((group) => {
+    const examples = remoteTargetWithoutImplementationExamples(db, String(group.servicePath ?? ''), String(group.operationPath ?? ''));
+    return {
+      severity: 'warning',
+      code: 'remote_target_without_implementation',
+      message: `Remote target operation has no implementation edge: ${String(group.servicePath ?? '')}${String(group.operationPath ?? '')}`,
+      sourceFile: group.sourceFile,
+      sourceLine: group.sourceLine,
+      servicePath: group.servicePath,
+      operationPath: group.operationPath,
+      callSiteCount: Number(group.callSiteCount ?? 0),
+      examples: examples.slice(0, 3),
+      expandedExamples: detail ? examples : undefined,
+    };
+  });
+}
+
+function remoteTargetWithoutImplementationExamples(db: Db, servicePath: string, operationPath: string): Diagnostic[] {
+  return db.prepare(`SELECT r.name repo,c.source_file sourceFile,c.source_line sourceLine,c.operation_path_expr operationPathExpr
+    FROM graph_edges remote JOIN cds_operations o ON o.id=CAST(remote.to_id AS INTEGER) JOIN cds_services s ON s.id=o.service_id
+    LEFT JOIN outbound_calls c ON remote.from_kind='call' AND c.id=CAST(remote.from_id AS INTEGER)
+    LEFT JOIN repositories r ON r.id=c.repo_id
+    WHERE remote.edge_type='REMOTE_CALL_RESOLVES_TO_OPERATION' AND remote.to_kind='operation'
+      AND s.service_path=? AND o.operation_path=?
+      AND NOT EXISTS (SELECT 1 FROM graph_edges impl WHERE impl.edge_type='OPERATION_IMPLEMENTED_BY_HANDLER' AND impl.from_kind='operation' AND impl.from_id=remote.to_id)
+    ORDER BY r.name,c.source_file,c.source_line`).all(servicePath, operationPath) as Diagnostic[];
 }
 
 function schemaDriftDiagnostics(db: Db, strict: boolean): Diagnostic[] {

package/src/cli.ts

@@ -1,7 +1,6 @@
 import { Command } from 'commander';
 import path from 'node:path';
 import fs from 'node:fs/promises';
-import pc from 'picocolors';
 import { DEFAULT_IGNORES } from './config/defaults.js';
 import {
   createWorkspaceConfig,
@@ -27,6 +26,7 @@ import { parseVars } from './trace/selectors.js';
 import { parseImplementationHint } from './trace/implementation-hints.js';
 import { renderTraceTable } from './output/table-output.js';
 import { renderTraceJson, renderJson } from './output/json-output.js';
+import { renderDoctorDiagnostics } from './output/doctor-output.js';
 import { renderMermaid } from './output/mermaid-output.js';
 import { VERSION } from './version.js';
 async function init(
@@ -370,15 +370,12 @@ export function createProgram(): Command {
     .option('--workspace <path>')
     .option('--strict')
     .option('--detail')
+    .option('--format <format>', 'json|table')
     .action(
-      (opts: { workspace?: string; strict?: boolean; detail?: boolean }) =>
+      (opts: { workspace?: string; strict?: boolean; detail?: boolean; format?: string }) =>
         void withReadOnlyWorkspace(opts.workspace, (db) => {
           const allDiagnostics = doctorDiagnostics(db, Boolean(opts.strict), { detail: Boolean(opts.detail) });
-          process.stdout.write(
-            allDiagnostics.length
-              ? renderJson(allDiagnostics)
-              : `${pc.green('No diagnostics recorded')}\n`,
-          );
+          process.stdout.write(renderDoctorDiagnostics(allDiagnostics, opts.format));
         }).catch(fail),
     );
   program

package/src/output/doctor-output.ts

@@ -0,0 +1,98 @@
+import pc from 'picocolors';
+import { renderJson } from './json-output.js';
+
+type Diagnostic = Record<string, unknown>;
+
+export function renderDoctorDiagnostics(diagnostics: Diagnostic[], format: string | undefined): string {
+  if (format === 'json') return renderJson(diagnostics);
+  if (format === 'table') return renderDoctorTable(diagnostics);
+  if (format) throw new Error(`Unsupported doctor format: ${format}. Expected json or table.`);
+  return renderLegacyDoctorOutput(diagnostics);
+}
+
+function renderLegacyDoctorOutput(diagnostics: Diagnostic[]): string {
+  if (diagnostics.length === 0) return cleanDoctorMessage();
+  return renderJson(diagnostics);
+}
+
+export function renderDoctorTable(diagnostics: Diagnostic[]): string {
+  if (diagnostics.length === 0) return cleanDoctorMessage();
+  const rows = diagnostics.map((diagnostic) => ({
+    severity: String(diagnostic.severity ?? 'info'),
+    code: String(diagnostic.code ?? 'diagnostic'),
+    location: diagnosticLocation(diagnostic),
+    message: compactMessage(diagnostic),
+    hints: suggestedHintLines(diagnostic),
+  }));
+  const widths = {
+    severity: columnWidth('Severity', rows.map((row) => row.severity), 10),
+    code: columnWidth('Code', rows.map((row) => row.code), 44),
+    location: columnWidth('Location', rows.map((row) => row.location), 28),
+  };
+  const lines = [
+    `${'Severity'.padEnd(widths.severity)} ${'Code'.padEnd(widths.code)} ${'Location'.padEnd(widths.location)} Message`,
+    `${'-'.repeat(widths.severity)} ${'-'.repeat(widths.code)} ${'-'.repeat(widths.location)} ${'-'.repeat(7)}`,
+  ];
+  for (const row of rows) {
+    lines.push(`${truncate(row.severity, widths.severity).padEnd(widths.severity)} ${truncate(row.code, widths.code).padEnd(widths.code)} ${truncate(row.location, widths.location).padEnd(widths.location)} ${row.message}`);
+    lines.push(...row.hints.map((hint) => `  try ${hint}`));
+  }
+  return `${lines.join('\n')}\n`;
+}
+
+function diagnosticLocation(diagnostic: Diagnostic): string {
+  const file = diagnostic.sourceFile ?? diagnostic.file;
+  const line = diagnostic.sourceLine ?? diagnostic.line;
+  if (file || line) return `${String(file ?? '')}:${String(line ?? '')}`;
+  return '-';
+}
+
+function compactMessage(diagnostic: Diagnostic): string {
+  const message = String(diagnostic.message ?? '');
+  const count = typeof diagnostic.count === 'number' ? ` count=${diagnostic.count}` : '';
+  const total = typeof diagnostic.total === 'number' ? ` total=${diagnostic.total}` : '';
+  return `${message}${count}${total}`.trim();
+}
+
+function suggestedHintLines(diagnostic: Diagnostic): string[] {
+  const direct = cliHints(diagnostic.suggestedHints);
+  if (direct.length > 0) return cappedHints(direct);
+  return cappedHints(cliHintsFromSuggestions(diagnostic.implementationHintSuggestions));
+}
+
+function cliHints(value: unknown): string[] {
+  return Array.isArray(value) ? value.filter((item): item is string => typeof item === 'string') : [];
+}
+
+function cliHintsFromSuggestions(value: unknown): string[] {
+  if (!Array.isArray(value)) return [];
+  return value.flatMap((item) => {
+    if (!isRecord(item)) return [];
+    return typeof item.cli === 'string' ? [item.cli] : [];
+  });
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return Boolean(value && typeof value === 'object' && !Array.isArray(value));
+}
+
+function cappedHints(hints: string[]): string[] {
+  const unique = [...new Set(hints)];
+  const shown = unique.slice(0, 3);
+  if (unique.length > shown.length) shown.push(`... ${unique.length - shown.length} more hint(s) available in --format json`);
+  return shown;
+}
+
+function cleanDoctorMessage(): string {
+  return `${pc.green('No diagnostics recorded')}\n`;
+}
+
+function columnWidth(header: string, values: string[], max: number): number {
+  return Math.min(max, Math.max(header.length, ...values.map((value) => value.length)));
+}
+
+function truncate(value: string, width: number): string {
+  if (value.length <= width) return value;
+  if (width <= 1) return value.slice(0, width);
+  return `${value.slice(0, width - 1)}…`;
+}