@saptools/service-flow 0.1.44 → 0.1.46

package/dist/cli.js

@@ -3,17 +3,19 @@ import {
   classifyODataPathIntent,
   containsSupportedOutboundCall,
   discoverRepositories,
+  implementationHintSuggestions,
   linkWorkspace,
   normalizeODataOperationInvocationPath,
   normalizePath,
   parseCdsFile,
   parseDecorators,
   parseHandlerRegistrations,
+  parseImplementationHint,
   parseOutboundCalls,
   parsePackageJson,
   parseServiceBindings,
   trace
-} from "./chunk-UKNPHTUS.js";
+} from "./chunk-EGY2A4AT.js";
 
 // src/cli.ts
 import { Command } from "commander";
@@ -209,7 +211,7 @@ function migrate(db) {
 // package.json
 var package_default = {
   name: "@saptools/service-flow",
-  version: "0.1.44",
+  version: "0.1.46",
   description: "Trace SAP CAP service-to-service flows across multi-repository workspaces with runtime-aware graph resolution",
   type: "module",
   publishConfig: {
@@ -814,6 +816,10 @@ function argumentEvidence(args, source) {
       }
       return { kind: "object_literal", properties };
     }
+    if (ts.isArrayLiteralExpression(arg)) {
+      const elements = arg.elements.flatMap((element, index) => ts.isIdentifier(element) ? [{ index, kind: "identifier", name: element.text }] : []);
+      return { kind: "array_literal", elements };
+    }
     return { kind: "unsupported", expression: arg.getText(source) };
   });
 }
@@ -860,15 +866,21 @@ function parameterPropertyAliases(fn, source) {
 function parameterBindings(params) {
   return params.flatMap((param, index) => {
     if (ts.isIdentifier(param.name)) return [{ index, kind: "identifier", name: param.name.text }];
-    if (!ts.isObjectBindingPattern(param.name)) return [];
-    const properties = param.name.elements.flatMap((element) => {
-      if (element.dotDotDotToken || ts.isObjectBindingPattern(element.name) || ts.isArrayBindingPattern(element.name)) return [];
-      const property = element.propertyName ? nameOf(element.propertyName) : nameOf(element.name);
-      if (!property) return [];
-      const local = bindingLocalName(element.name, element.initializer);
-      return local ? [{ property, local }] : [];
-    });
-    return properties.length > 0 ? [{ index, kind: "object_pattern", properties }] : [];
+    if (ts.isObjectBindingPattern(param.name)) {
+      const properties = param.name.elements.flatMap((element) => {
+        if (element.dotDotDotToken || ts.isObjectBindingPattern(element.name) || ts.isArrayBindingPattern(element.name)) return [];
+        const property = element.propertyName ? nameOf(element.propertyName) : nameOf(element.name);
+        if (!property) return [];
+        const local = bindingLocalName(element.name, element.initializer);
+        return local ? [{ property, local }] : [];
+      });
+      return properties.length > 0 ? [{ index, kind: "object_pattern", properties }] : [];
+    }
+    if (ts.isArrayBindingPattern(param.name)) {
+      const elements = param.name.elements.flatMap((element, elementIndex) => ts.isBindingElement(element) && !element.dotDotDotToken && ts.isIdentifier(element.name) ? [{ index: elementIndex, local: element.name.text }] : []);
+      return elements.length > 0 ? [{ index, kind: "array_pattern", elements }] : [];
+    }
+    return [];
   });
 }
 async function parseExecutableSymbols(repoPath, filePath) {
@@ -1295,7 +1307,7 @@ async function indexWorkspace(db, workspaceId, options) {
 function linkUpgradeWarnings(db) {
   return [...schemaDriftDiagnostics(db, true), ...analyzerVersionDiagnostics(db, true)].filter((item) => ["schema_legacy_columns_present", "external_target_columns_missing_data", "reindex_required_after_upgrade", "reindex_required_after_analyzer_upgrade"].includes(String(item.code)));
 }
-function doctorDiagnostics(db, strict) {
+function doctorDiagnostics(db, strict, options = {}) {
   const diagnostics = db.prepare("SELECT severity,code,message,source_file sourceFile,source_line sourceLine FROM diagnostics ORDER BY id").all();
   return [
     ...diagnostics,
@@ -1303,7 +1315,7 @@ function doctorDiagnostics(db, strict) {
     ...localServiceDiagnostics(db, strict),
     ...schemaDriftDiagnostics(db, strict),
     ...analyzerVersionDiagnostics(db, strict),
-    ...parserQualityDiagnostics(db, strict)
+    ...parserQualityDiagnostics(db, strict, options)
   ];
 }
 function healthDiagnostics(db, strict) {
@@ -1380,7 +1392,7 @@ function localServiceDiagnostics(db, strict) {
   if (strict && implementationContext > 0) out.push({ severity: "info", code: "local_service_calls_resolved_by_implementation_context", message: `Local service calls resolved by implementation-context ownership: ${implementationContext}` });
   return out;
 }
-function parserQualityDiagnostics(db, strict) {
+function parserQualityDiagnostics(db, strict, options) {
   if (!strict) return [];
   const symbol = symbolCallQuality(db);
   const dbq = dbQueryQuality(db);
@@ -1389,7 +1401,7 @@ function parserQualityDiagnostics(db, strict) {
     identityAliasBindingQuality(db),
     remoteActionNoBindingQuality(db),
     contextualImplementationQuality(db),
-    implementationCandidateQuality(db),
+    implementationCandidateQuality(db, Boolean(options.detail)),
     classInstanceNoiseQuality(db),
     contextualBindingPropagationQuality(db),
     nestedThisReceiverQuality(db),
@@ -1452,19 +1464,26 @@ function graphDynamicFlagQuality(db) {
   const row = db.prepare("SELECT COUNT(*) count FROM graph_edges WHERE status='terminal' AND is_dynamic=1").get();
   return { severity: Number(row.count ?? 0) > 0 ? "warning" : "info", code: "strict_graph_dynamic_flag_consistency", message: "Graph dynamic flag consistency aggregate", dynamicTerminalEdges: Number(row.count ?? 0) };
 }
-function implementationCandidateQuality(db) {
-  const categories = [...implementationEdgeCategories(db), missingParameterMetadataCategory(db)].filter((item) => item.count > 0);
+function implementationCandidateQuality(db, detail) {
+  const categories = [...implementationEdgeCategories(db, detail), missingParameterMetadataCategory(db, detail), dynamicWrapperCategory(db, detail)].filter((item) => item.count > 0);
   const total = categories.reduce((sum, item) => sum + item.count, 0);
-  return { severity: total > 0 ? "warning" : "info", code: "strict_implementation_candidate_quality", message: "Implementation candidate ambiguity and rejection aggregate", total, categories };
+  return { severity: total > 0 ? "warning" : "info", code: "strict_implementation_candidate_quality", message: "Implementation candidate ambiguity and rejection aggregate", total, summary: implementationSummary(categories), categories };
 }
-function implementationEdgeCategories(db) {
+function implementationEdgeCategories(db, detail) {
   const rows = db.prepare(`SELECT e.status,e.unresolved_reason unresolvedReason,e.evidence_json evidenceJson,o.operation_name operationName,base.operation_name baseOperation,s.service_path servicePath
     FROM graph_edges e JOIN cds_operations o ON o.id=CAST(e.from_id AS INTEGER)
     JOIN cds_services s ON s.id=o.service_id LEFT JOIN cds_operations base ON base.id=o.base_operation_id
     WHERE e.edge_type='OPERATION_IMPLEMENTED_BY_HANDLER' AND e.status IN ('ambiguous','unresolved') ORDER BY s.service_path,o.operation_name,e.id`).all();
   const grouped = /* @__PURE__ */ new Map();
   for (const row of rows) addImplementationCategory(grouped, row);
-  return [...grouped.values()].map(({ servicePaths, ...item }) => ({ ...item, servicePathPattern: pathPattern(servicePaths), examples: item.examples.slice(0, 3) }));
+  return [...grouped.values()].map(({ servicePaths, ...item }) => ({
+    ...item,
+    servicePathPattern: pathPattern(servicePaths),
+    suggestedAction: categoryAction(String(item.category)),
+    suggestedHints: suggestedHints(item.examples),
+    examples: item.examples.slice(0, 3),
+    expandedExamples: detail ? item.examples : void 0
+  }));
 }
 function addImplementationCategory(grouped, row) {
   const evidence = parseObject(row.evidenceJson);
@@ -1474,21 +1493,57 @@ function addImplementationCategory(grouped, row) {
   const baseOperation = String(row.baseOperation ?? row.operationName ?? evidence.operationName ?? "unknown");
   const key = [category, baseOperation, reason, family].join("\0");
   const current = grouped.get(key) ?? { category, baseOperation, reason, candidateFamily: family, count: 0, servicePaths: [], examples: [] };
+  const hintSuggestions = implementationSuggestions(evidence);
   current.count += 1;
   current.servicePaths.push(String(row.servicePath ?? evidence.servicePath ?? ""));
-  current.examples.push({ servicePath: row.servicePath, operation: row.operationName, status: row.status, reason: row.unresolvedReason });
+  current.examples.push({ servicePath: row.servicePath, operation: row.operationName, status: row.status, reason: row.unresolvedReason, implementationHintSuggestions: hintSuggestions });
   grouped.set(key, current);
 }
-function missingParameterMetadataCategory(db) {
+function implementationSuggestions(evidence) {
+  const persisted = asRecords(evidence.implementationHintSuggestions);
+  const suggestions = persisted.length ? persisted : implementationHintSuggestions(evidence);
+  return suggestions.length ? suggestions : void 0;
+}
+function suggestedHints(examples) {
+  const hints = examples.flatMap((example) => asRecords(example.implementationHintSuggestions).flatMap((suggestion) => typeof suggestion.cli === "string" ? [String(suggestion.cli)] : []));
+  const unique = [...new Set(hints)].slice(0, 3);
+  return unique.length ? unique : void 0;
+}
+function missingParameterMetadataCategory(db, detail = false) {
   const examples = db.prepare(`SELECT sc.source_file sourceFile,sc.source_line sourceLine,sc.callee_expression calleeExpression
     FROM symbol_calls sc JOIN symbols s ON s.id=sc.callee_symbol_id
     WHERE sc.status='resolved' AND json_extract(sc.evidence_json,'$.callArguments[0].kind') IN ('identifier','object_literal')
       AND (s.evidence_json IS NULL OR json_extract(s.evidence_json,'$.parameterBindings') IS NULL)
-    ORDER BY sc.source_file,sc.source_line LIMIT 3`).all();
+    ORDER BY sc.source_file,sc.source_line`).all();
   const row = db.prepare(`SELECT COUNT(*) count FROM symbol_calls sc JOIN symbols s ON s.id=sc.callee_symbol_id
     WHERE sc.status='resolved' AND json_extract(sc.evidence_json,'$.callArguments[0].kind') IN ('identifier','object_literal')
       AND (s.evidence_json IS NULL OR json_extract(s.evidence_json,'$.parameterBindings') IS NULL)`).get();
-  return { category: "missing_parameter_metadata", reason: "callee symbol is missing parameter binding metadata", candidateFamily: "symbol_parameter_metadata", count: Number(row.count ?? 0), examples };
+  return { category: "missing_parameter_metadata", reason: "callee symbol is missing parameter binding metadata", candidateFamily: "symbol_parameter_metadata", count: Number(row.count ?? 0), suggestedAction: categoryAction("missing_parameter_metadata"), examples: examples.slice(0, 3), expandedExamples: detail ? examples : void 0 };
+}
+function dynamicWrapperCategory(db, detail) {
+  const rows = db.prepare(`SELECT source_file sourceFile,source_line sourceLine,
+      json_extract(evidence_json,'$.receiver') receiverName,
+      COALESCE(json_extract(evidence_json,'$.missingPathIdentifier'),json_extract(evidence_json,'$.operationPathExpression')) pathIdentifier
+    FROM outbound_calls WHERE call_type='remote_action' AND unresolved_reason='dynamic_operation_path_identifier'
+    ORDER BY source_file,source_line`).all();
+  return { category: "dynamic_wrapper_paths", reason: "wrapper path cannot be proven statically", candidateFamily: "wrapper_path", count: rows.length, suggestedAction: categoryAction("dynamic_wrapper_paths"), examples: rows.slice(0, 3), expandedExamples: detail ? rows : void 0 };
+}
+function implementationSummary(categories) {
+  const grouped = /* @__PURE__ */ new Map();
+  for (const category of categories) {
+    const key = [category.category, category.candidateFamily, category.reason].join("\0");
+    const current = grouped.get(key) ?? { category: category.category, candidateFamily: category.candidateFamily, reason: category.reason, severity: "warning", suggestedAction: category.suggestedAction, count: 0 };
+    current.count += category.count;
+    grouped.set(key, current);
+  }
+  return [...grouped.values()].sort((left, right) => String(left.category).localeCompare(String(right.category)) || String(left.candidateFamily).localeCompare(String(right.candidateFamily)));
+}
+function categoryAction(category) {
+  if (category === "duplicate_package_name_candidates") return "Use scoped --implementation-hint fields to select one repository for each ambiguous hop.";
+  if (category === "missing_strong_ownership_evidence") return "Add an explicit package dependency, local service-path ownership, or registration ownership evidence.";
+  if (category === "missing_parameter_metadata") return "Export a statically analyzable helper with named or destructured parameters.";
+  if (category === "dynamic_wrapper_paths") return "Pass a literal path or provide the reported runtime identifier with --var key=value.";
+  return "Inspect the capped examples and add stronger implementation ownership evidence.";
 }
 function implementationCategory(row, evidence) {
   const reasons = JSON.stringify([evidence.ambiguityReasons, evidence.candidateFamilies, evidence.candidates, row.unresolvedReason]);
@@ -1670,11 +1725,24 @@ function renderTraceTable(result) {
   const lines = ["Step  Type                 From                                To                                  Evidence"];
   for (const e of result.edges) {
     lines.push(`${String(e.step).padEnd(5)} ${e.type.padEnd(20)} ${e.from.slice(0, 34).padEnd(35)} ${e.to.slice(0, 35).padEnd(36)} ${location(e.evidence)}`);
+    const hint = firstHint(e.evidence);
+    if (e.unresolvedReason && hint) lines.push(`      try ${hint}`);
   }
-  if (result.diagnostics.length > 0) lines.push("", "Diagnostics:", ...result.diagnostics.map((d) => `${String(d.severity ?? "info")} ${String(d.code ?? "diagnostic")} ${String(d.message ?? "")}`));
+  if (result.diagnostics.length > 0) lines.push("", "Diagnostics:", ...result.diagnostics.flatMap(diagnosticLines));
   return `${lines.join("\n")}
 `;
 }
+function diagnosticLines(diagnostic) {
+  const first = `${String(diagnostic.severity ?? "info")} ${String(diagnostic.code ?? "diagnostic")} ${String(diagnostic.message ?? "")}`;
+  const hint = firstHint(diagnostic);
+  return hint ? [first, `  try ${hint}`] : [first];
+}
+function firstHint(evidence) {
+  const suggestions = evidence.implementationHintSuggestions;
+  if (!Array.isArray(suggestions)) return void 0;
+  const first = suggestions.find((item) => Boolean(item) && typeof item === "object");
+  return typeof first?.cli === "string" ? first.cli : void 0;
+}
 
 // src/output/json-output.ts
 function renderJson(value) {
@@ -1788,7 +1856,7 @@ function createProgram() {
       );
     }).catch(fail)
   );
-  program.command("trace").option("--workspace <path>").option("--repo <name>").option("--operation <name>").option("--service <path>").option("--path <operationPath>").option("--handler <name>").option("--depth <n>", "trace depth", "25").option("--format <format>", "table|json|mermaid", "table").option("--include-external").option("--include-db").option("--include-async").option("--implementation-repo <name>").option("--var <key=value>", "dynamic variable", collect, []).action(
+  program.command("trace").option("--workspace <path>").option("--repo <name>").option("--operation <name>").option("--service <path>").option("--path <operationPath>").option("--handler <name>").option("--depth <n>", "trace depth", "25").option("--format <format>", "table|json|mermaid", "table").option("--include-external").option("--include-db").option("--include-async").option("--implementation-repo <name>").option("--implementation-hint <scope>", "scoped implementation hint", collect, []).option("--var <key=value>", "dynamic variable", collect, []).action(
     (opts) => void withReadOnlyWorkspace(opts.workspace, (db) => {
       const result = trace(
         db,
@@ -1805,7 +1873,8 @@ function createProgram() {
           includeExternal: Boolean(opts.includeExternal),
           includeDb: Boolean(opts.includeDb),
           includeAsync: Boolean(opts.includeAsync),
-          implementationRepo: opts.implementationRepo
+          implementationRepo: opts.implementationRepo,
+          implementationHints: opts.implementationHint.map(parseImplementationHint)
         }
       );
       process.stdout.write(
@@ -1874,7 +1943,7 @@ function createProgram() {
       process.stdout.write(renderJson(rows));
     }).catch(fail)
   );
-  program.command("graph").option("--workspace <path>").option("--repo <name>").option("--operation <name>").option("--service <path>").option("--path <operationPath>").option("--format <format>", "mermaid|json", "mermaid").option("--implementation-repo <name>").option("--var <key=value>", "dynamic variable", collect, []).action(
+  program.command("graph").option("--workspace <path>").option("--repo <name>").option("--operation <name>").option("--service <path>").option("--path <operationPath>").option("--format <format>", "mermaid|json", "mermaid").option("--implementation-repo <name>").option("--implementation-hint <scope>", "scoped implementation hint", collect, []).option("--var <key=value>", "dynamic variable", collect, []).action(
     (opts) => void withReadOnlyWorkspace(opts.workspace, (db) => {
       const result = trace(
         db,
@@ -1890,7 +1959,8 @@ function createProgram() {
           includeDb: true,
           includeExternal: true,
           vars: parseVars(opts.var),
-          implementationRepo: opts.implementationRepo
+          implementationRepo: opts.implementationRepo,
+          implementationHints: opts.implementationHint.map(parseImplementationHint)
         }
       );
       process.stdout.write(
@@ -1915,9 +1985,9 @@ function createProgram() {
       process.stdout.write(renderJson(rows));
     }).catch(fail)
   );
-  program.command("doctor").option("--workspace <path>").option("--strict").action(
+  program.command("doctor").option("--workspace <path>").option("--strict").option("--detail").action(
     (opts) => void withReadOnlyWorkspace(opts.workspace, (db) => {
-      const allDiagnostics = doctorDiagnostics(db, Boolean(opts.strict));
+      const allDiagnostics = doctorDiagnostics(db, Boolean(opts.strict), { detail: Boolean(opts.detail) });
       process.stdout.write(
         allDiagnostics.length ? renderJson(allDiagnostics) : `${pc.green("No diagnostics recorded")}
 `