@saptools/service-flow 0.1.33 → 0.1.35

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.1.35
+
+- Hardened OData path precedence so entity key, navigation, and media/property paths with placeholders remain terminal entity evidence instead of dynamic operation candidates.
+- Preserved separate evidence for service-routing placeholders, operation invocation argument placeholders, and entity key placeholders.
+- Render operation-resolved parser entity calls as operation calls in traces while retaining the original parser call type for auditability.
+- Added strict doctor coverage for dynamic remote-entity false positives without indexed operation evidence.
+
+## 0.1.34
+
+- Prefer indexed CDS operation evidence over heuristic remote-entity classification for service-client operation invocations, while keeping true collection, entity, delete, navigation, and media paths terminal.
+- Added strict doctor collision diagnostics for terminal remote entity edges that look like operation invocations with indexed operation candidates.
+- Persist repository fact analyzer versions and warn during link/strict doctor when force reindex is required after an analyzer upgrade.
+
 ## 0.1.33
 
 - Preserved persisted graph decisions and call-site evidence during trace and graph rendering while keeping contextual runtime resolution as enrichment.

package/TECHNICAL-NOTE.md

@@ -137,3 +137,8 @@ Schema version 6 adds queryable external target metadata columns to `outbound_ca
 ### 0.1.17 parser ownership policy
 
 Outbound call extraction is AST-based and ignores comments, block comments, and string literals. CAP/service `.on(...)` registrations are indexed only when the receiver has CAP/service evidence, and top-level registrations receive `module:<relative-file>#event:<event-name>:<line>` synthetic owners. Generic event emitters such as desktop or window events are ignored by default rather than guessed as CAP async edges. Unsupported source shapes are surfaced through diagnostics and strict doctor ownerless categories instead of guessed graph edges.
+
+
+## 0.1.35 OData placeholder semantics
+
+Service-flow now records OData placeholders by semantic layer. Service-routing placeholders belong to service bindings and can make an operation edge dynamic until runtime variables are supplied. Operation invocation argument placeholders, such as action/function call arguments, remain operation evidence but are not service-routing variables. Entity key placeholders belong to entity addressing, so key, navigation, and media/property paths remain terminal remote entity/query edges unless indexed CDS operation evidence provides a credible operation match.

package/dist/{chunk-CWJYVIG2.js → chunk-R47GA5VW.js}

@@ -557,13 +557,29 @@ function classifyODataPathIntent(path9, method) {
   const hasNavigationSegments = segments.length > 1;
   const entitySegment = entitySegmentFromPath(pathWithoutQuery);
   const placeholderKeys = [...new Set(extractTemplatePlaceholders(rawPath))];
-  const base = { rawPath, method: normalizedMethod, pathWithoutQuery, queryString, hasQueryString: queryIndex >= 0, entitySegment, placeholderKeys };
+  const firstOpen = firstSegment.indexOf("(");
+  const firstClose = firstOpen >= 0 ? matchingClose(firstSegment, firstOpen) : void 0;
+  const keyPredicateText = firstOpen >= 0 && firstClose !== void 0 ? firstSegment.slice(firstOpen + 1, firstClose) : "";
+  const rawKeyPredicatePlaceholderKeys = [...new Set(extractTemplatePlaceholders(keyPredicateText))];
+  const navigationSuffix = hasNavigationSegments ? segments.slice(1).join("/") : void 0;
+  const lastSegment = segments.at(-1) ?? "";
+  const mediaOrPropertySuffix = hasNavigationSegments ? lastSegment : void 0;
+  const invocation = normalizeODataOperationInvocationPath(pathWithoutQuery);
+  const operationNameFromInvocation = invocation?.wasInvocation ? invocation.normalizedOperationPath.replace(/^\//, "").split(".").at(-1) : void 0;
+  const topLevelName = firstSegment.split("(")[0]?.replace(/^\//, "");
+  const topLevelOperationName = operationNameFromInvocation ?? (!hasNavigationSegments && !firstSegment.includes("(") ? topLevelName : void 0);
+  const topLevelOperationInvocation = Boolean(invocation?.wasInvocation && looksLikeLowerCamelInvocation(firstSegment));
+  const keyPredicatePlaceholderKeys = topLevelOperationInvocation ? [] : rawKeyPredicatePlaceholderKeys;
+  const topLevelOperationNameCandidate = Boolean(topLevelOperationName && !hasNavigationSegments && !firstSegment.includes("("));
+  const base = { rawPath, method: normalizedMethod, pathWithoutQuery, queryString, hasQueryString: queryIndex >= 0, entitySegment, placeholderKeys, keyPredicatePlaceholderKeys, invocationArgumentPlaceholderKeys: invocation?.invocationArgumentPlaceholderKeys ?? [], navigationSuffix, mediaOrPropertySuffix, hasEntityKeyPredicate: firstOpen >= 0 && firstClose !== void 0, hasNavigationSuffix: hasNavigationSegments, hasMediaOrPropertySuffix: Boolean(mediaOrPropertySuffix && isMediaOrPropertySuffix(mediaOrPropertySuffix)), topLevelOperationName, topLevelOperationNameCandidate, topLevelOperationInvocation };
   if (!rawPath || !rawPath.startsWith("/")) return { ...base, kind: "unknown", reason: "path_missing_or_not_absolute" };
   const upperEntityLike = /^[A-Z][A-Za-z0-9_]*$/.test(entitySegment ?? firstSegment);
-  const mediaLike = ["content", "$value"].includes((segments.at(-1) ?? "").toLowerCase());
+  const mediaLike = isMediaOrPropertySuffix(segments.at(-1) ?? "");
   if (normalizedMethod !== "GET") {
+    if (invocation?.wasInvocation && looksLikeLowerCamelInvocation(firstSegment)) return { ...base, kind: "operation_invocation", reason: "non_get_balanced_top_level_operation_invocation" };
     if (mediaLike) return { ...base, kind: "entity_media", reason: "non_get_entity_media_stream_path" };
-    if (upperEntityLike || firstSegment.includes("(") || hasNavigationSegments) return { ...base, kind: normalizedMethod === "DELETE" ? "entity_delete" : "entity_mutation", reason: "non_get_entity_path_shape" };
+    if (hasNavigationSegments || firstSegment.includes("(")) return { ...base, kind: normalizedMethod === "DELETE" ? "entity_delete" : "entity_mutation", reason: firstSegment.includes("(") ? "non_get_entity_key_or_navigation_path_shape" : "non_get_entity_navigation_path_shape" };
+    if (upperEntityLike) return { ...base, kind: normalizedMethod === "DELETE" ? "entity_delete" : "entity_mutation", reason: "non_get_entity_path_shape" };
     return { ...base, kind: "operation_invocation", reason: "non_get_lowercase_path_may_be_operation" };
   }
   if (queryIndex >= 0) {
@@ -573,6 +589,7 @@ function classifyODataPathIntent(path9, method) {
   }
   if (hasNavigationSegments) return mediaLike ? { ...base, kind: "entity_media", reason: "get_entity_media_stream_path" } : { ...base, kind: "entity_navigation_query", reason: "get_path_has_navigation_segments" };
   if (firstSegment.includes("(")) {
+    if (invocation?.wasInvocation && looksLikeLowerCamelInvocation(firstSegment)) return { ...base, kind: "operation_invocation", reason: "get_balanced_top_level_operation_invocation" };
     return looksLikeLowerCamelInvocation(firstSegment) ? { ...base, kind: "operation_invocation", reason: "get_single_lower_camel_segment_has_top_level_invocation" } : { ...base, kind: "entity_key_read", reason: "get_entity_segment_has_key_predicate" };
   }
   if (/^[A-Z][A-Za-z0-9_]*$/.test(firstSegment)) return { ...base, kind: "entity_candidate", reason: "uppercase_collection_segment_without_indexed_entity_evidence" };
@@ -585,6 +602,9 @@ function entitySegmentFromPath(path9) {
   const entity = (open >= 0 ? first.slice(0, open) : first).trim();
   return entity || void 0;
 }
+function isMediaOrPropertySuffix(segment) {
+  return ["file", "content", "$value", "metadata", "items"].includes(segment.toLowerCase());
+}
 function looksLikeLowerCamelInvocation(segment) {
   const open = segment.indexOf("(");
   if (open <= 0) return false;
@@ -2102,9 +2122,22 @@ function insertCallEdge(db, workspaceId, call, vars, generation) {
   const destination = call.destinationExpr ?? call.requireDestination;
   const isDynamic = Boolean(Number(call.isDynamic ?? 0));
   const isRemoteEntityCall = callType.startsWith("remote_entity_");
-  const isOperationCall = !isRemoteEntityCall && (callType === "remote_action" || callType === "local_service_call" || callType === "remote_query" && Boolean(op));
+  const indexedOperationCandidateCount = operationCandidateCount(db, workspaceId, op, intent.topLevelOperationName);
+  const credibleOperationSignal = Boolean(normalized?.wasInvocation) || Boolean(intent.topLevelOperationNameCandidate) && indexedOperationCandidateCount > 0;
+  const strongEntitySignal = ["entity_media", "entity_delete", "entity_key_read", "entity_navigation_query"].includes(intent.kind) || intent.kind === "entity_mutation" && (intent.hasEntityKeyPredicate || intent.hasNavigationSuffix);
+  const operationLikeRemoteEntity = isRemoteEntityCall && Boolean(op) && credibleOperationSignal && (!strongEntitySignal || indexedOperationCandidateCount > 0);
+  const isOperationCall = operationLikeRemoteEntity || (callType === "remote_action" || callType === "local_service_call" || callType === "remote_query" && Boolean(op));
   const resolution = isOperationCall ? resolveOperation(db, { servicePath, operationPath: op, serviceName: call.local_service_name, repoId: callType === "local_service_call" ? Number(call.repo_id) : void 0, alias: applyVariables(call.aliasExpr ?? call.alias, vars), destination: destination ? applyVariables(destination, vars) : void 0, isDynamic, hasExplicitOverride: Object.keys(vars).length > 0 || callType === "local_service_call" }, workspaceId) : { status: "unresolved", candidates: [], reasons: [] };
-  const evidence = callEvidence(call, resolution, servicePath, op, destination ? applyVariables(destination, vars) : void 0, normalized, intent);
+  const evidence = { ...callEvidence(call, resolution, servicePath, op, destination ? applyVariables(destination, vars) : void 0, normalized, intent), indexedOperationCandidateCount, parserCallType: callType };
+  if (isRemoteEntityCall && (resolution.target || resolution.candidates.length > 0 || resolution.status === "dynamic")) {
+    if (resolution.target) {
+      db.prepare("INSERT INTO graph_edges(workspace_id,edge_type,status,from_kind,from_id,to_kind,to_id,confidence,evidence_json,is_dynamic,generation) VALUES(?,?,?,?,?,?,?,?,?,?,?)").run(workspaceId, "REMOTE_CALL_RESOLVES_TO_OPERATION", "resolved", "call", String(call.id), "operation", String(resolution.target.operationId), resolution.target.score, JSON.stringify({ ...evidence, operationEntityPrecedence: "indexed_operation_over_parser_entity" }), 0, generation);
+      return { status: "resolved", callType };
+    }
+    const status2 = resolution.status === "dynamic" ? "dynamic" : resolution.status === "ambiguous" ? "ambiguous" : "unresolved";
+    db.prepare("INSERT INTO graph_edges(workspace_id,edge_type,status,from_kind,from_id,to_kind,to_id,confidence,evidence_json,is_dynamic,unresolved_reason,generation) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)").run(workspaceId, status2 === "dynamic" ? "DYNAMIC_EDGE_CANDIDATE" : "UNRESOLVED_EDGE", status2, "call", String(call.id), "operation_candidate", op ? `Remote action: ${op}` : "Remote action: unknown path", Number(call.confidence ?? 0.2), JSON.stringify({ ...evidence, operationEntityPrecedence: resolution.candidates.length > 0 ? "parser_entity_with_indexed_operation_candidates" : "parser_entity_operation_candidate_without_indexed_match" }), status2 === "dynamic" ? 1 : 0, unresolvedOperationReason(resolution), generation);
+    return { status: status2, callType };
+  }
   if (isRemoteEntityCall) {
     const target = buildRemoteQueryTarget({ queryEntity: intent.entitySegment ?? call.query_entity, servicePath, serviceAlias: call.alias, serviceAliasExpr: call.aliasExpr, destination: destination ? applyVariables(destination, vars) : void 0, isDynamic, parserWarning: evidence.parserWarning });
     const entityKind = callType.replace("remote_entity_", "remote_entity_");
@@ -2135,6 +2168,12 @@ function insertCallEdge(db, workspaceId, call, vars, generation) {
   db.prepare("INSERT INTO graph_edges(workspace_id,edge_type,status,from_kind,from_id,to_kind,to_id,confidence,evidence_json,is_dynamic,unresolved_reason,generation) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)").run(workspaceId, edgeType, status, "call", String(call.id), targetKind, targetId, Number(call.confidence ?? 0.2), JSON.stringify(finalEvidence), graphLevelDynamic ? 1 : 0, unresolvedReason, generation);
   return { status, callType };
 }
+function operationCandidateCount(db, workspaceId, operationPath, operationName) {
+  if (!operationPath && !operationName) return 0;
+  const normalizedName = operationName ?? operationPath?.replace(/^\//, "").split(".").at(-1);
+  const row = db.prepare(`SELECT COUNT(*) count FROM cds_operations o JOIN cds_services s ON s.id=o.service_id JOIN repositories r ON r.id=s.repo_id WHERE r.workspace_id=? AND (o.operation_path=? OR o.operation_path=? OR o.operation_name=?)`).get(workspaceId, operationPath, normalizedName ? `/${normalizedName}` : operationPath, normalizedName);
+  return Number(row?.count ?? 0);
+}
 function unresolvedOperationReason(resolution) {
   if (resolution.status === "dynamic") return `Dynamic target requires runtime variable overrides: ${(resolution.reasons.length ? resolution.reasons : ["missing runtime variables"]).join(", ")}`;
   if (resolution.candidates.length === 0) return "No indexed target operation matched";
@@ -2555,6 +2594,11 @@ function handlerScope(db, methodId) {
   if (!row) return void 0;
   return { repoId: row.repoId, files: new Set(row.sourceFile ? [row.sourceFile] : []), symbolId: row.symbolId };
 }
+function traceEdgeType(call, row) {
+  if (row.to_kind === "operation" && row.edge_type === "REMOTE_CALL_RESOLVES_TO_OPERATION") return "remote_action";
+  if (row.to_kind === "operation" && row.edge_type === "LOCAL_CALL_RESOLVES_TO_OPERATION") return "local_service_call";
+  return String(call.call_type);
+}
 function includeCall(type, options) {
   if (!options.includeDb && type === "local_db_query") return false;
   if (!options.includeExternal && type === "external_http") return false;
@@ -2848,7 +2892,7 @@ function trace(db, start, options) {
         const to = edgeTarget(effectiveRow, evidence);
         edges.push({
           step: current.depth,
-          type: String(call.call_type),
+          type: traceEdgeType(call, effectiveRow),
           from: `${call.repoName}:${call.source_file}:${call.source_line}`,
           to,
           evidence,
@@ -2920,6 +2964,7 @@ export {
   redactText,
   redactValue,
   normalizeODataOperationInvocationPath,
+  classifyODataPathIntent,
   containsSupportedOutboundCall,
   parseOutboundCalls,
   parseServiceBindings,
@@ -2929,4 +2974,4 @@ export {
   linkWorkspace,
   trace
 };
-//# sourceMappingURL=chunk-CWJYVIG2.js.map
+//# sourceMappingURL=chunk-R47GA5VW.js.map