@saptools/service-flow 0.1.11 → 0.1.13

package/dist/cli.js

@@ -10,7 +10,7 @@ import {
   parsePackageJson,
   parseServiceBindings,
   trace
-} from "./chunk-GG4XJGES.js";
+} from "./chunk-Q7W7TE3W.js";
 
 // src/cli.ts
 import { Command } from "commander";
@@ -185,7 +185,7 @@ function migrate(db) {
 // package.json
 var package_default = {
   name: "@saptools/service-flow",
-  version: "0.1.11",
+  version: "0.1.13",
   description: "Trace SAP CAP service-to-service flows across multi-repository workspaces with runtime-aware graph resolution",
   type: "module",
   publishConfig: {
@@ -545,7 +545,7 @@ function insertExecutableSymbols(db, repoId, rows) {
 function insertSymbolCalls(db, repoId, rows) {
   const stmt = db.prepare(`INSERT INTO symbol_calls(repo_id,caller_symbol_id,callee_symbol_id,callee_expression,import_source,source_file,source_line,status,confidence,evidence_json,unresolved_reason) VALUES(?,(SELECT id FROM symbols WHERE repo_id=? AND source_file=? AND qualified_name=? ORDER BY id LIMIT 1),(SELECT id FROM symbols WHERE repo_id=? AND ((source_file=? AND (name=? OR qualified_name=?)) OR (source_file<>? AND exported=1 AND (exported_name=? OR name=? OR qualified_name=?))) ORDER BY CASE WHEN source_file=? THEN 0 ELSE 1 END,id LIMIT 1),?,?,?,?,?,0.8,?,CASE WHEN (SELECT id FROM symbols WHERE repo_id=? AND ((source_file=? AND (name=? OR qualified_name=?)) OR (source_file<>? AND exported=1 AND (exported_name=? OR name=? OR qualified_name=?))) ORDER BY CASE WHEN source_file=? THEN 0 ELSE 1 END,id LIMIT 1) IS NULL THEN 'No local symbol target matched exactly' ELSE NULL END)`);
   for (const r of rows) stmt.run(repoId, repoId, r.sourceFile, r.callerQualifiedName, repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.calleeLocalName, r.sourceFile, r.calleeExpression, r.importSource, r.sourceFile, r.sourceLine, JSON.stringify(r.evidence), repoId, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.sourceFile, r.calleeLocalName, r.calleeLocalName, r.calleeLocalName, r.sourceFile);
-  db.prepare("UPDATE symbol_calls SET status=CASE WHEN callee_symbol_id IS NULL THEN 'unresolved' ELSE 'resolved' END WHERE repo_id=?").run(repoId);
+  db.prepare("UPDATE symbol_calls SET status=CASE WHEN callee_symbol_id IS NULL THEN 'unresolved' ELSE 'resolved' END, unresolved_reason=CASE WHEN callee_symbol_id IS NULL THEN COALESCE(unresolved_reason,'No local symbol target matched exactly') ELSE NULL END WHERE repo_id=?").run(repoId);
 }
 function insertCalls(db, repoId, rows) {
   const stmt = db.prepare(
@@ -643,11 +643,31 @@ function isFunctionLike(node) {
 function exported(node) {
   return Boolean(ts.getCombinedModifierFlags(node) & ts.ModifierFlags.Export);
 }
+function exportDeclarations(source) {
+  const exports = /* @__PURE__ */ new Map();
+  const visit = (node) => {
+    if (ts.isExportDeclaration(node) && node.exportClause && ts.isNamedExports(node.exportClause)) {
+      for (const el of node.exportClause.elements) exports.set((el.propertyName ?? el.name).text, el.name.text);
+    }
+    ts.forEachChild(node, visit);
+  };
+  visit(source);
+  return exports;
+}
+function isRelativeImport(value) {
+  return Boolean(value?.startsWith("."));
+}
+function isObjectFunction(node) {
+  return ts.isFunctionExpression(node) || ts.isArrowFunction(node) || ts.isMethodDeclaration(node);
+}
+var commonTerminalMembers = /* @__PURE__ */ new Set(["push", "includes", "find", "findIndex", "map", "filter", "reduce", "forEach", "some", "every", "toUpperCase", "toLowerCase", "trim", "split", "join", "get", "set", "has"]);
+var loggerMembers = /* @__PURE__ */ new Set(["trace", "debug", "info", "warn", "error", "fatal", "log"]);
+var globalObjects = /* @__PURE__ */ new Set(["JSON", "Object", "Array", "String", "Number", "Boolean", "Math", "Date", "Promise", "Reflect"]);
 function callName(expr) {
   if (ts.isIdentifier(expr)) return { expression: expr.text, local: expr.text };
   if (ts.isPropertyAccessExpression(expr)) {
     const left = expr.expression.getText();
-    return { expression: expr.getText(), local: left === "this" ? void 0 : left, member: expr.name.text };
+    return { expression: expr.getText(), local: left === "this" ? void 0 : left, member: expr.name.text, receiver: left };
   }
   return { expression: expr.getText() };
 }
@@ -661,8 +681,13 @@ async function parseExecutableSymbols(repoPath, filePath) {
   const symbols = [];
   const calls = [];
   const imports = /* @__PURE__ */ new Map();
+  const exportNames = exportDeclarations(source);
+  const objectExports = /* @__PURE__ */ new Set();
   const addSymbol = (kind, localName, node, parentName, exportedName) => {
-    symbols.push({ kind, localName, exportedName, qualifiedName: parentName ? `${parentName}.${localName}` : localName, sourceFile, startLine: lineOf(source, node.getStart(source)), endLine: lineOf(source, node.getEnd()), startOffset: node.getStart(source), endOffset: node.getEnd(), exported: exported(node) || Boolean(exportedName), importExportEvidence: exportedName ? { exportedName } : void 0 });
+    const declaredExportName = exportedName ?? exportNames.get(parentName ? parentName.split(".")[0] ?? localName : localName);
+    const qualifiedName = parentName ? `${parentName}.${localName}` : localName;
+    const objectExported = parentName ? objectExports.has(parentName.split(".")[0] ?? "") : false;
+    symbols.push({ kind, localName: kind === "object_method" ? qualifiedName : localName, exportedName: objectExported ? qualifiedName : declaredExportName, qualifiedName, sourceFile, startLine: lineOf(source, node.getStart(source)), endLine: lineOf(source, node.getEnd()), startOffset: node.getStart(source), endOffset: node.getEnd(), exported: exported(node) || Boolean(declaredExportName) || objectExported, importExportEvidence: declaredExportName ? { exportedName: declaredExportName, source: "export_declaration" } : objectExported ? { exportedName: qualifiedName, source: "exported_object_literal" } : void 0 });
   };
   const visitImports = (node) => {
     if (ts.isImportDeclaration(node) && ts.isStringLiteral(node.moduleSpecifier)) {
@@ -686,20 +711,46 @@ async function parseExecutableSymbols(repoPath, filePath) {
       if (localName) addSymbol("method", localName, node, parentClass);
     } else if (ts.isFunctionDeclaration(node) && node.name) addSymbol("function", node.name.text, node, void 0, exported(node) ? node.name.text : void 0);
     else if (ts.isVariableStatement(node)) {
-      for (const d of node.declarationList.declarations) if (d.initializer && isFunctionLike(d.initializer)) {
+      for (const d of node.declarationList.declarations) {
         const localName = nameOf(d.name);
-        if (localName) addSymbol("function", localName, d.initializer, void 0, exported(node) ? localName : void 0);
+        if (!localName || !d.initializer) continue;
+        if (isFunctionLike(d.initializer)) addSymbol("function", localName, d.initializer, void 0, exported(node) ? localName : exportNames.get(localName));
+        if (ts.isObjectLiteralExpression(d.initializer)) {
+          if (exported(node) || exportNames.has(localName)) objectExports.add(localName);
+          for (const prop of d.initializer.properties) {
+            if (ts.isPropertyAssignment(prop) && isObjectFunction(prop.initializer)) {
+              const propName = nameOf(prop.name);
+              if (propName) addSymbol("object_method", propName, prop.initializer, localName);
+            } else if (ts.isMethodDeclaration(prop)) {
+              const propName = nameOf(prop.name);
+              if (propName) addSymbol("object_method", propName, prop, localName);
+            }
+          }
+        }
       }
     } else ts.forEachChild(node, (child) => visitSymbols(child, parentClass));
   };
   visitSymbols(source);
+  const localCallables = new Set(symbols.flatMap((sym) => [sym.localName, sym.qualifiedName]));
   const visitCalls = (node) => {
     if (ts.isCallExpression(node)) {
       const line = lineOf(source, node.getStart(source));
       const caller = nearest(symbols, line);
       if (caller) {
         const callee = callName(node.expression);
-        calls.push({ callerQualifiedName: caller.qualifiedName, calleeExpression: callee.expression, calleeLocalName: callee.member ?? callee.local, receiverLocalName: callee.member ? callee.local : void 0, importSource: (callee.local ? imports.get(callee.local) : void 0) ?? (callee.member && callee.local ? imports.get(callee.local) : void 0), sourceFile, sourceLine: line, evidence: { relation: callee.importSource ? "imported" : callee.expression.startsWith("this.") ? "this_method" : "local" } });
+        const importSource = (callee.local ? imports.get(callee.local) : void 0) ?? (callee.member && callee.local ? imports.get(callee.local) : void 0);
+        const targetName = callee.expression.startsWith("this.") ? callee.member : callee.member && callee.local ? `${callee.local}.${callee.member}` : callee.local;
+        const className = caller.qualifiedName.includes(".") ? caller.qualifiedName.split(".")[0] : void 0;
+        const thisTarget = className && callee.member ? `${className}.${callee.member}` : void 0;
+        const loggerLike = callee.receiver?.endsWith(".logger") || callee.local === "logger" || (callee.expression.startsWith("this.logger.") && callee.member ? loggerMembers.has(callee.member) : false);
+        const terminalMember = callee.member ? commonTerminalMembers.has(callee.member) || loggerMembers.has(callee.member) : false;
+        const provenLocal = Boolean(targetName) && localCallables.has(String(targetName));
+        const provenThisMethod = Boolean(thisTarget && localCallables.has(thisTarget));
+        const provenRelativeImport = Boolean(isRelativeImport(importSource));
+        const globalLike = callee.local ? globalObjects.has(callee.local) : false;
+        const importedFromPackage = Boolean(importSource && !isRelativeImport(importSource));
+        const keep = Boolean(targetName) && !loggerLike && !globalLike && !importedFromPackage && (provenLocal || provenThisMethod || provenRelativeImport || !terminalMember && !callee.expression.startsWith("this."));
+        if (keep) calls.push({ callerQualifiedName: caller.qualifiedName, calleeExpression: callee.expression, calleeLocalName: provenThisMethod ? thisTarget : targetName, receiverLocalName: callee.member ? callee.local : void 0, importSource, sourceFile, sourceLine: line, evidence: { relation: importSource ? "relative_import" : provenThisMethod ? "indexed_this_method" : provenLocal ? "indexed_local_symbol" : "unresolved_actionable_property_call", caller: caller.qualifiedName, targetName: provenThisMethod ? thisTarget : targetName } });
       }
     }
     ts.forEachChild(node, visitCalls);
@@ -854,10 +905,14 @@ function location(evidence) {
   }
   return ":";
 }
+function displayTarget(value, evidence) {
+  if (/^\d+$/.test(value) && evidence.parserWarning) return "Entity: unknown";
+  return value;
+}
 function renderTraceTable(result) {
   const lines = ["Step  Type                 From                                To                                  Evidence"];
   for (const e of result.edges) {
-    lines.push(`${String(e.step).padEnd(5)} ${e.type.padEnd(20)} ${e.from.slice(0, 34).padEnd(35)} ${e.to.slice(0, 35).padEnd(36)} ${location(e.evidence)}`);
+    lines.push(`${String(e.step).padEnd(5)} ${e.type.padEnd(20)} ${e.from.slice(0, 34).padEnd(35)} ${displayTarget(e.to, e.evidence).slice(0, 35).padEnd(36)} ${location(e.evidence)}`);
   }
   if (result.diagnostics.length > 0) lines.push("", "Diagnostics:", ...result.diagnostics.map((d) => `${String(d.severity ?? "info")} ${String(d.code ?? "diagnostic")} ${String(d.message ?? "")}`));
   return `${lines.join("\n")}
@@ -877,11 +932,17 @@ function renderTraceJson(trace2) {
 function safe(value) {
   return value.replace(/[^\w-]/g, "_").slice(0, 60);
 }
+function label(trace2, idOrLabel) {
+  const edge = trace2.edges.find((item) => item.to === idOrLabel);
+  if (/^\d+$/.test(idOrLabel) && edge?.evidence.parserWarning) return "Entity: unknown";
+  const node = trace2.nodes.find((item) => item.id === idOrLabel || item.label === idOrLabel);
+  return String(node?.label ?? idOrLabel);
+}
 function renderMermaid(trace2) {
   const lines = ["flowchart TD"];
   for (const e of trace2.edges)
     lines.push(
-      `  ${safe(e.from)}["${e.from}"] -->|${e.type}| ${safe(e.to)}["${e.to}"]`
+      `  ${safe(e.from)}["${label(trace2, e.from)}"] -->|${e.type}| ${safe(e.to)}["${label(trace2, e.to)}"]`
     );
   return `${lines.join("\n")}
 `;
@@ -941,6 +1002,19 @@ async function withReadOnlyWorkspace(workspace, fn) {
     db.close();
   }
 }
+function localServiceDiagnostics(db, strict) {
+  const rows = db.prepare(`SELECT e.status status,e.unresolved_reason reason,e.evidence_json evidenceJson FROM graph_edges e JOIN outbound_calls c ON e.from_kind='call' AND c.id=CAST(e.from_id AS INTEGER) WHERE c.call_type='local_service_call'`).all();
+  const implementationContext = rows.filter((row) => row.status === "resolved" && String(row.evidenceJson ?? "").includes("implementation_context_caller_ownership")).length;
+  const withoutOwnership = rows.filter((row) => row.reason === "local_service_candidate_without_caller_ownership" || String(row.evidenceJson ?? "").includes("local_service_candidate_without_caller_ownership")).length;
+  const unresolved = rows.filter((row) => row.status === "unresolved").length;
+  const outsideScope = rows.filter((row) => row.status === "unresolved" && String(row.evidenceJson ?? "").includes("candidateCount")).length;
+  const out = [];
+  if (withoutOwnership > 0) out.push({ severity: "warning", code: "local_service_candidate_without_caller_ownership", message: `Local service calls have operation candidates but no caller ownership evidence: ${withoutOwnership}` });
+  if (outsideScope > 0) out.push({ severity: "warning", code: "local_service_candidates_outside_local_scope", message: `Local service calls found candidates outside same-repository scope: ${outsideScope}` });
+  if (strict && unresolved > 0) out.push({ severity: "warning", code: "local_service_calls_unresolved", message: `Unresolved local service calls: ${unresolved}` });
+  if (strict && implementationContext > 0) out.push({ severity: "info", code: "local_service_calls_resolved_by_implementation_context", message: `Local service calls resolved by implementation-context ownership: ${implementationContext}` });
+  return out;
+}
 function createProgram() {
   const program = new Command();
   program.name("service-flow").description(
@@ -1138,8 +1212,8 @@ function createProgram() {
                SELECT 'error','local_service_accessor_misclassified','Entity accessor calls were indexed as /entities operations',source_file,source_line
                FROM outbound_calls WHERE call_type='local_service_call' AND operation_path_expr='/entities' AND (? OR 1)
                UNION ALL
-               SELECT CASE WHEN ? THEN 'warning' ELSE 'error' END,'outbound_calls_without_source_symbol','Outbound calls lack source symbol ownership: ' || COUNT(*),NULL,NULL
-               FROM outbound_calls WHERE source_symbol_id IS NULL HAVING COUNT(*) >= CASE WHEN ? THEN 1 ELSE 10 END
+               SELECT 'warning','outbound_calls_without_source_symbol','Outbound calls lack source symbol ownership: ' || COUNT(*),NULL,NULL
+               FROM outbound_calls WHERE source_symbol_id IS NULL AND ? HAVING COUNT(*) >= 1
                UNION ALL
                SELECT 'warning','trace_scope_fell_back_to_file','Trace may fall back to source-file scope for calls without symbols',NULL,NULL
                WHERE EXISTS (SELECT 1 FROM outbound_calls WHERE source_symbol_id IS NULL) AND ?
@@ -1149,8 +1223,9 @@ function createProgram() {
                UNION ALL
                SELECT 'warning','index_run_abandoned','Index run ' || id || ' started at ' || started_at || ' is still running after the 60 minute abandonment threshold',NULL,NULL
                FROM index_runs WHERE status='running' AND datetime(started_at) < datetime('now','-60 minutes')`
-      ).all(Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict));
-      const allDiagnostics = [...diagnostics, ...health];
+      ).all(Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict), Boolean(opts.strict));
+      const localServiceHealth = localServiceDiagnostics(db, Boolean(opts.strict));
+      const allDiagnostics = [...diagnostics, ...health, ...localServiceHealth];
       process.stdout.write(
         allDiagnostics.length ? renderJson(allDiagnostics) : `${pc.green("No diagnostics recorded")}
 `