@sap/xsodata 8.2.1 → 8.3.1

package/lib/sql/dataCollectorPut.js

@@ -10,16 +10,16 @@ const SqlError = require('../utils/errors/sqlError');
 exports.moveRecordNV_ToInsertTmpStm = function (context, asyncDone) {
     context.logger.silly('dataCollector', 'moveRecordNV_ToInsertTmpStm');
     //get dbSegment for inserting the payload
-    var dbSeg = context.oData.dbSegmentLast;
-    var stm = dbSeg.sql.stmContainer.insertTmp;
+    const dbSeg = context.oData.dbSegmentLast;
+    const stm = dbSeg.sql.stmContainer.insertTmp;
     if (!stm) {
         return asyncDone("Internal server error", context);
     }
 
-    var max = dbSeg._recordNV.length;
-    var i;
+    const max = dbSeg._recordNV.length;
+    let i;
     for (i = 0; i < max; i++) {
-        var nv = dbSeg._recordNV[i];
+        const nv = dbSeg._recordNV[i];
         stm.setValue(nv.name, nv.value, dbSeg.entityType.propertiesMap[nv.name].DATA_TYPE_NAME); // OK
     }
     return asyncDone(null, context);
@@ -27,8 +27,8 @@ exports.moveRecordNV_ToInsertTmpStm = function (context, asyncDone) {
 
 
 exports.createTmpTables = function (context, asyncDone) {
-    var dbSeg = context.oData.dbSegmentLast;
-    var stms = [dbSeg.sql.stmContainer.createTmpOld, dbSeg.sql.stmContainer.createTmp];
+    const dbSeg = context.oData.dbSegmentLast;
+    const stms = [dbSeg.sql.stmContainer.createTmpOld, dbSeg.sql.stmContainer.createTmp];
     return statementProcessor.execStmsDirectlyNoResult(context,stms,  asyncDone);
 
 };
@@ -36,17 +36,17 @@ exports.createTmpTables = function (context, asyncDone) {
 exports.checkForAutoKeyGenUsage = function (context, asyncDone) {
     context.logger.silly('dataCollectorPut', 'checkForAutoKeyGenUsage');
 
-    var dbSeg = context.oData.dbSegmentLast;
+    const dbSeg = context.oData.dbSegmentLast;
     if (!dbSeg.entityType.hasAdmindata()) {
         return asyncDone(null, context);
     }
 
 
-    var stm = dbSeg.sql.stmContainer.insertTmp;
-    var appData = {};
-    var i;
-    var nv = stm.nv;
-    var name = '';
+    const stm = dbSeg.sql.stmContainer.insertTmp;
+    const appData = {};
+    let i;
+    const nv = stm.nv;
+    let name = '';
 
     const createBy = dbSeg.entityType.getAddAdmindata('create', 'by');
     const createAt = dbSeg.entityType.getAddAdmindata('create', 'at');
@@ -55,7 +55,7 @@ exports.checkForAutoKeyGenUsage = function (context, asyncDone) {
 
     for (i = 0; i < nv.length; i++) {
         name = nv[i].name.toSqlHana(null, null, { withoutTable: true });
-        name = name.substr(1, name.length - 2);
+        name = name.slice(1, -1);
         appData[name] = {
             value: nv[i].value,
             sequence: null
@@ -78,20 +78,20 @@ exports.checkForAutoKeyGenUsage = function (context, asyncDone) {
 };
 
 
-var insertOldDataToOldTable = function (context, asyncDone) {
+const insertOldDataToOldTable = function (context, asyncDone) {
     context.logger.silly('dataCollectorPost', 'insertOldDataToOldTable');
 
-    var dbSeg = context.oData.dbSegmentLast;
-    var stm = dbSeg.sql.stmContainer.selectCreateInfoFromTmpOld;
-    var nv = dbSeg.sql.stmContainer.insertTmp.nv;
-    var name;
+    const dbSeg = context.oData.dbSegmentLast;
+    const stm = dbSeg.sql.stmContainer.selectCreateInfoFromTmpOld;
+    const nv = dbSeg.sql.stmContainer.insertTmp.nv;
+    let name;
 
     const createBy = dbSeg.entityType.getAddAdmindata('create', 'by');
     const createAt = dbSeg.entityType.getAddAdmindata('create', 'at');
 
 
-    var p = [];
-    var sql = stm.toSqlHana(new sqlStatement.SqlBuildHanaContext(context), p);
+    const p = [];
+    const sql = stm.toSqlHana(new sqlStatement.SqlBuildHanaContext(context), p);
 
     dataCollector2.executeSqlAsPreparedStatement(context, sql, p, (err, rows) => {
         if (err) {
@@ -102,15 +102,15 @@ var insertOldDataToOldTable = function (context, asyncDone) {
 
         context.logger.silly('selectData', 'rows: ' + JSON.stringify(rows.length));
 
-        for (let i = 0; i < nv.length; i++) {
-            name = nv[i].name.toSqlHana(null, null, { withoutTable: true });
+        for (const element of nv) {
+            name = element.name.toSqlHana(null, null, { withoutTable: true });
             name = name.substr(1, name.length - 2);
 
             if (createBy && name === 'CREATED_BY') {
-                nv[i].value = new sqlStatement.Value(rows[0].CREATED_BY);
+                element.value = new sqlStatement.Value(rows[0].CREATED_BY);
             }
             if (createAt && name === 'CREATED_AT') {
-                nv[i].value = new sqlStatement.Value(rows[0].CREATED_AT);
+                element.value = new sqlStatement.Value(rows[0].CREATED_AT);
             }
         }
         return asyncDone(null, context);
@@ -119,25 +119,25 @@ var insertOldDataToOldTable = function (context, asyncDone) {
 };
 
 exports.insertOldDataToOldTable = function (context, asyncDone) {
-    var dbSeg = context.oData.dbSegmentLast;
+    const dbSeg = context.oData.dbSegmentLast;
     return statementProcessor.execStmsAsPreparedNoResult( context,dbSeg.sql.stmContainer.insertTmpOld, asyncDone);
 };
 
 exports.moveCreatedInfoToNewTempTable = function (context, asyncDone) {
-    var dbSeg = context.oData.dbSegmentLast;
+    const dbSeg = context.oData.dbSegmentLast;
     statementProcessor.execStmsAsPreparedNoResult(context,dbSeg.sql.stmContainer.updateTmpCreateInfo, asyncDone);
 };
 
 exports.insertPayloadIntoTempTable = function (context, asyncDone) {
     context.logger.silly('dataCollectorPut', 'insertPayloadIntoTempTable');
-    var dbSeg = context.oData.dbSegmentLast;
+    const dbSeg = context.oData.dbSegmentLast;
     statementProcessor.execStmsAsPreparedNoResult(context,dbSeg.sql.stmContainer.insertTmp, asyncDone);
 };
 
 
 exports.insertTmpTableToRealTable = function (context, asyncDone) {
     context.logger.silly('dataCollectorPut', 'insertTmpTableToRealTable');
-    var dbSeg = context.oData.dbSegmentLast;
+    const dbSeg = context.oData.dbSegmentLast;
 
     statementProcessor.execStmsAsPrepared(context,[dbSeg.sql.stmContainer.updateReal],  (err, context, resultset) => {
         if (err) {
@@ -149,11 +149,11 @@ exports.insertTmpTableToRealTable = function (context, asyncDone) {
 
 exports.selectData = function (context, asyncDone) {
     context.logger.silly('dataCollectorPost', 'selectData');
-    var dbSeg = context.oData.dbSegmentLast;
-    var stm = dbSeg.sql.stmContainer.selectFromTmp;
+    const dbSeg = context.oData.dbSegmentLast;
+    const stm = dbSeg.sql.stmContainer.selectFromTmp;
 
-    var p = [];
-    var sql = stm.toSqlHana(new sqlStatement.SqlBuildHanaContext(context), p);
+    const p = [];
+    const sql = stm.toSqlHana(new sqlStatement.SqlBuildHanaContext(context), p);
     dataCollector2.executeSqlAsPreparedStatement(context,sql,p, (err, rows)=> {
             dbSeg.sql.rows = rows;
             if (rows.length === 1 && utils.isETagHeaderRequired(context, dbSeg)) {
@@ -170,7 +170,7 @@ exports.commit = function (context, asyncDone) {
         return asyncDone(null, context);
     }
 
-    var client = context.db.client;
+    const client = context.db.client;
     client.commit(function (err) {
         if (err) {
             context.logger.info('SQL Exec', 'Commit Error: \n' + JSON.stringify(err));
@@ -187,7 +187,7 @@ exports.commit = function (context, asyncDone) {
  * @param {Function} asyncDone async waterfall callback
  */
 exports.truncateTempTables = function (context, asyncDone) {
-    var statements;
+    let statements;
     context.logger.silly('dataCollectorPut', 'truncateTempTables');
 
     statements = [
@@ -204,7 +204,7 @@ exports.truncateTempTables = function (context, asyncDone) {
  * @param {Function} asyncDone async waterfall callback
  */
 exports.dropTempTables = function (context, asyncDone) {
-    var statements;
+    let statements;
     context.logger.silly('dataCollectorPut', 'dropTempTables');
 
     statements = [

package/lib/sql/dataCollectorPutPostLinks.js

@@ -2,11 +2,11 @@
 
 //Include
 
-var dataCollector2 = require('./dataCollector2');
-var statementProcessor = require('./statementProcessor');
+const dataCollector2 = require('./dataCollector2');
+const statementProcessor = require('./statementProcessor');
 
 exports.insertTmpTableToRealMNTable = function (context, asyncDone) {
-	var dbSeg = context.oData.dbSegmentLast;
+	const dbSeg = context.oData.dbSegmentLast;
 
 	statementProcessor.execStmsAsPrepared(context,dbSeg.sql.stmContainer.insertReal,
     (err, context, resultset) => {