@sap/open.fe 1.98.0 → 1.99.0

package/packages/sap.fe.core/test/sap/fe/core/jest/controllerextensions/MessageHandler.spec.ts

@@ -1,12 +1,11 @@
 import { MessageHandler } from "sap/fe/core/controllerextensions";
-import { messageHandling } from "sap/fe/core/actions";
+import messageHandling from "sap/fe/core/actions/messageHandling";
 import { error } from "console";
-import { CommonUtils } from "sap/fe/core";
+import CommonUtils from "sap/fe/core/CommonUtils";
 
 describe("ShowMessages and ShowMessagesInDialog", () => {
 	class TestableMessageHandler extends MessageHandler {
 		getShowBoundMessagesInMessageDialog = jest.fn();
-		_checkNavigationToMessagePage = jest.fn();
 		removeTransitionMessages = jest.fn();
 		_getSecondsBeforeRetryAfter = jest.fn();
 	}
@@ -17,6 +16,29 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 	let oMockShowUnboundMessages: any;
 	let MessageHandlerExt = new TestableMessageHandler();
 	let oCheckFclEnabled: any;
+	let oMockIsSticky: any;
+
+	let getMessageMockObject = function(iHttpStatus: number, bRetryAfter: boolean) {
+		return [
+			{
+				getCode: function() {
+					return "" + iHttpStatus;
+				},
+				getMessage: function() {
+					return "Delete service not available";
+				},
+				getType: function() {
+					return "Error";
+				},
+				getTechnicalDetails: function() {
+					return {
+						httpStatus: iHttpStatus,
+						retryAfter: bRetryAfter
+					};
+				}
+			}
+		];
+	};
 	// let oMockGetMessages: any;
 	// let oMockIsSticky: any;
 	// let oMockGetSecondsBeforeRetryAfter: any;
@@ -106,9 +128,12 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 	});
 
 	describe("showMessages", () => {
+		let oCheckNavigationToMessagePageMock: any;
 		beforeEach(() => {
 			oCheckFclEnabled.mockReturnValue(oMockAppComponent);
 			oMockAppComponent._isFclEnabled.mockReturnValue(false);
+			oCheckNavigationToMessagePageMock = jest.spyOn(MessageHandlerExt, "_checkNavigationToMessagePage");
+			oCheckNavigationToMessagePageMock.mockImplementation(() => null);
 		});
 
 		it("ensures that basic flow of showMessages (dialog)", async () => {
@@ -117,8 +142,8 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 			});
 			const bResponse = await MessageHandlerExt.showMessages();
 			expect(bResponse).toEqual(true);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toBeCalledTimes(1);
-			expect(MessageHandlerExt._checkNavigationToMessagePage.mock.invocationCallOrder[0]).toBeLessThan(
+			expect(oCheckNavigationToMessagePageMock).toBeCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock.mock.invocationCallOrder[0]).toBeLessThan(
 				oMockGetShowBoundMessagesInMessageDialog.mock.invocationCallOrder[0]
 			);
 			expect(oMockShowUnboundMessages.mock.invocationCallOrder[0]).toBeGreaterThan(
@@ -128,8 +153,8 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 			expect(oMockGetShowBoundMessagesInMessageDialog).toHaveBeenCalledTimes(1);
 			// check that showUnboundMessages is only called once
 			expect(oMockShowUnboundMessages).toHaveBeenCalledTimes(1);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
 		});
 
 		it("rejects the promise of showMessages (dialog) if showUnboundMessages throws error", async () => {
@@ -139,8 +164,8 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 				});
 			});
 			await expect(MessageHandlerExt.showMessages()).rejects.toThrowError();
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toBeCalledTimes(1);
-			expect(MessageHandlerExt._checkNavigationToMessagePage.mock.invocationCallOrder[0]).toBeLessThan(
+			expect(oCheckNavigationToMessagePageMock).toBeCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock.mock.invocationCallOrder[0]).toBeLessThan(
 				oMockGetShowBoundMessagesInMessageDialog.mock.invocationCallOrder[0]
 			);
 			expect(oMockShowUnboundMessages.mock.invocationCallOrder[0]).toBeGreaterThan(
@@ -150,17 +175,17 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 			expect(oMockGetShowBoundMessagesInMessageDialog).toHaveBeenCalledTimes(1);
 			// check that showUnboundMessages is only called once
 			expect(oMockShowUnboundMessages).toHaveBeenCalledTimes(1);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
 		});
 
 		it("ensures the basic flow of showMessages (page)", async () => {
 			(MessageHandlerExt as any).base._routing.navigateToMessagePage.mockImplementationOnce(async () => {
 				return Promise.resolve(true);
 			});
-			MessageHandlerExt._checkNavigationToMessagePage.mockReturnValueOnce({ handleShellBack: false });
+			oCheckNavigationToMessagePageMock.mockReturnValueOnce({ handleShellBack: false });
 			const bResponse = await MessageHandlerExt.showMessages();
 			expect(bResponse).toEqual(true);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
 			expect((MessageHandlerExt as any).base._routing.navigateToMessagePage).toHaveBeenCalledTimes(1);
 		});
 
@@ -170,9 +195,9 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 					throw error;
 				});
 			});
-			MessageHandlerExt._checkNavigationToMessagePage.mockReturnValueOnce({ handleShellBack: false });
+			oCheckNavigationToMessagePageMock.mockReturnValueOnce({ handleShellBack: false });
 			await expect(MessageHandlerExt.showMessages()).rejects.toThrowError();
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
 			expect((MessageHandlerExt as any).base._routing.navigateToMessagePage).toHaveBeenCalledTimes(1);
 		});
 
@@ -182,9 +207,9 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 					return true;
 				});
 			});
-			MessageHandlerExt._checkNavigationToMessagePage.mockReturnValueOnce({ handleShellBack: false });
+			oCheckNavigationToMessagePageMock.mockReturnValueOnce({ handleShellBack: false });
 			await expect(MessageHandlerExt.showMessages()).resolves.toBeTruthy();
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toHaveBeenCalledTimes(1);
+			expect(oCheckNavigationToMessagePageMock).toHaveBeenCalledTimes(1);
 			expect((MessageHandlerExt as any).base._routing.navigateToMessagePage).toHaveBeenCalledTimes(1);
 		});
 
@@ -195,7 +220,133 @@ describe("ShowMessages and ShowMessagesInDialog", () => {
 			});
 			const bResponse = await MessageHandlerExt.showMessages();
 			expect(bResponse).toEqual(true);
-			expect(MessageHandlerExt._checkNavigationToMessagePage).toBeCalledTimes(0);
+			expect(oCheckNavigationToMessagePageMock).toBeCalledTimes(0);
+		});
+	});
+
+	describe("_checkNavigationToMessagePage", () => {
+		let oGetMessagesMock: any, oRetryAfterMessageMock: any, oGetSecondsBeforeRetryAfterMock: any;
+		beforeEach(() => {
+			jest.restoreAllMocks();
+			oGetMessagesMock = jest.spyOn(messageHandling, "getMessages");
+			oGetSecondsBeforeRetryAfterMock = jest.spyOn(MessageHandlerExt, "_getSecondsBeforeRetryAfter");
+			oRetryAfterMessageMock = jest.spyOn(messageHandling, "getRetryAfterMessage");
+			oMockIsSticky = jest.spyOn(CommonUtils, "isStickyEditMode");
+			oMockIsSticky.mockReturnValue(false);
+		});
+		afterEach(() => {
+			jest.restoreAllMocks();
+		});
+
+		it("With isDataReceivedError true", async () => {
+			const mParameters = {
+				isDataReceivedError: true,
+				title: "ERROR",
+				description: "DataReceived Failed"
+			};
+			oRetryAfterMessageMock.mockImplementation(() => {
+				return "We expect it to be available again at 04:06 PM.";
+			});
+			oGetMessagesMock.mockImplementation((bBoundMessages?: boolean, bTransitionOnly?: boolean) => {
+				if (bBoundMessages && bTransitionOnly) {
+					return [];
+				}
+				return getMessageMockObject(503, true);
+			});
+
+			oGetSecondsBeforeRetryAfterMock.mockReturnValue(200);
+			const oResponse = MessageHandlerExt._checkNavigationToMessagePage(mParameters);
+			expect(oResponse).toStrictEqual({
+				title: "ERROR",
+				description: "DataReceived Failed",
+				navigateBackToOrigin: true
+			});
+		});
+
+		it("With isInitialLoad503Error true", async () => {
+			const mParameters = {
+				isInitialLoad503Error: true,
+				title: "ERROR",
+				description: "DataReceived Failed"
+			};
+			oRetryAfterMessageMock.mockImplementation(() => {
+				return "We expect it to be available again at 04:06 PM.";
+			});
+			oGetMessagesMock.mockImplementation((bBoundMessages?: boolean, bTransitionOnly?: boolean) => {
+				if (bBoundMessages && bTransitionOnly) {
+					return [];
+				}
+				return getMessageMockObject(503, true);
+			});
+
+			oGetSecondsBeforeRetryAfterMock.mockReturnValue(200);
+			const oResponse = MessageHandlerExt._checkNavigationToMessagePage(mParameters);
+			expect(oResponse).toStrictEqual({
+				description: "We expect it to be available again at 04:06 PM. Delete service not available",
+				navigateBackToOrigin: true
+			});
+		});
+
+		it("With no retryAfter", async () => {
+			const mParameters = {
+				title: "ERROR",
+				description: "DataReceived Failed"
+			};
+			oRetryAfterMessageMock.mockImplementation(() => {
+				return "We do not know when will it be available again.";
+			});
+			oGetMessagesMock.mockImplementation((bBoundMessages?: boolean, bTransitionOnly?: boolean) => {
+				if (bBoundMessages && bTransitionOnly) {
+					return [];
+				}
+				return getMessageMockObject(503, false);
+			});
+
+			oGetSecondsBeforeRetryAfterMock.mockReturnValue(200);
+			const oResponse = MessageHandlerExt._checkNavigationToMessagePage(mParameters);
+			expect(oResponse).toStrictEqual({
+				description: "We do not know when will it be available again. Delete service not available",
+				navigateBackToOrigin: true
+			});
+		});
+		it("With retryAfter seconds less than 120", async () => {
+			const mParameters = {
+				title: "ERROR",
+				description: "DataReceived Failed"
+			};
+			oRetryAfterMessageMock.mockImplementation(() => {
+				return "We expect it to be available in less than a minute.";
+			});
+			oGetMessagesMock.mockImplementation((bBoundMessages?: boolean, bTransitionOnly?: boolean) => {
+				if (bBoundMessages && bTransitionOnly) {
+					return [];
+				}
+				return getMessageMockObject(503, true);
+			});
+
+			oGetSecondsBeforeRetryAfterMock.mockReturnValue(100);
+			const oResponse = MessageHandlerExt._checkNavigationToMessagePage(mParameters);
+			expect(oResponse).toStrictEqual(undefined);
+		});
+
+		it("With http status not equal to 503", async () => {
+			const mParameters = {
+				title: "ERROR",
+				description: "DataReceived Failed"
+			};
+			oRetryAfterMessageMock.mockImplementation(() => {
+				return "We expect it to be available in less than a minute.";
+			});
+			oGetMessagesMock.mockImplementation((bBoundMessages?: boolean, bTransitionOnly?: boolean) => {
+				if (bBoundMessages && bTransitionOnly) {
+					return [];
+				}
+				return getMessageMockObject(403, true);
+			});
+
+			oGetSecondsBeforeRetryAfterMock.mockReturnValue(200);
+			const oResponse = MessageHandlerExt._checkNavigationToMessagePage(mParameters);
+			expect(oResponse).toStrictEqual(undefined);
 		});
 	});
 });

package/packages/sap.fe.core/test/sap/fe/core/jest/controllerextensions/Routing.spec.js

@@ -0,0 +1,40 @@
+/*!
+ * SAP UI development toolkit for HTML5 (SAPUI5)
+ *      (c) Copyright 2009-2021 SAP SE. All rights reserved
+ */
+sap.ui.define(["sap/fe/core/controllerextensions/Routing", "sap/fe/test/UI5MockHelper"], function (Routing, UI5MockHelper) {
+  "use strict";
+
+  var MockMetaModel = UI5MockHelper.MockMetaModel;
+  var MockModel = UI5MockHelper.MockModel;
+
+  var oMetaModelDraft = new MockMetaModel({
+    "/SalesOrder@com.sap.vocabularies.Common.v1.DraftRoot": true,
+    "/com.c_salesordermanage_sd.SalesOrder@com.sap.vocabularies.Common.v1.DraftRoot": true,
+    "/com.c_salesordermanage_sd.SalesOrder/@com.sap.vocabularies.Common.v1.Messages/$Path": "SAP_Messages"
+  });
+  describe("Routing - navigateToRoute", function () {
+    var mockModel = new MockModel();
+    mockModel.setMetaModel(oMetaModelDraft);
+    var that = {
+      base: {
+        _routing: {
+          navigateToRoute: jest.fn().mockReturnValue("")
+        },
+        getModel: jest.fn().mockReturnValue(mockModel)
+      }
+    };
+    it("Check if navToHash is called with right parameters", function () {
+      try {
+        Routing.prototype.navigateToRoute.call(that, "route", {});
+        expect(that.base._routing.navigateToRoute).toHaveBeenCalledWith("route", {
+          "bIsStickyMode": false
+        });
+        return Promise.resolve();
+      } catch (e) {
+        return Promise.reject(e);
+      }
+    });
+  });
+}, false);
+//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIlJvdXRpbmcuc3BlYy50cyJdLCJuYW1lcyI6WyJvTWV0YU1vZGVsRHJhZnQiLCJNb2NrTWV0YU1vZGVsIiwiZGVzY3JpYmUiLCJtb2NrTW9kZWwiLCJNb2NrTW9kZWwiLCJzZXRNZXRhTW9kZWwiLCJ0aGF0IiwiYmFzZSIsIl9yb3V0aW5nIiwibmF2aWdhdGVUb1JvdXRlIiwiamVzdCIsImZuIiwibW9ja1JldHVyblZhbHVlIiwiZ2V0TW9kZWwiLCJpdCIsIlJvdXRpbmciLCJwcm90b3R5cGUiLCJjYWxsIiwiZXhwZWN0IiwidG9IYXZlQmVlbkNhbGxlZFdpdGgiXSwibWFwcGluZ3MiOiI7QUFBQTtBQUNBO0FBQ0E7Ozs7Ozs7QUFDQSxNQUFNQSxlQUFlLEdBQUcsSUFBSUMsYUFBSixDQUFrQjtBQUN6Qyw0REFBd0QsSUFEZjtBQUV6QyxzRkFBa0YsSUFGekM7QUFHekMsNEZBQXdGO0FBSC9DLEdBQWxCLENBQXhCO0FBS0FDLEVBQUFBLFFBQVEsQ0FBQywyQkFBRCxFQUE4QixZQUFNO0FBQzNDLFFBQU1DLFNBQVMsR0FBRyxJQUFJQyxTQUFKLEVBQWxCO0FBQ0FELElBQUFBLFNBQVMsQ0FBQ0UsWUFBVixDQUF1QkwsZUFBdkI7QUFFQSxRQUFNTSxJQUFJLEdBQUc7QUFDWkMsTUFBQUEsSUFBSSxFQUFFO0FBQ0xDLFFBQUFBLFFBQVEsRUFBRTtBQUNUQyxVQUFBQSxlQUFlLEVBQUVDLElBQUksQ0FBQ0MsRUFBTCxHQUFVQyxlQUFWLENBQTBCLEVBQTFCO0FBRFIsU0FETDtBQUlMQyxRQUFBQSxRQUFRLEVBQUVILElBQUksQ0FBQ0MsRUFBTCxHQUFVQyxlQUFWLENBQTBCVCxTQUExQjtBQUpMO0FBRE0sS0FBYjtBQVNBVyxJQUFBQSxFQUFFLENBQUMsb0RBQUQ7QUFBQSxVQUFtRTtBQUNwRUMsUUFBQUEsT0FBTyxDQUFDQyxTQUFSLENBQWtCUCxlQUFsQixDQUFrQ1EsSUFBbEMsQ0FBdUNYLElBQXZDLEVBQTZDLE9BQTdDLEVBQXNELEVBQXREO0FBQ0FZLFFBQUFBLE1BQU0sQ0FBQ1osSUFBSSxDQUFDQyxJQUFMLENBQVVDLFFBQVYsQ0FBbUJDLGVBQXBCLENBQU4sQ0FBMkNVLG9CQUEzQyxDQUFnRSxPQUFoRSxFQUF5RTtBQUFFLDJCQUFpQjtBQUFuQixTQUF6RTtBQUZvRTtBQUdwRSxPQUhDO0FBQUE7QUFBQTtBQUFBLE1BQUY7QUFJQSxHQWpCTyxDQUFSIiwic291cmNlUm9vdCI6Ii4iLCJzb3VyY2VzQ29udGVudCI6WyJpbXBvcnQgeyBSb3V0aW5nIH0gZnJvbSBcInNhcC9mZS9jb3JlL2NvbnRyb2xsZXJleHRlbnNpb25zXCI7XG5pbXBvcnQgeyBNb2NrTW9kZWwsIE1vY2tNZXRhTW9kZWwgfSBmcm9tIFwic2FwL2ZlL3Rlc3QvVUk1TW9ja0hlbHBlclwiO1xuXG5jb25zdCBvTWV0YU1vZGVsRHJhZnQgPSBuZXcgTW9ja01ldGFNb2RlbCh7XG5cdFwiL1NhbGVzT3JkZXJAY29tLnNhcC52b2NhYnVsYXJpZXMuQ29tbW9uLnYxLkRyYWZ0Um9vdFwiOiB0cnVlLFxuXHRcIi9jb20uY19zYWxlc29yZGVybWFuYWdlX3NkLlNhbGVzT3JkZXJAY29tLnNhcC52b2NhYnVsYXJpZXMuQ29tbW9uLnYxLkRyYWZ0Um9vdFwiOiB0cnVlLFxuXHRcIi9jb20uY19zYWxlc29yZGVybWFuYWdlX3NkLlNhbGVzT3JkZXIvQGNvbS5zYXAudm9jYWJ1bGFyaWVzLkNvbW1vbi52MS5NZXNzYWdlcy8kUGF0aFwiOiBcIlNBUF9NZXNzYWdlc1wiXG59KTtcbmRlc2NyaWJlKFwiUm91dGluZyAtIG5hdmlnYXRlVG9Sb3V0ZVwiLCAoKSA9PiB7XG5cdGNvbnN0IG1vY2tNb2RlbCA9IG5ldyBNb2NrTW9kZWwoKTtcblx0bW9ja01vZGVsLnNldE1ldGFNb2RlbChvTWV0YU1vZGVsRHJhZnQpO1xuXG5cdGNvbnN0IHRoYXQgPSB7XG5cdFx0YmFzZToge1xuXHRcdFx0X3JvdXRpbmc6IHtcblx0XHRcdFx0bmF2aWdhdGVUb1JvdXRlOiBqZXN0LmZuKCkubW9ja1JldHVyblZhbHVlKFwiXCIpXG5cdFx0XHR9LFxuXHRcdFx0Z2V0TW9kZWw6IGplc3QuZm4oKS5tb2NrUmV0dXJuVmFsdWUobW9ja01vZGVsKVxuXHRcdH1cblx0fTtcblxuXHRpdChcIkNoZWNrIGlmIG5hdlRvSGFzaCBpcyBjYWxsZWQgd2l0aCByaWdodCBwYXJhbWV0ZXJzXCIsIGFzeW5jICgpID0+IHtcblx0XHRSb3V0aW5nLnByb3RvdHlwZS5uYXZpZ2F0ZVRvUm91dGUuY2FsbCh0aGF0LCBcInJvdXRlXCIsIHt9KTtcblx0XHRleHBlY3QodGhhdC5iYXNlLl9yb3V0aW5nLm5hdmlnYXRlVG9Sb3V0ZSkudG9IYXZlQmVlbkNhbGxlZFdpdGgoXCJyb3V0ZVwiLCB7IFwiYklzU3RpY2t5TW9kZVwiOiBmYWxzZSB9KTtcblx0fSk7XG59KTtcbiJdfQ==

package/packages/sap.fe.core/test/sap/fe/core/jest/controllerextensions/Routing.spec.ts

@@ -0,0 +1,26 @@
+import { Routing } from "sap/fe/core/controllerextensions";
+import { MockModel, MockMetaModel } from "sap/fe/test/UI5MockHelper";
+
+const oMetaModelDraft = new MockMetaModel({
+	"/SalesOrder@com.sap.vocabularies.Common.v1.DraftRoot": true,
+	"/com.c_salesordermanage_sd.SalesOrder@com.sap.vocabularies.Common.v1.DraftRoot": true,
+	"/com.c_salesordermanage_sd.SalesOrder/@com.sap.vocabularies.Common.v1.Messages/$Path": "SAP_Messages"
+});
+describe("Routing - navigateToRoute", () => {
+	const mockModel = new MockModel();
+	mockModel.setMetaModel(oMetaModelDraft);
+
+	const that = {
+		base: {
+			_routing: {
+				navigateToRoute: jest.fn().mockReturnValue("")
+			},
+			getModel: jest.fn().mockReturnValue(mockModel)
+		}
+	};
+
+	it("Check if navToHash is called with right parameters", async () => {
+		Routing.prototype.navigateToRoute.call(that, "route", {});
+		expect(that.base._routing.navigateToRoute).toHaveBeenCalledWith("route", { "bIsStickyMode": false });
+	});
+});