@sap/open.fe 1.96.0 → 1.97.0

package/packages/sap.fe.core/test/sap/fe/core/jest/converters/Table.spec.ts

@@ -660,7 +660,26 @@ describe("Table Converter - #getSelectionMode ", function() {
 			true
 		);
 		const result = getSelectionModeForTest(
-			true,
+			false,
+			{ isDeletable: true, isUpdatable: false },
+			basicContext_OP,
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
+		);
+		expect(result).toEqual("None");
+	});
+	it("For a service that is neither Draft enabled/Sticky-Session/containment-enabled, the selectionMode is not set, there is no action and the entity is deletable : The OP tableSelectionMode is 'None'", () => {
+		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
+			entitySet: "NoDeleteButtonEntity",
+			converterType: TemplateType.ObjectPage
+		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_OP,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
+		const result = getSelectionModeForTest(
+			false,
 			{ isDeletable: true, isUpdatable: false },
 			basicContext_OP,
 			"@com.sap.vocabularies.UI.v1.LineItem",
@@ -714,7 +733,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			true
 		);
 		const result = getSelectionModeForTest(
-			true,
+			false,
 			{ isDeletable: true, isUpdatable: false },
 			basicContext_OP,
 			"@com.sap.vocabularies.UI.v1.LineItem",
@@ -768,7 +787,7 @@ describe("Table Converter - #getSelectionMode ", function() {
 			true
 		);
 		const result = getSelectionModeForTest(
-			true,
+			false,
 			{ isDeletable: true, isUpdatable: false },
 			basicContext_OP,
 			"@com.sap.vocabularies.UI.v1.LineItem",
@@ -781,37 +800,74 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("None");
 	});
-	it("If the Entity is deletable and the LR table has not action : the tableSelectionMode is 'Multi' ", () => {
+	it("If the Entity is deletable, LR table has not action and the service is draft : the tableSelectionMode is 'Multi' ", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: true, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("Multi");
 	});
+	it("If the Entity is deletable, the LR table has not action and the service is neither Draft enabled/Sticky-Session/containment-enabled : the tableSelectionMode is 'None' ", () => {
+		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
+			entitySet: "NoDeleteButtonEntity",
+			converterType: TemplateType.ListReport
+		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
+		const result = getSelectionModeForTest(
+			true,
+			{ isDeletable: true, isUpdatable: false },
+			basicContext_LR,
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
+		);
+		expect(result).toEqual("None");
+	});
 	it("If the Entity is not deletable and the LR table has at least 1 bound action : the tableSelectionMode is 'Multi' ", () => {
 		const basicContext_LR = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("Multi");
 	});
@@ -820,11 +876,17 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithUnBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("None");
 	});
@@ -833,11 +895,17 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithBoundActionOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("Multi");
 	});
@@ -846,11 +914,17 @@ describe("Table Converter - #getSelectionMode ", function() {
 			entitySet: "EntityWithActionRequingContextOnTable",
 			converterType: TemplateType.ListReport
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_LR,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			true,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_LR,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("Multi");
 	});
@@ -937,31 +1011,43 @@ describe("Table Converter - #getSelectionMode ", function() {
 		);
 		expect(result).toEqual("{= (( ${ui>/editMode} === 'Editable' ) || ( %{OverallSDProcessStatus} === 'B' )) ? 'Multi' : 'None'}");
 	});
-	it("If the Entity is not deletable and the OP table has not action : the tableSelectionMode is 'None' ", () => {
+	it("If the Entity is not deletable and the OP table has no action : the tableSelectionMode is 'None' ", () => {
 		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ObjectPage
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_OP,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_OP,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("None");
 	});
-	it("If the Entity is deletable and the OP table has not action : the tableSelectionMode is Multi in Edit Mode and None otherwise", () => {
+	it("If the Entity is deletable, the OP table has no action and the parent Entity set is not deletable : the tableSelectionMode is None", () => {
 		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithoutActionOnTable",
 			converterType: TemplateType.ObjectPage
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_OP,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: true, isUpdatable: false },
 			basicContext_OP,
-			"@com.sap.vocabularies.UI.v1.LineItem"
+			"@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
-		expect(result).toEqual("{= %{ui>/editMode} === 'Editable' ? 'Multi' : 'None'}");
+		expect(result).toEqual("None");
 	});
 	it("If the Entity is deletable and the OP table has 1 DataFieldForIntentBasedNavigation requiring a context with Hidden binding exp with nav property", () => {
 		const manifestSettings = {
@@ -1000,16 +1086,22 @@ describe("Table Converter - #getSelectionMode ", function() {
 		);
 		expect(result).toEqual("{= %{ui>/editMode} === 'Editable' ? 'Multi' : 'None'}");
 	});
-	it("If the Entity is not deletable and the OP table has 1 always visible Bound Action but bound on a different context from the table one : the tableSelectionMode is Multi in Edition, None otherwise", () => {
+	it("If the Entity is not deletable and the OP table has 1 always visible Bound Action but bound on a different context from the table one : the tableSelectionMode is None", () => {
 		const basicContext_OP = getConverterContextForTest(convertedTypesSelectionMode, {
 			entitySet: "EntityWithBoundActionNotBoundOnTheTable",
 			converterType: TemplateType.ObjectPage
 		});
+		const isDeleteButtonVisible = getDeleteVisible(
+			basicContext_OP,
+			splitPath("@com.sap.vocabularies.UI.v1.LineItem").navigationPropertyPath,
+			true
+		);
 		const result = getSelectionModeForTest(
 			false,
 			{ isDeletable: false, isUpdatable: false },
 			basicContext_OP,
-			"_Partner/@com.sap.vocabularies.UI.v1.LineItem"
+			"_Partner/@com.sap.vocabularies.UI.v1.LineItem",
+			isDeleteButtonVisible
 		);
 		expect(result).toEqual("None");
 	});