@sap/cli-core 2025.9.0 → 2025.11.0

package/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2025.11.0
+
+### Fixed
+
+- The CLI is now using the default browser set in the system. The default browser is used when the `--browser` option is not specified. If the default browser is not supported by the CLI, the CLI will fallback to the `chrome` browser as it is the most common browser.
+
 ## 2025.2.0
 
 ### Fixed

package/commands/handler/authentication/passcode/input.js

@@ -4,11 +4,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.create = void 0;
-const open_1 = __importDefault(require("open"));
 const prompts_1 = __importDefault(require("prompts"));
 const config_1 = require("../../../../config");
 const constants_1 = require("../../../../constants");
 const utils_1 = require("../../options/utils");
+const openUtils_1 = require("../../../../utils/openUtils");
 const create = () => async (command) => {
     await (0, utils_1.checkOptions)(constants_1.OPTION_PASSCODE, command);
     return async () => {
@@ -25,7 +25,7 @@ const create = () => async (command) => {
                 name: "value",
             });
             if (res.value) {
-                await (0, open_1.default)(config.passcodeUrl);
+                await (0, openUtils_1.openUrlInBrowser)(config.passcodeUrl);
                 passcode = (await prompts_1.default.prompt({
                     type: "password",
                     message: "Enter your temporary authentication code:",

package/commands/login.command.js

@@ -1,17 +1,16 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.verifyHost = void 0;
-const handler_1 = require("./handler");
+const SecretsStorageSingleton_1 = require("../cache/secrets/SecretsStorageSingleton");
+const utils_1 = require("../cache/secrets/utils");
 const constants_1 = require("../constants");
 const logger_1 = require("../logger");
-const options_1 = require("../utils/options");
-const init_command_1 = require("./config.command/cache.command/init.command");
-const utils_1 = require("../cache/secrets/utils");
 const utils_2 = require("../logger/utils");
-const utils_3 = require("../utils/utils");
-const utils_4 = require("./utils");
 const openUtils_1 = require("../utils/openUtils");
-const SecretsStorageSingleton_1 = require("../cache/secrets/SecretsStorageSingleton");
+const options_1 = require("../utils/options");
+const utils_3 = require("../utils/utils");
+const init_command_1 = require("./config.command/cache.command/init.command");
+const handler_1 = require("./handler");
 const getLogger = () => (0, logger_1.get)("commands.login");
 const verifyHost = async () => async () => {
     const logger = getLogger();
@@ -37,6 +36,10 @@ const initializeCache = async () => async () => {
         warn(`option ${(0, utils_3.buildOptionName)(constants_1.ROOT_COMMAND, constants_1.OPTION_HOST)} not defined, skipping cache init`);
     }
 };
+const fetchSupportedBrowsers = async () => {
+    const list = await (0, openUtils_1.getSupportedBrowsers)();
+    return list.map(({ name }) => name);
+};
 const saveSecrets = async () => async () => {
     await SecretsStorageSingleton_1.SecretsStorageSingleton.SINGLETON.synchronizeSecretsToStorage();
 };
@@ -59,7 +62,7 @@ const loginCommand = {
         { ...constants_1.OPTION_SECRETS_FILE, hidden: false },
         {
             ...constants_1.OPTION_BROWSER,
-            choices: utils_4.getBrowserChoices,
+            choices: fetchSupportedBrowsers,
             default: openUtils_1.getDefaultBrowser,
         },
         { ...constants_1.OPTION_AUTHORIZATION_FLOW, hidden: false },

package/commands/utils.js

@@ -1,13 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getBrowserChoices = exports.getChoices = void 0;
-const open_1 = require("open");
 const SecretsStorageSingleton_1 = require("../cache/secrets/SecretsStorageSingleton");
+const openUtils_1 = require("../utils/openUtils");
 const getChoices = async () => {
     return SecretsStorageSingleton_1.SecretsStorageSingleton.SINGLETON.getAllSecrets().map((secret) => secret.id.toString(10));
 };
 exports.getChoices = getChoices;
 const getBrowserChoices = async () => {
-    return Object.keys(open_1.apps);
+    const list = await (0, openUtils_1.getSupportedBrowsers)();
+    return list.map(({ name }) => name);
 };
 exports.getBrowserChoices = getBrowserChoices;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cli-core",
-  "version": "2025.9.0",
+  "version": "2025.11.0",
   "description": "Command-Line Interface (CLI) Core Module",
   "license": "SEE LICENSE IN LICENSE",
   "author": "SAP SE",
@@ -18,17 +18,17 @@
   ],
   "dependencies": {
     "ajv": "8.17.1",
-    "axios": "1.8.4",
+    "axios": "1.9.0",
     "commander": "12.1.0",
     "compare-versions": "6.1.1",
     "config": "3.3.12",
-    "dotenv": "16.4.7",
+    "dotenv": "16.5.0",
     "form-data": "4.0.2",
     "fs-extra": "11.3.0",
     "https": "1.0.0",
     "https-proxy-agent": "7.0.6",
     "lodash": "4.17.21",
-    "open": "8.4.2",
+    "open": "10.1.1",
     "path": "0.12.7",
     "prompts": "2.4.2",
     "qs": "6.14.0"

package/utils/openUtils.d.ts

@@ -1,10 +1,10 @@
-import { AppName } from "open";
+import type { AppName } from "open" with { "resolution-mode": "import" };
 export type Browser = {
     name: AppName;
     app: string;
 };
-export declare function getSupportedBrowsers(): Array<Browser>;
-export declare function getDefaultBrowser(): Promise<string>;
+export declare function getSupportedBrowsers(): Promise<Array<Browser>>;
+export declare function getDefaultBrowser(): Promise<AppName>;
 export declare const openUrlInBrowser: (url: string, queryParameters?: {
     [key: string]: string;
 }) => Promise<void>;

package/utils/openUtils.js

@@ -1,68 +1,54 @@
 "use strict";
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || (function () {
-    var ownKeys = function(o) {
-        ownKeys = Object.getOwnPropertyNames || function (o) {
-            var ar = [];
-            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
-            return ar;
-        };
-        return ownKeys(o);
-    };
-    return function (mod) {
-        if (mod && mod.__esModule) return mod;
-        var result = {};
-        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
-        __setModuleDefault(result, mod);
-        return result;
-    };
-})();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.openUrlInBrowser = void 0;
 exports.getSupportedBrowsers = getSupportedBrowsers;
 exports.getDefaultBrowser = getDefaultBrowser;
-const open_1 = __importStar(require("open"));
 const constants_1 = require("../constants");
-const options_1 = require("./options");
 const logger_1 = require("../logger");
+const options_1 = require("./options");
 const getLogger = () => (0, logger_1.get)("utils.open");
-function getSupportedBrowsers() {
-    return Object.entries(open_1.apps).map(([key, value]) => ({
+async function getSupportedBrowsers() {
+    const { apps } = await import("open");
+    return (Object.entries(apps)
+        // Private browser is not supported
+        .filter(([name]) => name !== "browserPrivate")
+        .map(([key, value]) => ({
         name: key,
         app: value,
-    }));
+    })));
 }
 async function getDefaultBrowser() {
-    return getSupportedBrowsers()[0].name;
+    const { apps } = await import("open");
+    return apps.browser;
 }
 async function getBrowser() {
+    const { apps } = await import("open");
     const browser = (0, options_1.getOptionValueFromConfig)(constants_1.OPTION_BROWSER, await getDefaultBrowser());
-    return open_1.apps[browser];
+    return apps[browser];
 }
 const openUrlInBrowser = async (url, queryParameters = {}) => {
-    const browser = await getBrowser();
     const u = new URL(url);
     for (const [key, value] of Object.entries(queryParameters)) {
         u.searchParams.append(key, value);
     }
     const urlString = u.toString();
-    const { debug } = getLogger();
-    debug(`open browser ${browser} at ${urlString}`);
-    await (0, open_1.default)(urlString, { app: { name: browser } });
+    const { debug, error } = getLogger();
+    let browser = await getBrowser();
+    const open = (await import("open")).default;
+    try {
+        debug(`Attempting to open browser ${browser} at ${urlString}`);
+        await open(urlString, { app: { name: browser } });
+    }
+    catch (err) {
+        error(`Failed to open browser ${browser}`, err);
+        debug("Retrying with Google Chrome as fallback browser");
+        try {
+            await open(urlString, { app: { name: "google chrome" } });
+        }
+        catch (fallbackErr) {
+            error(`Failed to open browser`, fallbackErr);
+            throw fallbackErr;
+        }
+    }
 };
 exports.openUrlInBrowser = openUrlInBrowser;