@sap/cli-core 2025.10.0 → 2025.11.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
5
5
  The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
6
6
  and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7
7
 
8
+ ## 2025.11.0
9
+
10
+ ### Fixed
11
+
12
+ - The CLI is now using the default browser set in the system. The default browser is used when the `--browser` option is not specified. If the default browser is not supported by the CLI, the CLI will fallback to the `chrome` browser as it is the most common browser.
13
+
8
14
  ## 2025.2.0
9
15
 
10
16
  ### Fixed
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@sap/cli-core",
3
- "version": "2025.10.0",
3
+ "version": "2025.11.0",
4
4
  "description": "Command-Line Interface (CLI) Core Module",
5
5
  "license": "SEE LICENSE IN LICENSE",
6
6
  "author": "SAP SE",
@@ -18,7 +18,7 @@
18
18
  ],
19
19
  "dependencies": {
20
20
  "ajv": "8.17.1",
21
- "axios": "1.8.4",
21
+ "axios": "1.9.0",
22
22
  "commander": "12.1.0",
23
23
  "compare-versions": "6.1.1",
24
24
  "config": "3.3.12",
@@ -28,7 +28,7 @@
28
28
  "https": "1.0.0",
29
29
  "https-proxy-agent": "7.0.6",
30
30
  "lodash": "4.17.21",
31
- "open": "10.1.0",
31
+ "open": "10.1.1",
32
32
  "path": "0.12.7",
33
33
  "prompts": "2.4.2",
34
34
  "qs": "6.14.0"
@@ -1,11 +1,10 @@
1
- type AppName = "chrome" | "firefox" | "edge";
1
+ import type { AppName } from "open" with { "resolution-mode": "import" };
2
2
  export type Browser = {
3
3
  name: AppName;
4
4
  app: string;
5
5
  };
6
6
  export declare function getSupportedBrowsers(): Promise<Array<Browser>>;
7
- export declare function getDefaultBrowser(): Promise<string>;
7
+ export declare function getDefaultBrowser(): Promise<AppName>;
8
8
  export declare const openUrlInBrowser: (url: string, queryParameters?: {
9
9
  [key: string]: string;
10
10
  }) => Promise<void>;
11
- export {};
@@ -9,14 +9,17 @@ const options_1 = require("./options");
9
9
  const getLogger = () => (0, logger_1.get)("utils.open");
10
10
  async function getSupportedBrowsers() {
11
11
  const { apps } = await import("open");
12
- return Object.entries(apps).map(([key, value]) => ({
12
+ return (Object.entries(apps)
13
+ // Private browser is not supported
14
+ .filter(([name]) => name !== "browserPrivate")
15
+ .map(([key, value]) => ({
13
16
  name: key,
14
17
  app: value,
15
- }));
18
+ })));
16
19
  }
17
20
  async function getDefaultBrowser() {
18
- const supportedBrowsers = await getSupportedBrowsers();
19
- return supportedBrowsers[0].name;
21
+ const { apps } = await import("open");
22
+ return apps.browser;
20
23
  }
21
24
  async function getBrowser() {
22
25
  const { apps } = await import("open");
@@ -24,15 +27,28 @@ async function getBrowser() {
24
27
  return apps[browser];
25
28
  }
26
29
  const openUrlInBrowser = async (url, queryParameters = {}) => {
27
- const browser = await getBrowser();
28
30
  const u = new URL(url);
29
31
  for (const [key, value] of Object.entries(queryParameters)) {
30
32
  u.searchParams.append(key, value);
31
33
  }
32
34
  const urlString = u.toString();
33
- const { debug } = getLogger();
34
- debug(`open browser ${browser} at ${urlString}`);
35
+ const { debug, error } = getLogger();
36
+ let browser = await getBrowser();
35
37
  const open = (await import("open")).default;
36
- await open(urlString, { app: { name: browser } });
38
+ try {
39
+ debug(`Attempting to open browser ${browser} at ${urlString}`);
40
+ await open(urlString, { app: { name: browser } });
41
+ }
42
+ catch (err) {
43
+ error(`Failed to open browser ${browser}`, err);
44
+ debug("Retrying with Google Chrome as fallback browser");
45
+ try {
46
+ await open(urlString, { app: { name: "google chrome" } });
47
+ }
48
+ catch (fallbackErr) {
49
+ error(`Failed to open browser`, fallbackErr);
50
+ throw fallbackErr;
51
+ }
52
+ }
37
53
  };
38
54
  exports.openUrlInBrowser = openUrlInBrowser;