@sap/cds 9.0.2 → 9.0.4

package/CHANGELOG.md

@@ -4,6 +4,25 @@
 - The format is based on [Keep a Changelog](https://keepachangelog.com/).
 - This project adheres to [Semantic Versioning](https://semver.org/).
 
+## Version 9.0.4 - 2025-06-18
+
+### Fixed
+
+- In some cases, the app crashed if an element was named like a reserved CSN key.
+- Locale detection does not enforce `<http-req>.query` to be present. Some protocol adapters do not set it.
+- `between` operator for remote OData requests
+- `cds serve/watch` and `cds.test()` no longer try to connect to an SQLite database if none is configured.
+- `cds.connect.to` for required queueable services if no persistence is configured
+- Persistent queue is not enabled if no persistence is configured
+
+## Version 9.0.3 - 2025-06-04
+
+### Fixed
+
+- Handling of bad timestamps in URL ($filter and temporals)
+- View metadata for requests with $apply
+- Server crash for some URLs
+
 ## Version 9.0.2 - 2025-05-28
 
 ### Changed

package/bin/serve.js

@@ -337,16 +337,18 @@ function _chdir_to (project) {
 }
 
 
-/** handles --in-memory option */
+/** handles --in-memory[?] option */
 function _in_memory (o) {
-  const {env} = cds, db = env.requires.db
-  if (o['in-memory'] || o['in-memory?'] && !db) {
-    env.add ({ requires: { db: {
-      kind:'sqlite', ...env.requires.kinds.sqlite,
-      credentials: db?.credentials?.url ? {url:':memory:'} : {database:':memory:'}
-    }}})
-    return true
-  }
+  const {env} = cds, db = env.requires.db, sqlite = env.requires.kinds.sqlite
+  try {
+    if (o['in-memory'] || (o['in-memory?'] && !db && require.resolve(sqlite.impl, {paths: [cds.root, cds.home]}))) {
+      env.add ({ requires: { db: {
+        kind:'sqlite', ...sqlite,
+        credentials: db?.credentials?.url ? {url:':memory:'} : {database:':memory:'}
+      }}})
+      return true
+    }
+  } catch (e) { if (e.code !== 'MODULE_NOT_FOUND') throw e }
   if (db && db.credentials && (db.credentials.database || db.credentials.url) === ':memory:') {
     return true
   }

package/lib/i18n/locale.js

@@ -18,7 +18,8 @@ function normalized_locale_from (req) {
 
 function raw_locale_from (req) {
   return !req ? undefined :
-  req.query['sap-locale'] || SAP_LANGUAGES[req.query['sap-language']] ||
+  // req.query is guaranteed by express, but not by others like websockets or plain Node http
+  req.query?.['sap-locale'] || SAP_LANGUAGES[req.query?.['sap-language']] ||
   req.headers['x-sap-request-language'] ||
   req.headers['accept-language']
 }

package/lib/log/cds-error.js

@@ -62,13 +62,14 @@ exports.expected = ([,type], arg) => {
 }
 
 
-exports.isSystemError = err => err.name in {
-  TypeError:1,
-  ReferenceError:1,
-  SyntaxError:1,
-  RangeError:1,
-  URIError:1,
-}
+const system_errors = [
+  TypeError,
+  ReferenceError,
+  SyntaxError,
+  RangeError,
+  URIError
+]
+exports.isSystemError = err => system_errors.some(e => err instanceof e) 
 
 
 //

package/lib/srv/cds-connect.js

@@ -44,7 +44,7 @@ connect.to = (datasource, options) => {
     }
     // construct new service instance
     let srv = await new Service (datasource,m,o); await (Service._is_service_class ? srv.init?.() : Service.init?.(srv))
-    if (!(srv instanceof cds.DatabaseService) && _is_queued(o)) srv = cds.queued(srv)
+    if (!srv.isDatabaseService && _is_queued(o)) srv = cds.queued(srv)
     if (datasource && !options) {
       if (datasource === 'db') cds.db = srv
       cds.services[datasource] = srv

package/libx/_runtime/common/generic/temporal.js

@@ -4,7 +4,6 @@ const normalizeTimestamp = require('../utils/normalizeTimestamp')
 const _getDateFromQueryOptions = str => {
   if (str) {
     const match = str.match(/^date'(.+)'$/)
-    // REVISIT: What happens with invalid date values in query parameter? if match.length > 1
     return normalizeTimestamp(match ? match[1] : str)
   }
 }

package/libx/_runtime/common/utils/normalizeTimestamp.js

@@ -9,13 +9,22 @@ const _lengthIfNotFoundIndex = (index, length) => (index > -1 ? index : length)
 module.exports = value => {
   if (value instanceof Date) value = value.toISOString()
   if (typeof value === 'number') value = new Date(value).toISOString()
+  if (typeof value !== 'string') {
+    const msg = `Value "${value}" is not a valid Timestamp`
+    throw Object.assign(new Error(msg), { statusCode: 400 })
+  }
 
   const decimalPointIndex = _lengthIfNotFoundIndex(value.lastIndexOf('.'), value.length)
   const tzRegexMatch = TZ_REGEX.exec(value)
   const tz = tzRegexMatch?.[0] || ''
   const tzIndex = _lengthIfNotFoundIndex(tzRegexMatch?.index, value.length)
   const dateEndIndex = Math.min(decimalPointIndex, tzIndex)
-  const dateNoMillisNoTZ = new Date(value.slice(0, dateEndIndex) + tz).toISOString().slice(0, 19)
+  let dt = new Date(value.slice(0, dateEndIndex) + tz)
+  if (isNaN(dt)) {
+    const msg = `Value "${value}" is not a valid Timestamp`
+    throw Object.assign(new Error(msg), { statusCode: 400 })
+  }
+  const dateNoMillisNoTZ = dt.toISOString().slice(0, 19)
   const normalizedFractionalDigits = value
     .slice(dateEndIndex + 1, tzIndex)
     .replace(NON_DIGIT_REGEX, '')

package/libx/odata/parse/afterburner.js

@@ -12,8 +12,7 @@ function _getDefinition(definition, name, namespace) {
   return (
     definition?.definitions?.[name] ||
     definition?.elements?.[name] ||
-    (definition.actions && (definition.actions[name] || definition.actions[name.replace(namespace + '.', '')])) ||
-    definition[name]
+    (definition.actions && (definition.actions[name] || definition.actions[name.replace(namespace + '.', '')]))
   )
 }
 

package/libx/odata/parse/cqn2odata.js

@@ -167,8 +167,8 @@ function _xpr(expr, target, kind, isLambda, navPrefix = []) {
         const operator = isOrIsNotValue[1] /* 'is not' */ ? 'ne' : 'eq'
         res.push(...[operator, _format({ val: isOrIsNotValue[2] })])
       } else if (cur === 'between') {
-        // ref gt low.val and ref lt high.val
-        const between = [expr[i - 1], 'gt', expr[i + 1], 'and', expr[i - 1], 'lt', expr[i + 3]]
+        // between is inclusive, so we need to use ge and le
+        const between = [expr[i - 1], 'ge', expr[i + 1], 'and', expr[i - 1], 'le', expr[i + 3]]
         // cleanup previous ref
         res.pop()
         res.push(`(${_xpr(between, target, kind, isLambda, navPrefix)})`)

package/libx/odata/utils/metadata.js

@@ -32,6 +32,14 @@ const _lastValidRef = ref => {
   }
 }
 
+const _getRef = query => {
+  if (query.SELECT?.from?.SELECT) return _getRef(query.SELECT.from)
+
+  return (
+    query.SELECT?.from?.ref ?? query.UPDATE?.entity?.ref ?? query.INSERT?.into?.ref ?? query.DELETE?.from?.ref ?? []
+  )
+}
+
 const _toBinaryKeyValue = value => `binary'${value.toString('base64')}'`
 
 const _odataContext = (query, options) => {
@@ -49,10 +57,7 @@ const _odataContext = (query, options) => {
 
   path += '#'
 
-  // REVISIT: subselect is treated as empty array
-  const ref =
-    query.SELECT?.from?.ref ?? query.UPDATE?.entity?.ref ?? query.INSERT?.into?.ref ?? query.DELETE?.from?.ref ?? []
-
+  const ref = _getRef(query)
   const isNavToDraftAdmin = _isNavToDraftAdmin(ref)
 
   let edmName

package/libx/odata/utils/normalizeTimeData.js

@@ -8,7 +8,7 @@ const _processorFn = elementInfo => {
     const { row, key } = elementInfo
     if (!(row[key] == null) && row[key] !== '$now') {
       const dt = typeof row[key] === 'string' && new Date(row[key])
-      if (!isNaN(dt)) {
+      if (dt && !isNaN(dt)) {
         switch (category) {
           case 'cds.DateTime':
             row[key] = new Date(row[key]).toISOString().replace(/\.\d\d\d/, '')

package/libx/queue/index.js

@@ -36,6 +36,7 @@ const _isProviderTenant = tenant =>
   cds.requires.multitenancy.t0 === tenant
 
 const _hasPersistentQueue = tenant => {
+  if (!cds.db) return false // no persistence configured
   if (cds.requires.multitenancy && tenant && _isProviderTenant(tenant)) return false // no persistence for provider account
   return true
 }
@@ -423,6 +424,7 @@ const _createTask = (name, msg, context, taskOpts) => {
     delete _msg.query._target
     delete _msg.query.__target
     delete _msg.query.target
+    delete _msg.data // `req.data` should be a getter to whatever is in `req.query`
   }
   const taskMsg = {
     ID: cds.utils.uuid(),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cds",
-  "version": "9.0.2",
+  "version": "9.0.4",
   "description": "SAP Cloud Application Programming Model - CDS for Node.js",
   "homepage": "https://cap.cloud.sap/",
   "keywords": [