@sap/cds-dk 6.0.4 → 6.1.3

package/CHANGELOG.md

@@ -1,3 +1,4 @@
+
 # Change Log
 
 All notable changes to this project will be documented in this file.
@@ -6,6 +7,63 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## Version 6.1.3 - 2022-09-06
+
+### Fixed
+
+- `cds extend` and other commands no longer fail with `TypeError: Class constructor CliError cannot be invoked without 'new'`
+
+## Version 6.1.2 - 2022-08-25
+
+### Changed
+- `cds init` uses latest Maven Java archetype version 1.27.1 for creating Java projects.
+
+### Fixed
+- `cds add helm` fixed JSON Schema for `srv` property in values.yaml
+- `cds add helm` fixed env property errors for `hana_deployer` and `html5_apps_deployer`
+- `cds add data` now creates proper data file names for entites in a `context`, i.e. `sap.common-Countries.csv` instead of `sap-common-Countries.csv`
+- `cds import` now captures the parameter/property of collection type differently and the associated annotations are pulled out of the `items` object of the parameter/property entry in the csn.
+- Remove redundant `console.log()` statement in `cds lint`
+- `cds push` now shows complete error messages from extension validation
+- `cds push` and related commands now show properly formatted error messages and also fail with a non-zero exit code in error situations
+
+## Version 6.1.1 - 2022-08-11
+
+### Added
+
+- `cds import` now supports OData and SAP annotations for OData V4 imports.
+- `cds compile --to openapi` defines operation-specific HTTP error response status codes with descriptions via `ErrorResponses` property of certain annotations.
+- `cds compile --to openapi` now supports `--openapi:servers` option.
+- `cds add multitenancy` will add feature multitenancy-specific configuration, without extensibility.
+- `cds add toggles` will add feature toggle-specific configuration.
+- `cds add extensibility` will add configuration for project extensibility.
+- `cds add helm` now supports resource configuration for HANA deployment job and HTML5 app deployment job.
+- `cds add helm` added JSON Schema for values.yaml
+- `cds pull` will download the current CDS model of an extended SaaS app running with @sap/cds-mtxs.
+- `cds push` will upload an extension to a SaaS app running with @sap/cds-mtxs.
+
+### Changed
+
+- `cds add helm` updated default resource requirements for both `java` and `nodejs` projects.
+- `cds add helm` uses servicebinding.io bindings for CAP Java services, HANA and HTML5 app deployment jobs.
+- `cds compile --to openapi` creates only component schemas for schemas referenced in operations and in other schemas.
+- `cds import` switch from `@openapi.schema` to `@JSON.Schema`.
+- `cds add mtx` will now add configuration for streamlined MTX. It effectively acts as a shortcut for `cds add multitenancy,toggles,extensibility`
+- `cds add mtx` no longer includes `hana` and `xsuaa`.  To achieve the same effect as before, run `cds add mtx && cds add hana,xsuaa --for production`.
+- `cds bind -2 <xsuaa service instance>` binds the CDS `auth` service to the xsuaa instance. Previously `uaa` was used.  This requires `@sap/cds` 6 or higher.
+- `cds add lint:dev` updated to adjust to new api structure of `@sap/eslint-plugin-cds` v2.5.0
+- `cds init` uses latest Maven Java archetype version 1.27.0 for creating Java projects.
+- `cds login localhost:<port> -u <username>` now saves username (and empty password, if applicable) with project settings for convenience.
+
+### Fixed
+
+- `cds add helm:connectivity`: `connectivity.configMapName` was not used for the `connectivity-proxy-info`.
+- `cds import` replaced occurrences of `\\` with `/` in the `package.json` for Linux platforms.
+- `cds import` fixed `@Core.Description` and `doc` property duplication.
+- `cds extend` and `cds activate` no longer save any data (this is reserved to `cds login`).
+- Extensibility commands now add http (not https) to local app URLs without schema.
+- Extensibility commands don't query CF any longer when run against local apps.
+
 ## Version 6.0.4 - 2022-08-02
 
 ### Changed
@@ -14,7 +72,6 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 - Use `@sap/cds` 6.0.4
 - `cds bind` handles orgs and spaces containing commas correctly.
 
-
 ## Version 6.0.3 - 2022-07-14
 
 ### Changed
@@ -24,6 +81,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
 ### Fixed
 
+- `--vap-file` parameter of `cds deploy` is available again (removed in 6.0.0)
+- `cds add helm:connectivity`: `connectivity.configMapName` was not used for the `connectivity-proxy-info`.
 - `--vcap-file` parameter of `cds deploy` is available again (removed in 6.0.0)
 - `cds add helm:connectivity`: `connectivity.configMapName` was not used for the `connectivity-proxy-info`.
 - `cds add helm:connectivity`: Environment variables added for connectivity service for Java.

package/bin/add.js

@@ -13,30 +13,40 @@ module.exports = Object.assign(add, {
 
     The following <features> are supported so far:
 
-    *hana*        - adds configuration for SAP HANA deployment
+    *hana*          - adds configuration for SAP HANA deployment
 
-    *xsuaa*       - adds configuration for authentication via XSUAA
+    *xsuaa*         - adds configuration for authentication via XSUAA
 
-    *mtx*         - adds configuration for multitenancy and extensibility
+    *multitenancy*  - adds configuration for multitenancy
 
-    *approuter*   - adds configuration for the Cloud Foundry approuter
+    *toggles*       - adds configuration for feature toggles
 
-    *mta*         - adds an _mta.yaml_ file for MTA-based SAP Business Technology Platform deployment
+    *extensibility* - adds configuration for extensibility
 
-    *cf-manifest* - adds _manifest.yml_ and _services-manifest.yml_ files for Cloud Foundry native deployment
+    *mtx*           - adds configuration for multitenancy, feature toggles and extensibility
 
-                  This approach makes use of the 'Create-Service-Push Plugin' that has to be installed
-                  separately using _cf install-plugin Create-Service-Push_.
-                  _cf create-service-push_ creates the service(s) and pushes the application(s) to the
-                  SAP Business Technology Platform.
+    *approuter*     - adds configuration for the Cloud Foundry approuter
 
-    *pipeline*    - adds files for CI/CD pipeline integration
+    *mta*           - adds an _mta.yaml_ file for MTA-based SAP Business Technology Platform deployment
 
-    *samples*     - adds simple sample files
+    *cf-manifest*   - adds _manifest.yml_ and _services-manifest.yml_ files for Cloud Foundry native deployment
 
-    *notebook*    - adds a Jupyter Notebook (beta)
+                    This approach makes use of the 'Create-Service-Push Plugin' that has to be installed
+                    separately using _cf install-plugin Create-Service-Push_.
+                    _cf create-service-push_ creates the service(s) and pushes the application(s) to the
+                    SAP Business Technology Platform.
+
+    *pipeline*      - adds files for CI/CD pipeline integration
+
+    *samples*       - adds simple sample files
+
+    *data*          - adds data content for CSN model entities (as csv files)
+
+    *helm*          - adds helm chart folder that contains the files needed to deploy the application using Kyma.
+
+                    To add a specific feature in the helm chart you can use the command 'cds add helm:<featureName>'.
+                    For example cds add helm:xsuaa and cds add helm:html5_apps_deployer.
 
-    *data*        - adds data content for CSN model entities (as csv files)
 
 # OPTIONS
 
@@ -56,10 +66,13 @@ module.exports = Object.assign(add, {
 
 # EXAMPLES
 
-    *cds add* hana,mta,pipeline
-    *cds add* mtx --for production
+    *cds add* mta,pipeline
+    *cds add* mtx
+    *cds add* hana,xsuaa --for production
     *cds add* cf-manifest
     *cds add* data --for my.namspace.MyEntity
+    *cds add* helm
+
 
 # SEE ALSO
 

package/bin/compile/index.js

@@ -1,6 +1,6 @@
 module.exports = Object.assign ( compile, {
   options: [
-  '--from', '--service', '--lang', '--for', '--to', '--dest', '--log-level', '--flavor', '--dialect', '--sql-dialect', '--openapi:url'
+  '--from', '--service', '--lang', '--for', '--to', '--dest', '--log-level', '--flavor', '--dialect', '--sql-dialect', '--openapi:url', '--openapi:servers'
   ],
   shortcuts: [
   undefined, '-s', '-l', '-4', '-2', '-o', undefined, '-f'
@@ -105,6 +105,11 @@ module.exports = Object.assign ( compile, {
     base path as declared in the CDS source.
     Use the \${service-path} variable to have the service path included in the URL.
 
+  *--openapi:servers* <Stringified JSON Object for Open API export>
+
+    The servers definition used in the generated OpenAPI document. *--openapi:url* is
+    ignored when this option is specified.
+
   *--openapi:diagram*
 
     Include YUML diagram in the generated OpenAPI document, default: *false*.
@@ -278,7 +283,7 @@ function _log (messages, options) {
   const { sortMessagesSeverityAware, deduplicateMessages } = cds.compiler
   deduplicateMessages(messages)
   messages = sortMessagesSeverityAware (messages)
-  cds.utils._log (messages, options)
+  cds._log (messages, options)
 }
 
 /* eslint no-console:0 */

package/bin/fix-redirects.js

@@ -1,5 +1,6 @@
 const [arg0, arg1, _, ...args] = process.argv  // eslint-disable-line no-unused-vars
-const files = require('../lib/cds').resolve(args.length ? args : '*')
+const cds = require('../lib/cds')
+const files = cds.resolve(args.length ? args : '*')
 process.argv = [ arg0, arg1, 'ria', ...files ]
 
 console.log ('[cds] - searching for ambiguous redirects in', files)
@@ -7,6 +8,7 @@ const log = console.log; console.log = (...args) => {
   if (!log.found) log (log.found = '> found ambiguous redirects in these models -> please fix as follows:\n')
   log (...args)
 }
-require ('@sap/cds-compiler/bin/cdsv2m')
+
+require(require.resolve ('@sap/cds-compiler/bin/cdsv2m', {paths: [ cds.home, process.cwd(), __dirname ]}))
 
 module.exports = ()=>{}

package/bin/init.js

@@ -50,6 +50,11 @@ module.exports = Object.assign(init, {
 
         *notebook*    - adds a Jupyter Notebook (beta)
 
+        *helm*        - adds helm chart folder that contains the files needed to deploy the application using Kyma.
+
+                      To add a specific feature in the helm chart you can use the command 'cds add helm:<featureName>'. 
+                      For example cds add helm:xsuaa and cds add helm:html5_apps_deployer.
+
     *--java:mvn* <Comma separated maven archetype specific parameters>
 
         Add the given parameters to the archetype call.

package/bin/login.js

@@ -1,8 +1,8 @@
 const { bold } = require('../lib/util/term');
 
 module.exports = Object.assign(login, {
-    options: ['--subdomain', '--directory', '--passcode', '--clientid'],
-    shortcuts: ['-s', '-d', '-p', '-c'],
+    options: ['--subdomain', '--directory', '--passcode', '--user', '--clientid'],
+    shortcuts: ['-s', '-d', '-p', '-u', '-c'],
     flags: ['--plain'],
     get help() {
         const config = require('../lib/client/settings_manager').SettingsManager.config
@@ -71,6 +71,17 @@ module.exports = Object.assign(login, {
 
         Tenant-specific passcode for authentication.
 
+    *-u* | *--user* <name>[:[<password>]]
+
+        Username and optionally password for authentication with Basic Auth in test scenarios.        
+        See https://cap.cloud.sap/docs/guides/multitenancy/#send-subscribe-events for information
+        on suitable mock users.
+
+        When typing the colon but omitting <password>, the password is assumed empty. 
+
+        For security reasons, username will only be saved for app URLs that look like localhost.
+        The same is true for an empty password. Non-empty passwords will never be saved.
+
     *-c* | *--clientid* <clientid>
 
         Client ID for authentication. This will override the default Client ID from environment.
@@ -100,14 +111,19 @@ module.exports = Object.assign(login, {
 
 
 async function login ([url], options = {}) {
+    const [username, password] = options.user?.split(':') ?? [];
+    delete options.user;
     Object.assign(options, {
         url,
+        username,
+        password,
         tokenStorage: options.plain ? 'plain' : 'keyring',
-        renewLogin: true
+        renewLogin: true,
+        saveData: true
     })
     delete options.plain
 
-    await require('../lib/client/auth_manager').loginAndUpdateSettings(options)
+    await require('../lib/client/auth_manager').login(options)
 }
 
 

package/bin/pull.js

@@ -0,0 +1,58 @@
+module.exports = Object.assign(pull, {
+    options: ['--directory', '--subdomain', '--passcode', '--username', '--clientid'],
+    flags: [],
+    shortcuts: ['-d', '-s', '-p', '-u', '-c'],
+    help: `
+# SYNOPSIS
+
+    *cds pull* [ <app-url> ]
+
+    Pull the base model for your SaaS app extension.
+    
+    To run this command, you need to obtain from the SaaS application provider:
+    - the app URL
+    - a template for your extension project.
+
+    Then create your extension project from the template and run *cds pull* to update your copy of the CDS model of the
+    SaaS app (also known as the base model).
+
+    To facilitate running this multiple times against the same app, refer to the *cds login* command.
+
+    If the app URL is omitted, it is determined from the current user's active CDS or Cloud Foundry login.
+
+
+# OPTIONS
+
+    *-d* | *--directory* <project-extension-directory>
+
+        Specify the target directory of your extension project. By default, the current working directory is used.
+
+    *-s* | *--subdomain* <tenant-subdomain>
+
+        Specify your tenant's subdomain. By default, it's determined from the app URL.
+
+    *-p* | *--passcode* <passcode>
+
+        Tenant-specific passcode for authentication.
+
+    *-u* | *--username* <name>
+
+        Username for authentication with Basic Auth in test scenarios.
+
+    *-c* | *--clientid* <clientid>
+
+        Client ID for authentication. This will override the default Client ID from environment.
+
+# SEE ALSO
+
+    *cds push* to push an extension to the SaaS app.
+    
+`})
+
+
+async function pull([url], options = {}) {
+    await require('../lib/client/pull').run({
+        ...options,
+        url
+    })
+}

package/bin/push.js

@@ -0,0 +1,52 @@
+module.exports = Object.assign(push, {
+    options: ['--subdomain', '--passcode', '--username', '--clientid', '--to'],
+    flags: [],
+    shortcuts: ['-s', '-p', '-u', '-c'],
+    help: `
+# SYNOPSIS
+
+    *cds push* [ <extension-project-directory> ]
+
+    Push your extension to the SaaS app in order to enable or update it.
+    
+    By default, the current working directory is used as project directory.
+
+    To facilitate running this multiple times against the same app, refer to the *cds login* command.
+
+
+# OPTIONS
+
+    *--to* <url>
+
+        Specify the URL of the extensible SaaS app. By default, it is determined from
+        the current user's active CDS or Cloud Foundry login.
+
+    *-s* | *--subdomain* <tenant-subdomain>
+
+        Specify your tenant's subdomain. By default, it's determined from project settings.
+
+    *-p* | *--passcode* <passcode>
+
+        Tenant-specific passcode for authentication.
+
+    *-u* | *--username* <name>
+
+        Username for authentication with Basic Auth in test scenarios.
+
+    *-c* | *--clientid* <clientid>
+
+        Client ID for authentication. This will override the default Client ID from environment.
+
+# SEE ALSO
+
+    *cds pull* to get the CDS model of the SaaS app.
+
+`})
+
+
+async function push([projectFolder], options = {}) {
+    await require('../lib/client/push').run({
+        ...options,
+        projectFolder
+    })
+}

package/bin/subscribe.js

@@ -0,0 +1,45 @@
+module.exports = Object.assign(subscribe, {
+  options: ['--to', '--user'],
+  flags: [],
+  shortcuts: ['-2', '-u'],
+  help: `
+# SYNOPSIS
+
+  *cds subscribe* <tenant>
+
+  Subscribe a tenant to a multi-tenant SaaS app.
+
+  *cds subscribe* only supports Basic Authentication and is intended for non-productive use,
+  including SaaS apps running on localhost with mock authentication.
+
+# OPTIONS
+
+  *-2* | *--to* <url>
+
+    Specify the URL of the extensible SaaS app. Required setting.
+
+  *-u* | *--user* <name>[:<password>]
+
+    Username and optionally password for authentication. Required setting.
+    See https://cap.cloud.sap/docs/guides/multitenancy/#send-subscribe-events for information on suitable mock users.
+    
+    If password is omitted, it is assumed empty.
+    Note: productive passwords should not be specified on the command line.
+
+`})
+
+
+
+async function subscribe([tenant], { to: url, user } = {}) {
+  const Logger = require('../lib/client/helper/logging');
+
+  if (!tenant)  throw new Error('Must provide a tenant')
+  if (!url)  throw new Error('Must provide an app URL via `--to`')  // for now, if we don't infer it from the project
+  if (typeof user !== 'string')  throw new Error('Must provide a username')
+  const [username, password = ''] = user.split(':');
+  Logger.log(`Subscribing to ${url} for tenant '${tenant}' with user '${username}'${password === '' ? ' and empty password' : ''}`);
+  const options = { auth: { username, password } };
+  return require('axios').post (url+'/-/cds/deployment/subscribe', { tenant }, options);
+}
+
+// cds subscribe t1 --to http://localhost:4004 -u yves

package/lib/bind/bindingUtil.js

@@ -3,8 +3,7 @@ const os = require('os');
 const IS_WIN = os.platform() === 'win32';
 
 const KindToRequiresNameMap = {
-    xsuaa: 'uaa',
-    'xsuaa-auth': 'uaa',
+    xsuaa: 'auth',
     'hana-cloud': 'db',
     hana: 'db',
     destinations: 'destinations',

package/lib/cds.js

@@ -1,9 +1,8 @@
-/** @type { import('@sap/cds/apis/cds') } */
+/** @type { import('@sap/cds/lib') } */
 const cds = module.exports = require(_local ('@sap/cds'))
 
 // for internal use in cds-dk only
-cds.utils._log = require(_local ('@sap/cds/bin/utils/log'))
-
+cds._log = require(_local ('@sap/cds/bin/utils/log'))
 
 function _local (id) {
   return require.resolve (id, {paths:[

package/lib/client/activate.js

@@ -6,6 +6,7 @@ const AuthManager = require('./auth_manager');
 const BaseCommand = require('./base_command');
 const { collectFileContent, collectFiles, toUnixPath } = require('./helper/fs_helper');
 const Logger = require('./helper/logging');
+const { CliError } = require('./helper/errors');
 
 const COMMAND_URL_SUFFIX = 'asyncActivate';
 const COMMAND_URL_SUFFIX_SYNC = 'activate';
@@ -27,7 +28,7 @@ async function checkFinished(jobId, statusUrl, params, finisher) {
         finisher.finished = true;
         clearInterval(finisher.timer);
         if (status === JOB_STATUS.FAILED) {
-            return finisher.reject(new Error(`Job ${jobId} failed: ${error.message || JSON.stringify(error)}`));
+            return finisher.reject(new CliError(`Job ${jobId} failed: ${error.message || JSON.stringify(error)}`));
         }
         Logger.log('Extension active');
         finisher.resolve();
@@ -42,7 +43,7 @@ module.exports = class Activate extends BaseCommand {
 
     static async run(injection, paramValues) {
         try {
-            const params = await AuthManager.loginAndUpdateSettings(paramValues);
+            const params = await AuthManager.login(paramValues);
 
             if (process.env.DEBUG) {
                 Logger.log('Activating extension with parameters ' + JSON.stringify({
@@ -55,17 +56,17 @@ module.exports = class Activate extends BaseCommand {
                 Logger.log(`Activating extension located at ${params.get('projectFolder')} to URL ${params.get('appUrl')}`);
             }
 
-            if (!await Activate.checkProject(params.get('projectFolder'))) {
-                throw new Error(params.get('projectFolder') + ' is not a valid extension project');
+            if (!await this.checkProject(params.get('projectFolder'))) {
+                throw new CliError(params.get('projectFolder') + ' is not a valid extension project');
             }
 
             try {
-                await Activate.runActivate(injection.cds, params);
+                await this.runActivate(injection.cds, params);
                 if (params.get('wsdl')) {
-                    await Activate.runCustomFileUpload(params);
+                    await this.runCustomFileUpload(params);
                 }
             } catch (error) {
-                Activate.handleHttpError(error, params);
+                await this.handleHttpError(error, params);
             }
         } catch (error) {
             Logger.error(undefined, error);
@@ -153,7 +154,7 @@ module.exports = class Activate extends BaseCommand {
             return wsdlFiles;
         } catch (error) {
             Logger.error(undefined, error);
-            throw new Error('No custom files found');
+            throw new CliError('No custom files found');
         }
     }
 
@@ -161,7 +162,7 @@ module.exports = class Activate extends BaseCommand {
         let activationUrl;
         const isSync = params.get('sync');
 
-        return Activate.collectExtensionFiles(cds, params.get('projectFolder'))
+        return this.collectExtensionFiles(cds, params.get('projectFolder'))
         .then(allFiles => {
             if (allFiles.size === 0) {
                 return null;
@@ -169,8 +170,8 @@ module.exports = class Activate extends BaseCommand {
 
             Logger.log('Activating extension...');
 
-            const urlSuffix = isSync ? Activate.COMMAND_URL_SUFFIX_SYNC : Activate.COMMAND_URL_SUFFIX;
-            activationUrl = Activate.getMtxApiUrl(params.get('appUrl'), urlSuffix);
+            const urlSuffix = isSync ? this.COMMAND_URL_SUFFIX_SYNC : this.COMMAND_URL_SUFFIX;
+            activationUrl = this.getMtxApiUrl(params.get('appUrl'), urlSuffix);
             const requestOptions = Object.assign({
                 headers: {}
             }, params.get('reqAuth'));
@@ -189,17 +190,17 @@ module.exports = class Activate extends BaseCommand {
             const { jobID: jobId, statusPath } = response.data;
 
             if (jobId === undefined) {
-                throw new Error('Activation failed: did not receive job ID');
+                throw new CliError('Activation failed: did not receive job ID');
             }
 
             if (!statusPath) {
-                throw new Error(`Job ${jobId} failed: did not receive job-status path`);
+                throw new CliError(`Job ${jobId} failed: did not receive job-status path`);
             }
 
             Logger.debug(`Job ID: ${jobId}`);
 
             return new Promise((resolve, reject) => {
-                const statusUrl = Activate.concatUrls(params.get('appUrl'), statusPath);
+                const statusUrl = this.concatUrls(params.get('appUrl'), statusPath);
                 const finisher = {
                     resolve,
                     reject,
@@ -214,7 +215,7 @@ module.exports = class Activate extends BaseCommand {
     static async runCustomFileUpload(params) {
         Logger.log(`Uploading custom files to ${params.get('appUrl')}...`);
 
-        const customFiles = Activate.collectCustomFiles(params.get('projectFolder'));
+        const customFiles = this.collectCustomFiles(params.get('projectFolder'));
 
         const customFilesSerialized = [];
         customFiles.forEach((value, key) => {
@@ -225,7 +226,7 @@ module.exports = class Activate extends BaseCommand {
             });
         });
 
-        const customFileUrl = Activate.getMtxApiUrl(params.get('appUrl'), Activate.UPDATE_CUSTOM_FILE_URL_SUFFIX);
+        const customFileUrl = this.getMtxApiUrl(params.get('appUrl'), this.UPDATE_CUSTOM_FILE_URL_SUFFIX);
         const requestOptions = Object.assign({
             headers: {},
         }, params.get('reqAuth'));

package/lib/client/auth_manager.js

@@ -4,6 +4,7 @@ const axios = require('axios');
 const Logger = require('./helper/logging');
 const { SettingsManager } = require('./settings_manager');
 const { ParamCollection } = require('./params');
+const { CliError } = require('./helper/errors');
 
 function addTokenInfo(params, authData) {
     params.set('token', authData.access_token);
@@ -60,7 +61,7 @@ async function retrieveTokenOrPasscodeUrl(params) {
         try {
             response = await axios.get(tokenUrl);
         } catch (error) {
-            throw new Error(`Failed to get authentication token: ${error}.\nResponse body: ${util.inspect(error.response && error.response.data)}`);
+            throw new CliError(`Failed to get authentication token: ${error}.\nResponse body: ${util.inspect(error.response && error.response.data)}`);
         }
         authData = response.data;
 
@@ -77,7 +78,7 @@ async function retrieveTokenOrPasscodeUrl(params) {
 
 module.exports = class AuthManager {
 
-    static async loginAndUpdateSettings(paramValues) {
+    static async login(paramValues) {
         SettingsManager.init();
         const params = new ParamCollection(paramValues);
         await SettingsManager.loadAndMergeSettings(params);
@@ -86,15 +87,19 @@ module.exports = class AuthManager {
         } else {
             await retrieveTokenOrPasscodeUrl(params);
             if (!params.has('token')) {
-                await SettingsManager.saveSettings(params);
-                throw new Error('Failed to login: no valid token or passcode provided. ' +
+                if (params.get('saveData')) {
+                    await SettingsManager.saveSettings(params);
+                }
+                throw new CliError('Failed to login: no valid token or passcode provided. ' +
                     'Get a passcode' + (params.get('passcodeUrl') ? ' from ' + params.get('passcodeUrl') : '') +
                     ' and supply the code when re-running the command');
             }
             params.set('reqAuth', { headers: { Authorization: 'Bearer ' + params.get('token') } });
         }
 
-        await SettingsManager.saveSettings(params); // saves token conditionally
+        if (params.get('saveData')) {
+            await SettingsManager.saveSettings(params); // saves token conditionally
+        }
 
         return params;
     }

package/lib/client/base_command.js

@@ -1,7 +1,7 @@
 const path = require('path');
 const fs = require('fs').promises;
 
-const Logger = require('./helper/logging');
+const { CliError } = require('./helper/errors');
 
 const MTX_URL_PATH_PREFIX = 'mtx/v1/model/';
 const CUSTOM_FILE_URL_SUFFIX = 'customTenantContent';
@@ -22,15 +22,13 @@ module.exports = class BaseCommand {
 
         switch (error.response && error.response.status) {
             case 401:
-                Logger.error('Request failed: authorization might have expired. Please retry with valid passcode' +
+                throw new CliError('Request failed: authorization might have expired. Please retry with valid passcode' +
                     (params.has('passcodeUrl') ? ` from ${params.get('passcodeUrl')}` : ''), error);
-                break;
             case 404:
-                Logger.error(`Request failed. Please check application URL ${params.get('appUrl')}`, error);
-                break;
+                throw new CliError(`Request failed. Please check application URL ${params.get('appUrl')}`, error);
             default:
                 // Including 422 (compilation or native-extension error).
-                Logger.error(undefined, error);
+                throw new CliError(undefined, error);
         }
     }