@sap/cds-dk 10.1.2 → 10.2.0

package/node_modules/@sap/cds-compiler/lib/compiler/checks.js

@@ -363,6 +363,56 @@ function check( model ) {
       for (const mixinName in query.mixin)
         checkAssociation( query.mixin[mixinName] );
     }
+
+    checkDuplicateProjections( query );
+  }
+
+  function checkDuplicateProjections( query ) {
+    if (model.options.$recompile)
+      return;
+    if (query._main.$inferred)
+      return;
+
+    forEachGeneric( query, '$tableAliases', ( alias ) => {
+      if (alias.kind === '$tableAlias') {
+        forEachGeneric( alias, 'elements', ( nav, name ) => {
+          traverseNavigationElements( nav, [ alias.name.id, name ] );
+        } );
+      }
+    } );
+
+    function traverseNavigationElements( nav, path ) {
+      const directProjections = isScalarOrStructuredElement( nav._origin )
+        ? (nav._projections || []).filter( p => !p.$duplicates )
+        : [];
+      reportDuplicateProjections( directProjections, path );
+
+      forEachGeneric( nav, 'elements', ( child, name ) => {
+        traverseNavigationElements( child, [ ...path, name ] );
+      } );
+    }
+
+    function reportDuplicateProjections( projections, path ) {
+      if (projections.length < 2)
+        return;
+      const names = projections.map( p => p.name.id );
+      const elemref = { path: path.map( id => ({ id }) ) };
+      projections.forEach( ( projection, i ) => {
+        const loc = (projection.value?.path?.at(-1) || projection.value || projection).location;
+        warning( 'query-duplicate-reference', [ loc, projection ], {
+          name: projection.name.id,
+          names: names.filter( ( _, index ) => index !== i ),
+          elemref,
+        }, 'Select item $(NAME) refers to the same source element $(ELEMREF) as $(NAMES)' );
+      } );
+    }
+
+    function isScalarOrStructuredElement( elem ) {
+      const effectiveType = elem._effectiveType;
+      if (!effectiveType || effectiveType.items || effectiveType.target)
+        return false;
+      return true;
+    }
   }
 
   function checkEnumType( enumNode ) {