@sap/cds-compiler 6.4.2 → 6.4.6

package/CHANGELOG.md

@@ -4,9 +4,35 @@
 <!-- markdownlint-disable MD004 -->
 <!-- (no-duplicate-heading)-->
 
-Note: `beta` fixes, changes and features are usually not listed in this ChangeLog
-but in [doc/CHANGELOG_BETA.md](doc/CHANGELOG_BETA.md).
-The compiler behavior concerning `beta` features can change at any time without notice.
+Note: while we list new `beta` flags and their removal in this ChangeLog,
+we might not list every change in its behavior here.
+Productive code should never require a `beta` flag to be set, and
+might use a deprecated flag only for a limited period of time.
+
+## Version 6.4.6 - 2025-10-23
+
+### Fixed
+
+- compiler: a references to an element of the target in a filter for associations
+  inside an annotation expression does not lead to a compiler message requesting
+  users to provide the annotation themselves (regression with v6.4.4)
+
+## Version 6.4.4 - 2025-10-15
+
+### Fixed
+
+- compiler:
+  + properly rewrite references in arguments of associations in annotation expressions
+  + a references to a variable (`$user.id`, …) in a filter of an annotation expression
+    does not lead to a compiler message requesting users to provide the annotation themselves
+  + improve code completion in annotation expressions: the editor can display valid names
+    for references even if the expression does not properly end by `)`
+- to.sql:
+  + reject `$self` in infix filter following exists predicate instead of just ignoring the filter expression
+  + properly add comparison for the `tenant` discriminator to the `join` condition of `localized` views
+    if the non-published option for tenant support is set (regression with v6.4.0)
+
+### Removed
 
 ## Version 6.4.2 - 2025-10-07
 
@@ -17,8 +43,8 @@ The compiler behavior concerning `beta` features can change at any time without
   + avoid clutter in message text for syntax errors: use `‹Value›` instead of listing value tokens
 - compiler: fix suppression of warnings when annotating backend-generated things
   like draft entities or localized convenience views
-- to.sql|hdi|hdbcds: Fix handling of structured columns when calculated elements are used
-  don't add explicit casts too eagerly
+- to.sql|hdi|hdbcds: don’t report unjustified errors when projecting structured elements and
+  calculated elements had been used (regression with v6.4.0)
 
 ## Version 6.4.0 - 2025-09-26
 
@@ -239,6 +265,19 @@ The compiler behavior concerning `beta` features can change at any time without
 
 - for.odata/to.edm(x):
   + Annotating the generated `DraftAdministrativeData` artifacts and their elements is now supported.
+- beta flag `v7preview`: if set, the compiler reports those issues as errors
+  which we consider severe enough to report as error with the v7 release.
+- new deprecated flags:
+  + If the deprecated flag `noQuasiVirtualAssocs` is set, managed to-many associations
+    will get foreign keys as they got in compiler v5.  If not set, managed to-many associations
+    without explicit foreign keys don't get `keys` anymore in  cds-compiler v6.
+  + If the deprecated flag `noCompositionIncludes` is set, generated entities for compositions
+    of named aspect will not get an `includes` property.
+  + If the deprecated flag `noPersistenceJournalForGeneratedEntities` is set,
+    `@cds.persistence.journal` will _not_ be propagated to generated entities,
+    including generated `.texts` entities for localized entities, nor generated entities
+    for managed compositions of aspects. If not set, this annotation is copied to those entities
+    in compiler v6.
 
 ### Removed
 
@@ -247,6 +286,9 @@ The compiler behavior concerning `beta` features can change at any time without
   + v5 deprecated flags are removed, see [CHANGELOG_DEPRECATED.md](doc/CHANGELOG_DEPRECATED.md).
   + Option `compositionIncludes` is removed, as its default is `true`; instead, a deprecated flag was added.
 - to.hdbcds: The HDBCDS backend is deprecated and can no longer be invoked.
+- beta feature `v6preview`
+- deprecated flags `includesNonShadowedFirst`, `eagerPersistenceForGeneratedEntities` and
+  noKeyPropagationWithExpansions`
 
 ### Fixed
 
@@ -358,6 +400,8 @@ The compiler behavior concerning `beta` features can change at any time without
   in parentheses such as `[ (1), (2) ]`, as well as "infinite" by using `[ _, _ ]`.
 - for.odata/to.edm(x)/for.seal: Propagate annotation expressions from managed associations
   to the foreign keys
+- beta feature `v6preview`: if set, the compiler reports those issues as errors
+  which we consider severe enough to report as error with the v6 release.
 
 ### Changed
 
@@ -530,6 +574,11 @@ The compiler behavior concerning `beta` features can change at any time without
 - CDL parser: Issue warning for arrayed parameter with default value.
 - to.cdl: Arrayed parameters with default values were not rendered correctly.
 
+### Removed
+
+- beta flag `optionalActionFunctionParameters`: in v5, action and function parameters
+  can be specified as optional without setting this beta flag.
+
 ## Version 5.2.0 - 2024-08-27
 
 ### Added
@@ -645,6 +694,7 @@ This is a preview version for the major release and contains breaking changes. I
 
 - API: Deprecated functions `preparedCsnToEdmx` and `preparedCsnToEdm` were removed.
   Use `to.edm(x)` instead.
+- beta feature `v5preview`
 
 ## Version 4.9.10 - 2025-04-29
 

package/lib/base/message-registry.js

@@ -707,8 +707,8 @@ const centralMessageTexts = {
     on: 'Unexpected $(ID) reference; is valid only if compared to be equal to an association of the target side',
     subQuery: 'Unexpected $(ID) reference in a sub query',
     setQuery: 'Unexpected $(ID) reference in a query on the right side of $(OP)',
-    exists: 'With $(NAME), path steps must not start with $(ID)',
-    'exists-filter': 'Unexpected $(ID) reference in filter of path $(ELEMREF) following “EXISTS” predicate',
+    exists: 'Paths following $(NAME) must not start with $(ID)',
+    'exists-filter': 'Unexpected $(ID) reference in filter of assoc $(ELEMREF) following “EXISTS” predicate',
   },
   'ref-unexpected-map': {
     std: 'Unexpected reference to an element of type $(TYPE)', // unused

package/lib/checks/existsExpressionsOnlyForeignKeys.js

@@ -3,39 +3,45 @@
 const { requireForeignKeyAccess } = require('../checks/onConditions');
 
 /**
- * Check that associations in filters (in an exists expression) are only fk-accesses. Everything else is forbidden.
+ * Filter expressions in an exists path must:
+ * - only contain fk-accesses for assocs. Unmanaged traversal / non-fk access is forbidden.
+ * - not contain a ref starting with $self
  *
  * @param {CSN.Artifact} parent
  * @param {string} name
  * @param {Array} expr
  */
-function forbidAssocInExists( parent, name, expr ) {
+function assertFilterOfExists( parent, name, expr ) {
   for (let i = 0; i < expr.length - 1; i++) {
     if (expr[i] === 'exists' && expr[i + 1].ref) {
       i++;
       const current = expr[i];
 
-      const { _links } = expr[i];
+      const { _links } = current;
 
       const assocs = _links.filter(link => link.art?.target).map(link => current.ref[link.idx]);
 
-      checkForInvalidAssoc.call(this, assocs);
+      ensureValidFilters.call(this, assocs);
     }
   }
 }
 
 /**
- * Check that associations in filters (in an exists expression) are only fk-accesses. Everything else is forbidden.
+ * Reject:
+ * - Unmanaged traversal / non-fk access.
+ * - ref's starting with $self
  *
  * @param {object[]} assocs Array of refs of assocs - possibly with a .where to check
  */
-function checkForInvalidAssoc( assocs ) {
+function ensureValidFilters( assocs ) {
   for (const assoc of assocs) {
     if (assoc.where) {
       for (let i = 0; i < assoc.where.length; i++) {
         const part = assoc.where[i];
 
         if (part._links && !(assoc.where[i - 1] && assoc.where[i - 1] === 'exists')) {
+          if (part.$scope === '$self')
+            this.error('ref-unexpected-self', part.$path, { '#': 'exists-filter', elemref: assoc.id, id: part.ref[0] });
           for (const link of part._links) {
             if (link.art && link.art.target) {
               if (link.art.keys) { // managed - allow FK access
@@ -55,7 +61,7 @@ function checkForInvalidAssoc( assocs ) {
               }
               // Recursively drill down if the assoc-step has a filter
               if (part.ref[link.idx].where)
-                checkForInvalidAssoc.call(this, [ part.ref[link.idx] ]);
+                ensureValidFilters.call(this, [ part.ref[link.idx] ]);
             }
           }
         }
@@ -65,7 +71,7 @@ function checkForInvalidAssoc( assocs ) {
 }
 
 module.exports = {
-  having: forbidAssocInExists,
-  where: forbidAssocInExists,
-  xpr: forbidAssocInExists,
+  having: assertFilterOfExists,
+  where: assertFilterOfExists,
+  xpr: assertFilterOfExists,
 };

package/lib/checks/existsMustEndInAssoc.js

@@ -13,8 +13,8 @@ function existsMustEndInAssoc( parent, prop, expression, path ) {
     if (expression[i] === 'exists') {
       const next = expression[i + 1];
       const { _art } = next;
-      const errorPath = path.concat([ prop, i ]);
       if (!next.SELECT && !_art?.target) {
+        const errorPath = path.concat([ prop, i ]);
         this.error('ref-expecting-assoc', errorPath, {
           '#': _art.type ? 'with-type' : 'std',
           elemref: next,

package/lib/checks/existsMustNotStartWithDollarSelf.js

@@ -0,0 +1,31 @@
+'use strict';
+
+/**
+ * A path following an “exists” predicate must always end in an association.
+ *
+ * @param {object} parent
+ * @param {string} prop
+ * @param {Array} expression
+ * @param {CSN.Path} path
+ */
+function existsMustNotStartWithDollarSelf( parent, prop, expression, path ) {
+  for (let i = 0; i < expression?.length - 1; i++) {
+    if (expression[i] === 'exists') {
+      const next = expression[i + 1];
+      if (next.$scope === '$self') {
+        const errorPath = path.concat([ prop, i ]);
+        this.error('ref-unexpected-self', errorPath, {
+          '#': 'exists',
+          id: next.ref[0],
+          name: 'exists',
+        });
+      }
+    }
+  }
+}
+
+module.exports = {
+  having: existsMustNotStartWithDollarSelf,
+  where: existsMustNotStartWithDollarSelf,
+  xpr: existsMustNotStartWithDollarSelf,
+};

package/lib/checks/validator.js

@@ -43,7 +43,8 @@ const { validateAssociationsInItems } = require('./arrayOfs');
 const checkQueryForNoDBArtifacts = require('./queryNoDbArtifacts');
 const checkExplicitlyNullableKeys = require('./nullableKeys');
 const existsMustEndInAssoc = require('./existsMustEndInAssoc');
-const forbidAssocInExists = require('./existsExpressionsOnlyForeignKeys');
+const existsMustNotStartWithDollarSelf = require('./existsMustNotStartWithDollarSelf');
+const assertFilterOfExists = require('./existsExpressionsOnlyForeignKeys');
 const checkPathsInStoredCalcElement = require('./checkPathsInStoredCalcElement');
 const managedWithoutKeys = require('./managedWithoutKeys');
 const {
@@ -85,7 +86,8 @@ const forRelationalDBArtifactValidators = [
 const forRelationalDBCsnValidators = [
   checkCdsMap,
   existsMustEndInAssoc,
-  forbidAssocInExists,
+  existsMustNotStartWithDollarSelf,
+  assertFilterOfExists,
   navigationIntoMany,
   checkPathsInStoredCalcElement,
   featureFlags,

package/lib/compiler/assert-consistency.js

@@ -207,7 +207,7 @@ function assertConsistency( model, stage ) {
             'elements', '$autoElement', '$uncheckedElements', '_origin', '_extensions',
             '$requireElementAccess', '_effectiveType', '$effectiveSeqNo', '_deps',
             '$calcDepElement', '$filtered', '$enclosed', '_parent',
-            'deprecated', '$onlyInExprCtx',
+            'deprecated', '$restricted',
           ],
           schema: {
             kind: { test: isString, enum: [ 'builtin' ] },
@@ -216,7 +216,7 @@ function assertConsistency( model, stage ) {
             $uncheckedElements: { test: isBoolean },
             $requireElementAccess: { test: isBoolean },
             deprecated: { test: isBoolean },
-            $onlyInExprCtx: { test: TODO },
+            $restricted: { test: TODO },
             // missing location for normal "elements"
             elements: { test: TODO },
           },

package/lib/compiler/builtins.js

@@ -211,8 +211,7 @@ const magicVariables = {
     },
     // Require that elements are accessed, i.e. no $draft, only $draft.<element>.
     $requireElementAccess: true,
-    // See reference semantics in shared.js
-    $onlyInExprCtx: [ 'annotation', 'annoRewrite' ],
+    $restricted: true,          // only in annotation expression, see shared.js
   },
 };
 
@@ -454,8 +453,8 @@ function initBuiltins( model ) {
         art.$requireElementAccess = magic.$requireElementAccess;
       if (magic.deprecated)
         art.deprecated = magic.deprecated;
-      if (magic.$onlyInExprCtx)
-        art.$onlyInExprCtx = magic.$onlyInExprCtx;
+      if (magic.$restricted)
+        art.$restricted = magic.$restricted;
 
       createMagicElements( art, magic.elements );
       if (options.variableReplacements?.[id])
@@ -480,8 +479,8 @@ function initBuiltins( model ) {
       // Propagate this property so that it is available for sub-elements.
       if (art.$uncheckedElements)
         magic.$uncheckedElements = art.$uncheckedElements;
-      if (art.$onlyInExprCtx)
-        magic.$onlyInExprCtx = art.$onlyInExprCtx;
+      if (art.$restricted)
+        magic.$restricted = art.$restricted;
       setProp( magic, '_parent', art );
       // setProp( magic, '_effectiveType', magic );
       if (elements[id] && typeof elements[id] === 'object')