@sap/cds-compiler 4.8.0 → 4.9.2

package/lib/transform/universalCsn/universalCsnEnricher.js

@@ -9,7 +9,7 @@ const {
   applyTransformations,
   implicitAs,
 } = require('../../model/csnUtils');
-const { isBuiltinType } = require('../../base/builtins');
+const { isBuiltinType, propagationRules } = require('../../base/builtins');
 const {
   forEachValue, forEach,
 } = require('../../utils/objectUtils');
@@ -29,24 +29,10 @@ module.exports = (csn, options) => {
   } = csnUtils;
     // Properties on definition level that we treat specially.
   const definitionPropagationRules = {
-    '@cds.autoexpose': onlyViaArtifact,
-    '@cds.external': skip,
-    '@fiori.draft.enabled': onlyViaArtifact,
+    __proto__: null,
     '@': nullStopsPropagation,
     // Example: `type E : F;` does not have `elements`, but they are required for e.g. OData.
     elements: onlyTypeDef,
-    '@cds.persistence.exists': skip,
-    '@cds.persistence.table': skip,
-    '@cds.persistence.calcview': skip,
-    '@cds.persistence.udf': skip,
-    '@cds.persistence.skip': notWithPersistenceTable,
-    '@sql.append': skip,
-    '@sql.prepend': skip,
-    '@sql.replace': skip,
-    '@Analytics.hidden': skip,
-    '@Analytics.visible': skip,
-    '@cds.autoexposed': skip,
-    '@cds.redirection.target': skip,
     type: always,
     doc: nullStopsPropagation,
     length: always,
@@ -65,6 +51,16 @@ module.exports = (csn, options) => {
     keys: always,
   };
 
+  const ruleToFunction = {
+    __proto__: null,
+    never: skip,
+    onlyViaArtifact,
+    notWithPersistenceTable,
+  };
+
+  for (const rule in propagationRules)
+    definitionPropagationRules[rule] = ruleToFunction[propagationRules[rule]];
+
   // Properties on member level that we treat specially
   const memberPropagationRules = {
     key: skip,
@@ -284,7 +280,8 @@ module.exports = (csn, options) => {
       },
       params: (parent, prop, params) => {
         forEachValue(params, (param) => {
-          const propagateToParams = typeof param.type === 'string' ? csn.definitions[param.type]?.kind !== 'entity' : true;
+          const propagateToParams = (param.type !== '$self' || csn.definitions.$self) &&
+            (typeof param.type !== 'string' || csn.definitions[param.type]?.kind !== 'entity');
           propagateMemberPropsFromOrigin(param, {
             '@': !propagateToParams, items: true, elements: true, enum: true, virtual: true,
           });
@@ -343,8 +340,8 @@ module.exports = (csn, options) => {
             copyProperties(origin, target, getMemberPropagationRuleFor, except, force);
 
             // For a `type of` with .items, we want to take stuff from types (which we skip for "normal" propagation, see specialItemsRules).
-            // So for a type of we also propagate stuff from the virtual origin (which we don't give a "kind", therefore skipping that part of the check)
-            if (target.type && target.type.ref)
+            // So for a `type of` we also propagate stuff from the virtual origin (which we don't give a "kind", therefore skipping that part of the check)
+            if (target.type?.ref)
               copyProperties(virtualOrigin, target, getMemberPropagationRuleFor, except);
 
             if (!target.kind)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cds-compiler",
-  "version": "4.8.0",
+  "version": "4.9.2",
   "description": "CDS (Core Data Services) compiler and backends",
   "homepage": "https://cap.cloud.sap/",
   "author": "SAP SE (https://www.sap.com)",

package/share/messages/anno-missing-rewrite.md

@@ -0,0 +1,45 @@
+# anno-missing-rewrite
+
+A propagated annotation containing expressions can't be rewritten and would
+end up with invalid paths.
+
+While propagating annotations containing expressions such as `@anno: (path)`,
+the compiler ensures that the path remains valid.  If necessary, the paths
+have to be rewritten, e.g. when being propagated to projections that rename
+their source's elements.  If rewriting is not possible, this error is emitted.
+
+## Example
+
+Erroneous code example:
+
+```cds
+type T : {
+    @anno: (sibling)
+    elem: String;
+    sibling: String;
+};
+type TString : T:elem; // ❌ there is no `sibling`
+```
+
+The annotating `@anno` would be propagated to `TString`.  However, because its
+path refers to an element that is not reachable at `TString`, the path can't
+be rewritten and compilation fails.
+
+## How to Fix
+
+Explicitly override the annotation.  Either remove it by setting its value to
+`null` or by using another value.
+
+```cds
+// (1) direct annotation
+@anno: null
+type TString : T:elem;
+
+// (2) annotate statement
+type TString : T:elem;
+annotate TString with @(anno: null);
+```
+
+Variant (1) may not always be applicable, e.g. if annotations in a structured
+type would need to be overridden.  In those cases, use variant (2) and assign
+annotations via the `annotate` statement.

package/share/messages/message-explanations.json

@@ -2,6 +2,7 @@
   "$comment": "This is an auto-generated file! Do not edit this file directly!",
   "messages": [
     "anno-duplicate-unrelated-layer",
+    "anno-missing-rewrite",
     "check-proper-type-of",
     "def-duplicate-autoexposed",
     "def-missing-type",

package/bin/.eslintrc.json

@@ -1,17 +0,0 @@
-{
-  "extends": ["../.eslintrc-ydkjsi.json"],
-  "rules": {
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "template-curly-spacing": ["error", "never"],
-    "max-len": "off",
-    "no-console": "off",
-    "no-process-exit": "off",
-    "camelcase": "off",
-    "radix": "off",
-    "no-shadow": "warn",
-    "global-require": "off"
-  }
-}

package/lib/api/.eslintrc.json

@@ -1,37 +0,0 @@
-{
-  "root": true,
-  "env": {
-    "es2022": true,
-    "node": true
-  },
-  // we actually do not extend airbnb-base, as it weakens some eslint:recommended rules
-  "extends": ["plugin:jsdoc/recommended", "../../.eslintrc-ydkjsi.json"],
-  "parserOptions": {
-    "ecmaVersion": 2022,
-    "sourceType": "script"
-  },
-  "plugins":  [
-    "jsdoc"
-  ],
-  "rules": {
-    // Does not recognize TS types
-    "jsdoc/no-undefined-types": "off",
-    // eslint-plugin-jsdoc warning
-    "jsdoc/require-property": 0,
-    "jsdoc/tag-lines": "off",
-    // =airbnb, >eslint:
-    "max-len": [ "error", {
-      "code": 100,
-      "tabWidth": 2,
-      "ignoreComments": true,
-      "ignoreRegExpLiterals": true,
-      "ignoreStrings": true,
-      "ignoreTemplateLiterals": true
-    }]
-  },
-  "settings": {
-    "jsdoc": {
-      "mode": "typescript"
-    }
-  }
-}

package/lib/checks/.eslintrc.json

@@ -1,31 +0,0 @@
-{
-  // we actually do not extend airbnb-base, as it weakens some eslint:recommended rules
-  "extends": ["plugin:jsdoc/recommended", "../../.eslintrc-ydkjsi.json"],
-  "plugins":  [
-    "jsdoc"
-  ],
-  "rules": {
-    "cds-compiler/message-no-quotes": "off",
-    "quotes": ["error", "single", {
-      "avoidEscape": true,
-      "allowTemplateLiterals": true
-    }],
-    "jsdoc/no-undefined-types": 0,
-    // eslint-plugin-jsdoc warning
-    "jsdoc/require-property": 0,
-    // most of the main functions have the normal forEachArtifact/Member signature anyway
-    "jsdoc/require-param-description": 0,
-    // there seem to be false positives
-    "jsdoc/require-returns-check": 0,
-    "jsdoc/tag-lines": 0,
-    // =airbnb, >eslint:
-    "max-len": [ "error", {
-      "code": 110,
-      "tabWidth": 2,
-      "ignoreComments": true,
-      "ignoreRegExpLiterals": true,
-      "ignoreStrings": true,
-      "ignoreTemplateLiterals": true
-    }]
-  }
-}

package/lib/compiler/.eslintrc.json

@@ -1,8 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json",
-  "rules": {
-    "cds-compiler/message-no-quotes": "warn",
-    "cds-compiler/space-in-func-call": "warn"
-  }
-}

package/lib/edm/.eslintrc.json

@@ -1,46 +0,0 @@
-{
-  "root": true,
-  //"plugins": ["sonarjs", "jsdoc"],
-  //"extends": ["plugin:jsdoc/recommended", "../../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "plugins": ["sonarjs"],
-  "extends": ["../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "rules": {
-    "cds-compiler/message-no-quotes": "off",
-    "cds-compiler/message-template-string": "off",
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "template-curly-spacing":["error", "never"],
-    "complexity": ["warn", 50],
-    "max-len": "off",
-    // there seem to be false positives
-    "jsdoc/require-returns-check": "off",
-    // Don't enforce stupid descriptions
-    "jsdoc/require-param-description": "off",
-    "jsdoc/require-returns-description": "off",
-    // Sometimes if-else's are more specific
-    "sonarjs/prefer-single-boolean-return": "off",
-    // Very whiny and nitpicky
-    "sonarjs/cognitive-complexity": "off",
-    "sonarjs/no-duplicate-string": "off",
-    // Does not recognize TS types
-    "jsdoc/no-undefined-types": "off",
-    "jsdoc/tag-lines": "off",
-    "no-nested-ternary": "off",
-    "sonarjs/no-nested-template-literals": "off"
-  },
-  "parserOptions": {
-    "ecmaVersion": 2022,
-    "sourceType": "script"
-  },
-  "env": {
-    "es2022": true,
-    "node": true
-  },
-  "settings": {
-    "jsdoc": {
-      "mode": "typescript"
-    }
-  }
-}

package/lib/inspect/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json"
-}

package/lib/json/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json"
-}

package/lib/language/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json"
-}

package/lib/model/.eslintrc.json

@@ -1,13 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json",
-  "rules": {
-    "max-len": [ "error", {
-      "code": 180, // TODO: Remove
-      "tabWidth": 2,
-      "ignoreRegExpLiterals": false,
-      "ignoreStrings": false,
-      "ignoreTemplateLiterals": true
-    }]
-  }
-}

package/lib/modelCompare/utils/.eslintrc.json

@@ -1,22 +0,0 @@
-{
-  "plugins": ["sonarjs"],
-  "extends": ["../../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "rules": {
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "sonarjs/cognitive-complexity": "off",
-    "sonarjs/no-duplicate-string": ["off"],
-    "sonarjs/no-nested-template-literals": "off",
-    "template-curly-spacing":["error", "never"],
-    "class-methods-use-this": "off",
-    // Who cares - just very whiny and in the way
-    "complexity": "off",
-    "max-len": "off",
-    "no-shadow": "warn"
-  },
-  "env": {
-    "es2022": true
-  }
-}

package/lib/render/.eslintrc.json

@@ -1,22 +0,0 @@
-{
-  "plugins": ["sonarjs"],
-  "extends": ["../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "rules": {
-    "cds-compiler/message-no-quotes": "off",
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "sonarjs/cognitive-complexity": "off",
-    "sonarjs/no-duplicate-string": ["off"],
-    "sonarjs/no-nested-template-literals": "off",
-    "template-curly-spacing":["error", "never"],
-    "class-methods-use-this": "off",
-    "complexity": "off",
-    "max-len": "off",
-    "no-shadow": "warn"
-  },
-  "env": {
-    "es2022": true
-  }
-}

package/lib/transform/.eslintrc.json

@@ -1,13 +0,0 @@
-{
-  "rules": {
-    "no-shadow": "off"
-  },
-  "overrides": [
-    {
-      "files": [
-        "addTenantFields.js"
-      ],
-      "extends": "../../.eslintrc-ydkjsi.json"
-    }
-  ]
-}

package/lib/transform/db/.eslintrc.json

@@ -1,41 +0,0 @@
-{
-  "root": true,
-  "plugins": ["sonarjs", "jsdoc"],
-  "extends": ["plugin:jsdoc/recommended", "../../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "rules": {
-    "cds-compiler/message-no-quotes": "off",
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "template-curly-spacing":["error", "never"],
-    "complexity": ["warn", 40],
-    "max-len": "off",
-    // there seem to be false positives
-    "jsdoc/require-returns-check": "off",
-    // Don't enforce stupid descriptions
-    "jsdoc/require-param-description": "off",
-    "jsdoc/require-returns-description": "off",
-    // Sometimes if-else's are more specific
-    "sonarjs/prefer-single-boolean-return": "off",
-    // Very whiny and nitpicky
-    "sonarjs/cognitive-complexity": "off",
-    "sonarjs/no-duplicate-string": "off",
-    // Does not recognize TS types
-    "jsdoc/no-undefined-types": "off",
-    "jsdoc/tag-lines": "off"
-  },
-  "parserOptions": {
-    "ecmaVersion": 2022,
-    "sourceType": "script"
-  },
-  "env": {
-    "es2022": true,
-    "node": true
-  },
-  "settings": {
-    "jsdoc": {
-      "mode": "typescript"
-    }
-  }
-}

package/lib/transform/draft/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "root": true,
-  "extends": ["../db/.eslintrc.json"]
-}

package/lib/transform/effective/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "root": true,
-  "extends": ["../db/.eslintrc.json"]
-}

package/lib/transform/universalCsn/.eslintrc.json

@@ -1,37 +0,0 @@
-{
-  "root": true,
-  "plugins": ["sonarjs", "jsdoc"],
-  "extends": ["plugin:jsdoc/recommended", "../../../.eslintrc-ydkjsi.json", "plugin:sonarjs/recommended"],
-  "rules": {
-    "prefer-const": "error",
-    "quotes": ["error", "single", "avoid-escape"],
-    "prefer-template": "error",
-    "no-trailing-spaces": "error",
-    "template-curly-spacing":["error", "never"],
-    "complexity": ["warn", 30],
-    "max-len": "off",
-    // Don't enforce stupid descriptions
-    "jsdoc/require-param-description": "off",
-    "jsdoc/require-returns-description": "off",
-    // Very whiny and nitpicky
-    "sonarjs/cognitive-complexity": "off",
-    // Does not recognize TS types
-    "jsdoc/no-undefined-types": "off",
-    "jsdoc/tag-lines": "off",
-    // Just annoying as hell
-    "sonarjs/no-duplicate-string": "off"
-  },
-  "parserOptions": {
-    "ecmaVersion": 2022,
-    "sourceType": "script"
-  },
-  "env": {
-    "es2022": true,
-    "node": true
-  },
-  "settings": {
-    "jsdoc": {
-      "mode": "typescript"
-    }
-  }
-}

package/lib/utils/.eslintrc.json

@@ -1,7 +0,0 @@
-{
-  "root": true,
-  "extends": "../../.eslintrc-ydkjsi.json",
-  "rules": {
-    "prefer-const": "warn"
-  }
-}