@sap/cds-compiler 4.7.6 → 4.9.0

package/lib/transform/translateAssocsToJoins.js

@@ -29,10 +29,10 @@ function translateAssocsToJoinsCSN(csn, options){
   // Use the effective elements list as columns
   forEachDefinition(model, art => {
     if (art.$queries) {
-      for (let query of art.$queries) {
+      for (const query of art.$queries) {
         query.columns = Object.values(query.elements);
         // TODO: Remove viaAll
-        for (let elemName in query.elements) {
+        for (const elemName in query.elements) {
           const elem = query.elements[elemName];
           if (elem.$inferred === '*')
             delete elem.$inferred;
@@ -172,8 +172,8 @@ function translateAssocsToJoins(model, inputOptions = {})
   // Transform each FROM table path into a join tree and attach the tree to the path object
   function createInnerJoins(fromPathNode, env)
   {
-    let fqat = env.lead.$tableAliases[fromPathNode.name.id].$fqat;
-    let joinTree = createJoinTree(env, undefined, fqat, 'inner', '$fqat', undefined);
+    const fqat = env.lead.$tableAliases[fromPathNode.name.id].$fqat;
+    const joinTree = createJoinTree(env, undefined, fqat, 'inner', '$fqat', undefined);
 
     replaceTableAliasInPlace( fromPathNode, joinTree);
   }
@@ -185,11 +185,11 @@ function translateAssocsToJoins(model, inputOptions = {})
     {
       env.lead = query;
       let joinTree = query.from;
-      for(let tan in query.$tableAliases)
+      for(const tan in query.$tableAliases)
       {
         if(query.$tableAliases[tan].kind !== '$self') // don't drive into $projection/$self tableAlias (yet)
         {
-          let ta = query.$tableAliases[tan];
+          const ta = query.$tableAliases[tan];
           joinTree = createJoinTree(env, joinTree, ta.$qat, 'left', '$qat', ta.$QA);
         }
       }
@@ -207,9 +207,9 @@ function translateAssocsToJoins(model, inputOptions = {})
   */
   function createQAForFromClauseSubQuery(query, env)
   {
-    for (let taName in query.$tableAliases) {
+    for (const taName in query.$tableAliases) {
       if (query.$tableAliases[taName].kind !== '$self') {
-        let ta = query.$tableAliases[taName];
+        const ta = query.$tableAliases[taName];
         if(!ta.$QA) {
           let alias = taName;
           if (ta.name.$inferred === '$internal') {
@@ -306,8 +306,8 @@ function translateAssocsToJoins(model, inputOptions = {})
     if(env.location === 'onCondFrom')
     {
       if(checkPathDictionary(pathNode, env)) {
-        let [ tableAlias, tail ] = constructTableAliasAndTailPath(pathNode.path);
-        let pathStr = translateONCondPath(tail).map(ps => ps.id).join(pathDelimiter);
+        const [ tableAlias, tail ] = constructTableAliasAndTailPath(pathNode.path);
+        const pathStr = translateONCondPath(tail).map(ps => ps.id).join(pathDelimiter);
         replaceNodeContent(pathNode,
           constructPathNode([ tableAlias, { id: pathStr, _artifact: pathNode._artifact } ]));
       }
@@ -329,11 +329,11 @@ function translateAssocsToJoins(model, inputOptions = {})
         tail = pathNode.path;
       // if tail.length > 1, search bottom up for QA
       // default to rootQA, _parent.$QA has precedence
-      let [QA, ps] = rightMostQA(tail, head._navigation._parent.$QA || head._navigation.$QA);
+      const [QA, ps] = rightMostQA(tail, head._navigation._parent.$QA || head._navigation.$QA);
       if(!QA) {
         error(null, pathNode.$location,
           { name: pathName(pathNode.path) },
-          'Please debug me: No QA found for generic path rewriting in $(NAME)')
+          'Debug me: No QA found for generic path rewriting in $(NAME)')
         return;
       }
       // if the found QA is the mixin QA and if the path length is one,
@@ -360,7 +360,7 @@ function translateAssocsToJoins(model, inputOptions = {})
             // const revealInternalProperties = require('../model/revealInternalProperties.js');
             // console.log('++++++++ Path tail: ', revealInternalProperties(tail[tail.length-1]._artifact));
             // console.log('******** Flat FKs\n', tail[i]._artifact.$flatSrcFKs.map(f => revealInternalProperties(f._artifact)));
-            throw new CompilerAssertion('Please debug me: No flat FK found for FK rewriting');
+            throw new CompilerAssertion('Debug me: No flat FK found for FK rewriting');
           }
           // replace tail path with flattened foreign key including prefix
           tail.splice(i, tail.length, fk);
@@ -431,7 +431,7 @@ function translateAssocsToJoins(model, inputOptions = {})
   */
   function createJoinTree(env, joinTree, parentQat, joinType, qatAttribName, lastAssocQA)
   {
-    for(let childQatId in parentQat)
+    for(const childQatId in parentQat)
     {
       const childQat = parentQat[childQatId];
 
@@ -454,10 +454,10 @@ function translateAssocsToJoins(model, inputOptions = {})
             if(childQat._filter)
             {
               // Filter conditions are unique for each JOIN, they don't need to be copied
-              let filter = childQat._filter;
+              const filter = childQat._filter;
               rewritePathsInFilterExpression(filter, function(pathNode) {
                 return [ /* tableAlias=> */ constructTableAliasPathStep(childQat.$QA),
-                        /* filterPath=> */ pathNode.path ]; // eslint-disable-line indent-legacy
+                        /* filterPath=> */ pathNode.path ];
               }, env);
 
               if(!env.lead.$startFilters)
@@ -486,28 +486,28 @@ function translateAssocsToJoins(model, inputOptions = {})
 
   function createJoinQA(joinType, lhs, rhs, assocQAT, assocSourceQA, env)
   {
-    let node = { op: { val: 'join' }, join: { val: joinType }, args: [ lhs, rhs ] };
+    const node = { op: { val: 'join' }, join: { val: joinType }, args: [ lhs, rhs ] };
     const assoc = assocQAT._origin;
     if(isBetaEnabled(options, 'mapAssocToJoinCardinality')) {
       node.cardinality = mapAssocToJoinCardinality(assoc);
     }
     // 'path steps' for the src/tgt table alias
-    let srcTableAlias = constructTableAliasPathStep(assocSourceQA);
-    let tgtTableAlias = constructTableAliasPathStep(assocQAT.$QA);
+    const srcTableAlias = constructTableAliasPathStep(assocSourceQA);
+    const tgtTableAlias = constructTableAliasPathStep(assocQAT.$QA);
 
     node.on = createOnCondition(assoc, srcTableAlias, tgtTableAlias, options.tenantDiscriminator);
 
     if(assocQAT._filter)
     {
       // Filter conditions are unique for each JOIN, they don't need to be copied
-      let filter = assocQAT._filter;
+      const filter = assocQAT._filter;
       rewritePathsInFilterExpression(filter, function(pathNode) {
         return [ tgtTableAlias, pathNode.path ];
       }, env);
 
       // If toplevel ON cond op is AND add filter condition to the args array,
       // create a new toplevel AND op otherwise
-      let onCond = (Array.isArray(node.on) ? node.on[0] : node.on);
+      const onCond = (Array.isArray(node.on) ? node.on[0] : node.on);
 
       if(onCond.op.val === 'and')
         onCond.args.push(parenthesise(filter));
@@ -567,7 +567,7 @@ function translateAssocsToJoins(model, inputOptions = {})
     // produce the ON condition for a given association
     function createOnCondition(assoc, srcAlias, tgtAlias, compareTenants)
     {
-      let prefixes = [ assoc.name.id ];
+      const prefixes = [ assoc.name.id ];
       /* This is no art and can be removed once ON cond for published
           and renamed backlink assocs are publicly available. Example:
 
@@ -600,12 +600,12 @@ function translateAssocsToJoins(model, inputOptions = {})
           Put all src/tgt path siblings into the EQ term and create the proper path objects
           with the src/tgt table alias path steps in front.
         */
-        let args = compareTenants ? [ addTenantComparison(assoc) ] : [];
+        const args = compareTenants && addTenantComparison(assoc) || [];
         for(let i = 0; i < assoc.$flatSrcFKs.length; i++)
         {
           args.push({op: {val: '=' },
             args: [ constructPathNode( [ srcAlias, prefixFK(assoc.$elementPrefix, assoc.$flatSrcFKs[i]) ] ),
-                    constructPathNode( [ tgtAlias, assoc.$flatTgtFKs[i] ] ) ] });   // eslint-disable-line indent-legacy
+                    constructPathNode( [ tgtAlias, assoc.$flatTgtFKs[i] ] ) ] });
         }
         return parenthesise((args.length > 1 ? { op: { val: 'and' }, args: [ ...args.map(parenthesise) ] } : args[0] ));
       }
@@ -678,7 +678,7 @@ function translateAssocsToJoins(model, inputOptions = {})
         args[1].path.push({ id: 'tenant' }); // no need for _artifact
         const comparison = { op: {val: '=' }, args };
         if (!cond)              // for managed assoc
-          return comparison;
+          return [ comparison ];
         return { op: { val: 'and' }, args: [ comparison, parenthesise(cond) ] };
       }
 
@@ -761,7 +761,7 @@ function translateAssocsToJoins(model, inputOptions = {})
         // If this is an ordinary expression, clone it and mangle its arguments
         // this will substitute multiple backlink conditions ($self = ... AND $self = ...AND ...)
         if(expr.op) {
-          let x = clone(expr);
+          const x = clone(expr);
           if(expr.args)
             x.args = expr.args.map(cloneOnCondition);
           return x;
@@ -845,7 +845,7 @@ function translateAssocsToJoins(model, inputOptions = {})
             $projection must be removed from $projection.yid (get's aliased with the mixinAssocQAT.$QA)
             */
             if(env.assocStack.length < 2) {
-              let value = env.lead.elements[path[0].id].value;
+              const value = env.lead.elements[path[0].id].value;
               /*
                 If the value is an expression in the select block, return the unmodified
                 expression. rewriteGenericPaths will check and rewrite these paths later
@@ -957,7 +957,7 @@ function translateAssocsToJoins(model, inputOptions = {})
             if(head.id === env.assocStack.id()) {
               // source side from view point of view (target side from forward point of view)
               path = tail; // pop assoc step
-              let elt = env.lead._combined[path[0].id];
+              const elt = env.lead._combined[path[0].id];
 
               if(elt) {
                 if(Array.isArray(elt)) {
@@ -1008,7 +1008,7 @@ function translateAssocsToJoins(model, inputOptions = {})
             path = translateONCondPath(path, !hasDollarSelfPrefix ? assoc.$elementPrefix : undefined);
           }
         }
-        let pathStr = path.map(ps => ps.id).join(pathDelimiter);
+        const pathStr = path.map(ps => ps.id).join(pathDelimiter);
         return constructPathNode([ tableAlias, { id: pathStr, _artifact: pathNode._artifact } ]);
       }
 
@@ -1209,11 +1209,11 @@ function translateAssocsToJoins(model, inputOptions = {})
    */
   function constructTableAliasAndTailPath(path, navigation=undefined)
   {
-    let [head, ...tail] = path;
+    const [head, ...tail] = path;
     if(navigation === undefined)
       navigation = head._navigation;
 
-    let QA = navigation.$QA || navigation._parent.$QA;
+    const QA = navigation.$QA || navigation._parent.$QA;
 
     // First path step is table alias, use and pop it off
     if(navigation.$QA && tail.length > 0)
@@ -1251,7 +1251,7 @@ function translateAssocsToJoins(model, inputOptions = {})
   {
     if(!pathStr)
       pathStr = '';
-    let assocStep = path.find(ps => {
+    const assocStep = path.find(ps => {
       if(pathStr.length > 0)
         pathStr += pathDelimiter;
       pathStr += ps.id;
@@ -1303,7 +1303,7 @@ function translateAssocsToJoins(model, inputOptions = {})
         pathStr += fk.name.id;
       }
 
-      let tail = path.slice(path.indexOf(fkPs)+1);
+      const tail = path.slice(path.indexOf(fkPs)+1);
       // If foreign key is an association itself, apply substituteFKAliasForPath on tail
       if(fk && fk.targetElement._artifact.target && tail.length)
         return substituteFKAliasForPath(fk.targetElement, tail, pathStr);
@@ -1377,7 +1377,7 @@ function translateAssocsToJoins(model, inputOptions = {})
       if(ps._artifact && ps._artifact.target)
       {
         // if this is not the last path step, complain
-        let la1 = pathDict.path[pathDict.path.indexOf(ps)+1];
+        const la1 = pathDict.path[pathDict.path.indexOf(ps)+1];
         if(la1) {
           if(ps._artifact.on)
           {
@@ -1438,7 +1438,7 @@ function translateAssocsToJoins(model, inputOptions = {})
   */
   function mergePathIntoQAT(pathDict, env)
   {
-    let path = pathDict.path;
+    const path = pathDict.path;
 
     if(path.length === 0)
       return;
@@ -1505,7 +1505,7 @@ function translateAssocsToJoins(model, inputOptions = {})
     if(qatParent == undefined)
       throw new CompilerAssertion('table alias/qathost not found for path: ' +  pathAsStr(path));
 
-    let rootQat = qatParent;
+    const rootQat = qatParent;
 
     // Create the very first QAT if it doesn't exist
     // (filter condition for table alias prefix not allowed)
@@ -1526,7 +1526,7 @@ function translateAssocsToJoins(model, inputOptions = {})
       }
       if(pathStep.args) {
         // sort named arguments
-        let sortedNamedArgs = Object.create(null);
+        const sortedNamedArgs = Object.create(null);
         Object.keys(pathStep.args).sort().forEach(p => {
           sortedNamedArgs[p] = compactExpr(pathStep.args[p]);
         })
@@ -1687,10 +1687,10 @@ function translateAssocsToJoins(model, inputOptions = {})
   // eslint-disable-next-line no-unused-vars
   function printPath(pathDict, env)
   {
-    let alias = (pathDict.name && pathDict.name.id) || '<undefined>'
-    let path = pathDict.path;
-    let s = pathAsStr(path, '"');
-    let me = env.lead && (env.lead.name.id || env.lead.op);
+    const alias = (pathDict.name && pathDict.name.id) || '<undefined>'
+    const path = pathDict.path;
+    const s = pathAsStr(path, '"');
+    const me = env.lead && (env.lead.name.id || env.lead.op);
     // eslint-disable-next-line no-console
     console.log(me + ': ' + env.location + ': ' + s + ' alias: ' + alias);
   }
@@ -1708,9 +1708,9 @@ function translateAssocsToJoins(model, inputOptions = {})
     else
       newObj = {};
 
-    let props =  Object.getOwnPropertyNames(obj);  // clone own properties only, not inherited ones
-    for (let p of props) {
-      let pd = Object.getOwnPropertyDescriptor(obj, p);
+    const props =  Object.getOwnPropertyNames(obj);  // clone own properties only, not inherited ones
+    for (const p of props) {
+      const pd = Object.getOwnPropertyDescriptor(obj, p);
       if (pd && pd.enumerable === false)
       {
         pd.value = obj[p]; // don't copy references
@@ -1740,10 +1740,10 @@ function translateAssocsToJoins(model, inputOptions = {})
  */
 function constructPathNode(pathSteps, alias, rewritten=true)
 {
-  let node = {
+  const node = {
     $rewritten: rewritten,
     path : pathSteps.map(p => {
-      let o = {};
+      const o = {};
       Object.keys(p).forEach(k => {
         if(!(rewritten && ['_'].includes(k[0])))
           o[k] = p[k];
@@ -1784,7 +1784,7 @@ function walkQuery(query, env)
     env.location = 'select';
     if(env.walkover[env.location])
     {
-      for(let alias in query.elements)
+      for(const alias in query.elements)
         walk(query.elements[alias].value, env);
 
       env.location = 'Where';
@@ -1809,7 +1809,7 @@ function walkQuery(query, env)
 
   function walkFrom(fromBlock)
   {
-    let aliases = [];
+    const aliases = [];
     env.position = fromBlock;
     if(fromBlock)
     {

package/lib/transform/universalCsn/coreComputed.js

@@ -5,6 +5,7 @@ const {
 } = require('../../model/csnUtils');
 const { setAnnotationIfNotDefined } = require('./utils');
 const { CompilerAssertion } = require('../../base/error');
+const { isMagicVariable } = require('../../base/builtins');
 
 /**
  * Set @Core.Computed on the elements of views (and projections) as well
@@ -157,7 +158,7 @@ function setCoreComputedOnViewsAndCalculatedElements( csn, csnUtils ) {
         (
           column.xpr || column.list || column.func || column.val !== undefined || column['#'] !== undefined || column.param ||
           column.SELECT || column.SET ||
-          column.ref && [ '$at', '$valid', '$now', '$user', '$tenant', '$session', '$parameters' ].includes(column.ref[0])
+          column.ref && (isMagicVariable(column.ref[0]) || column.ref[0] === '$parameters')
         );
     }
 

package/lib/transform/universalCsn/universalCsnEnricher.js

@@ -8,8 +8,8 @@ const {
   getUtils,
   applyTransformations,
   implicitAs,
-  isBuiltinType,
 } = require('../../model/csnUtils');
+const { isBuiltinType, propagationRules } = require('../../base/builtins');
 const {
   forEachValue, forEach,
 } = require('../../utils/objectUtils');
@@ -29,24 +29,10 @@ module.exports = (csn, options) => {
   } = csnUtils;
     // Properties on definition level that we treat specially.
   const definitionPropagationRules = {
-    '@cds.autoexpose': onlyViaArtifact,
-    '@cds.external': skip,
-    '@fiori.draft.enabled': onlyViaArtifact,
+    __proto__: null,
     '@': nullStopsPropagation,
     // Example: `type E : F;` does not have `elements`, but they are required for e.g. OData.
     elements: onlyTypeDef,
-    '@cds.persistence.exists': skip,
-    '@cds.persistence.table': skip,
-    '@cds.persistence.calcview': skip,
-    '@cds.persistence.udf': skip,
-    '@cds.persistence.skip': notWithPersistenceTable,
-    '@sql.append': skip,
-    '@sql.prepend': skip,
-    '@sql.replace': skip,
-    '@Analytics.hidden': skip,
-    '@Analytics.visible': skip,
-    '@cds.autoexposed': skip,
-    '@cds.redirection.target': skip,
     type: always,
     doc: nullStopsPropagation,
     length: always,
@@ -65,6 +51,16 @@ module.exports = (csn, options) => {
     keys: always,
   };
 
+  const ruleToFunction = {
+    __proto__: null,
+    never: skip,
+    onlyViaArtifact,
+    notWithPersistenceTable,
+  };
+
+  for (const rule in propagationRules)
+    definitionPropagationRules[rule] = ruleToFunction[propagationRules[rule]];
+
   // Properties on member level that we treat specially
   const memberPropagationRules = {
     key: skip,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cds-compiler",
-  "version": "4.7.6",
+  "version": "4.9.0",
   "description": "CDS (Core Data Services) compiler and backends",
   "homepage": "https://cap.cloud.sap/",
   "author": "SAP SE (https://www.sap.com)",
@@ -28,7 +28,7 @@
     "gentest3": "cross-env MAKEREFS=${MAKEREFS:-'true'} mocha --reporter-option maxDiffSize=0 test3/testRefFiles.js",
     "coverage": "cross-env nyc mocha --reporter-option maxDiffSize=0 test/ test3/testRefFiles.js && nyc report --reporter=lcov",
     "coverage:piper": "cross-env nyc mocha --reporter test/TestMochaReporter.js --reporter-options mochaFile=./coverage/TEST-results.xml --reporter-option maxDiffSize=0 --timeout 10000 test/ test3/ && nyc report --reporter=cobertura && nyc report --reporter=lcov",
-    "lint": "eslint bin/ benchmark/ lib/ test/ test3/ scripts/ types/ && node scripts/linter/lintGrammar.js && node scripts/linter/lintTests.js test3/ && node scripts/linter/lintMessages.js && node scripts/linter/lintMessageIdCoverage.js lib/ && markdownlint README.md CHANGELOG.md doc/ internalDoc/ && cd share/messages && markdownlint .",
+    "lint": "eslint bin/ benchmark/ lib/ test/ test3/ scripts/ types/ && node scripts/linter/lintGrammar.js && node scripts/linter/lintTests.js test3/ && node scripts/linter/lintMessages.js && node scripts/linter/lintMessageIdCoverage.js lib/ && markdownlint README.md CHANGELOG.md doc/ internalDoc/ && cd share/messages && markdownlint . && cd ../../ && node scripts/check-changelog.js",
     "tslint": "tsc --pretty -p .",
     "updateVocs": "node scripts/odataAnnotations/generateDictMain.js && npm run generateAllRefs",
     "updateTocs": "node scripts/update-toc.js",

package/share/messages/README.md

@@ -41,8 +41,12 @@ Usually mentions the severity.
 
 ## Example
 
+Erroneous code example:
+
+```
 Code which also lead to the current message,
 with an explanation why it is problematic.
+```
 
 ## How to Fix
 

package/share/messages/anno-duplicate-unrelated-layer.md

@@ -23,7 +23,7 @@ annotate FooBar with @Anno: 'Foo';
 using from './Base';
 annotate FooBar with @Anno: 'Bar';
 
-// (4) All.cds: Combine all files
+// (4) All.cds: Combine all files ❌
 using from './FooAnnotate';
 using from './BarAnnotate';
 ```

package/share/messages/anno-missing-rewrite.md

@@ -0,0 +1,45 @@
+# anno-missing-rewrite
+
+A propagated annotation containing expressions can't be rewritten and would
+end up with invalid paths.
+
+While propagating annotations containing expressions such as `@anno: (path)`,
+the compiler ensures that the path remains valid.  If necessary, the paths
+have to be rewritten, e.g. when being propagated to projections that rename
+their source's elements.  If rewriting is not possible, this error is emitted.
+
+## Example
+
+Erroneous code example:
+
+```cds
+type T : {
+    @anno: (sibling)
+    elem: String;
+    sibling: String;
+};
+type TString : T:elem; // ❌ there is no `sibling`
+```
+
+The annotating `@anno` would be propagated to `TString`.  However, because its
+path refers to an element that is not reachable at `TString`, the path can't
+be rewritten and compilation fails.
+
+## How to Fix
+
+Explicitly override the annotation.  Either remove it by setting its value to
+`null` or by using another value.
+
+```cds
+// (1) direct annotation
+@anno: null
+type TString : T:elem;
+
+// (2) annotate statement
+type TString : T:elem;
+annotate TString with @(anno: null);
+```
+
+Variant (1) may not always be applicable, e.g. if annotations in a structured
+type would need to be overridden.  In those cases, use variant (2) and assign
+annotations via the `annotate` statement.

package/share/messages/check-proper-type-of.md

@@ -18,7 +18,7 @@ view ViewFoo as select from Foo {
   1+1 as calculatedField @(anno)
 };
 entity Bar {
-  // `e` has no proper type but has the annotation `@anno`.
+  // ❌ `e` has no proper type but has the annotation `@anno`.
   e : ViewFoo:calculatedField;
 };
 ```

package/share/messages/def-duplicate-autoexposed.md

@@ -31,7 +31,7 @@ entity ns.Base {
   to_second : Composition of many ns.second.Foo;
 }
 service ns.MyService {
-  // (4)
+  // (4) ❌
   entity BaseView as projection on ns.Base;
 };
 ```

package/share/messages/extend-repeated-intralayer.md

@@ -9,30 +9,17 @@ They form a cyclic connection through their dependencies
 
 ## Example
 
-Erroneous code example with a single CDL file:
-
-```cds
-entity FooBar { }
-
-extend FooBar { foo : Integer; }
-extend FooBar { bar : Integer; }
-```
-
-Due to multiple extensions in the example above, the order of `foo` and `bar`
-inside `FooBar` may not be stable.  You therefore can’t depend on it.
-
-It's also possible to trigger this warning with multiple files.
-Look at the following example:
+Erroneous code example with multiple CDL files:
 
 ```cds
 // (1) Definition.cds
 using from './Extension.cds';
 entity FooBar { };
-extend FooBar { foo: Integer; };
+extend FooBar { foo: Integer; }; // ❌
 
 // (2) Extension.cds
 using from './Definition.cds';
-extend FooBar { bar: Integer; }
+extend FooBar { bar: Integer; }; // ❌
 ```
 
 Here we have a cyclic dependency between (1) and (2).  Together they form one

package/share/messages/extend-unrelated-layer.md

@@ -23,7 +23,7 @@ extend FooBar { foo : Integer; }
 using from './Base';
 extend FooBar { bar : Integer; }
 
-// (4) All.cds: Combine all files
+// (4) ❌ All.cds: Combine all files
 using from './FooExtend';
 using from './BarExtend';
 ```

package/share/messages/message-explanations.json

@@ -2,6 +2,7 @@
   "$comment": "This is an auto-generated file! Do not edit this file directly!",
   "messages": [
     "anno-duplicate-unrelated-layer",
+    "anno-missing-rewrite",
     "check-proper-type-of",
     "def-duplicate-autoexposed",
     "def-missing-type",
@@ -12,6 +13,7 @@
     "redirected-to-unrelated",
     "rewrite-not-supported",
     "syntax-expecting-unsigned-int",
+    "type-missing-enum-value",
     "wildcard-excluding-one"
   ]
 }

package/share/messages/redirected-to-ambiguous.md

@@ -26,7 +26,7 @@ view View as select from
     Target,
     Target as Duplicate
 {
-    // This redirection can’t be resolved:
+    // ❌ This redirection can’t be resolved:
     Main.toTarget : redirected to View
 };
 ```

package/share/messages/redirected-to-complex.md

@@ -21,7 +21,7 @@ entity Secondary {
 entity CrossJoin as SELECT from Main, Secondary;
 entity RedirectToComplex as projection on Main {
     id,
-    toMain: redirected to CrossJoin,
+    toMain: redirected to CrossJoin, // ❌
 };
 ```
 

package/share/messages/redirected-to-unrelated.md

@@ -21,7 +21,7 @@ entity Secondary {
 }
 entity InvalidRedirect as projection on Main {
     id,
-    // Invalid redirection
+    // ❌ Invalid redirection
     toMain: redirected to Secondary,
 };
 ```

package/share/messages/rewrite-not-supported.md

@@ -29,7 +29,7 @@ entity Secondary {
 
 entity View as select from Base {
   id,
-  primary.secondary // Error: The ON condition isn’t rewritten here
+  primary.secondary // ❌ The ON condition isn’t rewritten here
 };
 ```
 

package/share/messages/syntax-expecting-unsigned-int.md

@@ -17,8 +17,8 @@ Erroneous code example:
 
 <!-- cds-mode: ignore -->
 ```cds
-type LengthIsUnsafe : String(9007199254740992);
-type NotAnInteger : String(42.1);
+type LengthIsUnsafe : String(9007199254740992); // ❌
+type NotAnInteger : String(42.1);               // ❌
 ```
 
 In the erroneous example, the string length for the type `LengthIsUnsafe` is