@sap/cds-compiler 4.1.2 → 4.2.2

package/CHANGELOG.md

@@ -7,11 +7,92 @@
 Note: `beta` fixes, changes and features are usually not listed in this ChangeLog but [here](doc/CHANGELOG_BETA.md).
 The compiler behavior concerning `beta` features can change at any time without notice.
 
+## Version 4.2.2 - 2023-08-31
+
+### Fixed
+
+- to.sql|hdi.migration: Fix bug that caused a migration to be rendered for the HANA CDS types that were removed from the CSN
+
+## Version 4.2.0 - 2023-08-29
+
+### Added
+
+- Compiler:
+  + Option `moduleLookupDirectories: [ 'strings' ]` can be used to specify additional module lookup
+    directories, similar to `node_modules/`.
+  + LIMIT and OFFSET clauses can now contain expressions, including parameter references.
+- to.edm(x):
+  + Detect spec violation `scale` > `precision`.
+- to.sql/for.odata:
+  + With the new option `fewerLocalizedViews: true|false`, an entity/view will not get a localized convenience
+    view, if it only has associations to localized entities/views.  Only if there is actually a localized
+    element (e.g. new localized element or reference to one), will it get a convenience view.
+- to.sql
+  + In a localized scenario, create foreign key constraints for the generated `.texts` entities.
+  + Casting `null` to a structure such as `null as field : StructT` is now supported.  For each leaf element,
+    an additional `null as field_name` column is added.
+
+### Changed
+
+- Compiler:
+  + Selecting fields of structures or associations (without filters) are now candidates for ON-condition
+    rewrites: It is no longer necessary to select the struct/association directly.
+  + Consistently handle the case when type elements are defined to be a `key`:
+    the `key` property is not only preserved with `includes`, but also in other cases.
+    Use option `deprecated.noKeyPropagationWithExpansions` to switch to the v3 behavior.
+  + When including aspects or entities into structured type definitions,
+    do not add actions to the type.
+  + An `annotate` statement in the `extensions` section of a CSN now consistently uses the
+    `elements` property even if the `annotate` is intended to be used for an enum symbol.
+    Before v4.2, the compiler has used the `enum` property in a CSN of flavor `xtended`
+    (`gensrc`) if it was certain that it was to be applied to an enum symbol.
+- to.cdl: If a definition has an `actions` property, an `actions {…}` block is now always rendered,
+  and is not ignored if empty.
+- to.sql:
+  + For SQL dialect "sqlite", `cds.DateTime` is now rendered as `DATETIME_TEXT` instead of `TIMESTAMP_TEXT`.
+  + Casting a literal (except `null`) to a structure now yields a proper error.
+  + `.texts` entities annotated with `@cds.persistence.skip` (without their original entity having that annotation)
+    lead to deployment issues later.  It is now an error.
+
+### Fixed
+
+- Compiler:
+  + Reject invalid reference in the `on` of `join`s already while compiling,
+    not just when calling the (SQL) backend.
+  + Correct the calculation of annotation assignments on the return structure of actions
+    when both `annotate … with {…}` and `annotate … with returns {…}` had been used
+    on the same structure element.  Ensure that it works when non-applied, too.
+  + Do not remove or invent `actions` properties with zero actions or functions in it.
+  + Correct auto-redirection of direct cycle associations: if the source and target of a
+    model association are the same entity, and the main artifact of the service association
+    based on the model association is a suitable auto-redirection target, then use it
+    as new target, independently from the value of `@cds.redirection.target`.
+- to.cdl: Indirectly structured types (`type T: Struct;`) with `includes` (`extend T with T2;`), are now properly rendered.
+- to.sql/hdi/hdbcds:
+  + Views on views with parameters did not have localized convenience views based on
+  other localized views (missing `localized.` prefix in FROM clause)
+  + Run less checks on entities marked with `@cds.persistence.exists`
+  + Correctly render SELECT items where the column name conflicts with a table alias
+- to.sql: Casting expressions to a structured type yields a proper error instead of strange compiler error.
+- to.edm(x):
+  + Don't expand `@mandatory` if element has an annotation with prefix `@Common.FieldControl.`.
+  + Fix a bug when referencing nested many structures, especially referring to a managed association via
+  `$self` comparison.
+  + Improve handling of non-collection annotation values for collection-like vocabulary types.
+  + Don't render `Scale: variable` for `cds.Decimal(scale:0)`.
+- to.sql|hdi.migration:
+  + Fixed a bug that caused rendering of `ALTER` statements to abort early and not render some statements.
+  + CSN output now only contains real `cds` builtins, no early remapping to HANA CDS types or similar.
+- to.sql.migration: Don't drop-create views marked with `@cds.persistence.exists`
+
+### Removed
+
 ## Version 4.1.2 - 2023-07-31
 
 ### Fixed
 
-- to.hdi.migration: Changes in constraints are not rendered as part of the .hdbmigrationtable file, as they belong in other HDI artifacts
+- to.hdi.migration: Changes in constraints are not rendered as part of the .hdbmigrationtable file,
+  as they belong in other HDI artifacts
 
 ## Version 4.1.0 - 2023-07-28
 
@@ -196,6 +277,25 @@ The compiler behavior concerning `beta` features can change at any time without
     are removed, because since - `Entity.myElement` could also be a definition,
     creating ambiguities. This did not work always, anyway.
 
+## Version 3.9.10 - 2023-08-25
+
+### Fixed
+
+- to.edm(x): Error reporting for incorrect handling of "Collection()" has been improved.
+- to.sql/hdi/hdbcds: Views on views with parameters did not have localized convenience views based on
+  other localized views (missing `localized.` prefix in FROM clause)
+- to.sql: Casting expressions to a structured type yields a proper error instead of strange compiler error.
+- to.sql.migration: Don't drop-create views marked with `@cds.persistence.exists` or `@cds.persistence.skip`
+
+## Version 3.9.8 - 2023-08-03
+
+### Fixed
+
+- to.edm(x):
+  + Don't expand `@mandatory` if element has an annotation with prefix `@Common.FieldControl.`.
+  + Fix a bug when referencing nested many structures, especially referring to a managed association via
+  `$self` comparison.
+- to.sql/hdi/hdbcds: Detect navigation into arrayed structures and raise helpful errors instead of running into internal errors.
 
 ## Version 3.9.6 - 2023-07-27
 

package/bin/cdsc.js

@@ -162,7 +162,7 @@ function cdsc_main() {
     validateDirectBackendOption(cmdLine.command, cmdLine.options, cmdLine.args);
 
   // If set through CLI (and not options file), `beta` is a string and needs processing.
-  if (cmdLine.options.beta && typeof cmdLine.options.beta === 'string') {
+  if (typeof cmdLine.options.beta === 'string') {
     const features = cmdLine.options.beta.split(',');
     cmdLine.options.beta = {};
     features.forEach((val) => {
@@ -191,14 +191,17 @@ function cdsc_main() {
     console.error( `Running ‘${cmdLine.command}’ with test-mode shuffle ${cmdLine.options.testMode} …` );
   }
 
-  // If set through CLI (and not options file), `deprecated` is a string and needs processing.
-  if (cmdLine.options.deprecated && typeof cmdLine.options.deprecated === 'string') {
+  // If set through CLI (and not options file), `deprecated` and `moduleLookupDirectories`
+  // are strings and needs processing.
+  if (typeof cmdLine.options.deprecated === 'string') {
     const features = cmdLine.options.deprecated.split(',');
     cmdLine.options.deprecated = {};
     features.forEach((val) => {
       cmdLine.options.deprecated[val] = true;
     });
   }
+  if (typeof cmdLine.options.moduleLookupDirectories === 'string')
+    cmdLine.options.moduleLookupDirectories = cmdLine.options.moduleLookupDirectories.split(',');
 
   parseSeverityOptions(cmdLine);
 

package/doc/CHANGELOG_BETA.md

@@ -73,6 +73,11 @@ Now enabled per default.
 
 ## Version 3.7.0 - 2023-02-22
 
+### Added `annotationExpressions`
+
+This option allows to use expressions as annotation values, e.g.
+`@anno: (1+2)`.
+
 ### Added `calculatedElements`
 
 Allows to define calculated elements in entities and aspects.  When used in views, they

package/doc/CHANGELOG_DEPRECATED.md

@@ -11,6 +11,21 @@ Note: `deprecated` features are listed in this ChangeLog just for information.
 **When the `deprecated` option is set, the `beta` option is ignored,
 and several new features are not available.**
 
+## Version 4.2.0 - 2023-08-29
+
+### Added `noKeyPropagationWithExpansions`
+
+When this option is set, element `id` in types `Orig` and `I` are keys,
+but `id` in `D` is not.
+
+```cds
+type Orig { key id: Integer };
+type I: Orig {};
+type D: Orig;
+```
+
+When this option is not set, element `id` in all three types are keys.
+
 ## Version 4.0.0 - 2023-06-06
 
 ### Added `downgradableErrors`

package/lib/api/main.js

@@ -400,8 +400,7 @@ function sqlMigration( csn, options, beforeImage ) {
       const beforeArtifact = beforeImage.definitions[artifactName];
       const diffArtifact = diff.definitions[artifactName];
       // TODO: exists, abstract? isPersistedOnDb?
-      if (diffArtifact && diffArtifact['@cds.persistence.name'] && !diffArtifact['@cds.persistence.skip'] &&
-        (diffArtifact.query || diffArtifact.projection) &&
+      if (diffArtifact && diffArtifact['@cds.persistence.name'] && csnUtils.isPersistedAsView(diffArtifact) &&
         (diffArtifact[modelCompare.isChanged] === true || // we know it changed because we compared two views
           diffArtifact[modelCompare.isChanged] === undefined)) { // if it was removed in the after, then we don't have the flag
         drops.creates[artifactName] = `DROP VIEW ${ identifierUtils.renderArtifactName(artifactName) };`;
@@ -409,6 +408,7 @@ function sqlMigration( csn, options, beforeImage ) {
       else if (diffArtifact &&
         diffArtifact['@cds.persistence.skip'] !== true &&
         diffArtifact.kind === beforeArtifact.kind && // detect action -> entity
+        csnUtils.isPersistedAsTable(diffArtifact) === csnUtils.isPersistedAsTable(beforeArtifact) && // detect removal of @cds.persistence.exists
         csnUtils.isPersistedAsView(diffArtifact) === csnUtils.isPersistedAsView(beforeArtifact) // detect view -> entity
       ) { // don't render again, but need info for primary key extension
         diffArtifact['@cds.persistence.skip'] = true;

package/lib/api/options.js

@@ -30,6 +30,7 @@ const publicOptionsNewAPI = [
   'pre2134ReferentialConstraintNames',
   'generatedByComment',
   'betterSqliteSessionVariables',
+  'fewerLocalizedViews',
   // ODATA
   'odataOpenapiHints',
   'odataVersion',
@@ -52,7 +53,6 @@ const privateOptions = [
   // Not callable via cdsc, keep private for now until we are sure that we want this
   'filterCsn',
   'lintMode',
-  'fuzzyCsnError',
   'traceFs',
   'traceParser',
   'traceParserAmb',
@@ -66,7 +66,7 @@ const privateOptions = [
   'noRecompile',
   'internalMsg',
   'disableHanaComments',      // in case of issues with hana comment rendering
-  'localizedWithoutCoalesce', // deprecated version of 'localizedLanguageFallback', TODO(v4): Remove option
+  'localizedWithoutCoalesce', // deprecated version of 'localizedLanguageFallback', TODO(v5): Remove option
 ];
 
 const overallOptions = publicOptionsNewAPI.concat(privateOptions);

package/lib/api/validate.js

@@ -130,26 +130,28 @@ const validators = {
   assertIntegrityType: generateStringValidator([ 'DB', 'RT' ]),
 };
 
+// Note: if `validate()` returns true, it means the option is _invalid_!
 const allCombinationValidators = {
-  'valid-structured': {
-    validate: options => options.odataVersion === 'v2' && options.odataFormat === 'structured',
-    severity: 'error',
-    getParameters: () => {},
-    getMessage: () => 'Structured OData is only supported with OData version v4',
-  },
-  'sql-dialect-and-naming': {
-    validate: options => options.sqlDialect && options.sqlMapping && ![ 'hana' ].includes(options.sqlDialect) && [ 'quoted', 'hdbcds' ].includes(options.sqlMapping),
-    severity: 'error',
-    getParameters: options => ({ name: options.sqlDialect, prop: options.sqlMapping }),
-    getMessage: () => 'sqlDialect $(NAME) can\'t be combined with sqlMapping $(PROP)',
-  },
-  'beta-no-test': {
-    validate: options => options.beta && !options.testMode,
-    severity: 'warning',
-    getParameters: () => {},
-    getMessage: () => 'Option "beta" was used. This option should not be used in productive scenarios!',
+  'valid-structured': (options, message) => {
+    if (options.odataVersion === 'v2' && options.odataFormat === 'structured')
+      message.error('api-invalid-combination', null, { '#': 'valid-structured' });
+  },
+  'sql-dialect-and-naming': (options, message) => {
+    if (options.sqlDialect && options.sqlMapping && options.sqlDialect !== 'hana' && [ 'quoted', 'hdbcds' ].includes(options.sqlMapping))
+      message.error('api-invalid-combination', null, { '#': 'sql-dialect-and-naming', name: options.sqlDialect, prop: options.sqlMapping });
+  },
+  'sql-dialect-and-localized': (options, message) => {
+    if (options.fewerLocalizedViews && options.sqlDialect === 'hana')
+      message.error('api-invalid-combination', null, { '#': 'sql-dialect-and-localized', option: 'fewerLocalizedViews', value: 'hana' });
+  },
+  'beta-no-test': (options, message) => {
+    if (options.beta && !options.testMode)
+      message.warning('api-unexpected-combination', null, { '#': 'beta-no-test', option: 'beta' });
   },
 };
+
+const alwaysRunValidators = [ 'beta-no-test', 'sql-dialect-and-localized' ];
+
 /* eslint-disable jsdoc/no-undefined-types */
 /**
  * Run the validations for each option.
@@ -172,11 +174,12 @@ function validate( options, moduleName, customValidators = {}, combinationValida
       const validator = customValidators[optionName] || validators[optionName] || booleanValidator;
 
       if (!validator.validate(optionValue)) {
-        error('invalid-option', null, {
+        error('api-invalid-option', null, {
+          '#': 'value',
           prop: optionName,
           value: validator.expected(optionValue),
           othervalue: validator.found(optionValue),
-        }, 'Expected option $(PROP) to have $(VALUE). Found: $(OTHERVALUE)');
+        });
       }
     });
     throwWithAnyError();
@@ -184,11 +187,8 @@ function validate( options, moduleName, customValidators = {}, combinationValida
 
   const message = makeMessageFunction(null, options, moduleName);
 
-  for (const combinationValidatorName of combinationValidators.concat([ 'beta-no-test' ])) {
-    const combinationValidator = allCombinationValidators[combinationValidatorName];
-    if (combinationValidator.validate(options))
-      message[combinationValidator.severity]('invalid-option-combination', null, combinationValidator.getParameters(options), combinationValidator.getMessage(options));
-  }
+  for (const combinationValidatorName of combinationValidators.concat(alwaysRunValidators))
+    allCombinationValidators[combinationValidatorName](options, message);
 
   message.throwWithAnyError();
 }

package/lib/base/message-registry.js

@@ -63,6 +63,7 @@ const centralMessages = {
   'anno-undefined-element': { severity: 'Warning' },
   'anno-undefined-param':   { severity: 'Warning' },
   'anno-unexpected-ellipsis': { severity: 'Error', configurableFor: 'deprecated' },
+  'anno-unexpected-localized-skip': { severity: 'Error', configurableFor: true },
 
   'name-invalid-dollar-alias': { severity: 'Error', configurableFor: true },
 
@@ -114,6 +115,7 @@ const centralMessages = {
   'type-ambiguous-target': { severity: 'Warning' },
 
   'ref-unexpected-autoexposed': { severity: 'Error' },
+  'ref-unexpected-many-navigation': { severity: 'Error' },
   // Published! Used in @sap/cds-lsp; if renamed, add to oldMessageIds and contact colleagues
   'ref-undefined-art':    { severity: 'Error' },
   'ref-undefined-def':    { severity: 'Error' },
@@ -230,6 +232,8 @@ const centralMessageTexts = {
     std: 'Invalid option $(NAME)!',
     deprecated: 'Option $(NAME) is no longer supported! Use latest API options instead',
     magicVars: 'Option $(PROP) is no longer supported! Use $(OTHERPROP) instead. See <https://cap.cloud.sap/docs/guides/databases#configuring-variables> for details',
+    value: 'Expected option $(PROP) to have $(VALUE). Found: $(OTHERVALUE)',
+    type: 'Expected option $(OPTION) to be of type $(VALUE). Found: $(OTHERVALUE)',
   },
 
   'api-invalid-variable-replacement': {
@@ -239,6 +243,22 @@ const centralMessageTexts = {
     'noDollar': 'Option $(OPTION) does not know $(NAME). Did you forget a leading $(CODE)?'
   },
 
+  'api-invalid-combination': {
+    std: 'Invalid option combination found: $(OPTION) and $(PROP)', // unused
+    'valid-structured': 'Structured OData is only supported with OData version v4',
+    'sql-dialect-and-naming': 'sqlDialect $(NAME) can\'t be combined with sqlMapping $(PROP)',
+    'sql-dialect-and-localized':  'Option $(OPTION) can\'t be combined with SQL dialect $(VALUE) or the to.hdi()/to.hdbcds() backend',
+  },
+  'api-unexpected-combination': {
+    std: 'Unexpected option combination: $(OPTION) and $(PROP)', // unused
+    'beta-no-test':'Option $(OPTION) was used. This option should not be used in productive scenarios!',
+  },
+  'api-invalid-lookup-dir': {
+    std: '',
+    slash: 'Expected directory $(VALUE) in option $(OPTION) to end with $(OTHERVALUE)',
+    relative: 'Expected directory $(VALUE) in option $(OPTION) to not start with $(OTHERVALUE)',
+  },
+
   'anno-duplicate': {
     std: 'Duplicate assignment with $(ANNO)',
     doc: 'Duplicate assignment with a doc comment',
@@ -546,6 +566,9 @@ const centralMessageTexts = {
     std: '$(ART) can\'t be extended because it originates from an include',
     elements: '$(ART) can\'t be extended by elements/enums because it originates from an include',
   },
+  'ref-unexpected-many-navigation': {
+    std: 'Unexpected navigation into arrayed structure',
+  },
   'ref-unexpected-scope': {
     std: 'Unexpected parameter reference',
     calc: 'Calculated elements can\'t use parameter references',
@@ -737,6 +760,12 @@ const centralMessageTexts = {
     elements: 'Duplicate element $(NAME) through multiple includes $(SORTED_ARTS)',
     actions: 'Duplicate action or function $(NAME) through multiple includes $(SORTED_ARTS)',
   },
+  'ref-invalid-element': {
+    std: 'Invalid element reference',
+    $tableAlias: 'Can\'t refer to source elements of table alias $(ID)',
+    mixin: 'Can\'t refer to the query\'s own mixin $(ID)',
+    $self: 'Can\'t refer to the query\'s own elements',
+  },
   'ref-invalid-override': {
     std: 'Overridden element of include must not change element structure', // unused
     'new-not-structured': 'Expected element $(NAME) to be structured, because it overrides the included element from $(ART)',
@@ -848,14 +877,17 @@ const centralMessageTexts = {
     changed: 'Changed element $(ID) is a primary key change and will not work with dialect $(NAME)'
   },
 
+  'type-invalid-cast': {
+    std: 'Invalid cast to $(TYPE)', // unused
+    'to-structure': 'Can\'t cast to a structured type',
+    'from-structure':  'Structured elements can\'t be cast to a different type',
+    'expr-to-structure': 'Can\'t cast an expression to a structured type',
+    'val-to-structure': 'Can\'t cast $(VALUE) to a structured type'
+  },
+
   // -----------------------------------------------------------------------------------
   // Expressions
   // -----------------------------------------------------------------------------------
-  'expr-invalid-operator': 'Comparing $(ID) is only allowed with $(OP)',
-  'expr-missing-comparison': {
-    std: 'Expected a comparison with $(OP) when using $(ID) in an ON-condition',
-  },
-
   'type-invalid-cardinality': {
     std: 'Invalid value $(VALUE) for cardinality', // unused variant
     sourceMax: 'Invalid value $(PROP) for maximum source cardinality, expecting a positive number or $(OTHERPROP)',
@@ -868,6 +900,8 @@ const centralMessageTexts = {
 
   'i18n-different-value': 'Different translation for key $(PROP) of language $(OTHERPROP) in unrelated layers',
 
+  'expr-missing-foreign-key': 'Path step $(ID) of $(ELEMREF) has no valid foreign keys',
+
   // OData version dependent messages
   'odata-spec-violation-array': 'Unexpected array type for OData $(VERSION)',
   'odata-spec-violation-param' : 'Expected parameter to be typed with either scalar or structured type for OData $(VERSION)',
@@ -900,6 +934,7 @@ const centralMessageTexts = {
     incompatible: 'Unexpected EDM Type $(TYPE) for OData $(VERSION)',
     facet: 'Unexpected EDM Type facet $(NAME) of type $(TYPE) for OData $(VERSION)',
     external: 'Referenced type $(TYPE) marked as $(ANNO) can\'t be rendered as $(CODE) in service $(NAME) for OData $(VERSION)',
+    scale: 'Expected scale $(NUMBER) to be less than or equal to precision $(RAWVALUE)'
   },
   'odata-spec-violation-property-name': 'Expected element name to be different from declaring $(META)',
   'odata-spec-violation-namespace': {
@@ -965,7 +1000,7 @@ const centralMessageTexts = {
     // -----------------------------------------------------------------------------------
     'enum': 'Value $(VALUE) is not one out of $(RAWVALUES) for $(ANNO) of type $(TYPE)',
     'std': 'Unexpected value $(VALUE) for $(ANNO) of type $(TYPE)',
-    'struct': 'Unexpected $(STR) value for $(ANNO) of type $(TYPE)',
+    'incompval': 'Unexpected $(STR) value for $(ANNO) of type $(TYPE)',
     'nestedcollection': 'Nested collections are not supported for $(ANNO)',
     'enumincollection': 'Enum inside collection is not supported for $(ANNO)',
     'multexpr': 'EDM JSON code contains more than one dynamic expression: $(RAWVALUES) for $(ANNO)',

package/lib/base/messages.js

@@ -1300,6 +1300,13 @@ function deduplicateMessages( messages ) {
 
 function shortArtName( art ) {
   const name = getArtifactName( art );
+  if (!name) {
+    const loc = art.location ? ` at ${ locationString( art.location ) }` : '';
+    throw new CompilerAssertion(
+      art.path
+        ? `No artifact for ${ art.path.map( i => i.id ).join( '.' )}${ loc }`
+        : `No name found in ${ Object.keys( art ).join( '+' )}${ loc }` );
+  }
   if ([ 'select', 'action', 'alias', 'param' ].every( n => name[n] == null || name[n] === 1 ) &&
       !name.absolute.includes(':'))
     return quote.double( name.element ? `${ name.absolute }:${ name.element }` : name.absolute );

package/lib/base/model.js

@@ -34,6 +34,7 @@ const availableBetaFlags = {
   odataTerms: true,
   optionalActionFunctionParameters: true, // not supported by runtime, yet.
   associationDefault: true,
+  annotateForeignKeys: true,
   // disabled by --beta-mode
   nestedServices: false,
 };
@@ -44,6 +45,7 @@ const availableDeprecatedFlags = {
   downgradableErrors: true,
   includesNonShadowedFirst: true,
   eagerPersistenceForGeneratedEntities: true,
+  noKeyPropagationWithExpansions: true,
 }
 
 const oldDeprecatedFlags_v2 = [
@@ -130,18 +132,26 @@ function checkRemovedDeprecatedFlags( options, { error } ) {
   });
 }
 
-// Apply function `callback` to all artifacts in dictionary
-// `model.definitions`.  See function `forEachGeneric` for details.
-// TODO: should we skip "namespaces" already here?
+/**
+ * Apply function `callback` to all artifacts in dictionary
+ * `model.definitions`.  See function `forEachGeneric` for details.
+ * TODO: should we skip "namespaces" already here?
+ */
 function forEachDefinition( model, callback ) {
   forEachGeneric( model, 'definitions', callback );
 }
 
-// Apply function `callback` to all members of object `obj` (main artifact or
-// parent member).  Members are considered those in dictionaries `elements`,
-// `enum`, `actions` and `params` of `obj`, `elements` and `enums` are also
-// searched inside property `items` (array of).  See function `forEachGeneric`
-// for details.
+/**
+ * Apply function `callback` to all members of object `obj` (main artifact or
+ * parent member).  Members are considered those in dictionaries `elements`,
+ * `enum`, `actions` and `params` of `obj`, `elements` and `enums` are also
+ * searched inside property `items` (array of).  See function `forEachGeneric`
+ * for details.
+ *
+ * @param {XSN.Artifact} construct
+ * @param {(member: XSN.Artifact, memberName: string, prop: string) => void} callback
+ * @param {XSN.Artifact} [target]
+ */
 function forEachMember( construct, callback, target ) {
   let obj = construct;
   while (obj.items)
@@ -155,6 +165,24 @@ function forEachMember( construct, callback, target ) {
     callback( construct.returns, '', 'params' );
 }
 
+/**
+ * Same as forEachMember, but inside each member, calls itself recursively, i.e.
+ * sub members are traversed as well.
+ *
+ * @param {XSN.Artifact} construct
+ * @param {(member: XSN.Artifact, memberName: string, prop: string) => void} callback
+ * @param {XSN.Artifact} [target]
+ */
+function forEachMemberRecursively( construct, callback, target ) {
+  forEachMember( construct, ( member, memberName, prop ) => {
+    callback( member, memberName, prop );
+    if (Array.isArray(member.$duplicates)) // redefinitions
+      member.$duplicates.forEach( o => callback( o, memberName, prop ) );
+    // Descend into nested members, too
+    forEachMemberRecursively( member, callback );
+  }, target);
+}
+
 // Apply function `callback` to all objects in dictionary `dict`, including all
 // duplicates (found under the same name).  Function `callback` is called with
 // the following arguments: the object, the name, and -if it is a duplicate-
@@ -197,6 +225,7 @@ module.exports = {
   queryOps,
   forEachDefinition,
   forEachMember,
+  forEachMemberRecursively,
   forEachGeneric,
   forEachInOrder,
   setProp,

package/lib/checks/elements.js

@@ -119,18 +119,19 @@ function checkManagedAssoc( art ) {
   forEachMemberRecursively(art, (member) => {
     if (this.csnUtils.isAssocOrComposition(member) &&
         !isManagedComposition.bind(this)(member)) {
+      // Implementation note:  Imported services (i.e. external ones) may contain to-many associations
+      // with an empty foreign key list.  If the user (in this case importer) explicitly sets an empty
+      // foreign key array, we won't emit a warning to avoid spamming the user.
       const max = member.cardinality?.max ? member.cardinality.max : 1;
-      if (max !== 1 && !member.on) {
+      if (max !== 1 && !member.on && (!member.keys || member.keys.length > 0)) {
         const isNoDb = art['@cds.persistence.skip'] || art['@cds.persistence.exists'];
-        this.warning(isNoDb ? 'to-many-no-on-noDB' : 'to-many-no-on', member.cardinality ? member.cardinality.$path : member.$path,
-                     {
-                       value: cardinality2str(member, false),
-                       '#': this.csnUtils.isComposition(member) ? 'comp' : 'std',
-                     },
-                     {
-                       std: 'Expected association with target cardinality $(VALUE) to have an ON-condition',
-                       comp: 'Expected composition with target cardinality $(VALUE) to have an ON-condition',
-                     });
+        this.warning(isNoDb ? 'to-many-no-on-noDB' : 'to-many-no-on', member.cardinality ? member.cardinality.$path : member.$path, {
+          value: cardinality2str(member, false),
+          '#': this.csnUtils.isComposition(member) ? 'comp' : 'std',
+        }, {
+          std: 'Expected association with target cardinality $(VALUE) to have an ON-condition',
+          comp: 'Expected composition with target cardinality $(VALUE) to have an ON-condition',
+        });
       }
     }
   });

package/lib/checks/manyNavigations.js

@@ -0,0 +1,33 @@
+'use strict';
+
+const { applyTransformationsOnNonDictionary } = require('../model/csnUtils');
+
+/**
+ * Check all refs in the given parent for the traversal of paths
+ * into `.items`
+ *
+ * @param {object} parent Object with the expression as a property
+ * @param {string} propOnParent Name of the expression property on parent
+ * @param {Array} e Expression to check - see module.exports
+ * @param {CSN.Path} path
+ */
+function navigationIntoMany( parent, propOnParent, e, path ) {
+  applyTransformationsOnNonDictionary(parent, propOnParent, {
+    ref: (_parent, _prop, ref, _path) => {
+      const itemNavigationIndex = _parent._links?.findIndex(l => l.art.items);
+      if (itemNavigationIndex !== -1 && _parent.ref.length > itemNavigationIndex + 1)
+        this.message('ref-unexpected-many-navigation', _path);
+    },
+  }, { skipStandard: { type: true } }, path);
+}
+
+module.exports = {
+  columns: navigationIntoMany,
+  from: navigationIntoMany,
+  on: navigationIntoMany,
+  having: navigationIntoMany,
+  groupBy: navigationIntoMany,
+  orderBy: navigationIntoMany,
+  where: navigationIntoMany,
+  xpr: navigationIntoMany,
+};

package/lib/checks/onConditions.js

@@ -182,10 +182,13 @@ function requireForeignKeyAccess( parent, refIndex, noForeignKeyCallback ) {
   }
   else {
     // For cases where `Association to T { struct.one, struct.two };` is used instead of `{ struct }`.
-    // Note: We know that `{ struct, struct.one }` is not possible, so no prefix check required.
+    // We know that `{ struct, struct.one }` is not possible, so no prefix check required.
+    // If `ref.length` does not cover any full foreign key, then we call noForeignKeyCallback()
+    // as well.  This could happen for `struct.one` as foreign key, and `assoc.struct = …`
+    // in ON-condition.
     let fkIndex = 0;
     let success = false;
-    while (!success && possibleKeys.length > 0) {
+    while (!success && possibleKeys.length > 0 && refIndex + fkIndex + 1 < ref.length) {
       const pathStep = ref[refIndex + fkIndex + 1].id || ref[refIndex + fkIndex + 1];
 
       // Function is immediately executed, before next iteration of loop. Access is fine.

package/lib/checks/queryNoDbArtifacts.js

@@ -76,7 +76,7 @@ function _hasForeignKeyOrElements( def ) {
  * @param {boolean} inColumns True if the ref is part of a from
  */
 function checkQueryRef( obj, inColumns ) {
-  if (!obj || obj.$scope === 'alias')
+  if (!obj)
     return;
 
   if (obj.expand || obj.inline)
@@ -179,8 +179,7 @@ function _checkRef( ref, _links, $path, inColumns ) {
 
     // check managed association to have foreign keys array filled
     if (art.keys && !hasForeignKeys.call(this, art)) {
-      this.error(null, $path, { id: pathStep, elemref: { ref } },
-                 'Path step $(ID) of $(ELEMREF) has no foreign keys');
+      this.error('expr-missing-foreign-key', $path, { id: pathStep, elemref: { ref } } );
       break; // only one error per path
     }
     else if (art.on) {