@sap/cds-compiler 3.9.10 → 3.9.12

package/CHANGELOG.md

@@ -7,6 +7,21 @@
 Note: `beta` fixes, changes and features are usually not listed in this ChangeLog but [here](doc/CHANGELOG_BETA.md).
 The compiler behavior concerning `beta` features can change at any time without notice.
 
+
+## Version 3.9.12 - 2023-12-06
+
+### Fixed
+
+- compiler:
+  + SQL function `STDDEV(*)` was not parsable.
+  + Numbers in scientific notation `-1e1` were sometimes not recognized via CSN input.
+- for.odata: Fix crash when using a projection with associations as action parameter type.
+- for.hana: Fix a bug in association to join translation, expect ON condition operand to be a function without arguments.
+- to.edm(x):
+  + Omit `EntitySet` attribute on `Edm.FunctionImport` and `Edm.ActionImport` that return a singleton.
+  + Don't render `Scale: variable` for `cds.Decimal(scale:0)`.
+- to.sql/hdi/hdbcds: consider `having` predicate for `exists` expansion
+
 ## Version 3.9.10 - 2023-08-25
 
 ### Fixed

package/lib/api/main.js

@@ -48,7 +48,7 @@ const warnAboutMismatchOdata = [ 'odataVersion' ];
  * @param {string} transformation Name of the transformation - odata or hana
  * @param {NestedOptions} options Options used for the transformation
  * @param {string[]} relevantOptionNames Option names that are defining characteristics
- * @param {string[]} [optionalOptionNames=[]] Option names that should be attached as a fyi
+ * @param {string[]} [optionalOptionNames] Option names that should be attached as a fyi
  */
 function attachTransformerCharacteristics( csn, transformation, options,
                                            relevantOptionNames, optionalOptionNames = [] ) {
@@ -141,7 +141,7 @@ function odataInternal( csn, internalOptions ) {
  * Return a odata-transformed CSN
  *
  * @param {CSN.Model} csn Clean input CSN
- * @param {ODataOptions} [options={}] Options
+ * @param {ODataOptions} [options] Options
  * @returns {oDataCSN} Return an oData-pre-processed CSN
  */
 function odata( csn, options = {} ) {
@@ -154,7 +154,7 @@ function odata( csn, options = {} ) {
  * Process the given csn back to cdl.
  *
  * @param {object} csn CSN to process
- * @param {object} [options={}] Options
+ * @param {object} [options] Options
  * @returns {object} { model: string, namespace: string }
  */
 function cdl( csn, options = {} ) {
@@ -167,7 +167,7 @@ function cdl( csn, options = {} ) {
  * Transform a CSN like to.sql
  *
  * @param {CSN.Model} csn Plain input CSN
- * @param {SqlOptions} [options={}] Options
+ * @param {SqlOptions} [options] Options
  * @returns {CSN.Model} CSN transformed like to.sql
  * @private
  */
@@ -182,7 +182,7 @@ function forSql( csn, options = {} ) {
  * Transform a CSN like to.hdi
  *
  * @param {CSN.Model} csn Plain input CSN
- * @param {HdiOptions} [options={}] Options
+ * @param {HdiOptions} [options] Options
  * @returns {CSN.Model} CSN transformed like to.hdi
  * @private
  */
@@ -197,7 +197,7 @@ function forHdi( csn, options = {} ) {
  * Transform a CSN like to.hdbcds
  *
  * @param {CSN.Model} csn Plain input CSN
- * @param {HdbcdsOptions} [options={}] Options
+ * @param {HdbcdsOptions} [options] Options
  * @returns {CSN.Model} CSN transformed like to.hdbcds
  * @private
  */
@@ -214,7 +214,7 @@ function forHdbcds( csn, options = {} ) {
  * Process the given CSN into SQL.
  *
  * @param {CSN.Model} csn A clean input CSN
- * @param {SqlOptions} [options={}] Options
+ * @param {SqlOptions} [options] Options
  * @returns {SQL[]} Array of SQL statements, tables first, views second
  */
 function sql( csn, options = {} ) {
@@ -235,7 +235,7 @@ function sql( csn, options = {} ) {
  * Process the given CSN into HDI artifacts.
  *
  * @param {CSN.Model} csn A clean input CSN
- * @param {HdiOptions} [options={}] Options
+ * @param {HdiOptions} [options] Options
  * @returns {HDIArtifacts} { <filename>:<content>, ...}
  */
 function hdi( csn, options = {} ) {
@@ -529,7 +529,7 @@ sql.migration = sqlMigration;
  * Process the given CSN into HDBCDS artifacts.
  *
  * @param {any} csn A clean input CSN
- * @param {HdbcdsOptions} [options={}] Options
+ * @param {HdbcdsOptions} [options] Options
  * @returns {HDBCDS} { <filename>:<content>, ...}
  */
 function hdbcds( csn, options = {} ) {
@@ -546,7 +546,7 @@ function hdbcds( csn, options = {} ) {
  * Generate a edm document for the given service
  *
  * @param {CSN|oDataCSN} csn Clean input CSN or a pre-transformed CSN
- * @param {ODataOptions} [options={}] Options
+ * @param {ODataOptions} [options] Options
  * @returns {edm} The JSON representation of the service
  */
 function edm( csn, options = {} ) {
@@ -577,7 +577,7 @@ edm.all = edmall;
  * Generate edm documents for all services
  *
  * @param {CSN|oDataCSN} csn Clean input CSN or a pre-transformed CSN
- * @param {ODataOptions} [options={}] Options
+ * @param {ODataOptions} [options] Options
  * @returns {edms} { <service>:<JSON representation>, ...}
  */
 function edmall( csn, options = {} ) {
@@ -608,7 +608,7 @@ function edmall( csn, options = {} ) {
  * Generate a edmx document for the given service
  *
  * @param {CSN|oDataCSN} csn Clean input CSN or a pre-transformed CSN
- * @param {ODataOptions} [options={}] Options
+ * @param {ODataOptions} [options] Options
  * @returns {edmx} The XML representation of the service
  */
 function edmx( csn, options = {} ) {
@@ -640,7 +640,7 @@ edmx.all = edmxall;
  * Generate edmx documents for all services
  *
  * @param {CSN|oDataCSN} csn Clean input CSN or a pre-transformed CSN
- * @param {ODataOptions} [options={}] Options
+ * @param {ODataOptions} [options] Options
  * @returns {edmxs} { <service>:<XML representation>, ...}
  */
 function edmxall( csn, options = {} ) {

package/lib/api/options.js

@@ -74,9 +74,9 @@ const overallOptions = publicOptionsNewAPI.concat(privateOptions);
  * Apply defaults and make sure that the "hard requirements" are met,
  * i.e. src: sql if to.sql() was called.
  *
- * @param {FlatOptions} [input={}] Input options
- * @param {FlatOptions} [defaults={}] Default options to apply
- * @param {FlatOptions} [hardRequire={}] Hard requirements to enforce
+ * @param {FlatOptions} [input] Input options
+ * @param {FlatOptions} [defaults] Default options to apply
+ * @param {FlatOptions} [hardRequire] Hard requirements to enforce
  * @param {object} [customValidators] Custom validations to run instead of defaults
  * @param {string[]} [combinationValidators] Option combinations to validate
  * @param {string} moduleName The called module, e.g. 'for.odata', 'to.hdi'. Needed to initialize the message functions

package/lib/base/message-registry.js

@@ -792,6 +792,7 @@ const centralMessageTexts = {
     incompatible: 'Unexpected EDM Type $(TYPE) for OData $(VERSION)',
     facet: 'Unexpected EDM Type facet $(NAME) of type $(TYPE) for OData $(VERSION)',
     external: 'Referenced type $(TYPE) marked as $(ANNO) can\'t be rendered as $(CODE) in service $(NAME) for OData $(VERSION)',
+    scale: 'Expected scale $(NUMBER) to be less than or equal to precision $(RAWVALUE)'
   },
   'odata-spec-violation-property-name': 'Expected element name to be different from declaring $(META)',
   'odata-spec-violation-namespace': {
@@ -819,7 +820,7 @@ const centralMessageTexts = {
   'odata-anno-preproc': {
     'std': 'unused message text',
     'nokey': 'Expected target $(NAME) to have a key element for $(ANNO)',
-    'multkeys': 'Expected target $(NAME) to have only one key element',
+    'multkeys': 'Expected target $(NAME) to have only one key element for $(ANNO)',
     'vhlnokey': 'Expected value help list entity $(NAME) to have a key element for $(ANNO)',
     'vhlmultkeys': 'Expected value help list entity $(NAME) to have only one key element for $(ANNO)',
     'notforentity': 'Unexpected usage of $(ANNO) for an entity',
@@ -827,8 +828,8 @@ const centralMessageTexts = {
     'noassoc': 'Expected association $(ID) to exist for $(ANNO)',
     'vallistignored': '$(NAME) is ignored for $(ANNO) as $(CODE) is present',
     'notastring': 'Expected value to be a string for $(ANNO)',
-    'notexist': 'Expect entity $(ID) to exist for $(ANNO)',
-    'txtarr': 'Expect $(ANNO) shortcut to have a $(NAME) annotation'
+    'notexist': 'Expected entity $(ID) to exist for $(ANNO)',
+    'txtarr': 'Expected $(ANNO) shortcut to have a $(NAME) annotation'
   },
   // -----------------------------------------------------------------------------------
   // GenericTranslation:

package/lib/checks/validator.js

@@ -127,10 +127,10 @@ const commonQueryValidators = [ validateMixinOnCondition ];
  *
  * @param {CSN.Model} csn CSN to check
  * @param {object} that Will be provided to the validators via "this"
- * @param {object[]} [csnValidators=[]] Validations on whole CSN using applyTransformations
- * @param {Function[]} [memberValidators=[]] Validations on member-level
- * @param {Function[]} [artifactValidators=[]] Validations on artifact-level
- * @param {Function[]} [queryValidators=[]] Validations on query-level
+ * @param {object[]} [csnValidators] Validations on whole CSN using applyTransformations
+ * @param {Function[]} [memberValidators] Validations on member-level
+ * @param {Function[]} [artifactValidators] Validations on artifact-level
+ * @param {Function[]} [queryValidators] Validations on query-level
  * @param {object} iterateOptions can be used to skip certain kinds from being iterated e.g. 'action' and 'function' for hana
  * @returns {Function} Function taking no parameters, that cleans up the attached helpers
  */

package/lib/compiler/builtins.js

@@ -119,7 +119,7 @@ const specialFunctions = compileFunctions( {
   MAX: 'COUNT',
   SUM: 'COUNT',
   AVG: 'COUNT',
-  STDDDEV: 'COUNT',
+  STDDEV: 'COUNT',
   VAR: 'COUNT',
   LOCATE_REGEXPR: [
     {
@@ -216,7 +216,7 @@ const timeRegEx = /^T?(\d{1,2}):(\d{1,2})(?::(\d{1,2}))?(?:Z|[+-]\d{2}(?::\d{2})
 // eslint-disable-next-line max-len
 const timestampRegEx = /^(-?\d{4})-(\d{2})-(\d{2})[T ](\d{2}):(\d{2})(?::(\d{2})(\.\d{1,7})?)?(?:Z|[+-]\d{2}(?::\d{2})?)?$/;
 //                          YYYY  -  MM   -  dd    T    HH   :   mm     :  ss     . fraction     TZD
-const numberRegEx = /^[ \t]*[-+]?(\d+(\.\d*)?|\.\d+)(e[-+]\d+)?[ \t]*$/i;
+const numberRegEx = /^[ \t]*[-+]?(\d+(\.\d*)?|\.\d+)(e[-+]?\d+)?[ \t]*$/i;
 
 /**
  * Patterns for literal token tests and creation.  The value is a map from the

package/lib/edm/annotations/genericTranslation.js

@@ -1009,8 +1009,9 @@ function csn2annotationEdm(reqDefs, csnVocabularies, serviceName,
       else {
         // regular record
         if (dTypeIsACollection) {
-          message('odata-anno-value', msg.location,
-                  { anno: msg.anno(), str: 'structured', '#': 'incompval' });
+          message('odata-anno-value', msg.location, {
+            anno: msg.anno(), str: 'structured', type: dTypeName, '#': 'incompval',
+          });
         }
         oTarget.append(generateRecord(cAnnoValue, oTermName, dTypeName, dTypeIsACollection, msg));
       }

package/lib/edm/annotations/preprocessAnnotations.js

@@ -40,11 +40,11 @@ function preprocessAnnotations(csn, serviceName, options) {
     const keyNames = Object.keys(target.elements).filter(x => target.elements[x].key && !target.elements[x].target);
     if (keyNames.length === 0) {
       keyNames.push('MISSING');
-      message('odata-anno-preproc', null, { anno, name: targetName, '#': 'nokey' },
-      'target $(NAME) has no key');
+      message('odata-anno-preproc', assoc.$path, { anno, name: targetName, '#': 'nokey' } );
+    }
+    else if (keyNames.length > 1) {
+      message('odata-anno-preproc', assoc.$path, { anno, name: targetName, '#': 'multkeys' });
     }
-    else if (keyNames.length > 1)
-      message('odata-anno-preproc', null, { anno, name: targetName, '#': 'multkeys' });
 
     return keyNames[0];
   }

package/lib/edm/csn2edm.js

@@ -745,7 +745,7 @@ function csn2edmAll(_csn, _options, serviceNames=undefined) {
           if(rt) // add EntitySet attribute only if return type is a non abstract entity
           {
             const definition = schemaCsn.definitions[rt];
-            if(definition && definition.kind === 'entity' && !definition.abstract)
+            if (definition && definition.kind === 'entity' && !definition.abstract && !edmUtils.isSingleton(definition))
             {
               actionImport.setEdmAttribute('EntitySet', edmUtils.getBaseName(rt));
             }
@@ -1104,6 +1104,16 @@ function csn2edmAll(_csn, _options, serviceNames=undefined) {
                 { type:edmType, name, version: (p.v4 ? '4.0' : '2.0'), '#': 'facet' });
             }
           });
+          if (edmType === 'Edm.Decimal') {
+            const precision = Number.parseInt(p._edmAttributes.Precision, 10);
+            const scale = Number.parseInt(p._edmAttributes.Scale, 10);
+            if (!Number.isNaN(precision) && !Number.isNaN(scale) && scale > precision) {
+              message('odata-spec-violation-type', pLoc,
+                {
+                  type: edmType, number: scale, rawvalue: precision, ersion: (p.v4 ? '4.0' : '2.0'), '#': 'scale',
+                });
+            }
+          }
         }
         else {
           message('odata-spec-violation-type-unknown', pLoc,

package/lib/edm/edmUtils.js

@@ -610,7 +610,7 @@ function addTypeFacets(node, csn)
       // map both floating and variable to => variable
       if(node._edmAttributes.Scale === 'floating')
         node.setEdmAttribute('Scale', 'variable');
-      if(!csn.precision && !csn.scale)
+      if (csn.precision == null && csn.scale == null)
         // if Decimal has no p, s set scale 'variable'
         node.setXml( { Scale: 'variable' } ); // floating is V4.01
     }

package/lib/transform/db/applyTransformations.js

@@ -17,8 +17,8 @@ const { setProp } = require('../../base/model');
  * @param {object} parent The "parent" of which we transform a property of
  * @param {string} prop The property of parent to start at
  * @param {object} customTransformers Map of prop to transform and function to apply
- * @param {Function[]} [artifactTransformers=[]] Transformations to run on the artifacts, like forEachDefinition
- * @param {applyTransformationsOptions} [options={}]
+ * @param {Function[]} [artifactTransformers] Transformations to run on the artifacts, like forEachDefinition
+ * @param {applyTransformationsOptions} [options]
  * @param {CSN.Path} path Path to parent
  * @returns {object} parent with transformations applied
  */
@@ -165,8 +165,8 @@ function applyTransformationsInternal( parent, prop, customTransformers, artifac
  *
  * @param {object} csn CSN to enrich in-place
  * @param {object} customTransformers Map of _prop to transform and function to apply
- * @param {Function[]} [artifactTransformers=[]] Transformations to run on the artifacts, like forEachDefinition
- * @param {applyTransformationsOptions} [options={}]
+ * @param {Function[]} [artifactTransformers] Transformations to run on the artifacts, like forEachDefinition
+ * @param {applyTransformationsOptions} [options]
  * @returns {object} CSN with transformations applied
  */
 function applyTransformations( csn, customTransformers = {}, artifactTransformers = [], options = { } ) {
@@ -192,7 +192,7 @@ function applyTransformations( csn, customTransformers = {}, artifactTransformer
  * @param {object} parent The "parent" of which we transform a property of
  * @param {string} prop The property of parent to start at
  * @param {object} customTransformers Map of prop to transform and function to apply
- * @param {applyTransformationsOptions} [options={}]
+ * @param {applyTransformationsOptions} [options]
  * @param {CSN.Path} path Path pointing to parent
  * @returns {object} parent[prop] with transformations applied
  */
@@ -213,7 +213,7 @@ function applyTransformationsOnNonDictionary( parent, prop, customTransformers =
  *
  * @param {object} dictionary Dictionary to enrich in-place
  * @param {object} customTransformers Map of prop to transform and function to apply
- * @param {applyTransformationsOptions} [options={}]
+ * @param {applyTransformationsOptions} [options]
  * @param {CSN.Path} path Path pointing to parent
  * @returns {object} dictionary with transformations applied
  */

package/lib/transform/db/expansion.js

@@ -516,7 +516,7 @@ function expandStructureReferences( csn, options, pathDelimiter, messageFunction
    *
    * @param {Array} thing
    * @param {CSN.Path} path
-   * @param {boolean} [withAlias=false] Whether to "expand" the (implicit) alias aswell.
+   * @param {boolean} [withAlias] Whether to "expand" the (implicit) alias aswell.
    * @returns {Array} New array - with all structured things expanded
    */
   function expand( thing, path, withAlias = false ) {
@@ -617,7 +617,7 @@ function expandStructureReferences( csn, options, pathDelimiter, messageFunction
    *
    * @param {object} base The raw set of things a * can expand to
    * @param {Array} subs Things - the .expand/.inline or .columns
-   * @param {string[]} [excluding=[]]
+   * @param {string[]} [excluding]
    * @returns {Array} If there was a star, expand it and handle shadowing/excluding, else just return subs
    */
   function replaceStar( base, subs, excluding = [] ) {

package/lib/transform/db/flattening.js

@@ -192,7 +192,7 @@ function flattenAllStructStepsInRefs( csn, options, resolved, pathDelimiter, ite
    * For each step of the links, check if there is a type reference.
    * If there is, resolve it and store the result in a WeakMap.
    *
-   * @param {Array} [links=[]]
+   * @param {Array} [links]
    * @todo seems too hacky
    * @returns {WeakMap} A WeakMap where a link is the key and the type is the value
    */

package/lib/transform/db/transformExists.js

@@ -63,6 +63,8 @@ function handleExists( csn, options, error, inspectRef, initDefinition, dropDefi
           if (query.SELECT && query.SELECT.where && query.SELECT.where.length > 1)
             toProcess.push([ path.slice(0, -1), path.concat('where') ]);
 
+          if (query.SELECT && query.SELECT.having?.length > 1)
+            toProcess.push([ path.slice(0, -1), path.concat('having') ]);
 
           if (query.SELECT && query.SELECT.columns)
             toProcess.push([ path.slice(0, -1), path.concat('columns') ]);

package/lib/transform/forOdataNew.js

@@ -98,7 +98,9 @@ function transform4odataWithCsn(inputModel, options) {
     inspectRef,
     artifactRef,
     effectiveType,
-    getFinalTypeInfo
+    getFinalTypeInfo,
+    dropDefinitionCache,
+    initDefinition,
   } = csnUtils;
 
   // are we working with structured OData or not
@@ -147,6 +149,8 @@ function transform4odataWithCsn(inputModel, options) {
       // TODO: handle artifact.projection instead of artifact.query correctly in future V2
       if (def.kind === 'entity' && def.projection) {
         def.query = { SELECT: def.projection };
+        dropDefinitionCache(def);
+        initDefinition(def);
       }
     }],
     { skipArtifact: isExternalServiceMember }

package/lib/transform/translateAssocsToJoins.js

@@ -730,7 +730,8 @@ function translateAssocsToJoins(model, inputOptions = {})
         // this will substitute multiple backlink conditions ($self = ... AND $self = ...AND ...)
         if(expr.op) {
           let x = clone(expr);
-          x.args = expr.args.map(cloneOnCondition);
+          if(expr.args)
+            x.args = expr.args.map(cloneOnCondition);
           return x;
         }
 

package/lib/transform/universalCsn/universalCsnEnricher.js

@@ -328,9 +328,9 @@ module.exports = (csn, options) => {
      * passed to this function.
      *
      * @param {CSN.Element}  member
-     * @param {object}       [except=null] List of properties which should not be propagated along the origin chain
+     * @param {object}       [except] List of properties which should not be propagated along the origin chain
      *                                     of the `member`
-     * @param {object}       [force=null]  Overwrite any member propagation rules or any except and always propagate the corresponding keys
+     * @param {object}       [force]  Overwrite any member propagation rules or any except and always propagate the corresponding keys
      */
     function propagateMemberPropsFromOrigin( member, except = null, force = null ) {
       const memberChain = getOriginChain(member);
@@ -613,8 +613,8 @@ module.exports = (csn, options) => {
  * @param {object} to
  * @param {Function} getCustomRule getter for the `memberProps` or `defProps`
  *                                 which shall be used for retrieving custom rules
- * @param {object} [except=null] array of properties which should not be propagated
- * @param {object} [force=null] Force propagation of the contained keys via a custom rule.
+ * @param {object} [except] array of properties which should not be propagated
+ * @param {object} [force] Force propagation of the contained keys via a custom rule.
  */
 function copyProperties( from, to, getCustomRule, except = null, force = null ) {
   const keys = Object.keys(from);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cds-compiler",
-  "version": "3.9.10",
+  "version": "3.9.12",
   "description": "CDS (Core Data Services) compiler and backends",
   "homepage": "https://cap.cloud.sap/",
   "author": "SAP SE (https://www.sap.com)",