@sap/cds-compiler 3.4.2 → 3.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sap/cds-compiler",
-  "version": "3.4.2",
+  "version": "3.5.0",
   "description": "CDS (Core Data Services) compiler and backends",
   "homepage": "https://cap.cloud.sap/",
   "author": "SAP SE (https://www.sap.com)",
@@ -21,16 +21,14 @@
     "xmakePrepareRelease": "echo \"$(node scripts/stripReadme.js README.md)\" > README.md && node scripts/assertSnapshotVersioning.js && node scripts/assertChangelog.js && node scripts/cleanup.js --remove-dev",
     "test": "node scripts/verifyGrammarChecksum.js && mocha --reporter min --reporter-option maxDiffSize=0 scripts/testLazyLoading.js && mocha --parallel --reporter min --reporter-option maxDiffSize=0 test/ test3/",
     "testverbose": "node scripts/verifyGrammarChecksum.js && mocha --parallel test/ test3/",
-    "test3": "node scripts/verifyGrammarChecksum.js && node scripts/linter/lintTests.js test3/ && mocha --reporter-option maxDiffSize=0 scripts/linter/lintMessages.js test3/",
-    "deployTest3SQL": "deployRefs=true mocha --reporter-option maxDiffSize=0 test3/testHANASQLDeployment.js",
+    "test3": "node scripts/verifyGrammarChecksum.js && mocha --reporter-option maxDiffSize=0 test3/",
+    "deployTest3SQL": "deployRefs=true mocha --reporter-option maxDiffSize=0 test3/test.deploy.hana-sql.js",
     "deployTest3": "deployRefs=true mocha --reporter-option maxDiffSize=0 test3/testDeployment.js",
+    "deployHanaDeltaSQL": "CDS_COMPILER_DEPLOY_HANA=1 mocha test3/test.deploy.hana-sql.delta.js",
     "deployDiffs": "deployRefs=true mocha --reporter-option maxDiffSize=0 test3/deployDiffs.js",
     "gentest3": "cross-env MAKEREFS=${MAKEREFS:-'true'} mocha --reporter-option maxDiffSize=0 test3/testRefFiles.js",
-    "testdb": "node scripts/verifyGrammarChecksum.js && cross-env TESTDB='TRUE' mocha",
-    "testmigration": "npm install --no-save @sap/hana-client@2.3.123 @sap/hdi-deploy@3.10.0 && node scripts/verifyGrammarChecksum.js && cross-env TESTMIGRATION='TRUE' mocha",
-    "testall": "npm install --no-save @sap/hana-client@2.3.123 @sap/hdi-deploy@3.10.0 && node scripts/verifyGrammarChecksum.js && cross-env TESTDB='TRUE' TESTMIGRATION='TRUE' mocha",
     "coverage": "cross-env nyc mocha --reporter-option maxDiffSize=0 test/ test3/ && nyc report --reporter=lcov",
-    "lint": "eslint bin/ benchmark/ lib/ test/ test3/ scripts/ types/ && node scripts/linter/lintGrammar.js && node scripts/linter/lintTests.js test3/ && markdownlint README.md CHANGELOG.md doc/ internalDoc/ && cd share/messages && markdownlint .",
+    "lint": "eslint bin/ benchmark/ lib/ test/ test3/ scripts/ types/ && node scripts/linter/lintGrammar.js && node scripts/linter/lintTests.js test3/ && node scripts/linter/lintMessages.js && node scripts/linter/lintMessageIdCoverage.js lib/ && markdownlint README.md CHANGELOG.md doc/ internalDoc/ && cd share/messages && markdownlint .",
     "tslint": "tsc --pretty -p .",
     "updateVocs": "node scripts/odataAnnotations/generateDictMain.js && npm run generateAllRefs",
     "generateCompilerRefs": "cross-env MAKEREFS='true' mocha test/testCompiler.js",
@@ -41,7 +39,6 @@
     "generateToSqlRefs": "cross-env MAKEREFS='true' mocha test/testToSql.js",
     "generateToRenameRefs": "cross-env MAKEREFS='true' mocha test/testToRename.js",
     "generateChecksRefs": "cross-env MAKEREFS='true' mocha test/testChecks.js",
-    "generateScenarioRefs": "cross-env MAKEREFS='true' mocha test/testScenarios.js",
     "generateDraftRefs": "cross-env MAKEREFS='true' mocha test/testDraft.js",
     "generateAllRefs": "node scripts/verifyGrammarChecksum.js && cross-env MAKEREFS='true' mocha --reporter-option maxDiffSize=0 test/ test3/"
   },

package/share/messages/check-proper-type-of.md

@@ -19,7 +19,7 @@ view ViewFoo as select from Foo {
 };
 entity Bar {
   // `e` has no proper type but has the annotation `@anno`.
-  e : type of ViewFoo:calculatedField;
+  e : ViewFoo:calculatedField;
 };
 ```
 

package/share/messages/message-explanations.json

@@ -11,7 +11,7 @@
     "redirected-to-complex",
     "redirected-to-unrelated",
     "rewrite-not-supported",
-    "syntax-expecting-integer",
+    "syntax-expecting-unsigned-int",
     "wildcard-excluding-one"
   ]
 }

package/share/messages/redirected-to-complex.md

@@ -3,7 +3,7 @@
 The redirected target is a complex view, for example, contains a JOIN or UNION.
 
 The message's severity is `Info` and is raised by the compiler.
-It is emitted to help developers identify possible modelling issues.
+It is emitted to help developers identify possible modeling issues.
 
 ## Example
 
@@ -33,7 +33,7 @@ The cross join in the view `CrossJoin` results in multiple rows with the same
 `id`.  Following the redirected view now returns multiple results, effectively
 making the to-one association a to-many association.
 
-Visualizing the tables with a bit of data, this issues becomes obvious:
+Visualizing the tables with a bit of data, this issue becomes obvious:
 
 ```markdown
 Main                        Secondary
@@ -54,8 +54,8 @@ CrossJoin
 ## How to Fix
 
 Ensure that the redirected association points to an entity that is a reasonable
-redirection target.  You must ensure that the redirection does not accidentally
-result in a to-one association becoming a to-many association.
+redirection target.  That means, the redirection target shouldn't accidentally
+make it a to-many association.
 
 ## Related Messages
 

package/share/messages/{syntax-expecting-integer.md → syntax-expecting-unsigned-int.md}

@@ -1,6 +1,6 @@
-# syntax-expecting-integer
+# syntax-expecting-unsigned-int
 
-The compiler expects a safe integer here.
+The compiler expects a safe non-negative integer here.
 The last safe integer is `2^53 - 1` or `9007199254740991`.
 
 A safe integer is an integer that fulfills all of the following:
@@ -34,5 +34,8 @@ type LengthIsSafe : String(9007199254740991);
 type AnInteger : String(42);
 ```
 
-If it's not feasible to use a safe integer, a string representation of the
-number needs to be used, for example, in annotation values.
+At other places, using unsafe integers (or non-integer numbers) is allowed:
+
+- Annotation values: The value is then simply a string.
+- Expressions: The `val` property in the CSN contains a string
+  having a sibling `literal: 'number'`.

package/lib/modelCompare/filter.js

@@ -1,83 +0,0 @@
-// Each db has some changes that it can and cannot represent, or that cause problems only on that specific db
-// In this file, we define rules for each db-dialect to detect and act on these cases.
-
-const { forEach } = require("../utils/objectUtils");
-const { isPersistedAsTable } = require('../model/csnUtils');
-
-function isKey(element) {
-  return element.key;
-}
-
-module.exports = {
-  sqlite: getFilterObject(
-    'sqlite', 
-    (extend, name, element, error) => {
-      if(isKey(element)) { // Key must not be extended
-        error(null, ['definitions', extend, 'elements', name], {id: name, name: 'sqlite'}, "Added element $(ID) is a primary key change and will not work with $(NAME)")
-      }
-    },
-    (migrate, name, migration, change, error) => {
-      const newIsKey = isKey(migration.new);
-      const oldIsKey = isKey(migration.old);
-      if((newIsKey || oldIsKey) && oldIsKey !== newIsKey) { // Turned into key or key was removed
-        error(null, ['definitions', migrate, 'elements', name], {id: name, name: 'sqlite'}, "Changed element $(ID) is a primary key change and will not work with $(NAME)")
-      } else { // Ignore simple migrations
-        delete change[name];
-      }
-    })
-}
-
-function getFilterObject(dialect, extensionCallback, migrationCallback) {
-  return {
-        // will be called with a simple Array.forEach
-    extension: ({ elements, extend }, error) => {
-      forEach(elements, (name, element) => {
-        extensionCallback(extend, name, element, error);
-      });
-    },
-    // will be called with a Array.map, as we need to filter "change" for SQLite
-    migration: ({ change, migrate, remove }, error) => {
-      forEach(remove, (name) => {
-        error(null, ['definitions', migrate, 'elements', name], {}, "Dropping elements is not supported")
-      });
-
-      forEach(change, (name, migration) => {
-        if(migration.new.type !== migration.old.type && typeChangeIsNotCompatible(dialect, migration.old.type, migration.new.type)) {
-          error(null, ['definitions', migrate, 'elements', name], { id: name, name: migration.old.type, type: migration.new.type }, "Changed element $(ID) is a lossy type change from $(NAME) to $(TYPE) and is not supported")
-        } else if(migration.new.length < migration.old.length) {
-          error(null, ['definitions', migrate, 'elements', name], { id: name }, "Changed element $(ID) is a length reduction and is not supported")
-        } else {
-          migrationCallback(migrate, name, migration, change, error);
-        }
-
-        // TODO: precision/scale growth
-      });
-    },
-    deletion: ([artifactName, artifact ], error) => {
-      if(isPersistedAsTable(artifact))
-        error(null, ['definitions', artifactName], "Dropping tables is not supported");
-    }
-  }
-}
-
-const baseMatrix = {
-  // Integer types
-  'cds.hana.tinyint':['cds.UInt8', 'cds.Int16', 'cds.Int32', 'cds.Integer', 'cds.Int64', 'cds.Integer64'],
-  'cds.UInt8': ['cds.hana.tinyint', 'cds.Int16', 'cds.Int32', 'cds.Integer', 'cds.Int64', 'cds.Integer64'],
-  'cds.Int16': ['cds.hana.smallint', 'cds.Int32', 'cds.Integer', 'cds.Int64', 'cds.Integer64'],
-  'cds.hana.smallint':['cds.Int16', 'cds.Int32', 'cds.Integer', 'cds.Int64', 'cds.Integer64'],
-  'cds.Int32': ['cds.Integer', 'cds.Int64', 'cds.Integer64'],
-  'cds.Integer': ['cds.Int32', 'cds.Int64', 'cds.Integer64'],
-  'cds.Integer64': ['cds.Int64'],
-  'cds.Int64': ['cds.Integer64']
-}
-
-const allowedTypeChanges = {
-  'sqlite': baseMatrix
-};
-
-function typeChangeIsNotCompatible(dialect, before, after) {
-  if(allowedTypeChanges[dialect])
-    return allowedTypeChanges[dialect][before]?.indexOf(after) === -1;
-  return true;
-}