@sap/cds-compiler 3.1.2 → 3.4.0

package/share/messages/redirected-to-ambiguous.md

@@ -11,7 +11,7 @@ your model.
 
 Erroneous code example:
 
-```cdl
+```cds
 entity Main {
       key id : Integer;
     toTarget : Association to Target;
@@ -42,11 +42,11 @@ to trigger this error.
 
 ## How to Fix
 
-To fix the issue, you must have the original target only once in your direct
-and indirect sources.  The previous example can be fixed by removing
-`Duplicate` from the select clause.
+You must have the original target only once in your direct and indirect
+sources.  The previous example can be fixed by removing `Duplicate` from
+the select clause.
 
-```cdl
+```cds
 view View as select from Main, Target {
     Main.toTarget : redirected to View
 };
@@ -55,7 +55,7 @@ view View as select from Main, Target {
 If this isn’t feasible then you have to redefine the association using a mixin
 clause.
 
-```cdl
+```cds
 view View as select from Main, Target mixin {
     toMain : Association to View on Main.id = Target.id;
 } into {
@@ -68,3 +68,4 @@ view View as select from Main, Target mixin {
 ## Related Messages
 
 - `redirected-to-unrelated`
+- `redirected-to-complex`

package/share/messages/redirected-to-complex.md

@@ -0,0 +1,63 @@
+# redirected-to-complex
+
+The redirected target is a complex view, for example, contains a JOIN or UNION.
+
+The message's severity is `Info` and is raised by the compiler.
+It is emitted to help developers identify possible modelling issues.
+
+## Example
+
+Erroneous code example:
+
+```cds
+entity Main {
+    key id : Integer;
+    // self association for example purpose only
+    toMain : Association to one Main;
+}
+entity Secondary {
+    content: String;
+};
+entity CrossJoin as SELECT from Main, Secondary;
+entity RedirectToComplex as projection on Main {
+    id,
+    toMain: redirected to CrossJoin,
+};
+```
+
+`Main:toMain` is a to-one association.  Since `Main` contains a single key,
+which is used in the managed association, we know that following the
+association returns a single result.
+
+The cross join in the view `CrossJoin` results in multiple rows with the same
+`id`.  Following the redirected view now returns multiple results, effectively
+making the to-one association a to-many association.
+
+Visualizing the tables with a bit of data, this issues becomes obvious:
+
+```markdown
+Main                        Secondary
+| id  | toMain_id |         | content |
+|-----|-----------|         |---------|
+| 1   | 2         |         | 'Hello' |
+| 2   | 1         |         | 'World' |
+
+CrossJoin
+| id  | toMain_id | content |
+|-----|-----------|---------|
+| 1   | 2         | 'Hello' |
+| 1   | 2         | 'World' |
+| 2   | 1         | 'Hello' |
+| 2   | 1         | 'World' |
+```
+
+## How to Fix
+
+Ensure that the redirected association points to an entity that is a reasonable
+redirection target.  You must ensure that the redirection does not accidentally
+result in a to-one association becoming a to-many association.
+
+## Related Messages
+
+- `redirected-to-ambiguous`
+- `redirected-to-unrelated`

package/share/messages/redirected-to-unrelated.md

@@ -10,7 +10,7 @@ your model.
 
 Erroneous code example:
 
-```cdl
+```cds
 entity Main {
     key id : Integer;
     // self association for example purpose only
@@ -35,7 +35,7 @@ that make the error not as obvious.
 
 Erroneous code example with multiple redirections:
 
-```cdl
+```cds
 entity Main {
     key id : Integer;
     toMain : Association to Main;
@@ -58,12 +58,12 @@ originate from `FirstRedirect` but only vice versa.
 
 ## How to Fix
 
-To fix the issue, you must redirect the association to an entity that originates
-from the original target.  In the first example above you could redirect
+You must redirect the association to an entity that originates from the
+original target.  In the first example above you could redirect
 `SecondRedirect:toMain` to `SecondRedirect`.  However, if that isn’t feasible
 then you have to redefine the association using a mixin clause.
 
-```cdl
+```cds
 view SecondRedirect as select from FirstRedirect mixin {
     toMain : Association to Main on id = $self.id;
 } into {
@@ -75,3 +75,4 @@ view SecondRedirect as select from FirstRedirect mixin {
 ## Related Messages
 
 - `redirected-to-ambiguous`
+- `redirected-to-complex`

package/share/messages/rewrite-not-supported.md

@@ -9,7 +9,7 @@ The message's severity is `Error`.
 
 Erroneous code example:
 
-```cdl
+```cds
 entity Base {
   key id     : Integer;
   primary    : Association to Primary on primary.id = primary_id;
@@ -39,10 +39,10 @@ compiler can’t determine how to properly rewrite them for `View`.
 
 ## How to Fix
 
-To fix the issue, you have to provide an explicit ON condition.  This can be
-achieved by using the `redirected to` statement:
+You have to provide an explicit ON condition.  This can be achieved by using
+the `redirected to` statement:
 
-```cdl
+```cds
 entity View as select from Base {
   id,
   primary.secondary_id,

package/share/messages/{syntax-expected-integer.md → syntax-expecting-integer.md}

@@ -1,4 +1,4 @@
-# syntax-expected-integer
+# syntax-expecting-integer
 
 The compiler expects a safe integer here.
 The last safe integer is `2^53 - 1` or `9007199254740991`.
@@ -16,7 +16,7 @@ The message's severity is `Error`.
 Erroneous code example:
 
 <!-- cds-mode: ignore -->
-```cdl
+```cds
 type LengthIsUnsafe : String(9007199254740992);
 type NotAnInteger : String(42.1);
 ```
@@ -27,9 +27,9 @@ Likewise, the string length for the type `NotAnInteger` is a decimal.
 
 ## How to Fix
 
-To fix the issue, you have to provide a safe integer:
+You have to provide a safe integer:
 
-```cdl
+```cds
 type LengthIsSafe : String(9007199254740991);
 type AnInteger : String(42);
 ```

package/share/messages/wildcard-excluding-one.md

@@ -0,0 +1,37 @@
+# wildcard-excluding-one
+
+You're replacing an element in your projection, that is already included by
+using the wildcard `*`.
+
+The message's severity is `Info`.
+
+## Example
+
+Erroneous code example:
+
+```cds
+entity Book {
+  key  id : String;
+     isbn : String;
+  content : String;
+};
+entity IsbnBook as projection on Book {
+  *,
+  isbn as id,
+};
+```
+
+`IsbnBook:id` replaces `Book:id`, which was included in `IsbnBook` through
+the wildcard `*`.
+
+## How to Fix
+
+Add the replaced element to the list of wildcard excludes:
+
+```cds
+entity IsbnBook as projection on Book {
+  *,
+  isbn as id
+} excluding { id };
+```
+