@sap/cds-compiler 2.5.0 → 2.10.4

package/lib/compiler/resolver.js

@@ -45,9 +45,7 @@ const {
   dictAdd, dictAddArray,
 } = require('../base/dictionaries');
 const { dictLocation } = require('../base/location');
-const {
-  makeMessageFunction, searchName, weakLocation,
-} = require('../base/messages');
+const { searchName, weakLocation } = require('../base/messages');
 const { combinedLocation } = require('../base/location');
 const { pushLink } = require('./utils');
 const {
@@ -84,7 +82,7 @@ function resolve( model ) {
   } = fns( model, environment );
   const {
     info, warning, error, message,
-  } = makeMessageFunction( model, model.options, 'compile' );
+  } = model.$messageFunctions;
   const {
     initArtifact,
     lateExtensions,
@@ -95,6 +93,8 @@ function resolve( model ) {
 
   // behavior depending on option `deprecated`:
   const enableExpandElements = !isDeprecatedEnabled( options, 'noElementsExpansion' );
+  // TODO: we should get rid of noElementsExpansion soon; both
+  // beta.nestedProjections and beta.universalCsn do not work with it.
   const scopedRedirections
         = enableExpandElements &&
           !isDeprecatedEnabled( options, 'generatedEntityNameWithUnderscore' ) &&
@@ -319,6 +319,7 @@ function resolve( model ) {
     return null;
   }
 
+  // TODO: test it in combination with top-level CAST function
   function directType( art ) {
     // Be careful when using it with art.target or art.enum or art.elements
     if (art._origin || art.builtin)
@@ -326,14 +327,14 @@ function resolve( model ) {
     if (art.type)
       return resolveType( art.type, art );
     // console.log( 'EXPR-IN', art.kind, refString(art.name) )
-    if (!art._main)
+    if (!art._main || !art.value || !art.value.path)
       return undefined;
     if (art._pathHead && art.value) {
       setProp( art, '_origin', resolvePath( art.value, 'expr', art, null ) );
       return art._origin;
     }
     const query = userQuery( art ) || art._parent;
-    if (query.kind !== 'select' || !art.value.path)
+    if (query.kind !== 'select')
       return undefined;
     // Reached an element in a query which is a simple ref -> return referred artifact
     // TODO: remember that we still have to resolve path arguments and filters
@@ -424,7 +425,7 @@ function resolve( model ) {
         info( 'query-missing-element', [ ielem.name.location, view ], { id },
               'Element $(ID) is missing in specified elements' );
       }
-      else if (!Array.isArray( ielem ) && !Array.isArray( selem )) {
+      else {
         for (const prop in selem) {
           // just annotation assignments and doc comments for the moment
           if (prop.charAt(0) === '@' || prop === 'doc')
@@ -435,7 +436,7 @@ function resolve( model ) {
     }
     for (const id in view.elements$) {
       const selem = view.elements$[id]; // specified element
-      if (!Array.isArray( selem ) && !selem.$replacement) {
+      if (!selem.$replacement) {
         error( 'query-unspecified-element', [ selem.name.location, selem ], { id },
                'Element $(ID) does not result from the query' );
       }
@@ -445,8 +446,7 @@ function resolve( model ) {
   function traverseElementEnvironments( art ) {
     populateView( art );
     environment( art );
-    // TODO: but we have no proxy copy of sub elements yet - no redirection in ValueHelpList.cds
-    forEachGeneric( art, 'elements', traverseElementEnvironments );
+    forEachMember( art, traverseElementEnvironments );
   }
 
   function populateQuery( query ) {
@@ -454,6 +454,7 @@ function resolve( model ) {
       // already done or $join query or parse error
       return;
     setProp( query, '_combined', Object.create(null) );
+    query.$inlines = [];
     forEachGeneric( query, '$tableAliases', resolveTabRef );
 
     initFromColumns( query, query.columns );
@@ -540,7 +541,8 @@ function resolve( model ) {
     if (art.elements || art.kind === '$tableAlias' ||
         // no element expansions for "non-proper" types like
         // entities (as parameter types) etc:
-        struct.kind !== 'type' && struct.kind !== 'element' && !struct._outer)
+        struct.kind !== 'type' && struct.kind !== 'element' && struct.kind !== 'param' &&
+        !struct._outer)
       return false;
     if (struct.elements === 0 || isInParents( art, eType )) {
       art.elements = 0;         // circular
@@ -559,8 +561,12 @@ function resolve( model ) {
         // or should we use orig.location? - TODO: try to find test to see message
         .$inferred = 'expand-element';
     }
-    art.$expand = 'origin';   // if value stays, elements won't appear in CSN
-    // TODO: should we also set 'virtual' here?
+    // Set elements expansion status (the if condition is always true, as no
+    // elements expansion will take place on artifact with existing other
+    // member property):
+    if (!art.$expand)
+      art.$expand = 'origin';   // if value stays, elements won't appear in CSN
+    // TODO: have some art.elements[SYM.$inferred] = 'expand-elements';
     return true;
   }
 
@@ -586,14 +592,45 @@ function resolve( model ) {
     return false;
   }
 
-  function setExpandStatus( elem ) {
+  // About Helper property $expand for faster the XSN-to-CSN transformation
+  // - null/undefined: artifact, member, items does not contain expanded members
+  // - 'origin': all expanded (sub) elements have no new target/on and no new annotations
+  //             that value is only on elements, types, and params -> no other members
+  //             when set, only on elem/art with expanded elements
+  // - 'target': all expanded (sub) elements might only have new target/on, but
+  //             no indivual annotations on any (sub) member
+  //             when set, traverse all parents where the value has been 'origin' before
+  // - 'annotate': at least one inferred (sub) member has an individual annotation,
+  //               not counting propagated ones; set up to the definition (main artifact)
+  //               (only set with anno on $inferred elem)
+  // Usage according to CSN flavor:
+  // - gensrc: do not render enferred elements (including expanded elements),
+  //           collect annotate statements with value 'annotate'
+  // - client: do not render expanded sub elements if artifact/member is no type, has a type,
+  //           has $expand = 'origin', and all its _origin also have $expand = 'origin'
+  //           (might sometimes render the elements unnecessarily, which is not wrong)
+  // - universal: do not render expanded sub elements if $expand = 'origin'
+  function setExpandStatus( elem, status ) {
+    // set on element
     while (elem._main) {
       elem = elem._parent;
-      if (!elem.$expand)
+      if (elem.$expand !== 'origin')
         return;
-      elem.$expand = 'target';  // meaning: expanded, containing assocs
+      elem.$expand = status;    // meaning: expanded, containing assocs
+      for (let line = elem.items; line; line = line.items)
+        line.$expand = status; // to-csn just uses the innermost $expand
+    }
+  }
+  function setExpandStatusAnnotate( elem, status ) {
+    for (;;) {
+      if (elem.$expand === status)
+        return;                 // already set
+      elem.$expand = status;    // meaning: expanded, containing annos
       for (let line = elem.items; line; line = line.items)
-        line.$expand = 'target'; // to-csn just uses the innermost $expand
+        line.$expand = status; // to-csn just uses the innermost $expand
+      if (!elem._main)
+        return;
+      elem = elem._parent;
     }
   }
 
@@ -605,7 +642,7 @@ function resolve( model ) {
     // PRE: elem has no target, assoc has target prop
     if (elem.kind === '$tableAlias')
       return false;
-    setExpandStatus( elem );
+    setExpandStatus( elem, 'target' );
     let target = resolvePath( assoc.target, 'target', assoc );
     // console.log( info( null, [ elem.location, elem ], {target,art:assoc,name:''+assoc.target},
     //              'RED').toString())
@@ -718,6 +755,7 @@ function resolve( model ) {
     const nullScope = {
       kind: 'namespace', name: { absolute: autoScopeName, location }, location,
     };
+    model.definitions[autoScopeName] = nullScope;
     initArtifact( nullScope );
     return nullScope;
   }
@@ -926,26 +964,53 @@ function resolve( model ) {
     return art;
   }
 
+  // TODO: probably do this already in definer.js
+  function ensureColumnName( col, query ) {
+    if (col.name)
+      return col.name.id;
+    if (col.inline || col.val === '*')
+      return '';
+    const path = col.value &&
+        (col.value.path || !col.value.args && col.value.func && col.value.func.path);
+    if (path) {
+      const last = !path.broken && path.length && path[path.length - 1];
+      if (last) {
+        col.name = { id: last.id, location: last.location, $inferred: 'as' };
+        return col.name.id;
+      }
+    }
+    else if (col.value || col.expand) {
+      error( 'query-req-name', [ col.value && col.value.location || col.location, query ], {},
+             'Alias name is required for this select item' );
+    }
+    // invent a name for code completion in expression
+    col.name = {
+      id: '',
+      location: col.value && col.value.location || col.location,
+      $inferred: 'none',
+    };
+    return '';
+  }
+
   // TODO: make this function shorter - make part of this (e.g. setting
   // parent/name) also be part of definer.js
   // TODO: query is actually the elemParent, where the new elements are added to
-  function initFromColumns( query, columns, elements = undefined, colParent = undefined ) {
+  // top-level: just query, columns
+  // inline: + elements (TODO: remove), colParent
+  // expand: just query (which is a column/element), columns=array of expand
+  function initFromColumns( query, columns, inlineHead = undefined ) {
     const elemsParent = query.items || query;
-    if (!elements) {
-      elements = Object.create(null); // explicitly prov
+    if (!inlineHead) {
       elemsParent.elements = Object.create(null);
       if (query._main._leadingQuery === query) // never the case for 'expand'
         query._main.elements = elemsParent.elements;
     }
-    let wildcard = false;
-    let inline = 0;
 
     for (const col of columns || [ { val: '*' } ]) {
       if (col.val === '*') {
-        wildcard = col;
-        continue;
+        const siblings = wildcardSiblings( columns, query );
+        expandWildcard( col, siblings, inlineHead, query );
       }
-      col.kind = 'element';
       if ((col.expand || col.inline) && !isBetaEnabled( options, 'nestedProjections' )) {
         error( null, [ col.location, query ], { prop: (col.expand ? 'expand' : 'inline') },
                'Unsupported nested $(PROP)' );
@@ -957,137 +1022,135 @@ function resolve( model ) {
         col.name = {};
         // a name for this internal symtab entry (e.g. '.2' to avoid clashes
         // with real elements) is only relevant for for `cdsc -R`/debugging
-        // TODO: user better scheme with _outer (for messages /column:…/inline:2),
-        // use depth-first numbering
-        setMemberParent( col, `.${ ++inline }`, query );
-        initFromColumns( query, col.inline, elements, col );
+        const q = userQuery( query );
+        q.$inlines.push( col );
+        // or use userQuery( query ) in the following, too?
+        setMemberParent( col, `.${ q.$inlines.length }`, query );
+        initFromColumns( query, col.inline, col );
         continue;
       }
-      if (!col.name) {
-        const path = col.value &&
-          (col.value.path || !col.value.args && col.value.func && col.value.func.path);
-        if (!path) {
-          error( 'query-req-name', [ col.value && col.value.location || col.location, query ], {},
-                 'Alias name is required for this select item' );
-        }
-        else if (path.length && !path.broken) {
-          const last = path[path.length - 1];
-          if (last)
-            col.name = { id: last.id, location: last.location, $inferred: 'as' };
-        }
-        if (!col.name) {
-          // invent a name for code completion in expression
-          col.name = {
-            id: '',
-            location: col.value && col.value.location || col.location,
-            $inferred: 'none',
-          };
-        }
-      }
-      const { id } = col.name;
-      dictAdd( elements, id, col, ( name, location ) => {
-        error( 'duplicate-definition', [ location, query ], { name, '#': 'element' } );
-      });
-      setMemberParent( col, id, query );
-      if (!wildcard) {
-        if (col.$duplicates !== true)
-          dictAdd( elemsParent.elements, id, col );
-        col.$replacement = true;
+      else if (!col.$replacement) {
+        const id = ensureColumnName( col, query );
+        col.kind = 'element';
+        dictAdd( elemsParent.elements, id, col, ( name, location ) => {
+          error( 'duplicate-definition', [ location, query ], { name, '#': 'element' } );
+        });
+        setMemberParent( col, id, query );
       }
     }
-    if (wildcard)
-      expandWildcard( elements, wildcard );
     forEachGeneric( query, 'elements', e => initElem( e, query ) );
     return true;
+  }
 
-    // TODO: make this function shorter, probably outside initFromColumns
-    // `elements` are the element explicitly provided via `columns`
-    // TODO: make struct.* are to be added at place, not sub-wildcards first,
-    // see test3/Queries/ExpandInlineCreate/Excluding.cds
-    // TODO: disallow $self.elem.* and $self.*, toSelf.* (circular dependency)
-    // eslint-disable-next-line no-shadow
-    function expandWildcard( elements, wildcard ) {
-      let location = wildcard.location || query.from && query.from.location || query.location;
-      const inferred = query._main.$inferred;
-      const excludingDict = (colParent || query).excludingDict || Object.create(null);
-
-      const envParent = wildcard._pathHead; // TODO: rename _pathHead to _pathEnv
-      // console.log('S1:',location.line,location.col,
-      //             envParent&&!!envParent._origin&&envParent._origin.name)
-      const env = columnEnv( envParent, query );
-      // console.log('S2:',location.line,location.col,
-      //             envParent&&!!envParent._origin&&envParent._origin.name,
-      //             Object.keys(env),Object.keys(elements))
-      for (const name in env) {
-        const navElem = env[name];
-        // TODO: if it is an array, filter out those with masked
-        if (excludingDict[name] || navElem.masked && navElem.masked.val)
-          continue;
-        const selElem = elements[name];
-        if (selElem) {          // is explicitly provided
-          if (!selElem.name)    // no name with parse error or repeated def
-            continue;
-          const path = selElem.value && selElem.value.path;
-          // TODO: to bring the message below for ParentElem.Assoc, we should move this
-          // check to resolveElem for elems with $replacement, by comparing the
-          // name with the name.element of the _origin.
-          // We cannot check path.length === 1, as we want to allow Alias.Elem.
-
-          // TODO: bring this less often (only if shadowed elem does not appear
-          // in expr and if not projected as other name)
-          // TODO: in general - re-think and implement
-          if (!inferred && (
-              selElem.$replacement !== 'silent' && !envParent &&
-              (!selElem.target || selElem.target.$inferred ) ||
-              path && path[path.length - 1].id !== selElem.name.id)) {
-            if (Array.isArray(navElem)) {
-              info( 'wildcard-excluding-many', [ selElem.name.location, query ], { id: name },
-                    'This select item replaces $(ID) from two or more sources' );
-            }
-            else {
-              info( 'wildcard-excluding-one', [ selElem.name.location, query ],
-                    { id: name, alias: navElem._parent.name.id },
-                    'This select item replaces $(ID) from table alias $(ALIAS)' );
-            }
-          }
-          if (!selElem.$replacement || selElem.$replacement === 'silent') {
-            selElem.$replacement = true;
-            dictAdd( elemsParent.elements, name, selElem );
-          }
-          else {
-            selElem.$inferred = 'query';
-          }
-        }
-        else if (Array.isArray(navElem)) {
-          const names = navElem.filter( e => !e.$duplicates)
-            .map( e => `${ e.name.alias }.${ e.name.element }` );
-          if (names.length) {
-            error( 'wildcard-ambiguous', [ location, query ], { id: name, names },
-                   'Ambiguous wildcard, select $(ID) explicitly with $(NAMES)' );
-          }
+  // col ($replacement set before *)
+  // false if two cols have same name
+  function wildcardSiblings( columns, query ) {
+    const siblings = Object.create(null);
+    if (!columns)
+      return siblings;
+
+    let seenWildcard = null;
+    for (const col of columns) {
+      const id = ensureColumnName( col, query );
+      if (id) {
+        col.$replacement = !seenWildcard;
+        siblings[id] = !(id in siblings) && col;
+      }
+      else if (col.val === '*') {
+        seenWildcard = true;
+      }
+    }
+    return siblings;
+  }
+
+  // TODO: make struct.* are to be added at place, not sub-wildcards first,
+  // see test3/Queries/ExpandInlineCreate/Excluding.cds
+  // TODO: disallow $self.elem.* and $self.*, toSelf.* (circular dependency)
+  function expandWildcard( wildcard, siblingElements, colParent, query ) {
+    const { elements } = query.items || query;
+    let location = wildcard.location || query.from && query.from.location || query.location;
+    const inferred = query._main.$inferred;
+    const excludingDict = (colParent || query).excludingDict || Object.create(null);
+
+    const envParent = wildcard._pathHead; // TODO: rename _pathHead to _pathEnv
+    // console.log('S1:',location.line,location.col,
+    //             envParent&&!!envParent._origin&&envParent._origin.name)
+    const env = columnEnv( envParent, query );
+    // console.log('S2:',location.line,location.col,
+    //             envParent&&!!envParent._origin&&envParent._origin.name,
+    //             Object.keys(env),Object.keys(elements))
+    for (const name in env) {
+      const navElem = env[name];
+      // TODO: if it is an array, filter out those with masked
+      if (excludingDict[name] || navElem.masked && navElem.masked.val)
+        continue;
+      const sibling = siblingElements[name];
+      if (sibling) {          // is explicitly provided (without duplicate)
+        if (!inferred && !envParent) // not yet for expand/inline
+          reportReplacement( sibling, navElem, query );
+        if (!sibling.$replacement) {
+          sibling.$replacement = true;
+          sibling.kind = 'element';
+          dictAdd( elements, name, sibling, ( _name, loc ) => {
+            // there can be a definition from a previous inline with the same name:
+            error( 'duplicate-definition', [ loc, query ], { name, '#': 'element' } );
+          });
+          setMemberParent( sibling, name, query );
         }
-        else {
-          location = weakLocation( location );
-          const origin = envParent ? navElem : navElem._origin;
-          const elem = linkToOrigin( origin, name, query, 'elements', location );
-          elem.$inferred = '*';
-          elem.name.$inferred = '*';
-          if (envParent)
-            setWildcardExpandInline( elem, envParent, origin, name, location );
-          else
-            setElementOrigin( elem, navElem, name, location );
+        // else {
+        //   sibling.$inferred = 'query';
+        // }
+      }
+      else if (Array.isArray(navElem)) {
+        const names = navElem.filter( e => !e.$duplicates)
+          .map( e => `${ e.name.alias }.${ e.name.element }` );
+        if (names.length) {
+          error( 'wildcard-ambiguous', [ location, query ], { id: name, names },
+                 'Ambiguous wildcard, select $(ID) explicitly with $(NAMES)' );
         }
       }
-      forEachInOrder( { elements }, 'elements', (elem, name) => {
-        if (!elem.$replacement)
-          dictAdd( elemsParent.elements, name, elem );
-      });
-      if (envParent || query.kind !== 'select') {
-        // already done in populateQuery (TODO: change that and check whether
-        // `*` is allowed at all in definer)
-        const user = colParent || query;
-        for (const name in user.excludingDict)
-          resolveExcluding( name, env, excludingDict, query );
+      else {
+        location = weakLocation( location );
+        const origin = envParent ? navElem : navElem._origin;
+        const elem = linkToOrigin( origin, name, query, null, location );
+        // TODO: check assocToMany { * }
+        dictAdd( elements, name, elem, ( _name, loc ) => {
+          // there can be a definition from a previous inline with the same name:
+          error( 'duplicate-definition', [ loc, query ], { name, '#': 'element' } );
+        });
+        elem.$inferred = '*';
+        elem.name.$inferred = '*';
+        if (envParent)
+          setWildcardExpandInline( elem, envParent, origin, name, location );
+        else
+          setElementOrigin( elem, navElem, name, location );
+      }
+    }
+    if (envParent || query.kind !== 'select') {
+      // already done in populateQuery (TODO: change that and check whether
+      // `*` is allowed at all in definer)
+      const user = colParent || query;
+      for (const name in user.excludingDict)
+        resolveExcluding( name, env, excludingDict, query );
+    }
+  }
+
+  function reportReplacement( sibling, navElem, query ) {
+    // TODO: bring this much less often = only if shadowed elem does not appear
+    // in expr and if not projected as other name.
+    // Probably needs to be reported at a later phase
+    const path = sibling.value && sibling.value.path;
+    if (!sibling.target || sibling.target.$inferred || // not explicit REDIRECTED TO
+        path && path[path.length - 1].id !== sibling.name.id) { // or renamed
+      const { id } = sibling.name;
+      if (Array.isArray(navElem)) {
+        info( 'wildcard-excluding-many', [ sibling.name.location, query ], { id },
+              'This select item replaces $(ID) from two or more sources' );
+      }
+      else {
+        info( 'wildcard-excluding-one', [ sibling.name.location, query ],
+              { id, alias: navElem._parent.name.id },
+              'This select item replaces $(ID) from table alias $(ALIAS)' );
       }
     }
   }
@@ -1378,6 +1441,7 @@ function resolve( model ) {
     }
     // Resolve projections/views
     // if (art.query)console.log( info( null, [art.query.location,art.query], 'VQ:' ).toString() );
+    // TODO: here, any order should be ok, i.e. just loop over $queries
     traverseQueryPost( art.query, false, resolveQuery );
 
     if (obj.type || obj._origin || obj.value && obj.value.path || obj.elements) // typed artifacts
@@ -1523,14 +1587,28 @@ function resolve( model ) {
       }
     }
     if (art && art._annotate) {
-      if (art.$expand && art._annotate.elements)
-        art.$expand = 'annotate'; // do not omit expanded elements when they are annotated
-      // TODO: returns
-      let obj = art.returns || art; // why the extra `returns` for actions?
-      obj = obj.items || obj;
+      if (art.kind === 'action' || art.kind === 'function') {
+        expandParameters( art );
+        if (art.returns)
+          effectiveType( art.returns );
+      }
+      const aor = art.returns || art;
+      const obj = aor.items || aor.targetAspect || aor;
+      // Currently(?), effectiveType() does not calculate the effective type of
+      // its line item:
+      effectiveType( obj );
+      if (art._annotate.elements)
+        setExpandStatusAnnotate( aor, 'annotate' );
       annotate( obj, 'element', 'elements', 'enum', art );
       annotate( art, 'action', 'actions' );
       annotate( art, 'param', 'params' );
+      // const { returns } = art._annotate;
+      // if (returns) {
+      //   const dict = returns.elements;
+      //   const env = obj.returns && obj.returns.elements || null;
+      //   for (const n in dict)
+      //     annotateMembers( env && env[n], dict[n], 'elements', n, parent, 'element' );
+      // }
     }
     return;
 
@@ -1548,6 +1626,42 @@ function resolve( model ) {
         annotateMembers( env && env[n], dict[n], prop, n, parent, kind );
     }
   }
+  function expandParameters( action ) {
+    // see also expandElements()
+    if (!enableExpandElements || !effectiveType( action ))
+      return;
+    const chain = [];
+    // Should we be able to consider params and returns separately?
+    // Probably not, let to-csn omit unchanged params/returns.
+    while (action._origin && !action.params) {
+      chain.push( action );
+      action = action._origin;
+    }
+    chain.reverse();
+    for (const art of chain) {
+      const origin = art._origin;
+      if (!art.params && origin.params) {
+        for (const name in origin.params) {
+          // TODO: we could check _annotate here to decide whether we really
+          // not to create proxies
+          const orig = origin.params[name];
+          linkToOrigin( orig, name, art, 'params', weakLocation( orig.location ), true )
+            .$inferred = 'expand-param';
+        }
+      }
+      if (!art.returns && origin.returns) {
+        // TODO: make linkToOrigin() work for returns, kind/name?
+        const location = weakLocation( origin.returns.location );
+        art.returns = {
+          name: Object.assign( {}, art.name, { id: '', param: '', location } ),
+          kind: 'param',
+          location,
+          $inferred: 'expand-param',
+        };
+        setProp( art.returns, '_origin', origin.returns );
+      }
+    }
+  }
 
   function extensionFor( art ) {
     if (art.kind === 'annotate')
@@ -1586,6 +1700,8 @@ function resolve( model ) {
     ext.kind = 'annotate';    // after setMemberParent()!
     setProp( art, '_extension', ext );
     setProp( ext.name, '_artifact', art );
+    if (art.returns)
+      ext.$syntax = 'returns';
     return ext;
   }
 
@@ -1761,8 +1877,11 @@ function resolve( model ) {
         // pure path has been resolved, resolve args and filter now:
         resolveExpr( alias, 'from', query._parent );
     } );
+    for (const col of query.$inlines)
+      resolveExpr( col.value, 'expr', col, undefined, true );
+    // for (const col of query.$inlines)
+    //   if (!col.value.path) throw Error(col.name.element)
     if (query !== query._main._leadingQuery) // will be done later
-      // TODO: rethink elements(view) === elements(view._leadingQuery)
       forEachGeneric( query, 'elements', resolveRefs );
     if (query.from)
       resolveJoinOn( query.from );
@@ -1786,7 +1905,7 @@ function resolve( model ) {
     return;
 
     function resolveJoinOn( join ) {
-      if (join.args) {             // JOIN
+      if (join && join.args) {  // JOIN
         for (const j of join.args)
           resolveJoinOn( j );
         if (join.on)
@@ -1823,7 +1942,10 @@ function resolve( model ) {
     }
     const target = resolvePath( obj.target, 'target', art );
     if (obj.on) {
-      if (!art._main || !art._parent.elements && !art._parent.items) {
+      if (!art._main || !art._parent.elements && !art._parent.items && !art._parent.targetAspect) {
+        // TODO: test of .items a bit unclear - we should somehow restrict the
+        // use of unmanaged assocs in MANY, at least with $self
+        // TODO: $self usage in anonymous aspects to be corrected in Core Compiler
         const isComposition = obj.type && obj.type.path && obj.type.path[0] &&
                               obj.type.path[0].id === 'cds.Composition';
         message( 'assoc-as-type', [ obj.on.location, art ],
@@ -2264,6 +2386,9 @@ function resolve( model ) {
 
   // TODO: there is no need to rewrite the on condition of non-leading queries,
   // i.e. we could just have on = {…}
+  // TODO: re-check $self rewrite (with managed composition of aspects),
+  // and actually also $self inside anonymous aspect definitions
+  // (not entirely urgent as we do not analyse it further, at least sole "$self")
   function rewriteCondition( elem, assoc ) {
     if (enableExpandElements && elem._parent && elem._parent.kind === 'element') {
       // managed association as sub element not supported yet
@@ -2515,12 +2640,18 @@ function resolve( model ) {
       const args = Array.isArray(expr.args) ? expr.args : Object.values( expr.args );
       args.forEach( e => e && resolveExpr( e, e.$expected || expected, user, extDict ) );
     }
+    if (expr.suffix && !isBetaEnabled( options, 'windowFunctions' )) {
+      const { location } = expr.suffix[0] || expr;
+      error( null, [ location, user ], 'Window functions are not supported' );
+    }
+    if (expr.suffix)
+      expr.suffix.forEach( s => s && resolveExpr( s, expected, user, extDict ) );
   }
 
   function resolveParamsAndWhere( step, expected, user, extDict, isLast ) {
     const alias = step._navigation && step._navigation.kind === '$tableAlias' && step._navigation;
     const type = alias || effectiveType( step._artifact );
-    const art = type && type.target && type.target._artifact || type;
+    const art = (type && type.target) ? type.target._artifact : type;
     if (!art)
       return;
     const entity = (art.kind === 'entity') &&
@@ -2531,7 +2662,7 @@ function resolve( model ) {
       if (step.where)
         resolveExpr( step.where, 'filter', user, environment( type ) );
     }
-    else if (step.where || step.cardinality ) {
+    else if (step.where && step.where.location || step.cardinality ) {
       const location = combinedLocation( step.where, step.cardinality );
       // XSN TODO: filter$location including […]
       message( 'expr-no-filter', [ location, user ], { '#': expected },