@sap/cds-compiler 2.12.0 → 2.13.6

package/lib/compiler/assert-consistency.js

@@ -298,6 +298,7 @@ function assertConsistency( model, stage ) {
     },
     expand: { kind: [ 'element' ], inherits: 'columns' },
     inline: { kind: [ 'element' ], inherits: 'columns' },
+    $noOrigin: { kind: [ 'element' ], test: TODO },
     excludingDict: {
       kind: 'element',
       test: isDictionary( definition ), // definition since redef
@@ -325,8 +326,8 @@ function assertConsistency( model, stage ) {
       kind: true,
       requires: [ 'location' ],
       optional: [
-        'path', 'elements', '_outer',
-        'scope', '_artifact', '$inferred', '$expand',
+        'path', 'elements', '_outer', '_parent', '_main', '_block', 'kind',
+        'scope', '_artifact', '$inferred', '$expand', '$tableAliases', '_$next',
         '_effectiveType',           // by propagation
       ],
     },
@@ -641,7 +642,8 @@ function assertConsistency( model, stage ) {
    * and `localized` namespaces.
    */
   function builtin( node, parent, prop, spec, name ) {
-    if (![ 'string', 'boolean' ].includes(typeof node))
+    const type = typeof node;
+    if (type !== 'string' && type !== 'boolean')
       throw new Error(`Property '${ prop }' must be a boolean or string but was '${ typeof node }'${ at( [ node, parent ], prop, name ) }` );
 
     if (parent.kind !== 'namespace')

package/lib/compiler/builtins.js

@@ -1,9 +1,14 @@
 // The builtin artifacts of CDS
 
+// TODO: split this file
+// - in base/: common definitions
+// - in compiler/: XSN-specific
+// - in ?: CSN-specific
+
 'use strict';
 
 const { builtinLocation } = require('../base/location');
-const { setProp } = require('./utils');
+const { setLink: setProp } = require('./utils');
 
 const core = {
   String: { parameters: [ 'length' ], category: 'string' },
@@ -56,7 +61,6 @@ const coreHana = {
  * (do not add more - make it part of the SQL renderer to remove parentheses for
  * other funny SQL functions like CURRENT_UTCTIMESTAMP).
  */
-
 const functionsWithoutParens = [
   'CURRENT_DATE', 'CURRENT_TIME', 'CURRENT_TIMESTAMP',
   'CURRENT_USER', 'SESSION_USER', 'SYSTEM_USER',
@@ -176,7 +180,8 @@ function isRelationTypeName(typeName) {
 function isInReservedNamespace(absolute) {
   return absolute.startsWith( 'cds.') &&
     !absolute.match(/^cds\.foundation(\.|$)/) &&
-    !absolute.match(/^cds\.outbox(\.|$)/); // Requested by Node runtime
+    !absolute.match(/^cds\.outbox(\.|$)/) && // Requested by Node runtime
+    !absolute.match(/^cds\.xt(\.|$)/); // Requested by Mtx
 }
 
 /**
@@ -214,9 +219,6 @@ function initBuiltins( model ) {
   model.$builtins.hana = hana;
   cds._subArtifacts.hana = hana;
   env( coreHana, 'cds.hana.', hana );
-  // namespace:"localized" stores localized convenience views ---
-  const localized = createNamespace( 'localized', true );
-  model.definitions.localized = localized;
   model.$internal = { $frontend: '$internal' };
   return;
 

package/lib/compiler/checks.js

@@ -459,6 +459,10 @@ function check( model ) {       // = XSN
    * Check whether the argument count of the given path expression matches its artifact.
    * If there is a mismatch, an error is issued.
    *
+   * TODO: remove this function - it also checks for parameter in type
+   * references.  We could have a warning, see also configurable errors
+   * 'args-no-params', 'args-undefined-param'.
+   *
    * @param {object} pathStep The expression to check
    */
   function checkPathForMissingArguments(pathStep) {
@@ -494,8 +498,15 @@ function check( model ) {       // = XSN
 
       const missingArgs = [];
       for (const fAName in formalArgs) {
-        if (!actualArgs[fAName] && !formalArgs[fAName].default)
-          missingArgs.push(fAName);
+        if (!actualArgs[fAName]) {
+          // Note: _effectiveType points to cds.String for `type T : DefaultString`.
+          //       And `default` may appear at any `type` in the hierarchy.
+          let fArg = formalArgs[fAName];
+          while (fArg.type && !fArg.default)
+            fArg = fArg.type._artifact;
+          if (!fArg.default)
+            missingArgs.push(fAName);
+        }
       }
 
       if (missingArgs.length) {
@@ -635,7 +646,7 @@ function check( model ) {       // = XSN
     return checkTreeLikeExpression(xpr, allowAssocTail);
   }
   /**
-   * Check wether the supplied argument is a virtual element
+   * Check whether the supplied argument is a virtual element
    *
    * TO CLARIFY: do we want the "no virtual element" check for virtual elements/columns, too?
    *

package/lib/compiler/cycle-detector.js

@@ -16,7 +16,7 @@
 
 'use strict';
 
-const { setProp } = require('../base/model');
+const { setLink: setProp } = require('./utils'); // check enum/non-enum
 
 // Detect cyclic dependencies between all nodes reachable from `definitions`.
 // If such a dependency is found, call `reportCycle` with arguments `dep.art`