@sap/cds-compiler 2.11.4 → 2.13.8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (133) hide show
  1. package/CHANGELOG.md +159 -1
  2. package/bin/cds_update_identifiers.js +7 -7
  3. package/bin/cdsc.js +22 -23
  4. package/bin/cdsse.js +2 -2
  5. package/doc/CHANGELOG_ARCHIVE.md +1 -1
  6. package/doc/CHANGELOG_BETA.md +25 -6
  7. package/doc/CHANGELOG_DEPRECATED.md +22 -6
  8. package/doc/NameResolution.md +21 -16
  9. package/lib/api/main.js +30 -63
  10. package/lib/api/options.js +5 -5
  11. package/lib/api/validate.js +0 -5
  12. package/lib/backends.js +15 -23
  13. package/lib/base/dictionaries.js +0 -8
  14. package/lib/base/error.js +26 -0
  15. package/lib/base/keywords.js +7 -17
  16. package/lib/base/location.js +9 -4
  17. package/lib/base/message-registry.js +52 -2
  18. package/lib/base/messages.js +16 -26
  19. package/lib/base/model.js +2 -62
  20. package/lib/base/optionProcessorHelper.js +246 -183
  21. package/lib/checks/.eslintrc.json +2 -0
  22. package/lib/checks/actionsFunctions.js +2 -1
  23. package/lib/checks/annotationsOData.js +1 -1
  24. package/lib/checks/cdsPersistence.js +2 -1
  25. package/lib/checks/enricher.js +17 -1
  26. package/lib/checks/foreignKeys.js +4 -4
  27. package/lib/checks/invalidTarget.js +3 -1
  28. package/lib/checks/managedInType.js +4 -4
  29. package/lib/checks/managedWithoutKeys.js +3 -1
  30. package/lib/checks/queryNoDbArtifacts.js +1 -3
  31. package/lib/checks/selectItems.js +4 -4
  32. package/lib/checks/sql-snippets.js +94 -0
  33. package/lib/checks/types.js +1 -1
  34. package/lib/checks/validator.js +12 -7
  35. package/lib/compiler/assert-consistency.js +10 -6
  36. package/lib/compiler/base.js +0 -1
  37. package/lib/compiler/builtins.js +8 -6
  38. package/lib/compiler/checks.js +46 -12
  39. package/lib/compiler/cycle-detector.js +1 -1
  40. package/lib/compiler/define.js +1103 -0
  41. package/lib/compiler/extend.js +983 -0
  42. package/lib/compiler/finalize-parse-cdl.js +231 -0
  43. package/lib/compiler/index.js +33 -14
  44. package/lib/compiler/kick-start.js +190 -0
  45. package/lib/compiler/moduleLayers.js +4 -4
  46. package/lib/compiler/populate.js +1226 -0
  47. package/lib/compiler/propagator.js +113 -47
  48. package/lib/compiler/resolve.js +1433 -0
  49. package/lib/compiler/shared.js +76 -38
  50. package/lib/compiler/tweak-assocs.js +529 -0
  51. package/lib/compiler/utils.js +204 -33
  52. package/lib/edm/.eslintrc.json +5 -0
  53. package/lib/edm/annotations/genericTranslation.js +38 -25
  54. package/lib/edm/annotations/preprocessAnnotations.js +3 -3
  55. package/lib/edm/csn2edm.js +10 -9
  56. package/lib/edm/edm.js +19 -20
  57. package/lib/edm/edmPreprocessor.js +166 -95
  58. package/lib/edm/edmUtils.js +127 -34
  59. package/lib/gen/Dictionary.json +92 -43
  60. package/lib/gen/language.checksum +1 -1
  61. package/lib/gen/language.interp +11 -1
  62. package/lib/gen/language.tokens +86 -82
  63. package/lib/gen/languageLexer.interp +18 -1
  64. package/lib/gen/languageLexer.js +925 -847
  65. package/lib/gen/languageLexer.tokens +78 -74
  66. package/lib/gen/languageParser.js +5434 -4298
  67. package/lib/json/from-csn.js +59 -17
  68. package/lib/json/to-csn.js +143 -71
  69. package/lib/language/antlrParser.js +3 -3
  70. package/lib/language/docCommentParser.js +3 -3
  71. package/lib/language/genericAntlrParser.js +144 -54
  72. package/lib/language/language.g4 +424 -203
  73. package/lib/language/multiLineStringParser.js +536 -0
  74. package/lib/main.d.ts +472 -61
  75. package/lib/main.js +38 -11
  76. package/lib/model/api.js +3 -1
  77. package/lib/model/csnRefs.js +321 -204
  78. package/lib/model/csnUtils.js +224 -263
  79. package/lib/model/enrichCsn.js +97 -40
  80. package/lib/model/revealInternalProperties.js +27 -6
  81. package/lib/model/sortViews.js +2 -1
  82. package/lib/modelCompare/compare.js +17 -12
  83. package/lib/optionProcessor.js +7 -6
  84. package/lib/render/DuplicateChecker.js +1 -1
  85. package/lib/render/manageConstraints.js +36 -33
  86. package/lib/render/toCdl.js +174 -275
  87. package/lib/render/toHdbcds.js +201 -115
  88. package/lib/render/toRename.js +7 -10
  89. package/lib/render/toSql.js +149 -75
  90. package/lib/render/utils/common.js +22 -8
  91. package/lib/render/utils/sql.js +10 -7
  92. package/lib/render/utils/stringEscapes.js +111 -0
  93. package/lib/sql-identifier.js +1 -1
  94. package/lib/transform/.eslintrc.json +5 -0
  95. package/lib/transform/braceExpression.js +4 -2
  96. package/lib/transform/db/.eslintrc.json +2 -0
  97. package/lib/transform/db/applyTransformations.js +35 -12
  98. package/lib/transform/db/assertUnique.js +1 -1
  99. package/lib/transform/db/associations.js +187 -0
  100. package/lib/transform/db/cdsPersistence.js +150 -0
  101. package/lib/transform/db/constraints.js +61 -56
  102. package/lib/transform/db/expansion.js +50 -29
  103. package/lib/transform/db/flattening.js +552 -105
  104. package/lib/transform/db/groupByOrderBy.js +3 -1
  105. package/lib/transform/db/temporal.js +236 -0
  106. package/lib/transform/db/transformExists.js +94 -28
  107. package/lib/transform/db/views.js +5 -4
  108. package/lib/transform/draft/.eslintrc.json +38 -0
  109. package/lib/transform/{db/draft.js → draft/db.js} +9 -7
  110. package/lib/transform/draft/odata.js +227 -0
  111. package/lib/transform/forHanaNew.js +94 -801
  112. package/lib/transform/forOdataNew.js +22 -175
  113. package/lib/transform/localized.js +36 -32
  114. package/lib/transform/odata/generateForeignKeyElements.js +3 -3
  115. package/lib/transform/odata/referenceFlattener.js +95 -89
  116. package/lib/transform/odata/structureFlattener.js +1 -1
  117. package/lib/transform/odata/toFinalBaseType.js +86 -12
  118. package/lib/transform/odata/typesExposure.js +5 -5
  119. package/lib/transform/odata/utils.js +2 -2
  120. package/lib/transform/transformUtilsNew.js +47 -33
  121. package/lib/transform/translateAssocsToJoins.js +10 -27
  122. package/lib/transform/universalCsn/.eslintrc.json +36 -0
  123. package/lib/transform/universalCsn/coreComputed.js +170 -0
  124. package/lib/transform/universalCsn/universalCsnEnricher.js +715 -0
  125. package/lib/transform/universalCsn/utils.js +63 -0
  126. package/lib/utils/file.js +2 -1
  127. package/lib/utils/objectUtils.js +30 -0
  128. package/lib/utils/timetrace.js +8 -2
  129. package/package.json +1 -1
  130. package/share/messages/README.md +26 -0
  131. package/lib/compiler/definer.js +0 -2340
  132. package/lib/compiler/resolver.js +0 -2988
  133. package/lib/transform/universalCsnEnricher.js +0 -67
package/lib/api/main.js CHANGED
@@ -35,6 +35,7 @@ const propertyToCheck = {
35
35
 
36
36
  const { cloneCsn } = require('../model/csnUtils');
37
37
  const { toHdbcdsSource } = require('../render/toHdbcds');
38
+ const { ModelError } = require('../base/error');
38
39
 
39
40
  const relevantGeneralOptions = [ /* for future generic options */ ];
40
41
  const relevantOdataOptions = [ 'sqlMapping', 'odataFormat' ];
@@ -115,7 +116,7 @@ function checkPreTransformedCsn(csn, options, relevantOptionNames, warnAboutMism
115
116
  * @returns {boolean} Return true if it is pre-transformed
116
117
  */
117
118
  function isPreTransformed(csn, transformation) {
118
- return csn.meta && csn.meta.transformation === transformation;
119
+ return csn && csn.meta && csn.meta.transformation === transformation;
119
120
  }
120
121
 
121
122
  /**
@@ -165,6 +166,7 @@ function cdl(csn, externalOptions = {}) {
165
166
  */
166
167
  function forSql(csn, options = {}) {
167
168
  const internalOptions = prepareOptions.to.sql(options);
169
+ internalOptions.transformation = 'sql';
168
170
  internalOptions.toSql.csn = true;
169
171
  return backends.toSqlWithCsn(csn, internalOptions).csn;
170
172
  }
@@ -172,7 +174,7 @@ function forSql(csn, options = {}) {
172
174
  * Transform a CSN like to.hdi
173
175
  *
174
176
  * @param {CSN.Model} csn Plain input CSN
175
- * @param {hdiOptions} [options={}] Options
177
+ * @param {HdiOptions} [options={}] Options
176
178
  * @returns {CSN.Model} CSN transformed like to.hdi
177
179
  * @private
178
180
  */
@@ -185,7 +187,7 @@ function forHdi(csn, options = {}) {
185
187
  * Transform a CSN like to.hdbcds
186
188
  *
187
189
  * @param {CSN.Model} csn Plain input CSN
188
- * @param {hdbcdsOptions} [options={}] Options
190
+ * @param {HdbcdsOptions} [options={}] Options
189
191
  * @returns {CSN.Model} CSN transformed like to.hdbcds
190
192
  * @private
191
193
  */
@@ -207,6 +209,7 @@ function forHdbcds(csn, options = {}) {
207
209
  */
208
210
  function sql(csn, options = {}) {
209
211
  const internalOptions = prepareOptions.to.sql(options);
212
+ internalOptions.transformation = 'sql';
210
213
 
211
214
  // we need the CSN for view sorting
212
215
  internalOptions.toSql.csn = true;
@@ -222,7 +225,7 @@ function sql(csn, options = {}) {
222
225
  * Process the given CSN into HDI artifacts.
223
226
  *
224
227
  * @param {CSN.Model} csn A clean input CSN
225
- * @param {hdiOptions} [options={}] Options
228
+ * @param {HdiOptions} [options={}] Options
226
229
  * @returns {HDIArtifacts} { <filename>:<content>, ...}
227
230
  */
228
231
  function hdi(csn, options = {}) {
@@ -245,19 +248,19 @@ function hdi(csn, options = {}) {
245
248
  const flat = flattenResultStructure(intermediateResult);
246
249
 
247
250
  const nameMapping = Object.create(null);
248
- const sqlsWithCSNNamesToSort = Object.create(null);
249
- const sqlsNotToSort = Object.create(null);
251
+ const sqlArtifactsWithCSNNamesToSort = Object.create(null);
252
+ const sqlArtifactsNotToSort = Object.create(null);
250
253
 
251
254
  Object.keys(flat).forEach((key) => {
252
255
  const artifactNameLikeInCsn = key.replace(/\.[^/.]+$/, '');
253
256
  nameMapping[artifactNameLikeInCsn] = key;
254
257
  if (key.endsWith('.hdbtable') || key.endsWith('.hdbview'))
255
- sqlsWithCSNNamesToSort[artifactNameLikeInCsn] = flat[key];
258
+ sqlArtifactsWithCSNNamesToSort[artifactNameLikeInCsn] = flat[key];
256
259
  else
257
- sqlsNotToSort[key] = flat[key];
260
+ sqlArtifactsNotToSort[key] = flat[key];
258
261
  });
259
262
 
260
- const sorted = sortViews({ sql: sqlsWithCSNNamesToSort, csn: sqlCSN })
263
+ const sorted = sortViews({ sql: sqlArtifactsWithCSNNamesToSort, csn: sqlCSN })
261
264
  .filter(obj => obj.sql)
262
265
  .reduce((previous, current) => {
263
266
  const hdiArtifactName = remapName(nameMapping[current.name], sqlCSN, k => !k.endsWith('.hdbindex'));
@@ -265,9 +268,9 @@ function hdi(csn, options = {}) {
265
268
  return previous;
266
269
  }, Object.create(null));
267
270
 
268
- // now add the not-sorted stuff, like indizes
269
- Object.keys(sqlsNotToSort).forEach((key) => {
270
- sorted[remapName(key, sqlCSN, k => !k.endsWith('.hdbindex'))] = sqlsNotToSort[key];
271
+ // now add the not-sorted stuff, like indices
272
+ Object.keys(sqlArtifactsNotToSort).forEach((key) => {
273
+ sorted[remapName(key, sqlCSN, k => !k.endsWith('.hdbindex'))] = sqlArtifactsNotToSort[key];
271
274
  });
272
275
 
273
276
  return sorted;
@@ -323,7 +326,7 @@ function remapName(key, csn, filter = () => true) {
323
326
  * Note: Only supports changes in entities (not views etc.) compiled/rendered as HANA-CSN/SQL.
324
327
  *
325
328
  * @param {CSN.Model} csn A clean input CSN representing the desired "after-image"
326
- * @param {hdiOptions} options Options
329
+ * @param {HdiOptions} options Options
327
330
  * @param {CSN.Model} beforeImage A HANA-transformed CSN representing the "before-image", or null in case no such image
328
331
  * is known, i.e. for the very first migration step
329
332
  * @returns {object} - afterImage: The desired after-image in HANA-CSN format
@@ -344,8 +347,8 @@ function hdiMigration(csn, options, beforeImage) {
344
347
  * This is for backward compatibility with @sap/cds@4.5.(2…3).
345
348
  *
346
349
  * @todo Remove in cds-compiler@2.x
347
- * @param {hdiOptions|CSN.Model} inputOptions Options or CSN image
348
- * @param {CSN.Model|hdiOptions} inputBeforeImage CSN image or options
350
+ * @param {HdiOptions|CSN.Model} inputOptions Options or CSN image
351
+ * @param {HdiOptions|CSN.Model} inputBeforeImage CSN image or options
349
352
  * @returns {Array} Array where the real options come first
350
353
  */
351
354
  function backwardCompatible(inputOptions, inputBeforeImage) {
@@ -436,7 +439,7 @@ hdi.migration = hdiMigration;
436
439
  * Process the given CSN into HDBCDS artifacts.
437
440
  *
438
441
  * @param {any} csn A clean input CSN
439
- * @param {hdbcdsOptions} [options={}] Options
442
+ * @param {HdbcdsOptions} [options={}] Options
440
443
  * @returns {HDBCDS} { <filename>:<content>, ...}
441
444
  */
442
445
  function hdbcds(csn, options = {}) {
@@ -641,12 +644,18 @@ function publishCsnProcessor( processor, _name ) {
641
644
  return processor( csn, options, ...args );
642
645
  }
643
646
  catch (err) {
644
- if (err instanceof CompilationError || options.noRecompile)
645
- // options.testMode && err instanceof RangeError) // stack overflow
647
+ if (err instanceof CompilationError || options.noRecompile || isPreTransformed(csn, 'odata')) // we cannot recompile a pre-transformed CSN
648
+ throw err;
649
+
650
+ if (options.testMode && !(err instanceof TypeError) &&
651
+ !(err instanceof ModelError))
646
652
  throw err;
647
653
 
648
654
  const { info } = makeMessageFunction( csn, options, 'compile' );
649
- info( 'api-recompiled-csn', emptyLocation('csn.json'), {}, 'CSN input had to be recompiled' );
655
+ const msg = info( 'api-recompiled-csn', emptyLocation('csn.json'), {}, 'CSN input had to be recompiled' );
656
+ if (options.internalMsg)
657
+ msg.error = err; // Attach original error
658
+
650
659
  // next line to be replaced by CSN parser call which reads the CSN object
651
660
  const xsn = recompileX(csn, options);
652
661
  const recompiledCsn = compactModel(xsn);
@@ -680,12 +689,6 @@ function publishCsnProcessor( processor, _name ) {
680
689
  * @typedef {'plain' | 'quoted' | 'hdbcds' } NamingMode
681
690
  */
682
691
 
683
- /**
684
- * Available SQL change modes
685
- *
686
- * @typedef {'alter' | 'drop' } SqlChangeMode
687
- */
688
-
689
692
  /**
690
693
  * Available oData versions
691
694
  *
@@ -698,42 +701,6 @@ function publishCsnProcessor( processor, _name ) {
698
701
  * @typedef { 'structured' | 'flat' } oDataFormat
699
702
  */
700
703
 
701
- /**
702
- * Generally available options
703
- *
704
- * @typedef {object} Options
705
- * @property {object} [beta] Enable experimental features - not for productive use!
706
- * @property {boolean} [dependentAutoexposed=false] For dependent autoexposed entities (managed compositions, texts entity), follow name of base entity
707
- * @property {boolean} [longAutoexposed=false] Deprecated: Produce long names (with underscores) for autoexposed entities
708
- * @property {Map<string, number>} [severities={}] Map of message-id and severity that allows setting the severity for the given message
709
- * @property {Array} [messages] Allows collecting all messages in the options instead of printing them to stderr.
710
- */
711
-
712
- /**
713
- * Options available for to.hdi
714
- *
715
- * @typedef {object} hdiOptions
716
- * @property {NamingMode} [sqlMapping='plain'] Naming mode to use
717
- * @property {SqlChangeMode} [sqlChangeMode='alter'] SQL change mode to use (for changed columns)
718
- * @property {boolean} [allowCsnDowngrade=false] Allow downgrades of CSN major version (for modelCompare)
719
- * @property {object} [beta] Enable experimental features - not for productive use!
720
- * @property {boolean} [longAutoexposed=false] Deprecated: Produce long names (with underscores) for autoexposed entities
721
- * @property {Map<string, number>} [severities={}] Map of message-id and severity that allows setting the severity for the given message
722
- * @property {Array} [messages] Allows collecting all messages in the options instead of printing them to stderr.
723
- */
724
-
725
- /**
726
- * Options available for to.hdbcds
727
- *
728
- * @typedef {object} hdbcdsOptions
729
- * @property {NamingMode} [sqlMapping='plain'] Naming mode to use
730
- * @property {object} [beta] Enable experimental features - not for productive use!
731
- * @property {boolean} [longAutoexposed=false] Deprecated: Produce long names (with underscores) for autoexposed entities
732
- * @property {Map<string, number>} [severities={}] Map of message-id and severity that allows setting the severity for the given message
733
- * @property {Array} [messages] Allows collecting all messages in the options instead of printing them to stderr.
734
- */
735
-
736
-
737
704
  /**
738
705
  * A fresh (just compiled, not transformed) CSN
739
706
  *
@@ -753,13 +720,13 @@ function publishCsnProcessor( processor, _name ) {
753
720
  */
754
721
 
755
722
  /**
756
- * A map of { <file.hdbcds>:<content> }.
723
+ * A map of { <file.hdbcds|hdbconstraint>:<content> }.
757
724
  *
758
725
  * @typedef {object} HDBCDS
759
726
  */
760
727
 
761
728
  /**
762
- * A map of { <file.hdbtable/view...>:<content> }.
729
+ * A map of { <file.hdbtable|hdbview|hdbconstraint...>:<content> }.
763
730
  *
764
731
  * @typedef {object} HDIArtifacts
765
732
  */
@@ -49,7 +49,7 @@ const privateOptions = [
49
49
  'traceParserAmb',
50
50
  'testMode',
51
51
  'testSortCsn',
52
- 'constraintsAsAlter',
52
+ 'constraintsInCreateTable',
53
53
  'integrityNotEnforced',
54
54
  'integrityNotValidated',
55
55
  'assertIntegrity',
@@ -84,9 +84,9 @@ function translateOptions(input = {}, defaults = {}, hardRequire = {},
84
84
  for (const name of overallOptions) {
85
85
  // Ensure that arrays are not passed as a reference!
86
86
  // This caused issues with the way messages are handled in processMessages
87
- if (Array.isArray(input[name]) && inputOptionNames.indexOf(name) !== -1)
87
+ if (Array.isArray(input[name]) && inputOptionNames.includes(name))
88
88
  options[name] = [ ...input[name] ];
89
- else if (inputOptionNames.indexOf(name) !== -1)
89
+ else if (inputOptionNames.includes(name))
90
90
  options[name] = input[name];
91
91
  }
92
92
 
@@ -158,7 +158,7 @@ module.exports = {
158
158
  sql: (options) => {
159
159
  const hardOptions = { src: 'sql' };
160
160
  const defaultOptions = { sqlMapping: 'plain', sqlDialect: 'plain' };
161
- const processed = translateOptions(options, defaultOptions, hardOptions, undefined, [ 'sql-dialect-and-naming', 'constraints-as-alter-sqlite' ], 'to.sql');
161
+ const processed = translateOptions(options, defaultOptions, hardOptions, undefined, [ 'sql-dialect-and-naming' ], 'to.sql');
162
162
 
163
163
  const result = Object.assign({}, processed);
164
164
  result.toSql = Object.assign({}, processed);
@@ -166,7 +166,7 @@ module.exports = {
166
166
  return result;
167
167
  },
168
168
  hdi: (options) => {
169
- const hardOptions = { src: 'hdi', constraintsAsAlter: false };
169
+ const hardOptions = { src: 'hdi' };
170
170
  const defaultOptions = { sqlMapping: 'plain', sqlDialect: 'hana' };
171
171
  const processed = translateOptions(options, defaultOptions, hardOptions, { sqlDialect: generateStringValidator([ 'hana' ]) }, undefined, 'to.hdi');
172
172
 
@@ -142,11 +142,6 @@ const allCombinationValidators = {
142
142
  severity: 'warning',
143
143
  getMessage: () => 'Option "beta" was used. This option should not be used in productive scenarios!',
144
144
  },
145
- 'constraints-as-alter-sqlite': {
146
- validate: options => options.constraintsAsAlter && options.sqlDialect && options.sqlDialect === 'sqlite',
147
- severity: 'warning',
148
- getMessage: options => `Option 'constraintsAsAlter' is ignored for sqlDialect '${ options.sqlDialect }'`,
149
- },
150
145
  };
151
146
  /* eslint-disable jsdoc/no-undefined-types */
152
147
  /**
package/lib/backends.js CHANGED
@@ -279,7 +279,7 @@ function transformSQLOptions(model, options) {
279
279
 
280
280
  if(options.toSql.dialect !== 'hana') {
281
281
  // CDXCORE-465, 'quoted' and 'hdbcds' are to be used in combination with dialect 'hana' only
282
- if(['quoted', 'hdbcds'].includes(options.toSql.names)) {
282
+ if (options.toSql.names === 'quoted' || options.toSql.names === 'hdbcds') {
283
283
  error(null, null, `Option "{ toSql.dialect: '${options.toSql.dialect}' }" can't be combined with "{ toSql.names: '${options.toSql.names}' }"`);
284
284
  }
285
285
  // No non-HANA SQL for HDI
@@ -296,17 +296,17 @@ function transformSQLOptions(model, options) {
296
296
  // If among the options user, user.id or user.locale are specified via the CLI or
297
297
  // via the API, then ensure that at the end there is a user option, which is an object and has(have)
298
298
  // "id" and/or "locale" prop(s)
299
- function transformUserOption(options) {
299
+ function transformUserOption(userOptions) {
300
300
  // move the user option value under user.id if specified as a string
301
- if (options.user && typeof options.user === 'string' || options.user instanceof String) {
302
- options.user = { id: options.user };
301
+ if (userOptions.user && typeof userOptions.user === 'string' || userOptions.user instanceof String) {
302
+ userOptions.user = { id: userOptions.user };
303
303
  }
304
304
  // move the locale option(if provided) under user.locale
305
- if (options.locale) {
306
- options.user = options.user
307
- ? Object.assign(options.user, { locale: options.locale })
308
- : { locale: options.locale };
309
- delete options.locale;
305
+ if (userOptions.locale) {
306
+ userOptions.user = userOptions.user
307
+ ? Object.assign(userOptions.user, { locale: userOptions.locale })
308
+ : { locale: userOptions.locale };
309
+ delete userOptions.locale;
310
310
  }
311
311
  }
312
312
  }
@@ -389,7 +389,7 @@ function toRenameWithCsn(csn, options) {
389
389
  let forHanaCsn = transformForHanaWithCsn(csn, mergeOptions(options, { forHana : options.toRename } ), 'to.rename');
390
390
  // forHanaCsn looses empty contexts and services, add them again so that toRename can calculate the namespaces
391
391
  forEachDefinition(csn, (artifact, artifactName) => {
392
- if(['context', 'service'].includes(artifact.kind) && forHanaCsn.definitions[artifactName] === undefined) {
392
+ if((artifact.kind === 'context' || artifact.kind === 'service') && forHanaCsn.definitions[artifactName] === undefined) {
393
393
  forHanaCsn.definitions[artifactName] = artifact;
394
394
  }
395
395
  });
@@ -416,6 +416,10 @@ function alterConstraintsWithCsn(csn, options) {
416
416
  names: names || 'plain'
417
417
  }
418
418
 
419
+ // Also set new-style options
420
+ options.sqlDialect = 'hana';
421
+ options.sqlMapping = names || 'plain';
422
+
419
423
  // Of course we want the database constraints
420
424
  options.assertIntegrityType = 'DB';
421
425
 
@@ -432,19 +436,7 @@ function alterConstraintsWithCsn(csn, options) {
432
436
  else
433
437
  intermediateResult = manageConstraints(forSqlCsn, mergedOptions);
434
438
 
435
- if(options.testMode !== true)
436
- return intermediateResult;
437
-
438
- // if in testmode, return a string containing all the artifacts
439
- let resultString = '';
440
- const extension = src && src === 'hdi' ? 'hdbconstraint' : 'sql';
441
- for(const id in intermediateResult){
442
- const initialComment = `--$ --- ${id}.${extension} ---\n\n`;
443
- resultString += initialComment;
444
- resultString += intermediateResult[id];
445
- resultString += '\n\n'
446
- }
447
- return resultString;
439
+ return intermediateResult;
448
440
  }
449
441
 
450
442
  // ----------- toCsn -----------
@@ -89,17 +89,9 @@ function pushToDict( dict, name, entry ) {
89
89
  dict[name] = [entry];
90
90
  }
91
91
 
92
- function forEachInDict( dict, callback ) {
93
- let r = Object.create(null);
94
- for (let name of Object.keys(dict))
95
- r[name] = callback( dict[name], name, dict );
96
- return r;
97
- }
98
-
99
92
  module.exports = {
100
93
  dictAdd, dictForEach,
101
94
  dictAddArray,
102
95
  pushToDict,
103
- forEachInDict,
104
96
  }
105
97
 
@@ -0,0 +1,26 @@
1
+ 'use strict';
2
+
3
+ /**
4
+ * Use this class to indicate that an internal error was noticed.
5
+ * In testMode, these errors do _not_ trigger a recompilation.
6
+ */
7
+ class CompilerAssertion extends Error {
8
+ constructor(message) {
9
+ super(message);
10
+ }
11
+ }
12
+
13
+ /**
14
+ * Use this class to indicate that something with the input CSN is wrong,
15
+ * which will be caught by the core compiler through recompiling the sources.
16
+ */
17
+ class ModelError extends Error {
18
+ constructor(message) {
19
+ super(message);
20
+ }
21
+ }
22
+
23
+ module.exports = {
24
+ CompilerAssertion,
25
+ ModelError,
26
+ };
@@ -1,3 +1,7 @@
1
+ 'use strict';
2
+
3
+ const { functionsWithoutParens } = require("../compiler/builtins");
4
+
1
5
  module.exports = {
2
6
  // CDL reserved keywords, used for automatic quoting in 'toCdl' renderer
3
7
  // Keep in sync with reserved keywords in language.g4
@@ -30,21 +34,7 @@ module.exports = {
30
34
  ],
31
35
  // CDL functions, used for automatic quoting in 'toCdl' renderer,
32
36
  // only relevant for element references of path length 1.
33
- cdl_functions: [
34
- 'CURRENT_CONNECTION',
35
- 'CURRENT_DATE',
36
- 'CURRENT_SCHEMA',
37
- 'CURRENT_TIME',
38
- 'CURRENT_TIMESTAMP',
39
- 'CURRENT_TRANSACTION_ISOLATION_LEVEL',
40
- 'CURRENT_USER',
41
- 'CURRENT_UTCDATE',
42
- 'CURRENT_UTCTIME',
43
- 'CURRENT_UTCTIMESTAMP',
44
- 'SESSION_USER',
45
- 'SYSTEM_USER',
46
- 'SYSUUID',
47
- ],
37
+ cdl_functions: functionsWithoutParens,
48
38
  // SQLite keywords, used to warn in 'toSql' renderer with dialect 'sqlite'
49
39
  // Taken from http://www.sqlite.org/draft/lang_keywords.html
50
40
  // Better use keywords in tool/mkkeywordhash.c of a sqlite distribution.
@@ -195,7 +185,7 @@ module.exports = {
195
185
  'OTHERS',
196
186
  'TIES',
197
187
  ],
198
- // HANA keywords, used for smart quoting in to-hdi.plain
188
+ // SAP HANA keywords, used for smart quoting in to-hdi.plain
199
189
  // Taken from https://help.sap.com/viewer/7c78579ce9b14a669c1f3295b0d8ca16/Cloud/en-US/28bcd6af3eb6437892719f7c27a8a285.html
200
190
  // Better use keywords in ptime/query/parser/syntax/qp_keyword.cc minus those
201
191
  // in rule unreserved_keyword_column (=…_common - "CONSTRAINT") in
@@ -675,7 +665,7 @@ module.exports = {
675
665
  'XMLTABLE',
676
666
  'YEAR'
677
667
  ],
678
- // HANA CDS keywords, used for smart quoting in to-hdbcds.plain
668
+ // SAP HANA CDS keywords, used for smart quoting in to-hdbcds.plain
679
669
  hdbcds: [
680
670
  'ALL', 'ALTER', 'AS',
681
671
  'BEFORE', 'BEGIN', 'BOTH',
@@ -12,6 +12,9 @@ const { copyPropIfExist } = require('../utils/objectUtils');
12
12
  * @param {XSN.WithLocation} start
13
13
  * @param {XSN.WithLocation} end
14
14
  * @returns {CSN.Location}
15
+ *
16
+ * TODO: make this function a CDL parser-only function (i.e. there should be
17
+ * no need to use it outside), it is XSN-only anyway already now
15
18
  */
16
19
  function combinedLocation( start, end ) {
17
20
  if (!start || !start.location)
@@ -33,6 +36,8 @@ function combinedLocation( start, end ) {
33
36
  *
34
37
  * @param {string} filename
35
38
  * @returns {CSN.Location}
39
+ *
40
+ * TODO: make this function redundant (XSN sparse locations project)
36
41
  */
37
42
  function emptyLocation(filename) {
38
43
  return {
@@ -50,6 +55,8 @@ function emptyLocation(filename) {
50
55
  *
51
56
  * @param {string} filename
52
57
  * @returns {CSN.Location}
58
+ *
59
+ * TODO: make this function redundant (XSN sparse locations project)
53
60
  */
54
61
  function emptyWeakLocation(filename) {
55
62
  return {
@@ -63,6 +70,8 @@ function emptyWeakLocation(filename) {
63
70
  * Returns a dummy location for built-in definitions.
64
71
  *
65
72
  * @returns {CSN.Location}
73
+ *
74
+ * TODO: make this function redundant (XSN sparse locations project)
66
75
  */
67
76
  function builtinLocation() {
68
77
  return emptyLocation('<built-in>');
@@ -140,10 +149,6 @@ function dictLocation( dict, extraLocation ) {
140
149
  endCol: max.endCol,
141
150
  };
142
151
  }
143
- dictLocation.end = (dict) => {
144
- const loc = dictLocation( dict );
145
- return loc && { file: loc.file, line: loc.endLine, col: loc.endCol };
146
- };
147
152
 
148
153
  function _objLocations( obj ) {
149
154
  return Array.isArray(obj) ? obj.map( o => o.location ) : [ obj.location ];
@@ -42,12 +42,17 @@ const centralMessages = {
42
42
  'anno-definition': { severity: 'Warning' },
43
43
  'anno-duplicate': { severity: 'Error', configurableFor: true }, // does not hurt us
44
44
  'anno-duplicate-unrelated-layer': { severity: 'Error', configurableFor: true }, // does not hurt us
45
+ 'anno-invalid-sql-element': { severity: 'Error', configurableFor: true }, // @sql.prepend/append - configurable for "I know what I'm doing"
46
+ 'anno-invalid-sql-struct': { severity: 'Error', configurableFor: true }, // @sql.prepend/append - configurable for "I know what I'm doing"
47
+ 'anno-invalid-sql-kind': { severity: 'Error', configurableFor: true }, // @sql.prepend/append - configurable for "I know what I'm doing"
48
+ 'anno-invalid-sql-view': { severity: 'Error', configurableFor: true }, // @sql.prepend/append - configurable for "I know what I'm doing"
49
+ 'anno-invalid-sql-view-element': { severity: 'Error', configurableFor: true }, // @sql.prepend/append - configurable for "I know what I'm doing"
45
50
  'anno-undefined-action': { severity: 'Info' },
46
51
  'anno-undefined-art': { severity: 'Info' }, // for annotate statement (for CDL path root)
47
52
  'anno-undefined-def': { severity: 'Info' }, // for annotate statement (for CSN or CDL path cont)
48
53
  'anno-undefined-element': { severity: 'Info' },
49
54
  'anno-undefined-param': { severity: 'Info' },
50
- 'anno-unstable-hdbcds': { severity: 'Warning' },
55
+ 'anno-unexpected-ellipsis-layers': { severity: 'Error', configurableFor: true }, // TODO(v3): Merge with anno-unexpected-ellipsis and make non-configurable
51
56
 
52
57
  'args-expected-named': { severity: 'Error', configurableFor: 'deprecated' }, // future --sloppy
53
58
  'args-no-params': { severity: 'Error', configurableFor: 'deprecated' }, // future --sloppy
@@ -55,6 +60,8 @@ const centralMessages = {
55
60
 
56
61
  'assoc-in-array': { severity: 'Error', configurableFor: 'deprecated' }, // not supported yet
57
62
  'assoc-as-type': { severity: 'Error', configurableFor: 'deprecated' }, // TODO: allow more, but not all
63
+ 'def-unexpected-paramview-assoc': { severity: 'Error' },
64
+ 'def-unexpected-calcview-assoc': { severity: 'Error' },
58
65
 
59
66
  'check-proper-type': { severity: 'Error', configurableFor: [ 'compile' ] },
60
67
  'check-proper-type-of': { severity: 'Info', errorFor: [ 'for.odata', 'to.edmx', 'to.hdbcds', 'to.sql', 'to.rename' ] },
@@ -128,6 +135,13 @@ const centralMessages = {
128
135
  'syntax-fragile-alias': { severity: 'Error', configurableFor: true },
129
136
  'syntax-fragile-ident': { severity: 'Error', configurableFor: true },
130
137
 
138
+ 'syntax-invalid-extend': { severity: 'Error' },
139
+
140
+ 'syntax-invalid-text-block' : { severity: 'Error' },
141
+ 'syntax-unknown-escape': { severity: 'Error', configurableFor: true },
142
+ 'syntax-invalid-escape': { severity: 'Error' },
143
+ 'syntax-missing-escape': { severity: 'Error' },
144
+
131
145
  'type-managed-composition': { severity: 'Error', configurableFor: 'deprecated' }, // TODO: non-config
132
146
 
133
147
  'def-missing-element': { severity: 'Error' },
@@ -148,8 +162,10 @@ const centralMessages = {
148
162
 
149
163
  // For messageIds, where no text has been provided via code (central def)
150
164
  const centralMessageTexts = {
165
+ 'anno-duplicate': 'Duplicate assignment with $(ANNO)',
151
166
  'anno-mismatched-ellipsis': 'An array with $(CODE) can only be used if there is an assignment below with an array value',
152
- 'anno-unexpected-ellipsis': 'Unexpected $(CODE) in annotation assignment',
167
+ 'anno-unexpected-ellipsis': 'No base annotation available to apply $(CODE)',
168
+ 'anno-unexpected-ellipsis-layers': 'No base annotation available to apply $(CODE)',
153
169
  'missing-type-parameter': 'Missing value for type parameter $(NAME) in reference to type $(ID)',
154
170
  'syntax-csn-expected-object': 'Expected object for property $(PROP)',
155
171
  'syntax-csn-expected-column': 'Expected object or string \'*\' for property $(PROP)',
@@ -171,6 +187,23 @@ const centralMessageTexts = {
171
187
  one: 'Expected array in $(PROP) to have at least one item',
172
188
  suffix: 'With sibling property $(OTHERPROP), expected array in $(PROP) to have at least one item',
173
189
  },
190
+ 'syntax-invalid-extend': 'Can\'t extend an element with $(KIND)',
191
+ 'syntax-invalid-text-block': 'Missing newline in text block',
192
+ 'syntax-unknown-escape': 'Unknown escape sequence $(CODE)',
193
+ 'syntax-invalid-escape': {
194
+ std: 'Invalid escape sequence $(CODE)',
195
+ octal: 'Octal escape sequences are not supported. Use unicode escapes instead',
196
+ whitespace: 'Unknown escape sequence: Can\'t escape whitespace',
197
+ codepoint: 'Undefined code-point for $(CODE)',
198
+ 'unicode-hex': 'Expected hexadecimal numbers for unicode escape but found $(CODE)',
199
+ 'hex-count': 'Expected $(NUMBER) hexadecimal numbers for escape sequence but found $(CODE)',
200
+ 'unicode-brace': 'Missing closing brace for unicode escape sequence',
201
+ 'language-identifier': 'Escape sequences in text-block\'s language identifier are not allowed',
202
+ },
203
+ 'syntax-missing-escape': {
204
+ std: 'Missing escape. Replace $(CODE) with $(NEWCODE)',
205
+ placeholder: 'Placeholders are not supported. Replace $(CODE) with $(NEWCODE)',
206
+ },
174
207
  'ref-undefined-def': {
175
208
  std: 'Artifact $(ART) has not been found',
176
209
  // TODO: proposal 'No definition of $(NAME) found',
@@ -185,6 +218,7 @@ const centralMessageTexts = {
185
218
  'ref-unknown-var': {
186
219
  std: 'Replacement $(ID) not found'
187
220
  },
221
+ 'ref-unexpected-draft-enabled': 'Composition in draft-enabled entity can\'t lead to another entity with $(ANNO)',
188
222
  'ref-rejected-on': {
189
223
  std: 'Do not refer to a artefact like $(ID) in the explicit ON of a redirection', // Not used
190
224
  mixin: 'Do not refer to a mixin like $(ID) in the explicit ON of a redirection',
@@ -214,6 +248,17 @@ const centralMessageTexts = {
214
248
  param: 'Artifact $(ART) has no parameter $(MEMBER)'
215
249
  },
216
250
 
251
+ 'def-unexpected-paramview-assoc': {
252
+ std: 'SAP HANA does no support associations in/to parameterized entities',
253
+ view: 'SAP HANA does no support associations in parameterized entities',
254
+ target: 'SAP HANA does no support associations to parameterized entities',
255
+ },
256
+ 'def-unexpected-calcview-assoc': {
257
+ std: 'SAP HANA does not allow associations in/to entities annotated with $(ANNO)',
258
+ 'entity-persistence': 'SAP HANA does not allow associations in entities annotated with $(ANNO)',
259
+ 'target-persistence': 'SAP HANA does not allow associations pointing to entities annotated with $(ANNO)',
260
+ },
261
+
217
262
  'def-missing-element': {
218
263
  std: 'Expecting entity to have at least one non-virtual element',
219
264
  view: 'Expecting view to have at least one non-virtual element'
@@ -289,6 +334,11 @@ const centralMessageTexts = {
289
334
  'odata-spec-violation-type': 'Expected element to have a type',
290
335
  'odata-spec-violation-property-name': 'Expected element name to be different from declaring $(KIND)',
291
336
  'odata-spec-violation-namespace': 'Expected service name not to be one of the reserved names $(NAMES)',
337
+ // Other odata/edm errors
338
+ 'odata-definition-exists': {
339
+ std: 'Entity can\'t be created due to name collision with existing definition $(NAME)',
340
+ proxy: 'No proxy entity created due to name collision with existing definition $(NAME) of kind $(KIND)'
341
+ }
292
342
  }
293
343
 
294
344
  /**