@sap-ux/preview-middleware 0.7.3 → 0.7.4

package/dist/client/adp/init-dialogs.ts

@@ -4,10 +4,13 @@ import type UI5Element from 'sap/ui/core/Element';
 
 /** sap.ui.rta */
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
+
 import AddFragment from './controllers/AddFragment.controller';
+import ControllerExtension from './controllers/ControllerExtension.controller';
 
 export const enum DialogNames {
-    ADD_FRAGMENT = 'AddFragment'
+    ADD_FRAGMENT = 'AddFragment',
+    CONTROLLER_EXTENSION = 'ControllerExtension'
 }
 
 /**
@@ -24,6 +27,13 @@ export const initDialogs = (rta: RuntimeAuthoring): void => {
         handler: async (overlays: UI5Element[]) => await handler(overlays[0], rta, DialogNames.ADD_FRAGMENT),
         icon: 'sap-icon://attachment-html'
     });
+
+    contextMenu.addMenuItem({
+        id: 'EXTEND_CONTROLLER',
+        text: 'Extend With Controller',
+        handler: async (overlays: UI5Element[]) => await handler(overlays[0], rta, DialogNames.CONTROLLER_EXTENSION),
+        icon: 'sap-icon://create-form'
+    });
 };
 
 /**
@@ -34,7 +44,10 @@ export const initDialogs = (rta: RuntimeAuthoring): void => {
  * @param dialogName Dialog name
  */
 export async function handler(overlays: UI5Element, rta: RuntimeAuthoring, dialogName: DialogNames): Promise<void> {
-    const controller = new AddFragment(`open.ux.preview.client.adp.controllers.${dialogName}`, overlays, rta);
+    const controller =
+        dialogName === DialogNames.ADD_FRAGMENT
+            ? new AddFragment(`open.ux.preview.client.adp.controllers.${dialogName}`, overlays, rta)
+            : new ControllerExtension(`open.ux.preview.client.adp.controllers.${dialogName}`, overlays, rta);
 
     await XMLView.create({
         viewName: `open.ux.preview.client.adp.ui.${dialogName}`,

package/dist/client/adp/init.ts

@@ -1,5 +1,6 @@
 import log from 'sap/base/Log';
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
+
 import init from '../cpe/init';
 import { initDialogs } from './init-dialogs';
 

package/dist/client/adp/ui/AddFragment.view.xml

@@ -52,7 +52,7 @@
                 <Button 
                     id="closeDialogBtn" 
                     text="Cancel"
-                    press="closeDialog"
+                    press="handleDialogClose"
                     type="Reject" />
             </endButton>
         </Dialog>

package/dist/client/adp/ui/ControllerExtension.view.xml

@@ -0,0 +1,38 @@
+<mvc:View xmlns:mvc="sap.ui.core.mvc"
+    xmlns="sap.m"
+    xmlns:core="sap.ui.core"
+    xmlns:f="sap.ui.layout.form">
+        <Dialog id="controllerExtensionDialog" title="Extend With Controller" contentWidth="450px" class="sapUiRTABorder">
+            <content>
+                <f:SimpleForm id="controllerExtensionDialog_Form"
+                    editable="true"
+                    layout="ResponsiveGridLayout"
+                    labelSpanS="4"
+                    singleContainerFullSize="false">
+                    <f:content>
+                        <Label text="Controller Name" />
+                        <Input 
+                            description=".js" 
+                            value="{/newControllerName}" 
+                            liveChange="onControllerNameInputChange">
+                        </Input>
+                    </f:content>
+                </f:SimpleForm>
+            </content>
+            <beginButton>
+                <Button 
+                    id="createDialogBtn" 
+                    text="Create"
+                    press="onCreateBtnPress"
+                    enabled="false"
+                    type="Emphasized" />
+            </beginButton>
+            <endButton>
+                <Button 
+                    id="closeDialogBtn" 
+                    text="Cancel"
+                    press="handleDialogClose"
+                    type="Reject" />
+            </endButton>
+        </Dialog>
+</mvc:View>

package/dist/client/cpe/changes/service.js

@@ -34,9 +34,8 @@ sap.ui.define([
     }
     class ChangeService {
         savedChanges = [];
-        constructor(options, ui5, selectionService) {
+        constructor(options, selectionService) {
             this.options = options;
-            this.ui5 = ui5;
             this.selectionService = selectionService;
         }
         async init(sendAction, subscribe) {
@@ -48,7 +47,7 @@ sap.ui.define([
                     } catch (exception) {
                         let name = '';
                         const id = action.payload.controlId || '';
-                        const control = this.ui5.getControlById(id);
+                        const control = sap.ui.getCore().byId(id);
                         if (control) {
                             name = control.getMetadata().getName();
                         }

package/dist/client/cpe/changes/service.ts

@@ -14,7 +14,7 @@ import {
 import { applyChange } from './flex-change';
 import type { SelectionService } from '../selection';
 
-import type { ActionSenderFunction, SubscribeFunction, UI5AdaptationOptions, UI5Facade } from '../types';
+import type { ActionSenderFunction, SubscribeFunction, UI5AdaptationOptions } from '../types';
 import type Event from 'sap/ui/base/Event';
 import type BaseCommand from 'sap/ui/rta/command/BaseCommand';
 import Log from 'sap/base/Log';
@@ -93,7 +93,6 @@ export class ChangeService {
      */
     constructor(
         private readonly options: UI5AdaptationOptions,
-        private readonly ui5: UI5Facade,
         private readonly selectionService: SelectionService
     ) {}
 
@@ -115,7 +114,7 @@ export class ChangeService {
                     // send error information
                     let name = '';
                     const id = action.payload.controlId || '';
-                    const control = this.ui5.getControlById(id);
+                    const control = sap.ui.getCore().byId(id);
                     if (control) {
                         name = control.getMetadata().getName();
                     }

package/dist/client/cpe/control-data.js

@@ -185,7 +185,6 @@ sap.ui.define([
                     });
                     break;
                 }
-            default:
             }
         }
         return {

package/dist/client/cpe/control-data.ts

@@ -292,7 +292,6 @@ export function buildControlData(control: ManagedObject, controlOverlay?: Elemen
                 });
                 break;
             }
-            default:
         }
     }
     return {

package/dist/client/cpe/init.js

@@ -2,36 +2,35 @@
 sap.ui.define([
     'open/ux/preview/client/thirdparty/@sap-ux-private/control-property-editor-common',
     './outline/index',
-    './facade',
     './selection',
     './changes/service',
     './documentation',
     'sap/base/Log',
-    './logger'
-], function (___sap_ux_private_control_property_editor_common, ___outline_index, ___facade, ___selection, ___changes_service, ___documentation, Log, ___logger) {
+    './logger',
+    './ui5-utils'
+], function (___sap_ux_private_control_property_editor_common, ___outline_index, ___selection, ___changes_service, ___documentation, Log, ___logger, ___ui5_utils) {
     'use strict';
     const startPostMessageCommunication = ___sap_ux_private_control_property_editor_common['startPostMessageCommunication'];
     const iconsLoaded = ___sap_ux_private_control_property_editor_common['iconsLoaded'];
     const enableTelemetry = ___sap_ux_private_control_property_editor_common['enableTelemetry'];
     const initOutline = ___outline_index['initOutline'];
-    const createUi5Facade = ___facade['createUi5Facade'];
     const SelectionService = ___selection['SelectionService'];
     const ChangeService = ___changes_service['ChangeService'];
     const loadDefaultLibraries = ___documentation['loadDefaultLibraries'];
     const logger = ___logger['logger'];
+    const getIcons = ___ui5_utils['getIcons'];
     function init(rta) {
         Log.info('Initializing Control Property Editor');
         const flexSettings = rta.getFlexSettings();
         if (flexSettings.telemetry === true) {
             enableTelemetry();
         }
-        const ui5 = createUi5Facade();
         const actionHandlers = [];
         function subscribe(handler) {
             actionHandlers.push(handler);
         }
-        const selectionService = new SelectionService(rta, ui5);
-        const changesService = new ChangeService({ rta }, ui5, selectionService);
+        const selectionService = new SelectionService(rta);
+        const changesService = new ChangeService({ rta }, selectionService);
         const services = [
             selectionService,
             changesService
@@ -50,8 +49,8 @@ sap.ui.define([
             for (const service of services) {
                 service.init(sendAction, subscribe);
             }
-            initOutline(rta, ui5, sendAction).catch(error => Log.error('Error during initialization of Control Property Editor', error));
-            const icons = ui5.getIcons();
+            initOutline(rta, sendAction).catch(error => Log.error('Error during initialization of Control Property Editor', error));
+            const icons = getIcons();
             sendAction(iconsLoaded(icons));
         } catch (error) {
             Log.error('Error during initialization of Control Property Editor', error);

package/dist/client/cpe/init.ts

@@ -8,13 +8,12 @@ import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
 
 import type { ActionHandler, Service } from './types';
 import { initOutline } from './outline/index';
-import { createUi5Facade } from './facade';
 import { SelectionService } from './selection';
 import { ChangeService } from './changes/service';
 import { loadDefaultLibraries } from './documentation';
 import Log from 'sap/base/Log';
 import { logger } from './logger';
-
+import { getIcons } from './ui5-utils';
 
 export default function init(rta: RuntimeAuthoring): Promise<void> {
     Log.info('Initializing Control Property Editor');
@@ -25,7 +24,6 @@ export default function init(rta: RuntimeAuthoring): Promise<void> {
         enableTelemetry();
     }
 
-    const ui5 = createUi5Facade();
     const actionHandlers: ActionHandler[] = [];
     /**
      *
@@ -35,9 +33,9 @@ export default function init(rta: RuntimeAuthoring): Promise<void> {
         actionHandlers.push(handler);
     }
 
-    const selectionService = new SelectionService(rta, ui5);
+    const selectionService = new SelectionService(rta);
 
-    const changesService = new ChangeService({ rta }, ui5, selectionService);
+    const changesService = new ChangeService({ rta }, selectionService);
     const services: Service[] = [selectionService, changesService];
     try {
         loadDefaultLibraries();
@@ -60,10 +58,10 @@ export default function init(rta: RuntimeAuthoring): Promise<void> {
         }
         // For initOutline to complete the RTA needs to already running (to access RTA provided services).
         // That can only happen if the plugin initialization has completed.
-        initOutline(rta, ui5, sendAction).catch((error) =>
+        initOutline(rta, sendAction).catch((error) =>
             Log.error('Error during initialization of Control Property Editor', error)
         );
-        const icons = ui5.getIcons();
+        const icons = getIcons();
         sendAction(iconsLoaded(icons));
     } catch (error) {
         Log.error('Error during initialization of Control Property Editor', error);

package/dist/client/cpe/outline/index.js

@@ -7,12 +7,12 @@ sap.ui.define([
     'use strict';
     const outlineChanged = ___sap_ux_private_control_property_editor_common['outlineChanged'];
     const transformNodes = ___nodes['transformNodes'];
-    async function initOutline(rta, ui5, sendAction) {
+    async function initOutline(rta, sendAction) {
         const outline = await rta.getService('outline');
         async function syncOutline() {
             try {
                 const viewNodes = await outline.get();
-                const outlineNodes = await transformNodes(ui5, viewNodes);
+                const outlineNodes = await transformNodes(viewNodes);
                 sendAction(outlineChanged(outlineNodes));
             } catch (error) {
                 Log.error('Outline sync failed!', error);

package/dist/client/cpe/outline/index.ts

@@ -4,26 +4,20 @@ import { outlineChanged } from '@sap-ux-private/control-property-editor-common';
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
 import type OutlineService from 'sap/ui/rta/command/OutlineService';
 
-import type { UI5Facade } from '../types';
 import { transformNodes } from './nodes';
 import Log from 'sap/base/Log';
 
 /**
  *
  * @param rta runtimeAuthoring object.
- * @param ui5 - facade for ui5 framework methods
  * @param sendAction send action method.
  */
-export async function initOutline(
-    rta: RuntimeAuthoring,
-    ui5: UI5Facade,
-    sendAction: (action: ExternalAction) => void
-): Promise<void> {
+export async function initOutline(rta: RuntimeAuthoring, sendAction: (action: ExternalAction) => void): Promise<void> {
     const outline = await rta.getService<OutlineService>('outline');
     async function syncOutline() {
         try {
             const viewNodes = await outline.get();
-            const outlineNodes = await transformNodes(ui5, viewNodes);
+            const outlineNodes = await transformNodes(viewNodes);
 
             sendAction(outlineChanged(outlineNodes));
         } catch (error) {

package/dist/client/cpe/outline/nodes.js

@@ -4,8 +4,8 @@ sap.ui.define(["./utils"], function (___utils) {
   "use strict";
 
   const isEditable = ___utils["isEditable"];
-  function getAdditionalData(ui5, id) {
-    const control = ui5.getControlById(id);
+  function getAdditionalData(id) {
+    const control = sap.ui.getCore().byId(id);
     if (control?.getMetadata().getProperty('text')) {
       const text = control.getProperty('text');
       if (typeof text === 'string' && text.trim() !== '') {
@@ -20,29 +20,28 @@ sap.ui.define(["./utils"], function (___utils) {
   /**
    * Transform node.
    *
-   * @param ui5 - facade for ui5 framework methods
    * @param input outline view node
    * @param getAdditionalData gets additional data for give control id.
    * @returns Promise<OutlineNode[]>
    */
-  async function transformNodes(ui5, input) {
+  async function transformNodes(input) {
     const stack = [...input];
     const items = [];
     while (stack.length) {
       const current = stack.shift();
-      const editable = await isEditable(ui5, current?.id);
+      const editable = await isEditable(current?.id);
       if (current?.type === 'element') {
         const children = (current.elements ?? []).flatMap(element => element.type === 'aggregation' ? element.elements ?? [] : []);
         const {
           text
-        } = getAdditionalData(ui5, current.id);
+        } = getAdditionalData(current.id);
         const node = {
           controlId: current.id,
           controlType: current.technicalName,
           name: text ?? current.technicalName.split('.').slice(-1)[0],
           editable,
           visible: current.visible ?? true,
-          children: await transformNodes(ui5, children)
+          children: await transformNodes(children)
         };
         items.push(node);
       }

package/dist/client/cpe/outline/nodes.ts

@@ -1,10 +1,9 @@
 import type { OutlineNode } from '@sap-ux-private/control-property-editor-common';
 import { isEditable } from './utils';
 import type { OutlineViewNode } from 'sap/ui/rta/command/OutlineService';
-import { UI5Facade } from '../types';
 
-function getAdditionalData(ui5: UI5Facade, id: string): { text?: string } {
-    const control = ui5.getControlById(id);
+function getAdditionalData(id: string): { text?: string } {
+    const control = sap.ui.getCore().byId(id);
     if (control?.getMetadata().getProperty('text')) {
         const text = control.getProperty('text');
         if (typeof text === 'string' && text.trim() !== '') {
@@ -19,22 +18,21 @@ function getAdditionalData(ui5: UI5Facade, id: string): { text?: string } {
 /**
  * Transform node.
  *
- * @param ui5 - facade for ui5 framework methods
  * @param input outline view node
  * @param getAdditionalData gets additional data for give control id.
  * @returns Promise<OutlineNode[]>
  */
-export async function transformNodes(ui5: UI5Facade, input: OutlineViewNode[]): Promise<OutlineNode[]> {
+export async function transformNodes(input: OutlineViewNode[]): Promise<OutlineNode[]> {
     const stack = [...input];
     const items: OutlineNode[] = [];
     while (stack.length) {
         const current = stack.shift();
-        const editable = await isEditable(ui5, current?.id);
+        const editable = await isEditable(current?.id);
         if (current?.type === 'element') {
             const children = (current.elements ?? []).flatMap((element: OutlineViewNode) =>
                 element.type === 'aggregation' ? element.elements ?? [] : []
             );
-            const { text } = getAdditionalData(ui5, current.id);
+            const { text } = getAdditionalData(current.id);
 
             const node: OutlineNode = {
                 controlId: current.id,
@@ -42,7 +40,7 @@ export async function transformNodes(ui5: UI5Facade, input: OutlineViewNode[]):
                 name: text ?? current.technicalName.split('.').slice(-1)[0],
                 editable,
                 visible: current.visible ?? true,
-                children: await transformNodes(ui5, children)
+                children: await transformNodes(children)
             };
 
             items.push(node);

package/dist/client/cpe/outline/utils.js

@@ -1,16 +1,17 @@
 "use strict";
 
-sap.ui.define(["../control-data", "../utils", "sap/ui/dt/OverlayUtil", "sap/ui/dt/OverlayRegistry"], function (___control_data, ___utils, OverlayUtil, OverlayRegistry) {
+sap.ui.define(["../control-data", "../utils", "sap/ui/dt/OverlayUtil", "sap/ui/dt/OverlayRegistry", "../ui5-utils"], function (___control_data, ___utils, OverlayUtil, OverlayRegistry, ___ui5_utils) {
   "use strict";
 
   const buildControlData = ___control_data["buildControlData"];
   const getRuntimeControl = ___utils["getRuntimeControl"];
-  const isEditable = function (ui5) {
-    let id = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : '';
+  const getComponent = ___ui5_utils["getComponent"];
+  const isEditable = function () {
+    let id = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : '';
     let editable = false;
-    const control = ui5.getControlById(id);
+    const control = sap.ui.getCore().byId(id);
     if (!control) {
-      const component = ui5.getComponent(id);
+      const component = getComponent(id);
       if (component) {
         return editable;
       }

package/dist/client/cpe/outline/utils.ts

@@ -2,13 +2,13 @@ import { buildControlData } from '../control-data';
 import { getRuntimeControl } from '../utils';
 import OverlayUtil from 'sap/ui/dt/OverlayUtil';
 import OverlayRegistry from 'sap/ui/dt/OverlayRegistry';
-import type { UI5Facade } from '../types';
+import { getComponent } from '../ui5-utils';
 
-export const isEditable = (ui5: UI5Facade, id = ''): boolean => {
+export const isEditable = (id = ''): boolean => {
     let editable = false;
-    const control = ui5.getControlById(id);
+    const control = sap.ui.getCore().byId(id);
     if (!control) {
-        const component = ui5.getComponent(id);
+        const component = getComponent(id);
         if (component) {
             return editable;
         }

package/dist/client/cpe/selection.js

@@ -4,8 +4,11 @@ sap.ui.define([
     './control-data',
     './utils',
     'sap/base/Log',
-    './documentation'
-], function (___sap_ux_private_control_property_editor_common, ___control_data, ___utils, Log, ___documentation) {
+    './documentation',
+    'sap/ui/dt/OverlayRegistry',
+    'sap/ui/dt/OverlayUtil',
+    './ui5-utils'
+], function (___sap_ux_private_control_property_editor_common, ___control_data, ___utils, Log, ___documentation, OverlayRegistry, OverlayUtil, ___ui5_utils) {
     'use strict';
     const controlSelected = ___sap_ux_private_control_property_editor_common['controlSelected'];
     const propertyChanged = ___sap_ux_private_control_property_editor_common['propertyChanged'];
@@ -14,6 +17,7 @@ sap.ui.define([
     const buildControlData = ___control_data['buildControlData'];
     const getRuntimeControl = ___utils['getRuntimeControl'];
     const getDocumentation = ___documentation['getDocumentation'];
+    const getComponent = ___ui5_utils['getComponent'];
     function propertyChangeId(controlId, propertyName) {
         return [
             controlId,
@@ -47,9 +51,8 @@ sap.ui.define([
     class SelectionService {
         appliedChangeCache = new Map();
         activeChangeHandlers = new Set();
-        constructor(rta, ui5) {
+        constructor(rta) {
             this.rta = rta;
-            this.ui5 = ui5;
         }
         async init(sendAction, subscribe) {
             const eventOrigin = new Set();
@@ -60,9 +63,9 @@ sap.ui.define([
             subscribe(async action => {
                 if (selectControl.match(action)) {
                     const id = action.payload;
-                    const control = this.ui5.getControlById(id);
+                    const control = sap.ui.getCore().byId(id);
                     if (!control) {
-                        const component = this.ui5.getComponent(id);
+                        const component = getComponent(id);
                         if (component) {
                             const controlData = buildControlData(component);
                             await addDocumentationForProperties(component, controlData);
@@ -72,13 +75,13 @@ sap.ui.define([
                         return;
                     }
                     eventOrigin.add('outline');
-                    let controlOverlay = this.ui5.getOverlay(control);
+                    let controlOverlay = OverlayRegistry.getOverlay(control);
                     const selectedOverlayControls = this.rta.getSelection() ?? [];
                     for (const selectedOverlayControl of selectedOverlayControls) {
                         selectedOverlayControl.setSelected(false);
                     }
                     if (!controlOverlay?.getDomRef()) {
-                        controlOverlay = this.ui5.getClosestOverlayFor(control);
+                        controlOverlay = OverlayUtil.getClosestOverlayFor(control);
                     }
                     if (controlOverlay?.isSelectable()) {
                         controlOverlay.setSelected(true);
@@ -103,7 +106,7 @@ sap.ui.define([
                 }
                 this.activeChangeHandlers.clear();
                 if (Array.isArray(selection) && selection.length === 1) {
-                    const overlayControl = this.ui5.getControlById(selection[0].getId());
+                    const overlayControl = sap.ui.getCore().byId(selection[0].getId());
                     if (overlayControl) {
                         const runtimeControl = getRuntimeControl(overlayControl);
                         const controlName = runtimeControl.getMetadata().getName();

package/dist/client/cpe/selection.ts

@@ -8,7 +8,7 @@ import {
 } from '@sap-ux-private/control-property-editor-common';
 import { buildControlData } from './control-data';
 import { getRuntimeControl, ManagedObjectMetadataProperties, PropertiesInfo } from './utils';
-import type { ActionSenderFunction, Service, SubscribeFunction, UI5Facade } from './types';
+import type { ActionSenderFunction, Service, SubscribeFunction } from './types';
 
 import type Event from 'sap/ui/base/Event';
 import type ElementOverlay from 'sap/ui/dt/ElementOverlay';
@@ -17,6 +17,9 @@ import type { SelectionChangeEvent } from 'sap/ui/rta/RuntimeAuthoring';
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
 import Log from 'sap/base/Log';
 import { getDocumentation } from './documentation';
+import OverlayRegistry from 'sap/ui/dt/OverlayRegistry';
+import OverlayUtil from 'sap/ui/dt/OverlayUtil';
+import { getComponent } from './ui5-utils';
 
 export interface PropertyChangeParams {
     name: string;
@@ -90,7 +93,7 @@ export class SelectionService implements Service {
      * @param rta - rta object.
      * @param ui5 - facade for ui5 framework methods
      */
-    constructor(private readonly rta: RuntimeAuthoring, private readonly ui5: UI5Facade) {}
+    constructor(private readonly rta: RuntimeAuthoring) {}
 
     /**
      * Initialize selection service.
@@ -107,9 +110,9 @@ export class SelectionService implements Service {
         subscribe(async (action: ExternalAction): Promise<void> => {
             if (selectControl.match(action)) {
                 const id = action.payload;
-                const control = this.ui5.getControlById(id);
+                const control = sap.ui.getCore().byId(id);
                 if (!control) {
-                    const component = this.ui5.getComponent(id);
+                    const component = getComponent(id);
                     if (component) {
                         const controlData = buildControlData(component);
 
@@ -121,7 +124,7 @@ export class SelectionService implements Service {
                     return;
                 }
                 eventOrigin.add('outline');
-                let controlOverlay = this.ui5.getOverlay(control);
+                let controlOverlay = OverlayRegistry.getOverlay(control);
                 const selectedOverlayControls = this.rta.getSelection() ?? [];
                 //remove previous selection
                 for (const selectedOverlayControl of selectedOverlayControls) {
@@ -130,7 +133,7 @@ export class SelectionService implements Service {
 
                 if (!controlOverlay?.getDomRef()) {
                     //look for closest control in order to highlight in UI the (without firing the selection event)
-                    controlOverlay = this.ui5.getClosestOverlayFor(control);
+                    controlOverlay = OverlayUtil.getClosestOverlayFor(control);
                 }
 
                 if (controlOverlay?.isSelectable()) {
@@ -173,7 +176,7 @@ export class SelectionService implements Service {
             }
             this.activeChangeHandlers.clear();
             if (Array.isArray(selection) && selection.length === 1) {
-                const overlayControl = this.ui5.getControlById<ElementOverlay>(selection[0].getId());
+                const overlayControl = sap.ui.getCore().byId(selection[0].getId()) as ElementOverlay;
                 if (overlayControl) {
                     const runtimeControl = getRuntimeControl(overlayControl);
                     const controlName = runtimeControl.getMetadata().getName();

package/dist/client/cpe/types.ts

@@ -1,9 +1,5 @@
-import type { ExternalAction, IconDetails } from '@sap-ux-private/control-property-editor-common';
+import type { ExternalAction } from '@sap-ux-private/control-property-editor-common';
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
-import type Element from 'sap/ui/core/Element';
-import type { ID } from 'sap/ui/core/library';
-import type ElementOverlay from 'sap/ui/dt/ElementOverlay';
-import type Component from 'sap/ui/core/Component';
 
 export interface UI5AdaptationOptions {
     rta: RuntimeAuthoring;
@@ -44,10 +40,3 @@ export interface Service {
     init(sendAction: ActionSenderFunction, subscribe: SubscribeFunction): void;
 }
 
-export interface UI5Facade {
-    getControlById: <T extends Element>(id: ID) => T | undefined;
-    getIcons: () => IconDetails[];
-    getComponent: <T extends Component>(id: ID) => T | undefined;
-    getOverlay: <T extends ElementOverlay>(control: Element) => T | undefined;
-    getClosestOverlayFor: <T extends ElementOverlay>(control: Element) => T | undefined;
-}