@sap-ux/preview-middleware 0.19.36 → 0.19.38

package/dist/client/adp/controllers/AddTableColumnFragments.controller.js

@@ -10,8 +10,9 @@ sap.ui.define([
     '../api-handler',
     './BaseDialog.controller',
     '../utils',
-    'sap/ui/core/library'
-], function (JSONModel, OverlayRegistry, ___sap_ux_private_control_property_editor_common, ____i18n, ____cpe_communication_service, __ControlUtils, __CommandExecutor, ___api_handler, __BaseDialog, ___utils, sap_ui_core_library) {
+    'sap/ui/core/library',
+    '../../utils/additional-change-info'
+], function (JSONModel, OverlayRegistry, ___sap_ux_private_control_property_editor_common, ____i18n, ____cpe_communication_service, __ControlUtils, __CommandExecutor, ___api_handler, __BaseDialog, ___utils, sap_ui_core_library, ____utils_additional_change_info) {
     'use strict';
     function _interopRequireDefault(obj) {
         return obj && obj.__esModule && typeof obj.default !== 'undefined' ? obj.default : obj;
@@ -26,6 +27,7 @@ sap.ui.define([
     const BaseDialog = _interopRequireDefault(__BaseDialog);
     const notifyUser = ___utils['notifyUser'];
     const ValueState = sap_ui_core_library['ValueState'];
+    const setAdditionalChangeInfoForChangeFile = ____utils_additional_change_info['setAdditionalChangeInfoForChangeFile'];
     const radix = 10;
     const COLUMNS_AGGREGATION = 'columns';
     const ITEMS_AGGREGATION = 'items';
@@ -149,7 +151,6 @@ sap.ui.define([
             const flexSettings = this.rta.getFlexSettings();
             const overlay = OverlayRegistry.getOverlay(this.runtimeControl);
             const designMetadata = overlay.getDesignTimeMetadata();
-            const result = [];
             const compositeCommand = await this.commandExecutor.createCompositeCommand(this.runtimeControl);
             for (const fragment of fragments) {
                 const modifiedValue = {
@@ -162,17 +163,11 @@ sap.ui.define([
                 const command = await this.commandExecutor.getCommand(targetObject, 'addXML', modifiedValue, designMetadata, flexSettings);
                 const templateName = fragment.targetAggregation === COLUMNS_AGGREGATION ? `V2_SMART_TABLE_COLUMN` : 'V2_SMART_TABLE_CELL';
                 const preparedChange = command.getPreparedChange();
-                const content = {
-                    ...preparedChange.getContent(),
-                    templateName
-                };
-                preparedChange.setContent(content);
+                setAdditionalChangeInfoForChangeFile(preparedChange.getDefinition().fileName, { templateName });
                 compositeCommand.addCommand(command, false);
-                result.push(templateName);
             }
             await this.commandExecutor.pushAndExecuteCommand(compositeCommand);
             CommunicationService.sendAction(setApplicationRequiresReload(true));
-            return result;
         }
     });
     return AddTableColumnFragments;

package/dist/client/adp/controllers/AddTableColumnFragments.controller.ts

@@ -39,6 +39,7 @@ import Input from 'sap/m/Input';
 import Control from 'sap/ui/core/Control';
 import ManagedObject from 'sap/ui/base/ManagedObject';
 import { QuickActionTelemetryData } from '../../cpe/quick-actions/quick-action-definition';
+import { setAdditionalChangeInfoForChangeFile } from '../../utils/additional-change-info';
 
 const radix = 10;
 
@@ -60,7 +61,6 @@ interface CreateFragmentProps {
  * @namespace open.ux.preview.client.adp.controllers
  */
 export default class AddTableColumnFragments extends BaseDialog<AddTableColumnsFragmentsModel> {
-
     constructor(
         name: string,
         overlays: UI5Element,
@@ -255,7 +255,7 @@ export default class AddTableColumnFragments extends BaseDialog<AddTableColumnsF
      *
      * @param fragmentData Fragment Data
      */
-    private async createFragmentChange(fragmentData: CreateFragmentProps): Promise<string[] | undefined> {
+    private async createFragmentChange(fragmentData: CreateFragmentProps): Promise<void> {
         const { fragments, index } = fragmentData;
 
         const flexSettings = this.rta.getFlexSettings();
@@ -263,8 +263,6 @@ export default class AddTableColumnFragments extends BaseDialog<AddTableColumnsF
         const overlay = OverlayRegistry.getOverlay(this.runtimeControl as UI5Element);
         const designMetadata = overlay.getDesignTimeMetadata();
 
-        const result: string[] = [];
-
         const compositeCommand = await this.commandExecutor.createCompositeCommand(this.runtimeControl);
 
         for (const fragment of fragments) {
@@ -292,15 +290,11 @@ export default class AddTableColumnFragments extends BaseDialog<AddTableColumnsF
             const templateName =
                 fragment.targetAggregation === COLUMNS_AGGREGATION ? `V2_SMART_TABLE_COLUMN` : 'V2_SMART_TABLE_CELL';
             const preparedChange = command.getPreparedChange();
-            const content = { ...preparedChange.getContent(), templateName };
-            preparedChange.setContent(content);
+            setAdditionalChangeInfoForChangeFile(preparedChange.getDefinition().fileName, { templateName });
             compositeCommand.addCommand(command, false);
-            result.push(templateName);
         }
 
         await this.commandExecutor.pushAndExecuteCommand(compositeCommand);
         CommunicationService.sendAction(setApplicationRequiresReload(true));
-
-        return result;
     }
 }

package/dist/client/utils/additional-change-info.js

@@ -5,11 +5,12 @@ sap.ui.define(["../cpe/additional-change-info/add-xml-additional-info"], functio
 
   const getAddXMLAdditionalInfo = ___cpe_additional_change_info_add_xml_additional_info["getAddXMLAdditionalInfo"];
   const additionalChangeInfoMap = new Map();
+
   /**
-  * This function is used to set additional change information for a given change.
-  * 
-  * @param change - The change object for which additional information is to be set.
-  */
+   * This function is used to set additional change information for a given change.
+   *
+   * @param change - The change object for which additional information is to be set.
+   */
   function setAdditionalChangeInfo(change) {
     if (!change) {
       return;
@@ -22,6 +23,9 @@ sap.ui.define(["../cpe/additional-change-info/add-xml-additional-info"], functio
       additionalChangeInfoMap.set(change.getDefinition().fileName, additionalChangeInfo);
     }
   }
+  function setAdditionalChangeInfoForChangeFile(fileName, additionalChangeInfo) {
+    additionalChangeInfoMap.set(fileName, additionalChangeInfo);
+  }
 
   /**
    * Retrieves additional change information for a given change.
@@ -33,11 +37,20 @@ sap.ui.define(["../cpe/additional-change-info/add-xml-additional-info"], functio
   function getAdditionalChangeInfo(change) {
     return additionalChangeInfoMap.get(change.fileName);
   }
+
+  /**
+   * Should only be used in tests.
+   */
+  function clearAdditionalChangeInfo() {
+    additionalChangeInfoMap.clear();
+  }
   var __exports = {
     __esModule: true
   };
   __exports.setAdditionalChangeInfo = setAdditionalChangeInfo;
+  __exports.setAdditionalChangeInfoForChangeFile = setAdditionalChangeInfoForChangeFile;
   __exports.getAdditionalChangeInfo = getAdditionalChangeInfo;
+  __exports.clearAdditionalChangeInfo = clearAdditionalChangeInfo;
   return __exports;
 });
 //# sourceMappingURL=additional-change-info.js.map

package/dist/client/utils/additional-change-info.ts

@@ -6,22 +6,22 @@ import {
 } from '../cpe/additional-change-info/add-xml-additional-info';
 import { FlexChange as Change } from '../flp/common';
 
-const additionalChangeInfoMap = new Map<string, AddXMLAdditionalInfo>();
+export type AdditionalChangeInfo = AddXMLAdditionalInfo | undefined;
 
-export type AdditionalChangeInfo = AddXMLAdditionalInfo | undefined
+const additionalChangeInfoMap = new Map<string, AdditionalChangeInfo>();
 
 /**
-* This function is used to set additional change information for a given change.
-* 
-* @param change - The change object for which additional information is to be set.
-*/
+ * This function is used to set additional change information for a given change.
+ *
+ * @param change - The change object for which additional information is to be set.
+ */
 export function setAdditionalChangeInfo(change: FlexChange<AddXMLChangeContent> | undefined): void {
     if (!change) {
         return;
     }
 
     let additionalChangeInfo;
-    if(change?.getChangeType?.() === 'addXML') {
+    if (change?.getChangeType?.() === 'addXML') {
         additionalChangeInfo = getAddXMLAdditionalInfo(change);
     }
 
@@ -30,6 +30,13 @@ export function setAdditionalChangeInfo(change: FlexChange<AddXMLChangeContent>
     }
 }
 
+export function setAdditionalChangeInfoForChangeFile(
+    fileName: string,
+    additionalChangeInfo: AdditionalChangeInfo
+): void {
+    additionalChangeInfoMap.set(fileName, additionalChangeInfo);
+}
+
 /**
  * Retrieves additional change information for a given change.
  *
@@ -38,5 +45,12 @@ export function setAdditionalChangeInfo(change: FlexChange<AddXMLChangeContent>
  *          or `undefined` if no additional information is available.
  */
 export function getAdditionalChangeInfo(change: Change): AdditionalChangeInfo {
-    return additionalChangeInfoMap.get(change.fileName);              
+    return additionalChangeInfoMap.get(change.fileName);
+}
+
+/**
+ * Should only be used in tests.
+ */
+export function clearAdditionalChangeInfo(): void {
+    additionalChangeInfoMap.clear();
 }

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Apreview-middleware"
   },
-  "version": "0.19.36",
+  "version": "0.19.38",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -25,13 +25,13 @@
     "ejs": "3.1.10",
     "mem-fs": "2.1.0",
     "mem-fs-editor": "9.4.0",
-    "@sap-ux/adp-tooling": "0.13.40",
+    "@sap-ux/adp-tooling": "0.13.41",
     "@sap-ux/btp-utils": "1.0.3",
     "@sap-ux/control-property-editor-sources": "npm:@sap-ux/control-property-editor@0.6.4",
     "@sap-ux/feature-toggle": "0.2.3",
-    "@sap-ux/logger": "0.6.0",
     "@sap-ux/project-access": "1.29.21",
-    "@sap-ux/system-access": "0.5.37"
+    "@sap-ux/logger": "0.6.0",
+    "@sap-ux/system-access": "0.5.38"
   },
   "devDependencies": {
     "@sap-ux-private/playwright": "0.1.0",
@@ -49,11 +49,11 @@
     "nock": "13.4.0",
     "npm-run-all2": "6.2.0",
     "supertest": "6.3.3",
-    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.13.20",
-    "@sap-ux/axios-extension": "1.20.1",
+    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.13.21",
     "@sap-ux/i18n": "0.2.3",
-    "@sap-ux/store": "1.0.0",
-    "@sap-ux/ui5-info": "0.10.1"
+    "@sap-ux/axios-extension": "1.20.2",
+    "@sap-ux/ui5-info": "0.10.1",
+    "@sap-ux/store": "1.0.0"
   },
   "peerDependencies": {
     "express": "4"