@sap-ux/preview-middleware 0.16.132 → 0.16.133

package/dist/client/adp/quick-actions/fe-v2/change-table-columns.js

@@ -13,7 +13,9 @@ sap.ui.define(["../../../utils/core", "../table-quick-action-base"], function (_
   const CONTROL_TYPES = [SMART_TABLE_TYPE, M_TABLE_TYPE, 'sap.ui.table.TreeTable', 'sap.ui.table.Table'];
   class ChangeTableColumnsQuickAction extends TableQuickActionDefinitionBase {
     constructor(context) {
-      super(CHANGE_TABLE_COLUMNS, CONTROL_TYPES, 'V2_QUICK_ACTION_CHANGE_TABLE_COLUMNS', context, true);
+      super(CHANGE_TABLE_COLUMNS, CONTROL_TYPES, 'V2_QUICK_ACTION_CHANGE_TABLE_COLUMNS', context, {
+        includeServiceAction: true
+      });
     }
     async execute(path) {
       const {

package/dist/client/adp/quick-actions/fe-v2/change-table-columns.ts

@@ -18,7 +18,9 @@ export class ChangeTableColumnsQuickAction
     implements NestedQuickActionDefinition
 {
     constructor(context: QuickActionContext) {
-        super(CHANGE_TABLE_COLUMNS, CONTROL_TYPES, 'V2_QUICK_ACTION_CHANGE_TABLE_COLUMNS', context, true);
+        super(CHANGE_TABLE_COLUMNS, CONTROL_TYPES, 'V2_QUICK_ACTION_CHANGE_TABLE_COLUMNS', context, {
+            includeServiceAction: true
+        });
     }
     async execute(path: string): Promise<FlexCommand[]> {
         const { table, iconTabBarFilterKey, changeColumnActionId, sectionInfo } = this.tableMap[path];

package/dist/client/adp/quick-actions/fe-v2/create-table-custom-column.js

@@ -44,7 +44,9 @@ sap.ui.define(["../../../utils/core", "sap/ui/dt/OverlayRegistry", "../../init-d
   }
   class AddTableCustomColumnQuickAction extends TableQuickActionDefinitionBase {
     constructor(context) {
-      super(CREATE_TABLE_CUSTOM_COLUMN, CONTROL_TYPES, 'QUICK_ACTION_ADD_CUSTOM_TABLE_COLUMN', context);
+      super(CREATE_TABLE_CUSTOM_COLUMN, CONTROL_TYPES, 'QUICK_ACTION_ADD_CUSTOM_TABLE_COLUMN', context, {
+        areTableRowsRequired: true
+      });
     }
     async execute(path) {
       const {

package/dist/client/adp/quick-actions/fe-v2/create-table-custom-column.ts

@@ -64,7 +64,9 @@ export class AddTableCustomColumnQuickAction
     implements NestedQuickActionDefinition
 {
     constructor(context: QuickActionContext) {
-        super(CREATE_TABLE_CUSTOM_COLUMN, CONTROL_TYPES, 'QUICK_ACTION_ADD_CUSTOM_TABLE_COLUMN', context);
+        super(CREATE_TABLE_CUSTOM_COLUMN, CONTROL_TYPES, 'QUICK_ACTION_ADD_CUSTOM_TABLE_COLUMN', context, {
+            areTableRowsRequired: true
+        });
     }
 
     async execute(path: string): Promise<FlexCommand[]> {

package/dist/client/adp/quick-actions/table-quick-action-base.js

@@ -53,12 +53,13 @@ sap.ui.define([
         get textKey() {
             return this.defaultTextKey;
         }
-        constructor(type, controlTypes, defaultTextKey, context, includeServiceAction) {
+        constructor(type, controlTypes, defaultTextKey, context) {
+            let options = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : {};
             this.type = type;
             this.controlTypes = controlTypes;
             this.defaultTextKey = defaultTextKey;
             this.context = context;
-            this.includeServiceAction = includeServiceAction;
+            this.options = options;
         }
         async initialize() {
             const version = await getUi5Version();
@@ -76,11 +77,9 @@ sap.ui.define([
                 if (section) {
                     this.collectChildrenInSection(section, table);
                 } else if (this.iconTabBar && tabKey) {
-                    this.children.push({
-                        label: `'${ iconTabBarfilterMap[tabKey] }' table`,
-                        enabled: true,
-                        children: []
-                    });
+                    const label = `'${ iconTabBarfilterMap[tabKey] }' table`;
+                    const child = this.createChild(label, table);
+                    this.children.push(child);
                     this.tableMap[`${ this.children.length - 1 }`] = {
                         table,
                         iconTabBarFilterKey: tabKey,
@@ -89,7 +88,7 @@ sap.ui.define([
                 } else {
                     this.processTable(table);
                 }
-                if (this.includeServiceAction) {
+                if (this.options.includeServiceAction) {
                     const actions = await this.context.actionService.get(table.getId());
                     const actionsIds = await getActionId(table);
                     const changeColumnAction = actionsIds.find(actionId => actions.findIndex(action => action.id === actionId) > -1);
@@ -102,6 +101,23 @@ sap.ui.define([
                 this.isApplicable = true;
             }
         }
+        getInternalTable(table) {
+            try {
+                let tableInternal;
+                if (isA(SMART_TABLE_TYPE, table)) {
+                    const itemsAggregation = table.getAggregation('items');
+                    tableInternal = itemsAggregation.find(item => [
+                        M_TABLE_TYPE,
+                        TREE_TABLE_TYPE,
+                        ANALYTICAL_TABLE_TYPE,
+                        GRID_TABLE_TYPE
+                    ].some(tType => isA(tType, item)));
+                }
+                return tableInternal;
+            } catch (error) {
+                return undefined;
+            }
+        }
         getTableLabel(table) {
             if (isA(SMART_TABLE_TYPE, table) || isA(MDC_TABLE_TYPE, table)) {
                 const header = table.getHeader();
@@ -146,24 +162,18 @@ sap.ui.define([
                 } else if (subSections.length > 1) {
                     const sectionChild = this.children.find(val => val.label === `${ section.getTitle() } section`);
                     let tableMapIndex = `${ this.children.length - 1 }`;
+                    const label = this.getTableLabel(table);
+                    const child = this.createChild(label, table);
                     if (!sectionChild) {
                         tableMapIndex = `${ tableMapIndex }/0`;
                         this.children.push({
                             label: `'${ section?.getTitle() }' section`,
                             enabled: true,
-                            children: [{
-                                    label: this.getTableLabel(table),
-                                    enabled: true,
-                                    children: []
-                                }]
+                            children: [child]
                         });
                     } else {
                         tableMapIndex = `${ tableMapIndex }/${ sectionChild.children.length - 1 }`;
-                        sectionChild.children.push({
-                            label: this.getTableLabel(table),
-                            enabled: true,
-                            children: []
-                        });
+                        sectionChild.children.push(child);
                     }
                     this.tableMap[tableMapIndex] = {
                         table,
@@ -184,11 +194,9 @@ sap.ui.define([
                     MDC_TABLE_TYPE,
                     TREE_TABLE_TYPE
                 ].some(type => isA(type, table))) {
-                this.children.push({
-                    label: this.getTableLabel(table),
-                    enabled: true,
-                    children: []
-                });
+                const label = this.getTableLabel(table);
+                const child = this.createChild(label, table);
+                this.children.push(child);
             }
             this.tableMap[`${ this.children.length - 1 }`] = {
                 table,
@@ -212,6 +220,23 @@ sap.ui.define([
                 children: this.children
             };
         }
+        createChild(label, table) {
+            const child = {
+                label,
+                enabled: true,
+                children: []
+            };
+            if (!this.options.areTableRowsRequired) {
+                return child;
+            }
+            const innerTable = this.getInternalTable(table);
+            const tableRows = innerTable?.getAggregation('items') || [];
+            if (isA(M_TABLE_TYPE, innerTable) && !tableRows.length) {
+                child.enabled = false;
+                child.tooltip = this.context.resourceBundle.getText('TABLE_CUSTOM_COLUMN_ACTION_NOT_AVAILABLE');
+            }
+            return child;
+        }
     }
     var __exports = { __esModule: true };
     __exports.SMART_TABLE_TYPE = SMART_TABLE_TYPE;

package/dist/client/adp/quick-actions/table-quick-action-base.ts

@@ -14,6 +14,7 @@ import { getUi5Version, isLowerThanMinimalUi5Version } from '../../utils/version
 import ObjectPageSection from 'sap/uxap/ObjectPageSection';
 import ObjectPageSubSection from 'sap/uxap/ObjectPageSubSection';
 import ObjectPageLayout from 'sap/uxap/ObjectPageLayout';
+import ManagedObject from 'sap/ui/base/ManagedObject';
 
 const SMART_TABLE_ACTION_ID = 'CTX_COMP_VARIANT_CONTENT';
 const M_TABLE_ACTION_ID = 'CTX_ADD_ELEMENTS_AS_CHILD';
@@ -39,6 +40,10 @@ async function getActionId(table: UI5Element): Promise<string[]> {
 
     return [M_TABLE_ACTION_ID, SETTINGS_ID];
 }
+export type TableQuickActionsOptions = {
+    includeServiceAction?: boolean;
+    areTableRowsRequired?: boolean;
+};
 
 /**
  * Base class for table quick actions.
@@ -85,7 +90,7 @@ export abstract class TableQuickActionDefinitionBase {
         protected readonly controlTypes: string[],
         protected readonly defaultTextKey: string,
         protected readonly context: QuickActionContext,
-        protected includeServiceAction?: boolean
+        protected options: TableQuickActionsOptions = {}
     ) {}
 
     /**
@@ -109,11 +114,9 @@ export abstract class TableQuickActionDefinitionBase {
             if (section) {
                 this.collectChildrenInSection(section, table);
             } else if (this.iconTabBar && tabKey) {
-                this.children.push({
-                    label: `'${iconTabBarfilterMap[tabKey]}' table`,
-                    enabled: true,
-                    children: []
-                });
+                const label = `'${iconTabBarfilterMap[tabKey]}' table`;
+                const child = this.createChild(label, table);
+                this.children.push(child);
                 this.tableMap[`${this.children.length - 1}`] = {
                     table,
                     iconTabBarFilterKey: tabKey,
@@ -124,7 +127,7 @@ export abstract class TableQuickActionDefinitionBase {
             }
 
             // add action id to the table map, if the service actions are needed.
-            if (this.includeServiceAction) {
+            if (this.options.includeServiceAction) {
                 const actions = await this.context.actionService.get(table.getId());
                 const actionsIds = await getActionId(table);
 
@@ -142,6 +145,30 @@ export abstract class TableQuickActionDefinitionBase {
         }
     }
 
+    /**
+     * Retrieves the internal table control from a UI5Element.
+     *
+     * @param table - The UI5Element instance to analyze.
+     * @returns The internal table otherwise undefined.
+     */
+    protected getInternalTable(table: UI5Element): UI5Element | undefined {
+        try {
+            let tableInternal: ManagedObject | undefined;
+
+            if (isA<SmartTable>(SMART_TABLE_TYPE, table)) {
+                const itemsAggregation = table.getAggregation('items') as ManagedObject[];
+                tableInternal = itemsAggregation.find((item) =>
+                    [M_TABLE_TYPE, TREE_TABLE_TYPE, ANALYTICAL_TABLE_TYPE, GRID_TABLE_TYPE].some((tType) =>
+                        isA(tType, item)
+                    )
+                );
+            }
+            return tableInternal as UI5Element | undefined;
+        } catch (error) {
+            return undefined;
+        }
+    }
+
     /**
      * Determines table label for the given table element
      * @param table - table element
@@ -204,26 +231,19 @@ export abstract class TableQuickActionDefinitionBase {
             } else if (subSections.length > 1) {
                 const sectionChild = this.children.find((val) => val.label === `${section.getTitle()} section`);
                 let tableMapIndex = `${this.children.length - 1}`;
+                const label = this.getTableLabel(table);
+                const child = this.createChild(label, table);
                 if (!sectionChild) {
                     tableMapIndex = `${tableMapIndex}/0`;
+
                     this.children.push({
                         label: `'${section?.getTitle()}' section`,
                         enabled: true,
-                        children: [
-                            {
-                                label: this.getTableLabel(table),
-                                enabled: true,
-                                children: []
-                            }
-                        ]
+                        children: [child]
                     });
                 } else {
                     tableMapIndex = `${tableMapIndex}/${sectionChild.children.length - 1}`;
-                    sectionChild.children.push({
-                        label: this.getTableLabel(table),
-                        enabled: true,
-                        children: []
-                    });
+                    sectionChild.children.push(child);
                 }
 
                 this.tableMap[tableMapIndex] = {
@@ -245,11 +265,9 @@ export abstract class TableQuickActionDefinitionBase {
         sectionInfo?: { section: ObjectPageSection; subSection: ObjectPageSubSection; layout?: ObjectPageLayout }
     ): void {
         if ([SMART_TABLE_TYPE, M_TABLE_TYPE, MDC_TABLE_TYPE, TREE_TABLE_TYPE].some((type) => isA(type, table))) {
-            this.children.push({
-                label: this.getTableLabel(table),
-                enabled: true,
-                children: []
-            });
+            const label = this.getTableLabel(table);
+            const child = this.createChild(label, table);
+            this.children.push(child);
         }
 
         this.tableMap[`${this.children.length - 1}`] = {
@@ -284,4 +302,22 @@ export abstract class TableQuickActionDefinitionBase {
             children: this.children
         };
     }
+
+    createChild(label: string, table: UI5Element): NestedQuickActionChild {
+        const child: NestedQuickActionChild = {
+            label,
+            enabled: true,
+            children: []
+        };
+        if (!this.options.areTableRowsRequired) {
+            return child;
+        }
+        const innerTable = this.getInternalTable(table);
+        const tableRows = (innerTable?.getAggregation('items') as ManagedObject[]) || [];
+        if (isA(M_TABLE_TYPE, innerTable) && !tableRows.length) {
+            child.enabled = false;
+            child.tooltip = this.context.resourceBundle.getText('TABLE_CUSTOM_COLUMN_ACTION_NOT_AVAILABLE');
+        }
+        return child;
+    }
 }

package/dist/client/messagebundle.properties

@@ -38,4 +38,6 @@ CPE_CHANGES_VISIBLE_AFTER_SAVE_AND_RELOAD_MESSAGE = Note: The change will be vis
 TABLE_ROWS_NEEDED_TO_CREATE_CUSTOM_COLUMN=At least one table row is required to create new custom column. Make sure the table data is loaded and try again.
 
 HIGHER_LAYER_CHANGES_INFO_MESSAGE=The preview of the project was reloaded due to detected changes in higher layer than the one used in your project.
+
+TABLE_CUSTOM_COLUMN_ACTION_NOT_AVAILABLE=This action has been disabled because the table rows are not available. Please load the table data and try again
 THE_CHANGE_HAS_ALREADY_BEEN_MADE=This option has been disabled because the change has already been made

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Apreview-middleware"
   },
-  "version": "0.16.132",
+  "version": "0.16.133",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -46,9 +46,9 @@
     "supertest": "6.3.3",
     "@sap-ux-private/playwright": "0.1.0",
     "dotenv": "16.3.1",
-    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.11.37",
-    "@sap-ux/axios-extension": "1.17.4",
+    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.11.38",
     "@sap-ux/store": "0.9.3",
+    "@sap-ux/axios-extension": "1.17.4",
     "@sap-ux/ui5-info": "0.8.3",
     "@sap-ux/i18n": "0.2.0"
   },