@sap-ux/preview-middleware 0.13.72 → 0.13.73

package/dist/client/cpe/selection.ts

@@ -20,6 +20,7 @@ import { getDocumentation } from './documentation';
 import OverlayRegistry from 'sap/ui/dt/OverlayRegistry';
 import OverlayUtil from 'sap/ui/dt/OverlayUtil';
 import { getComponent } from './ui5-utils';
+import { getError } from './error-utils';
 
 export interface PropertyChangeParams {
     name: string;
@@ -78,7 +79,7 @@ async function addDocumentationForProperties(control: ManagedObject, controlData
             controlProp.documentation = getPropertyDocument(property, controlProp.ui5Type, document);
         });
     } catch (e) {
-        Log.error('Document loading failed', e);
+        Log.error('Document loading failed', getError(e));
     }
 }
 
@@ -105,7 +106,7 @@ export class SelectionService implements Service {
         const eventOrigin: Set<string> = new Set();
         const onselectionChange = this.createOnSelectionChangeHandler(sendAction, eventOrigin);
         this.rta.attachSelectionChange((event) => {
-            onselectionChange(event).catch((error) => Log.error('Event interrupted: ', error));
+            onselectionChange(event).catch((error) => Log.error('Event interrupted: ', getError(error)));
         });
         subscribe(async (action: ExternalAction): Promise<void> => {
             if (selectControl.match(action)) {
@@ -192,7 +193,7 @@ export class SelectionService implements Service {
                             reportTelemetry({ category: 'Overlay Selection', controlName: name });
                         }
                     } catch (error) {
-                        Log.error('Failed to report telemetry', error);
+                        Log.error('Failed to report telemetry', getError(error));
                     } finally {
                         const controlData = buildControlData(runtimeControl, overlayControl);
                         await addDocumentationForProperties(runtimeControl, controlData);

package/dist/client/flp/init.js

@@ -7,7 +7,6 @@ sap.ui.define(["sap/base/Log", "sap/ui/core/IconPool", "sap/base/i18n/ResourceBu
    * SAPUI5 delivered namespaces from https://ui5.sap.com/#/api/sap
    */
   const UI5_LIBS = ['sap.apf', 'sap.base', 'sap.chart', 'sap.collaboration', 'sap.f', 'sap.fe', 'sap.fileviewer', 'sap.gantt', 'sap.landvisz', 'sap.m', 'sap.ndc', 'sap.ovp', 'sap.rules', 'sap.suite', 'sap.tnt', 'sap.ui', 'sap.uiext', 'sap.ushell', 'sap.uxap', 'sap.viz', 'sap.webanalytics', 'sap.zen'];
-
   /**
    * Check whether a specific dependency is a custom library, and if yes, add it to the map.
    *
@@ -38,7 +37,7 @@ sap.ui.define(["sap/base/Log", "sap/ui/core/IconPool", "sap/base/i18n/ResourceBu
       promises.push(fetch(`${url}/manifest.json`).then(async resp => {
         const manifest = await resp.json();
         if (manifest) {
-          if (manifest['sap.ui5'] && manifest['sap.ui5'].dependencies) {
+          if (manifest['sap.ui5']?.dependencies) {
             if (manifest['sap.ui5'].dependencies.libs) {
               addKeys(manifest['sap.ui5'].dependencies.libs, result);
             }
@@ -46,7 +45,7 @@ sap.ui.define(["sap/base/Log", "sap/ui/core/IconPool", "sap/base/i18n/ResourceBu
               addKeys(manifest['sap.ui5'].dependencies.components, result);
             }
           }
-          if (manifest['sap.ui5'] && manifest['sap.ui5'].componentUsages) {
+          if (manifest['sap.ui5']?.componentUsages) {
             addKeys(manifest['sap.ui5'].componentUsages, result);
           }
         }

package/dist/client/flp/init.ts

@@ -1,7 +1,7 @@
 import Log from 'sap/base/Log';
 import type AppLifeCycle from 'sap/ushell/services/AppLifeCycle';
 import type { InitRtaScript, RTAPlugin, StartAdaptation } from 'sap/ui/rta/api/startAdaptation';
-import type { RTAOptions } from 'sap/ui/rta/RuntimeAuthoring';
+import type { FlexSettings, RTAOptions } from 'sap/ui/rta/RuntimeAuthoring';
 import IconPool from 'sap/ui/core/IconPool';
 import ResourceBundle from 'sap/base/i18n/ResourceBundle';
 import AppState from 'sap/ushell/services/AppState';
@@ -34,6 +34,27 @@ const UI5_LIBS = [
     'sap.zen'
 ];
 
+interface Manifest {
+    ['sap.ui5']?: {
+        dependencies?: {
+            libs: Record<string, unknown>;
+            components: Record<string, unknown>;
+        };
+        componentUsages?: Record<string, unknown>;
+    };
+}
+
+type AppIndexData = Record<
+    string,
+    {
+        dependencies?: {
+            url?: string;
+            type?: string;
+            componentId: string;
+        }[];
+    }
+>;
+
 /**
  * Check whether a specific dependency is a custom library, and if yes, add it to the map.
  *
@@ -65,9 +86,9 @@ async function getManifestLibs(appUrls: string[]): Promise<string> {
     for (const url of appUrls) {
         promises.push(
             fetch(`${url}/manifest.json`).then(async (resp) => {
-                const manifest = await resp.json();
+                const manifest = (await resp.json()) as Manifest;
                 if (manifest) {
-                    if (manifest['sap.ui5'] && manifest['sap.ui5'].dependencies) {
+                    if (manifest['sap.ui5']?.dependencies) {
                         if (manifest['sap.ui5'].dependencies.libs) {
                             addKeys(manifest['sap.ui5'].dependencies.libs, result);
                         }
@@ -75,7 +96,7 @@ async function getManifestLibs(appUrls: string[]): Promise<string> {
                             addKeys(manifest['sap.ui5'].dependencies.components, result);
                         }
                     }
-                    if (manifest['sap.ui5'] && manifest['sap.ui5'].componentUsages) {
+                    if (manifest['sap.ui5']?.componentUsages) {
                         addKeys(manifest['sap.ui5'].componentUsages, result);
                     }
                 }
@@ -90,18 +111,7 @@ async function getManifestLibs(appUrls: string[]): Promise<string> {
  *
  * @param dataFromAppIndex data returned from the app index service
  */
-function registerModules(
-    dataFromAppIndex: Record<
-        string,
-        {
-            dependencies?: {
-                url?: string;
-                type?: string;
-                componentId: string;
-            }[];
-        }
-    >
-) {
+function registerModules(dataFromAppIndex: AppIndexData) {
     Object.keys(dataFromAppIndex).forEach(function (moduleDefinitionKey) {
         const moduleDefinition = dataFromAppIndex[moduleDefinitionKey];
         if (moduleDefinition && moduleDefinition.dependencies) {
@@ -151,7 +161,7 @@ export async function registerComponentDependencyPaths(appUrls: string[], urlPar
         }
         const response = await fetch(url);
         try {
-            registerModules(await response.json());
+            registerModules((await response.json()) as AppIndexData);
         } catch (error) {
             Log.error(`Registering of reuse libs failed. Error:${error}`);
         }
@@ -224,7 +234,7 @@ export async function init({
                 const version = sap.ui.version;
                 const minor = parseInt(version.split('.')[1], 10);
                 const view = event.getParameter('componentInstance');
-                const flexSettings = JSON.parse(flex);
+                const flexSettings = JSON.parse(flex) as FlexSettings;
                 const pluginScript = flexSettings.pluginScript ?? '';
 
                 let libs: string[] = [];
@@ -235,7 +245,7 @@ export async function init({
                 }
 
                 if (flexSettings.pluginScript) {
-                    libs.push(pluginScript);
+                    libs.push(pluginScript as string);
                     delete flexSettings.pluginScript;
                 }
 

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Apreview-middleware"
   },
-  "version": "0.13.72",
+  "version": "0.13.73",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -25,11 +25,11 @@
     "ejs": "3.1.10",
     "mem-fs": "2.1.0",
     "mem-fs-editor": "9.4.0",
-    "@sap-ux/logger": "0.5.1",
     "@sap-ux/btp-utils": "0.14.4",
+    "@sap-ux/project-access": "1.22.3",
     "@sap-ux/adp-tooling": "0.11.6",
     "@sap-ux/control-property-editor-sources": "npm:@sap-ux/control-property-editor@0.4.23",
-    "@sap-ux/project-access": "1.22.3"
+    "@sap-ux/logger": "0.5.1"
   },
   "devDependencies": {
     "@types/ejs": "3.1.2",
@@ -45,8 +45,8 @@
     "supertest": "6.3.3",
     "@sap-ux-private/playwright": "0.0.3",
     "dotenv": "16.3.1",
-    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.9.15",
     "@sap-ux/axios-extension": "1.14.1",
+    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.9.16",
     "@sap-ux/store": "0.6.0",
     "@sap-ux/ui5-info": "0.5.0",
     "@sap-ux/i18n": "0.0.7"