@sap-ux/preview-middleware 0.13.37 → 0.13.38

package/dist/client/adp/init.js

@@ -1,13 +1,12 @@
 'use strict';
 sap.ui.define([
     'sap/base/Log',
-    'sap/ui/core/ElementRegistry',
     '../cpe/init',
     './init-dialogs',
     'open/ux/preview/client/thirdparty/@sap-ux-private/control-property-editor-common',
     'sap/ui/VersionInfo',
     './ui5-version-utils'
-], function (log, UI5ElementRegistry, __init, ___init_dialogs, ___sap_ux_private_control_property_editor_common, VersionInfo, ___ui5_version_utils) {
+], function (log, __init, ___init_dialogs, ___sap_ux_private_control_property_editor_common, VersionInfo, ___ui5_version_utils) {
     'use strict';
     function _interopRequireDefault(obj) {
         return obj && obj.__esModule && typeof obj.default !== 'undefined' ? obj.default : obj;
@@ -52,7 +51,7 @@ sap.ui.define([
                 }
             }
         });
-        const syncViewsIds = getAllSyncViewsIds();
+        const syncViewsIds = await getAllSyncViewsIds(minor);
         initDialogs(rta, syncViewsIds);
         if (minor > 77) {
             const ExtensionPointService = (await __ui5_require_async('open/ux/preview/client/adp/extension-point')).default;
@@ -76,16 +75,34 @@ sap.ui.define([
         }
         log.debug('ADP init executed.');
     };
-    function getAllSyncViewsIds() {
-        const elements = UI5ElementRegistry.all();
+    async function getAllSyncViewsIds(minor) {
         const syncViewIds = [];
-        Object.entries(elements).forEach(_ref => {
-            let [key, ui5Element] = _ref;
-            if (ui5Element?.getMetadata()?.getName()?.includes('XMLView') && ui5Element?.oAsyncState === undefined) {
-                syncViewIds.push(key);
+        try {
+            if (minor < 120) {
+                const Element = (await __ui5_require_async('sap/ui/core/Element')).default;
+                const elements = Element.registry.filter(() => true);
+                elements.forEach(ui5Element => {
+                    if (isSyncView(ui5Element)) {
+                        syncViewIds.push(ui5Element.getId());
+                    }
+                });
+            } else {
+                const ElementRegistry = (await __ui5_require_async('sap/ui/core/ElementRegistry')).default;
+                const elements = ElementRegistry.all();
+                Object.entries(elements).forEach(_ref => {
+                    let [key, ui5Element] = _ref;
+                    if (isSyncView(ui5Element)) {
+                        syncViewIds.push(key);
+                    }
+                });
             }
-        });
+        } catch (error) {
+            log.error('Could not get application sync views', error);
+        }
         return syncViewIds;
     }
+    const isSyncView = element => {
+        return element?.getMetadata()?.getName()?.includes('XMLView') && element?.oAsyncState === undefined;
+    };
     return __exports;
 });

package/dist/client/adp/init.ts

@@ -1,7 +1,5 @@
 import log from 'sap/base/Log';
 import type RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring';
-import UI5ElementRegistry from 'sap/ui/core/ElementRegistry';
-
 import init from '../cpe/init';
 import { initDialogs } from './init-dialogs';
 import {
@@ -46,7 +44,7 @@ export default async function (rta: RuntimeAuthoring) {
         }
     );
 
-    const syncViewsIds = getAllSyncViewsIds();
+    const syncViewsIds = await getAllSyncViewsIds(minor);
     initDialogs(rta, syncViewsIds);
 
     if (minor > 77) {
@@ -77,19 +75,45 @@ export default async function (rta: RuntimeAuthoring) {
 }
 
 /**
- *
  * Get Ids for all sync views
+ * 
+ * @param minor UI5 Version
  *
  * @returns array of Ids for application sync views
  */
-function getAllSyncViewsIds(): string[] {
-    const elements = UI5ElementRegistry.all() as Record<string, UI5Element>;
+async function getAllSyncViewsIds(minor: number): Promise<string[]> {
     const syncViewIds: string[] = [];
-    Object.entries(elements).forEach(([key, ui5Element]) => {
-        if (ui5Element?.getMetadata()?.getName()?.includes('XMLView') && ui5Element?.oAsyncState === undefined) {
-            syncViewIds.push(key);
+    try {
+        if (minor < 120) {
+            const Element = (await import('sap/ui/core/Element')).default;
+            const elements = Element.registry.filter(() => true) as UI5Element[];
+            elements.forEach((ui5Element) => {
+                if (isSyncView(ui5Element)) {
+                    syncViewIds.push(ui5Element.getId());
+                }
+            });
+        } else {
+            const ElementRegistry = (await import('sap/ui/core/ElementRegistry')).default;
+            const elements = ElementRegistry.all() as Record<string, UI5Element>;
+            Object.entries(elements).forEach(([key, ui5Element]) => {
+                if (isSyncView(ui5Element)) {
+                    syncViewIds.push(key);
+                }
+            });
         }
-    });
+    } catch (error) {
+        log.error('Could not get application sync views', error);
+    }
 
     return syncViewIds;
 }
+
+/**
+ * Check if element is sync view
+ *
+ * @param element UI5Element
+ * @returns boolean if element is sync view or not
+ */
+const isSyncView = (element: UI5Element): boolean => {
+    return element?.getMetadata()?.getName()?.includes('XMLView') && element?.oAsyncState === undefined;
+};

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Apreview-middleware"
   },
-  "version": "0.13.37",
+  "version": "0.13.38",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -25,11 +25,11 @@
     "ejs": "3.1.10",
     "mem-fs": "2.1.0",
     "mem-fs-editor": "9.4.0",
-    "@sap-ux/btp-utils": "0.14.4",
-    "@sap-ux/adp-tooling": "0.10.5",
     "@sap-ux/logger": "0.5.1",
+    "@sap-ux/adp-tooling": "0.10.5",
     "@sap-ux/control-property-editor-sources": "npm:@sap-ux/control-property-editor@0.4.20",
-    "@sap-ux/project-access": "1.20.0"
+    "@sap-ux/project-access": "1.20.0",
+    "@sap-ux/btp-utils": "0.14.4"
   },
   "devDependencies": {
     "@types/ejs": "3.1.2",
@@ -45,10 +45,10 @@
     "supertest": "6.3.3",
     "@sap-ux-private/playwright": "0.0.3",
     "dotenv": "16.3.1",
-    "@sap-ux/i18n": "0.0.6",
-    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.9.10",
+    "@private/preview-middleware-client": "npm:@sap-ux-private/preview-middleware-client@0.9.11",
     "@sap-ux/axios-extension": "1.12.3",
-    "@sap-ux/store": "0.5.0"
+    "@sap-ux/store": "0.5.0",
+    "@sap-ux/i18n": "0.0.6"
   },
   "peerDependencies": {
     "express": "4"