@sap-ux/fiori-freestyle-writer 0.14.13 → 0.14.15

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sap-ux/fiori-freestyle-writer",
   "description": "SAP Fiori freestyle application writer",
-  "version": "0.14.13",
+  "version": "0.14.15",
   "repository": {
     "type": "git",
     "url": "https://github.com/SAP/open-ux-tools.git",
@@ -20,9 +20,9 @@
     "!dist/**/*.map"
   ],
   "dependencies": {
-    "@sap-ux/odata-service-writer": "0.14.12",
-    "@sap-ux/ui5-application-writer": "0.17.10",
-    "@sap-ux/ui5-config": "0.15.4",
+    "@sap-ux/odata-service-writer": "0.14.13",
+    "@sap-ux/ui5-application-writer": "0.17.12",
+    "@sap-ux/ui5-config": "0.16.0",
     "ejs": "3.1.7",
     "i18next": "20.3.2",
     "lodash": "4.17.21",

package/templates/listdetail/add/webapp/controller/Detail.controller.ts

@@ -49,7 +49,7 @@ export default class Detail extends BaseController {
      public onListUpdateFinished(event: Event) {
         const viewModel = this.getModel<JSONModel>("detailView");
         const totalItems = event.getParameter("total") as number;
-        let title: string;
+        let title: string | undefined;
         // only update the counter if the length is final
         if ((this.byId("lineItemsList")!.getBinding("items") as ListBinding).isLengthFinal()) {
             if (totalItems) {
@@ -111,7 +111,7 @@ export default class Detail extends BaseController {
         const elementBinding = view.getElementBinding();
 
         // No data for the binding
-        if (!elementBinding.getBoundContext()) {
+        if (!elementBinding?.getBoundContext()) {
             this.getRouter().getTargets()!.display("detailObjectNotFound");
             // if object could not be found, the selection in the list
             // does not make sense anymore.
@@ -121,7 +121,7 @@ export default class Detail extends BaseController {
 
         const path = elementBinding.getPath();
         const resourceBundle = this.getResourceBundle();
-        const detailObject = view.getModel().getObject(path);
+        const detailObject = this.getModel().getObject(path);
         const viewModel = this.getModel<JSONModel>("detailView");
 
         this.getUIComponent().listSelector.selectAListItem(path);

package/templates/listdetail/add/webapp/controller/ErrorHandler.ts

@@ -45,7 +45,7 @@ export default class ErrorHandler extends UI5Object {
         }
         this.messageOpen = true;
         MessageBox.error(
-            ((this.component.getModel("i18n") as ResourceModel).getResourceBundle() as ResourceBundle).getText("errorText"),
+            ((this.component.getModel("i18n") as ResourceModel).getResourceBundle() as ResourceBundle).getText("errorText") || "",
             {
                 id: "serviceErrorMessageBox",
                 details: (event.getParameters() as XMLHttpRequest['response']).response,

package/templates/listdetail/add/webapp/controller/List.controller.ts

@@ -122,7 +122,7 @@ export default class List extends BaseController {
      * and group settings and refreshes the list binding.
      */
     public onRefresh() {
-        this.list.getBinding("items").refresh(false);
+        this.list.getBinding("items")?.refresh(false);
     }
 
     /**

package/templates/listdetail/add/webapp/controller/ListSelector.ts

@@ -27,7 +27,7 @@ export default class ListSelector extends UI5Object {
         this.oWhenListLoadingIsDone = new Promise(function (this: ListSelector, resolve: Function, reject: Function) {
             this._oWhenListHasBeenSet
                 .then(function (this: ListSelector, list: List) {
-                    list.getBinding("items").attachEventOnce("dataReceived",
+                    list.getBinding("items")?.attachEventOnce("dataReceived",
                         function (this: ListSelector) {
                             if (this.list.getItems().length) {
                                 resolve({ list });

package/templates/worklist/add/webapp/controller/ErrorHandler.ts

@@ -44,7 +44,7 @@ export default class ErrorHandler extends UI5Object {
             // Due to batching there can be more than one technical message. However the UX
             // guidelines say "display a single message in a message box" assuming that there
             // will be only one at a time.
-            const errorTitle = resourceBundle.getText(messages.length === 1 ? "errorText" : "multipleErrorsText");
+            const errorTitle = resourceBundle.getText(messages.length === 1 ? "errorText" : "multipleErrorsText") || "";
             this.showServiceError(errorTitle, messages[0].getMessage());
         }, this);
     }

package/templates/worklist/add/webapp/controller/Object.controller.ts

@@ -61,7 +61,7 @@ export default class Object extends BaseController {
         const elementBinding = view.getElementBinding();
 
         // No data for the binding
-        if (!elementBinding.getBoundContext()) {
+        if (!elementBinding?.getBoundContext()) {
             this.getRouter().getTargets()!.display("objectNotFound");
             return;
         }

package/templates/worklist/add/webapp/controller/Worklist.controller.ts

@@ -41,7 +41,7 @@ export default class Worklist extends BaseController {
         const total = event.getParameter("total") as number;
         // only update the counter if the length is final and
         // the table is not empty
-        let title: string;
+        let title: string | undefined;
         if (total && (table.getBinding("items") as ListBinding).isLengthFinal()) {
             title = this.getResourceBundle().getText("worklistTableTitleCount", [total]);
         } else {
@@ -84,7 +84,7 @@ export default class Worklist extends BaseController {
      *
      */
     public onRefresh() {
-        this.byId("table")!.getBinding("items").refresh(false);
+        this.byId("table")?.getBinding("items")?.refresh(false);
     }
 
     /**