@sap-ux/deploy-tooling 0.11.4 → 0.11.6

package/dist/base/validate.d.ts

@@ -8,6 +8,7 @@ export type ValidationInputs = {
     transport: string;
     client: string;
     url: string;
+    destination: string;
 };
 export type ValidationOutput = {
     summary: SummaryRecord[];

package/dist/base/validate.js

@@ -14,6 +14,7 @@ const axios_extension_1 = require("@sap-ux/axios-extension");
 const chalk_1 = require("chalk");
 const project_input_validator_1 = require("@sap-ux/project-input-validator");
 const os_1 = require("os");
+const btp_utils_1 = require("@sap-ux/btp-utils");
 var SummaryStatus;
 (function (SummaryStatus) {
     SummaryStatus[SummaryStatus["Valid"] = 0] = "Valid";
@@ -41,7 +42,7 @@ exports.summaryMessage = {
  * @returns Validation result and a summary report of identified issues.
  */
 function validateBeforeDeploy(config, provider, logger) {
-    var _a, _b, _c, _d, _e, _f;
+    var _a, _b, _c, _d, _e, _f, _g;
     return __awaiter(this, void 0, void 0, function* () {
         const output = {
             summary: [],
@@ -53,10 +54,12 @@ function validateBeforeDeploy(config, provider, logger) {
             package: (_c = config.app.package) !== null && _c !== void 0 ? _c : '',
             transport: (_d = config.app.transport) !== null && _d !== void 0 ? _d : '',
             client: (_e = config.target.client) !== null && _e !== void 0 ? _e : '',
-            url: (_f = config.target.url) !== null && _f !== void 0 ? _f : ''
+            url: (_f = config.target.url) !== null && _f !== void 0 ? _f : '',
+            destination: (_g = config.target.destination) !== null && _g !== void 0 ? _g : ''
         };
         // output is passed by reference and status updated during the internal pipeline below.
         yield validateInputTextFormat(input, output, provider, logger);
+        convertInputsForAdtValidations(input, output);
         yield validatePackageWithAdt(input, output, provider, logger);
         yield validateTransportRequestWithAdt(input, output, provider, logger);
         return output;
@@ -86,7 +89,7 @@ function formatSummary(summary) {
                 statusSymbol = (0, chalk_1.yellow)('?');
                 break;
         }
-        return `${'    '}${statusSymbol} ${next.message}`;
+        return `${' '.repeat(4)}${statusSymbol} ${next.message}`;
     })
         .reduce((aggregated, current) => {
         return `${aggregated}${os_1.EOL}${current}`;
@@ -94,6 +97,29 @@ function formatSummary(summary) {
     return summaryStr;
 }
 exports.formatSummary = formatSummary;
+/**
+ *
+ * @param input
+ * @param output
+ */
+function convertInputsForAdtValidations(input, output) {
+    const upperCasePackageName = input.package.toUpperCase();
+    const upperCaseTransport = input.transport.toUpperCase();
+    if (upperCasePackageName !== input.package) {
+        input.package = upperCasePackageName;
+        output.summary.push({
+            message: `Package name contains lower case letter(s). ${input.package} is used for ADT validation.`,
+            status: SummaryStatus.Unknown
+        });
+    }
+    if (upperCaseTransport !== input.transport) {
+        input.transport = upperCaseTransport;
+        output.summary.push({
+            message: `Transport request number contains lower case letter(s). ${input.transport} is used for ADT validation.`,
+            status: SummaryStatus.Unknown
+        });
+    }
+}
 /**
  * Client-side validation on the deploy configuration based on the
  * known input format constraints.
@@ -120,7 +146,7 @@ function validateInputTextFormat(input, output, provider, logger) {
         processInputValidationResult(result, output);
         result = (0, project_input_validator_1.validateClient)(input.client);
         processInputValidationResult(result, output);
-        result = (0, project_input_validator_1.validateUrl)(input.url);
+        result = validateUrlForOnPremTargetOnly(input.destination, input.url);
         processInputValidationResult(result, output);
         // If all the text validation passed, only show the following success message.
         if (output.result) {
@@ -131,6 +157,26 @@ function validateInputTextFormat(input, output, provider, logger) {
         }
     });
 }
+/**
+ * A wrapper of validateUrl(). It uses same logic in system-access module's createAbapServiceProvider()
+ * function to determine the deploy target. Only validate URL for on-prem ABAP deploy target.
+ *
+ * @param destination
+ * @param url
+ * @returns
+ */
+function validateUrlForOnPremTargetOnly(destination, url) {
+    if ((0, btp_utils_1.isAppStudio)() && destination) {
+        // No validation required for destination name
+        return true;
+    }
+    else if (url) {
+        return (0, project_input_validator_1.validateUrl)(url);
+    }
+    else {
+        return 'Invalid deploy target';
+    }
+}
 /**
  * Helper function that calls ADT service to retrieve system specific prefix
  * requirement for Fiori app name.
@@ -200,10 +246,7 @@ function validatePackageWithAdt(input, output, provider, logger) {
             return;
         }
         // ADT expects input package
-        let inputPackage = input.package;
-        if (inputPackage.toUpperCase() === '$TMP') {
-            inputPackage = '$TMP';
-        }
+        const inputPackage = input.package;
         try {
             const adtService = yield provider.getAdtService(axios_extension_1.ListPackageService);
             if (!adtService) {

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Adeploy-tooling"
   },
-  "version": "0.11.4",
+  "version": "0.11.6",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -32,16 +32,16 @@
     "prompts": "2.4.2",
     "adm-zip": "0.5.10",
     "chalk": "4.1.2",
-    "@sap-ux/axios-extension": "1.7.1",
+    "@sap-ux/axios-extension": "1.7.2",
     "@sap-ux/btp-utils": "0.12.0",
     "@sap-ux/logger": "0.4.0",
-    "@sap-ux/system-access": "0.3.3",
+    "@sap-ux/system-access": "0.3.4",
     "@sap-ux/ui5-config": "0.20.0",
-    "@sap-ux/project-input-validator": "0.2.0"
+    "@sap-ux/project-input-validator": "0.2.1"
   },
   "devDependencies": {
     "@types/prompts": "2.4.4",
-    "@types/adm-zip": "0.5.2",
+    "@types/adm-zip": "0.5.3",
     "@sap-ux/store": "0.4.0"
   },
   "ui5": {