@sap-ux/create 1.3.26 → 1.4.2

package/dist/cli/utils/system-lookup.js

@@ -0,0 +1,94 @@
+import prompts from 'prompts';
+import { BackendSystemKey as BackendSystemKeyClass, ConnectionType } from '@sap-ux/store';
+import { getLogger } from '../../tracing/index.js';
+import { t } from '../../i18n.js';
+/**
+ * Finds a backend system by URL with smart matching when client is not specified or doesn't match.
+ *
+ * Logic:
+ * 1. Find all systems with the same URL (across all connection types).
+ * 2. If exactly one system found, use it automatically.
+ * 3. If multiple systems found, try exact match first, then prompt user to select if no exact match.
+ * 4. If none found, return undefined.
+ *
+ * @param url - URL of the backend system
+ * @param client - optional SAP client
+ * @param service - backend system service
+ * @returns the matched system, or undefined if not found or user cancelled
+ */
+export async function findSystemByUrl(url, client, service) {
+    const logger = getLogger();
+    // Normalize URL for comparison (remove trailing slash)
+    const normalizedUrl = url.trim().replace(/\/$/, '');
+    // Search all systems with this URL (across all connection types)
+    // Explicitly specify all connection types to bypass the default 'abap_catalog' filter
+    logger.debug(`Searching for systems with URL: ${normalizedUrl}`);
+    const allSystems = await service.getAll({
+        backendSystemFilter: {
+            connectionType: Object.values(ConnectionType)
+        }
+    });
+    const matches = allSystems.filter((s) => {
+        const systemUrl = s.url.trim().replace(/\/$/, '');
+        return systemUrl === normalizedUrl;
+    });
+    if (matches.length === 0) {
+        logger.debug(`No systems found with URL: ${normalizedUrl}`);
+        return undefined;
+    }
+    if (matches.length === 1) {
+        logger.debug(`Found single system with URL ${normalizedUrl}: ${matches[0].name}`);
+        return matches[0];
+    }
+    // Multiple matches - only try exact match if client was explicitly provided
+    if (client !== undefined) {
+        const exactKey = new BackendSystemKeyClass({ url: normalizedUrl, client });
+        const exactMatch = matches.find((s) => {
+            const systemClient = s.client || undefined;
+            return systemClient === client;
+        });
+        if (exactMatch) {
+            logger.debug(`Found exact match for ${exactKey.getId()}: ${exactMatch.name}`);
+            return exactMatch;
+        }
+    }
+    // No exact match or client not provided - prompt user to select from multiple matches
+    return await promptToSelectSystem(matches);
+}
+/**
+ * Prompts the user to select a system from multiple matches.
+ *
+ * @param systems - list of matching systems
+ * @returns the selected system, or undefined if cancelled
+ */
+async function promptToSelectSystem(systems) {
+    const logger = getLogger();
+    logger.info(t('systemLookup.multipleSystemsFound', { count: systems.length }));
+    systems.forEach((s, index) => {
+        const clientInfo = s.client
+            ? ` ${t('systemLookup.clientInfo', { client: s.client })}`
+            : ` ${t('systemLookup.noClient')}`;
+        logger.info(`${index + 1}. ${s.name}${clientInfo}`);
+    });
+    const answer = await prompts({
+        type: 'select',
+        name: 'index',
+        message: t('systemLookup.selectSystemPrompt'),
+        choices: systems.map((s, index) => {
+            const clientLabel = s.client
+                ? ` ${t('systemLookup.clientInfo', { client: s.client })}`
+                : ` ${t('systemLookup.noClient')}`;
+            return {
+                title: `${s.name}${clientLabel}`,
+                value: index
+            };
+        }),
+        initial: 0
+    });
+    if (answer.index == null || answer.index < 0 || answer.index >= systems.length) {
+        logger.debug('User cancelled system selection or invalid index');
+        return undefined;
+    }
+    return systems[answer.index];
+}
+//# sourceMappingURL=system-lookup.js.map

package/dist/cli/utils/system-prompts.d.ts

@@ -1,16 +1,24 @@
 import type { BackendSystem } from '@sap-ux/store';
+import { SystemType, AuthenticationType, ConnectionType } from '@sap-ux/store';
+/**
+ * Error thrown when user cancels credential clearing operation.
+ */
+export declare class ClearCredentialsCancelledError extends Error {
+    constructor();
+}
 /**
  * Prompts for complete system configuration, filling in any missing fields.
  *
  * @param partial - Partial system configuration with some fields already provided
- * @param partial.name
- * @param partial.url
- * @param partial.client
- * @param partial.systemType
- * @param partial.authenticationType
- * @param partial.connectionType
- * @param partial.username
- * @param partial.password
+ * @param partial.name - System display name
+ * @param partial.url - System URL
+ * @param partial.client - SAP client (optional)
+ * @param partial.systemType - System type
+ * @param partial.authenticationType - Authentication type
+ * @param partial.connectionType - Connection type
+ * @param partial.username - Username for basic auth
+ * @param partial.password - Password for basic auth
+ * @param partial.skipCredentialsPrompt - skip credential prompts entirely
  * @returns Complete system configuration with all required fields
  */
 export declare function promptForSystemConfig(partial: {
@@ -22,13 +30,14 @@ export declare function promptForSystemConfig(partial: {
     connectionType?: string;
     username?: string;
     password?: string;
+    skipCredentialsPrompt?: boolean;
 }): Promise<{
     name: string;
     url: string;
     client?: string;
-    systemType: string;
-    authenticationType: string;
-    connectionType: string;
+    systemType: SystemType;
+    authenticationType: AuthenticationType;
+    connectionType: ConnectionType;
     username?: string;
     password?: string;
 }>;

package/dist/cli/utils/system-prompts.js

@@ -1,6 +1,16 @@
 import prompts from 'prompts';
 import { SystemType, AuthenticationType, ConnectionType, isSystemNameInUse } from '@sap-ux/store';
-import { validateClient } from '@sap-ux/project-input-validator';
+import { validateClient, validateUrl } from '@sap-ux/project-input-validator';
+import { t } from '../../i18n.js';
+/**
+ * Error thrown when user cancels credential clearing operation.
+ */
+export class ClearCredentialsCancelledError extends Error {
+    constructor() {
+        super('Clear credentials cancelled');
+        this.name = 'ClearCredentialsCancelledError';
+    }
+}
 /**
  * Checks if a string is empty or contains only whitespace.
  *
@@ -10,21 +20,6 @@ import { validateClient } from '@sap-ux/project-input-validator';
 function isEmptyString(value) {
     return !value || !/\S/.test(value);
 }
-/**
- * Checks if a string is a valid URL.
- *
- * @param value - The value to check
- * @returns true if valid URL, false otherwise
- */
-function isValidUrl(value) {
-    try {
-        const url = new URL(value);
-        return !!url.protocol && !!url.host;
-    }
-    catch {
-        return false;
-    }
-}
 /**
  * Validates that a string is not empty after trimming whitespace.
  *
@@ -32,7 +27,7 @@ function isValidUrl(value) {
  * @returns True if valid, error message otherwise
  */
 function validateNonEmpty(value) {
-    return isEmptyString(value) ? 'This field is required and cannot be empty' : true;
+    return isEmptyString(value) ? t('systemPrompts.validation.fieldRequired') : true;
 }
 /**
  * Validates that a URL is in correct format.
@@ -45,7 +40,11 @@ function validateUrlField(value) {
     if (nonEmptyCheck !== true) {
         return nonEmptyCheck;
     }
-    return isValidUrl(value) ? true : 'Please enter a valid URL (e.g., https://my-system.example.com)';
+    const result = validateUrl(value);
+    if (result === true) {
+        return true;
+    }
+    return typeof result === 'string' ? result : t('systemPrompts.validation.invalidUrl');
 }
 /**
  * Validates that a client number is in correct format (empty or 3-digit number).
@@ -80,55 +79,29 @@ async function validateSystemNameUniqueness(value, excludeSystem) {
             }
         }
         if (isTaken) {
-            return `A system with the name '${value}' already exists. Please choose a different name.`;
-        }
-        return true;
-    }
-    catch (error) {
-        // Catch and convert service errors to validation messages to prevent duplicate names
-        console.error('Error checking system name uniqueness:', error);
-        return 'Unable to check system name uniqueness. Please try again.';
-    }
-}
-/**
- * Validates that a system name is unique when updating (excluding the current system).
- *
- * @param value - The system name to validate
- * @param currentSystem - The system being updated (to exclude from uniqueness check)
- * @returns True if valid, error message otherwise
- */
-async function validateSystemNameUniquenessForUpdate(value, currentSystem) {
-    const nonEmptyCheck = validateNonEmpty(value);
-    if (nonEmptyCheck !== true) {
-        return nonEmptyCheck;
-    }
-    try {
-        const isTaken = await isSystemNameInUse(value);
-        // Allow keeping the same name (case-insensitive)
-        const isSameName = currentSystem.name.trim().toLowerCase() === value.trim().toLowerCase();
-        if (isTaken && !isSameName) {
-            return `A system with the name '${value}' already exists. Please choose a different name.`;
+            return t('systemPrompts.validation.systemNameExists', { name: value });
         }
         return true;
     }
     catch (error) {
         // Catch and convert service errors to validation messages to prevent duplicate names
         console.error('Error checking system name uniqueness:', error);
-        return 'Unable to check system name uniqueness. Please try again.';
+        return t('systemPrompts.validation.checkNameFailed');
     }
 }
 /**
  * Prompts for complete system configuration, filling in any missing fields.
  *
  * @param partial - Partial system configuration with some fields already provided
- * @param partial.name
- * @param partial.url
- * @param partial.client
- * @param partial.systemType
- * @param partial.authenticationType
- * @param partial.connectionType
- * @param partial.username
- * @param partial.password
+ * @param partial.name - System display name
+ * @param partial.url - System URL
+ * @param partial.client - SAP client (optional)
+ * @param partial.systemType - System type
+ * @param partial.authenticationType - Authentication type
+ * @param partial.connectionType - Connection type
+ * @param partial.username - Username for basic auth
+ * @param partial.password - Password for basic auth
+ * @param partial.skipCredentialsPrompt - skip credential prompts entirely
  * @returns Complete system configuration with all required fields
  */
 export async function promptForSystemConfig(partial) {
@@ -137,7 +110,7 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'text',
             name: 'name',
-            message: 'System name (display name):',
+            message: t('systemPrompts.prompts.systemName'),
             validate: (value) => validateSystemNameUniqueness(value)
         });
     }
@@ -145,7 +118,7 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'text',
             name: 'url',
-            message: 'System URL:',
+            message: t('systemPrompts.prompts.systemUrl'),
             validate: validateUrlField
         });
     }
@@ -153,7 +126,7 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'text',
             name: 'client',
-            message: 'SAP client (optional, press Enter to skip):',
+            message: t('systemPrompts.prompts.sapClient'),
             validate: validateClientField
         });
     }
@@ -161,7 +134,7 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'select',
             name: 'systemType',
-            message: 'System type:',
+            message: t('systemPrompts.prompts.systemType'),
             choices: Object.values(SystemType).map((type) => ({ title: type, value: type }))
         });
     }
@@ -169,7 +142,7 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'select',
             name: 'authenticationType',
-            message: 'Authentication type:',
+            message: t('systemPrompts.prompts.authenticationType'),
             choices: Object.values(AuthenticationType).map((type) => ({ title: type, value: type }))
         });
     }
@@ -177,34 +150,47 @@ export async function promptForSystemConfig(partial) {
         questions.push({
             type: 'select',
             name: 'connectionType',
-            message: 'Connection type:',
+            message: t('systemPrompts.prompts.connectionType'),
             choices: Object.values(ConnectionType).map((type) => ({ title: type, value: type }))
         });
     }
-    if (partial.username === undefined) {
-        questions.push({
+    // Prompt for basic questions first
+    const answers = questions.length > 0 ? await prompts(questions) : {};
+    // Determine final authenticationType (from partial or answers)
+    const finalAuthType = partial.authenticationType || answers.authenticationType;
+    // Only prompt for credentials if:
+    // 1. skipCredentialsPrompt flag is NOT set, AND
+    // 2. authenticationType is 'basic' (other types don't use username/password)
+    const shouldPromptCredentials = !partial.skipCredentialsPrompt && finalAuthType === 'basic';
+    // Display informational message for re-entrance ticket authentication
+    if (finalAuthType === 'reentranceTicket') {
+        console.log(t('systemPrompts.prompts.reentranceTicketNote'));
+    }
+    const credentialQuestions = [];
+    if (shouldPromptCredentials && partial.username === undefined) {
+        credentialQuestions.push({
             type: 'text',
             name: 'username',
-            message: 'Username (optional, press Enter to skip):'
+            message: t('systemPrompts.prompts.username')
         });
     }
-    if (partial.password === undefined) {
-        questions.push({
+    if (shouldPromptCredentials && partial.password === undefined) {
+        credentialQuestions.push({
             type: 'password',
             name: 'password',
-            message: 'Password (optional, press Enter to skip):'
+            message: t('systemPrompts.prompts.password')
         });
     }
-    const answers = questions.length > 0 ? await prompts(questions) : {};
+    const credentialAnswers = credentialQuestions.length > 0 ? await prompts(credentialQuestions) : {};
     return {
         name: partial.name || answers.name,
         url: partial.url || answers.url,
         client: partial.client ?? (answers.client || undefined),
-        systemType: partial.systemType || answers.systemType,
-        authenticationType: partial.authenticationType || answers.authenticationType,
-        connectionType: partial.connectionType || answers.connectionType,
-        username: partial.username ?? (answers.username || undefined),
-        password: partial.password ?? (answers.password || undefined)
+        systemType: (partial.systemType || answers.systemType),
+        authenticationType: finalAuthType,
+        connectionType: (partial.connectionType || answers.connectionType),
+        username: partial.username ?? (credentialAnswers?.username || undefined),
+        password: partial.password ?? (credentialAnswers?.password || undefined)
     };
 }
 /**
@@ -221,15 +207,17 @@ export async function promptForSystemIdentifier(partial) {
         questions.push({
             type: 'text',
             name: 'url',
-            message: 'System URL:',
+            message: t('systemPrompts.prompts.systemUrl'),
             validate: validateUrlField
         });
     }
-    if (partial.client === undefined) {
+    // Only prompt for client if URL is also being prompted (fully interactive mode)
+    // When URL is provided via flag, skip client prompt - let smart lookup handle multiple matches
+    if (!partial.url && partial.client === undefined) {
         questions.push({
             type: 'text',
             name: 'client',
-            message: 'SAP client (optional, press Enter to skip):',
+            message: t('systemPrompts.prompts.sapClient'),
             validate: validateClientField
         });
     }
@@ -249,16 +237,25 @@ export async function promptForUpdateFields(existing) {
     const answer = await prompts({
         type: 'multiselect',
         name: 'fields',
-        message: 'Select fields to update:',
+        message: t('systemPrompts.updateFields.selectPrompt'),
         choices: [
-            { title: `Name (current: ${existing.name})`, value: 'name' },
-            { title: `Username (current: ${existing.username || '(none)'})`, value: 'username' },
-            { title: 'Password', value: 'password' }
+            {
+                title: t('systemPrompts.updateFields.nameLabel', { name: existing.name }),
+                value: 'name'
+            },
+            {
+                title: t('systemPrompts.updateFields.usernameLabel', {
+                    username: existing.username || t('systemPrompts.updateFields.usernameNone')
+                }),
+                value: 'username'
+            },
+            { title: t('systemPrompts.updateFields.passwordLabel'), value: 'password' },
+            { title: t('systemPrompts.updateFields.clearCredentialsLabel'), value: 'clearCredentials' }
         ],
         min: 1
     });
     if (!answer.fields || answer.fields.length === 0) {
-        throw new Error('At least one field must be selected');
+        throw new Error(t('systemPrompts.updateFields.minOneRequired'));
     }
     return answer.fields;
 }
@@ -270,6 +267,25 @@ export async function promptForUpdateFields(existing) {
  * @returns Object with new values for the specified fields
  */
 export async function promptForFieldUpdates(fields, existing) {
+    // Track if clearCredentials was requested
+    const clearCredentialsRequested = fields.includes('clearCredentials');
+    // Handle clearCredentials separately - it doesn't need a prompt, only confirmation
+    if (clearCredentialsRequested) {
+        const answer = await prompts({
+            type: 'confirm',
+            name: 'confirmClear',
+            message: t('systemPrompts.updateFields.clearCredentialsConfirm'),
+            initial: false
+        });
+        if (!answer.confirmClear) {
+            throw new ClearCredentialsCancelledError();
+        }
+        // Remove clearCredentials from fields to process
+        fields = fields.filter((f) => f !== 'clearCredentials');
+        if (fields.length === 0) {
+            return { clearCredentials: true };
+        }
+    }
     const questions = fields
         .map((field) => {
         switch (field) {
@@ -277,15 +293,15 @@ export async function promptForFieldUpdates(fields, existing) {
                 return {
                     type: 'text',
                     name: 'name',
-                    message: 'New system name:',
+                    message: t('systemPrompts.updateFields.newNamePrompt'),
                     initial: existing.name,
-                    validate: (value) => validateSystemNameUniquenessForUpdate(value, existing)
+                    validate: (value) => validateSystemNameUniqueness(value, existing)
                 };
             case 'username':
                 return {
                     type: 'text',
                     name: 'username',
-                    message: 'New username:',
+                    message: t('systemPrompts.updateFields.newUsernamePrompt'),
                     initial: existing.username || '',
                     validate: validateNonEmpty
                 };
@@ -293,7 +309,7 @@ export async function promptForFieldUpdates(fields, existing) {
                 return {
                     type: 'password',
                     name: 'password',
-                    message: 'New password:',
+                    message: t('systemPrompts.updateFields.newPasswordPrompt'),
                     validate: validateNonEmpty
                 };
             default:
@@ -301,7 +317,12 @@ export async function promptForFieldUpdates(fields, existing) {
         }
     })
         .filter((q) => q !== null);
-    return await prompts(questions);
+    const result = await prompts(questions);
+    // Add clearCredentials flag if it was originally selected
+    if (clearCredentialsRequested) {
+        result.clearCredentials = true;
+    }
+    return result;
 }
 /**
  * Prompts for confirmation before removing a system.
@@ -313,7 +334,7 @@ export async function promptForRemoveConfirmation(systemName) {
     const answer = await prompts({
         type: 'confirm',
         name: 'confirm',
-        message: `Are you sure you want to remove system '${systemName}'?`,
+        message: t('systemPrompts.removeConfirmation.prompt', { systemName }),
         initial: false
     });
     return answer.confirm === true;

package/dist/i18n.d.ts

@@ -0,0 +1,15 @@
+import type { i18n as i18nNext, TOptions } from 'i18next';
+export declare const i18n: i18nNext;
+/**
+ * Initialize i18next with the translations for this module.
+ */
+export declare function initI18n(): Promise<void>;
+/**
+ * Helper function facading the call to i18next. Unless a namespace option is provided, the local namespace will be used.
+ *
+ * @param key i18n key
+ * @param options additional options
+ * @returns {string} localized string stored for the given key
+ */
+export declare function t(key: string, options?: TOptions): string;
+//# sourceMappingURL=i18n.d.ts.map

package/dist/i18n.js

@@ -0,0 +1,41 @@
+import i18next from 'i18next';
+import translations from './translations/ux-create.i18n.json' with { type: 'json' };
+const NS = 'ux-create';
+export const i18n = i18next.createInstance();
+let isInitialized = false;
+/**
+ * Initialize i18next with the translations for this module.
+ */
+export async function initI18n() {
+    await i18n.init({
+        resources: {
+            en: {
+                [NS]: translations
+            }
+        },
+        lng: 'en',
+        fallbackLng: 'en',
+        defaultNS: NS,
+        ns: [NS],
+        interpolation: { escapeValue: false }
+    });
+    isInitialized = true;
+}
+/**
+ * Helper function facading the call to i18next. Unless a namespace option is provided, the local namespace will be used.
+ *
+ * @param key i18n key
+ * @param options additional options
+ * @returns {string} localized string stored for the given key
+ */
+export function t(key, options) {
+    if (!isInitialized) {
+        console.warn(`[i18n] t() called before initI18n() - returning key: ${key}`);
+        return key;
+    }
+    if (!options?.ns) {
+        options = Object.assign(options ?? {}, { ns: NS });
+    }
+    return i18n.t(key, options);
+}
+//# sourceMappingURL=i18n.js.map

package/dist/index.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
 import { handleCreateFioriCommand } from './cli/index.js';
-handleCreateFioriCommand(process.argv);
+// Use top-level await since handleCreateFioriCommand is now async (for i18n init)
+await handleCreateFioriCommand(process.argv);
 //# sourceMappingURL=index.js.map

package/dist/translations/ux-create.i18n.json

@@ -0,0 +1,68 @@
+{
+    "systemLookup": {
+        "multipleSystemsFound_one": "{{count}} system found with this URL:",
+        "multipleSystemsFound_other": "{{count}} systems found with this URL:",
+        "selectSystemPrompt": "Which system do you want to use?",
+        "clientInfo": "(Client: {{client}})",
+        "noClient": "(No Client)"
+    },
+    "systemPrompts": {
+        "validation": {
+            "fieldRequired": "This is a required field and can't be empty.",
+            "invalidUrl": "Please enter a valid URL, for example https://my-system.example.com",
+            "systemNameExists": "A system with the name '{{name}}' already exists. Please choose a different name.",
+            "checkNameFailed": "Unable to check if the system name is unique. Please try again."
+        },
+        "prompts": {
+            "systemName": "System Name: ",
+            "systemUrl": "System URL: ",
+            "sapClient": "SAP Client (Optional - Press Enter to Skip): ",
+            "systemType": "System Type: ",
+            "authenticationType": "Authentication Type: ",
+            "connectionType": "Connection Type: ",
+            "username": "Username (Optional - Press Enter to Skip): ",
+            "password": "Password (Optional - Press Enter to Skip): ",
+            "reentranceTicketNote": "\nNote: Re-entrance ticket authentication will open a browser tab when the system is first used.\n"
+        },
+        "updateFields": {
+            "selectPrompt": "Select Fields to Update:",
+            "nameLabel": "Name (Existing: {{name}})",
+            "usernameLabel": "Username (Existing: {{username}})",
+            "usernameNone": "(None)",
+            "passwordLabel": "Password",
+            "clearCredentialsLabel": "Clear Stored Credentials",
+            "clearCredentialsConfirm": "Are you sure you want to clear all stored credentials?",
+            "minOneRequired": "You must select at least one field.",
+            "newNamePrompt": "New System Name:",
+            "newUsernamePrompt": "New Username:",
+            "newPasswordPrompt": "New Password:"
+        },
+        "removeConfirmation": {
+            "prompt": "Are you sure you want to remove system '{{systemName}}'?"
+        }
+    },
+    "systemConnection": {
+        "invalidUrl": "Invalid URL: {{url}}",
+        "skippingCheck": "Skipping connection check (--skip-connection-validation flag provided)",
+        "verifying": "Verifying connection to the back-end system...",
+        "connectionSuccessful": "✓ Connection established",
+        "connectionFailed": "Connection check failed: {{error}}",
+        "unknownError": "Unknown error",
+        "saveAnywayPrompt": "Connection check failed. Save system anyway?",
+        "catalogServicesFound_one": "{{count}} catalog service found",
+        "catalogServicesFound_other": "{{count}} catalog services found",
+        "metadataRequestSuccessful": "✓ Metadata requested",
+        "unexpectedStatus": "Unexpected response status: {{status}}"
+    },
+    "systemActions": {
+        "systemNotAdded": "System wasn't added",
+        "systemNotAddedInvalidConfig": "The system wasn't added due to an invalid system configuration. Check the error logs for more details.",
+        "systemNotAddedDuplicate": "The system wasn't added due to a duplicate system configuration. Check the error logs for more details.",
+        "systemNotSaved": "System wasn't saved",
+        "systemNotUpdated": "System wasn't updated",
+        "operationCancelled": "Operation canceled",
+        "systemAdded": "System '{{name}}' added",
+        "systemUpdated": "System '{{name}}' updated",
+        "systemRemoved": "System '{{name}}' removed"
+    }
+}