@sap-ux/control-property-editor 0.4.3 → 0.4.4

package/package.json

@@ -3,7 +3,7 @@
   "displayName": "Control Property Editor",
   "description": "Control Property Editor",
   "license": "Apache-2.0",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "main": "dist/app.js",
   "repository": {
     "type": "git",
@@ -49,8 +49,8 @@
     "autoprefixer": "10.4.7",
     "postcss": "8.4.31",
     "yargs-parser": "21.1.1",
-    "@sap-ux-private/control-property-editor-common": "0.3.1",
-    "@sap-ux/ui-components": "1.13.3"
+    "@sap-ux/ui-components": "1.13.4",
+    "@sap-ux-private/control-property-editor-common": "0.3.1"
   },
   "scripts": {
     "clean": "rimraf ./dist ./coverage *.tsbuildinfo",

package/src/App.tsx

@@ -4,6 +4,8 @@ import { useSelector } from 'react-redux';
 import { useTranslation } from 'react-i18next';
 import { UIDialog, UILink, UIToggle } from '@sap-ux/ui-components';
 
+import type { Scenario } from '@sap-ux-private/control-property-editor-common';
+
 import { PropertiesPanel, LeftPanel } from './panels';
 import { useLocalStorage } from './use-local-storage';
 import type { RootState } from './store';
@@ -37,6 +39,7 @@ export default function App(appProps: AppProps): ReactElement {
     }, []);
     const { t } = useTranslation();
     const dispatch = useAppDispatch();
+    const scenario = useSelector<RootState, Scenario>((state) => state.scenario);
     const [hideWarningDialog, setHideWarningDialog] = useLocalStorage('hide-warning-dialog', false);
     const [isWarningDialogVisible, setWarningDialogVisibility] = useState(() => hideWarningDialog !== true);
 
@@ -107,30 +110,34 @@ export default function App(appProps: AppProps): ReactElement {
                 <PropertiesPanel />
             </section>
 
-            <UIDialog
-                hidden={!isWarningDialogVisible}
-                closeButtonAriaLabel={t('CLOSE')}
-                dialogContentProps={{
-                    title: t('TOOL_DISCLAIMER_TITLE'),
-                    subText: t('TOOL_DISCLAIMER_TEXT')
-                }}
-                acceptButtonText={t('OK')}
-                onAccept={closeWarningDialog}>
-                <UILink href="https://ui5.sap.com/#/topic/03265b0408e2432c9571d6b3feb6b1fd">
-                    {t('FE_DOCUMENTATION_LINK_TEXT')}
-                </UILink>
-                <UIToggle
-                    className="space space-toggle"
-                    label={t('DONT_SHOW_WARNING_ON_START')}
-                    inlineLabel
-                    inlineLabelLeft
-                    labelFlexGrow
-                    checked={hideWarningDialog}
-                    onChange={(_event, checked = false): void => {
-                        setHideWarningDialog(checked);
+            {scenario === 'FE_FROM_SCRATCH' ? (
+                <UIDialog
+                    hidden={!isWarningDialogVisible}
+                    closeButtonAriaLabel={t('CLOSE')}
+                    dialogContentProps={{
+                        title: t('TOOL_DISCLAIMER_TITLE'),
+                        subText: t('TOOL_DISCLAIMER_TEXT')
                     }}
-                />
-            </UIDialog>
+                    acceptButtonText={t('OK')}
+                    onAccept={closeWarningDialog}>
+                    <UILink href="https://ui5.sap.com/#/topic/03265b0408e2432c9571d6b3feb6b1fd">
+                        {t('FE_DOCUMENTATION_LINK_TEXT')}
+                    </UILink>
+                    <UIToggle
+                        className="space space-toggle"
+                        label={t('DONT_SHOW_WARNING_ON_START')}
+                        inlineLabel
+                        inlineLabelLeft
+                        labelFlexGrow
+                        checked={hideWarningDialog}
+                        onChange={(_event, checked = false): void => {
+                            setHideWarningDialog(checked);
+                        }}
+                    />
+                </UIDialog>
+            ) : (
+                <></>
+            )}
         </div>
     );
 }

package/test/unit/App.test.tsx

@@ -6,7 +6,7 @@ import { render, mockDomEventListener } from './utils';
 import { initI18n } from '../../src/i18n';
 
 import App from '../../src/App';
-import { controlSelected } from '@sap-ux-private/control-property-editor-common';
+import { controlSelected, scenarioLoaded } from '@sap-ux-private/control-property-editor-common';
 import { mockResizeObserver } from '../utils/utils';
 import { InputType } from '../../src/panels/properties/types';
 import { registerAppIcons } from '../../src/icons';
@@ -163,8 +163,17 @@ test('renders properties', () => {
     expect(notFoundException).toBeTruthy();
 });
 
-test('renders warning dialog', async () => {
+test('does not render warning dialog', async () => {
     render(<App previewUrl="" />);
+    const dialogContent = screen.queryByText(
+        /The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported./i
+    );
+    expect(dialogContent).not.toBeInTheDocument();
+});
+
+test('renders warning dialog for "FE_FROM_SCRATCH" scenario', async () => {
+    const { store } = render(<App previewUrl="" />, { initialState });
+    store.dispatch(scenarioLoaded('FE_FROM_SCRATCH'));
     const dialogContent = screen.getByText(
         /The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported./i
     );