@sap-ux/cf-deploy-config-writer 1.0.8 → 1.0.9

package/dist/cf-writer/app-config.js

@@ -195,31 +195,33 @@ export async function generateMTAFile(cfConfig, fs) {
  */
 async function appendAppRouter(cfConfig, fs) {
     const mtaInstance = await getMtaConfig(cfConfig.rootPath);
-    if (mtaInstance) {
-        await mtaInstance.addRoutingModules({
-            isManagedApp: cfConfig.addManagedAppRouter,
-            isAppFrontApp: cfConfig.addAppFrontendRouter,
-            addMissingModules: !cfConfig.addAppFrontendRouter
-        });
-        const appModule = cfConfig.appId;
-        const appRelativePath = toPosixPath(relative(cfConfig.rootPath, cfConfig.appPath));
-        await mtaInstance.addApp(appModule, appRelativePath ?? '.');
-        if ((cfConfig.addMtaDestination && cfConfig.isCap) || cfConfig.destinationName === DefaultMTADestination) {
-            // If the destination instance identifier is passed, create a destination instance
-            cfConfig.destinationName =
-                cfConfig.destinationName === DefaultMTADestination ? SRV_API : cfConfig.destinationName;
-            await mtaInstance.addDestinationToAppRouter(cfConfig.destinationName);
-            // This is required where a managed or standalone router hasn't been added yet to mta.yaml
-            if (!mtaInstance.hasManagedXsuaaResource()) {
-                cfConfig.destinationAuthentication = Authentication.NO_AUTHENTICATION;
-            }
-        }
-        cleanupStandaloneRoutes(cfConfig, mtaInstance, fs);
-        await saveMta(cfConfig, mtaInstance);
-        // Modify existing config, required in later steps
-        cfConfig.cloudServiceName = mtaInstance.cloudServiceName;
-        cfConfig.addAppFrontendRouter = mtaInstance.hasAppFrontendRouter();
+    if (!mtaInstance) {
+        return;
+    }
+    await mtaInstance.addRoutingModules({
+        isManagedApp: cfConfig.addManagedAppRouter,
+        isAppFrontApp: cfConfig.addAppFrontendRouter,
+        addMissingModules: !cfConfig.addAppFrontendRouter
+    });
+    const appRelativePath = toPosixPath(relative(cfConfig.rootPath, cfConfig.appPath));
+    await mtaInstance.addApp(cfConfig.appId, appRelativePath ?? '.');
+    // Resolve destination name before any mutations — DefaultMTADestination is a sentinel for "use SRV_API"
+    const shouldAddDestination = (!!cfConfig.addMtaDestination && !!cfConfig.isCap) || cfConfig.destinationName === DefaultMTADestination;
+    const destinationNameForMta = cfConfig.destinationName === DefaultMTADestination ? SRV_API : cfConfig.destinationName;
+    const resolvedDestinationName = shouldAddDestination ? destinationNameForMta : cfConfig.destinationName;
+    if (shouldAddDestination) {
+        await mtaInstance.addDestinationToAppRouter(resolvedDestinationName);
+    }
+    cleanupStandaloneRoutes(cfConfig, mtaInstance, fs);
+    // Apply all config mutations together once MTA state is finalised
+    cfConfig.destinationName = resolvedDestinationName;
+    // Required where a managed or standalone router hasn't been added yet to mta.yaml
+    if (shouldAddDestination && !mtaInstance.hasManagedXsuaaResource()) {
+        cfConfig.destinationAuthentication = Authentication.NO_AUTHENTICATION;
     }
+    cfConfig.cloudServiceName = mtaInstance.cloudServiceName;
+    cfConfig.addAppFrontendRouter = mtaInstance.hasAppFrontendRouter();
+    await saveMta(cfConfig, mtaInstance);
 }
 /**
  * Cleans up standalone routes in a Cloud Foundry application configuration.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sap-ux/cf-deploy-config-writer",
   "description": "Add or amend Cloud Foundry and ABAP deployment configuration for SAP projects",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "repository": {
     "type": "git",
     "url": "https://github.com/SAP/open-ux-tools.git",
@@ -30,12 +30,12 @@
     "mem-fs": "2.1.0",
     "mem-fs-editor": "9.4.0",
     "hasbin": "1.2.3",
-    "@sap-ux/project-access": "2.1.2",
-    "@sap-ux/yaml": "1.0.1",
     "@sap-ux/btp-utils": "2.0.2",
     "@sap-ux/logger": "1.0.1",
+    "@sap-ux/project-access": "2.1.2",
     "@sap-ux/ui5-config": "1.0.3",
-    "@sap-ux/nodejs-utils": "1.0.3"
+    "@sap-ux/nodejs-utils": "1.0.3",
+    "@sap-ux/yaml": "1.0.1"
   },
   "devDependencies": {
     "@jest/globals": "30.3.0",