@sap-ux/cf-deploy-config-writer 0.3.63 → 0.3.65

package/dist/cf-writer/app-config.js

@@ -26,9 +26,7 @@ const i18n_1 = require("../i18n");
  * @returns file system reference
  */
 async function generateAppConfig(cfAppConfig, fs, logger) {
-    if (!fs) {
-        fs = (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
-    }
+    fs ??= (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
     if (logger) {
         logger_helper_1.default.logger = logger;
     }
@@ -55,16 +53,16 @@ async function getUpdatedConfig(cfAppConfig, fs) {
     (0, utils_1.enforceValidRouterConfig)(cfAppConfig);
     const config = {
         appPath: cfAppConfig.appPath.replace(/\/$/, ''),
-        destinationName: cfAppConfig.destinationName || destination,
+        destinationName: cfAppConfig.destinationName ?? destination,
         addManagedAppRouter: cfAppConfig.addManagedAppRouter,
         addAppFrontendRouter: cfAppConfig.addAppFrontendRouter,
         addMtaDestination: cfAppConfig.addMtaDestination ?? false,
         cloudServiceName: cfAppConfig.cloudServiceName,
         lcapMode: !isCap ? false : isLCAP, // Restricting local changes is only applicable for CAP flows
         isMtaRoot: hasRoot ?? false,
-        serviceHost: cfAppConfig.serviceHost || serviceHost,
+        serviceHost: cfAppConfig.serviceHost ?? serviceHost,
         rootPath: rootPath.replace(/\/$/, ''),
-        destinationAuthentication: cfAppConfig.destinationAuthentication || destinationAuthentication,
+        destinationAuthentication: cfAppConfig.destinationAuthentication ?? destinationAuthentication,
         isDestinationFullUrl: cfAppConfig.isDestinationFullUrl ?? destinationIsFullUrl,
         apiHubConfig: cfAppConfig.apiHubConfig,
         firstServicePathSegment: firstServicePathSegmentUI5Config ?? firstServicePathSegment ?? '<apply-service-segment-path>',
@@ -138,10 +136,11 @@ async function processUI5Config(appPath, fs) {
  * @returns servicePath, firstServicePathSegment and appId properties
  */
 async function processManifest(appPath, fs) {
-    const manifest = await (0, utils_1.readManifest)((0, node_path_1.join)(await (0, project_access_1.getWebappPath)(appPath), project_access_1.FileName.Manifest), fs);
-    const appId = manifest?.['sap.app']?.id ? (0, mta_config_1.toMtaModuleName)(manifest?.['sap.app']?.id) : undefined;
+    const webappPath = await (0, project_access_1.getWebappPath)(appPath);
+    const manifest = (0, utils_1.readManifest)((0, node_path_1.join)(webappPath, project_access_1.FileName.Manifest), fs);
+    const appId = manifest?.['sap.app']?.id ? (0, mta_config_1.toMtaModuleName)(manifest['sap.app'].id) : undefined;
     const servicePath = manifest?.['sap.app']?.dataSources?.mainService?.uri;
-    const firstServicePathSegment = servicePath?.substring(0, servicePath?.indexOf('/', 1));
+    const firstServicePathSegment = servicePath?.substring(0, servicePath.indexOf('/', 1));
     return { servicePath, firstServicePathSegment, appId };
 }
 /**
@@ -307,16 +306,18 @@ async function appendCloudFoundryConfigurations(cfConfig, fs) {
 }
 /**
  * Updates the manifest.json file with the cloud service name.
+ * Preserves existing sap.cloud properties while updating public and service values.
  *
  * @param cfConfig writer configuration
  * @param fs reference to a mem-fs editor
  */
 async function updateManifest(cfConfig, fs) {
     const webappPath = await (0, project_access_1.getWebappPath)(cfConfig.appPath, fs);
-    const manifest = await (0, utils_1.readManifest)((0, node_path_1.join)(webappPath, project_access_1.FileName.Manifest), fs);
+    const manifest = (0, utils_1.readManifest)((0, node_path_1.join)(webappPath, project_access_1.FileName.Manifest), fs);
     if (manifest && cfConfig.cloudServiceName) {
+        // Preserve existing sap.cloud properties while updating required values (Sonar S7744 fix)
         const sapCloud = {
-            ...(manifest['sap.cloud'] || {}),
+            ...manifest['sap.cloud'],
             public: true,
             service: cfConfig.cloudServiceName
         };

package/dist/cf-writer/base-config.js

@@ -20,9 +20,7 @@ const i18n_1 = require("../i18n");
  * @returns file system reference
  */
 async function generateBaseConfig(config, fs, logger) {
-    if (!fs) {
-        fs = (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
-    }
+    fs ??= (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
     if (logger) {
         logger_helper_1.default.logger = logger;
     }

package/dist/cf-writer/cap-config.js

@@ -11,6 +11,7 @@ const mta_config_1 = require("../mta-config");
 const logger_helper_1 = __importDefault(require("../logger-helper"));
 const i18n_1 = require("../i18n");
 const project_access_1 = require("@sap-ux/project-access");
+const constants_1 = require("../constants");
 /**
  * Add a standalone | managed approuter to a CAP project.
  *
@@ -20,17 +21,15 @@ const project_access_1 = require("@sap-ux/project-access");
  * @returns file system reference
  */
 async function generateCAPConfig(config, fs, logger) {
-    if (!fs) {
-        fs = (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
-    }
+    fs ??= (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
     if (logger) {
         logger_helper_1.default.logger = logger;
     }
     logger?.debug(`Generate CAP configuration using: \n ${JSON.stringify(config)}`);
     await validateConfig(config);
     await (0, mta_config_1.generateCAPMTA)(config, fs);
-    // Delay, known issues with loading mta yaml after generation!
-    await new Promise((resolve) => setTimeout(resolve, 1000));
+    // Delay to ensure MTA file write completes before subsequent read operations
+    await new Promise((resolve) => setTimeout(resolve, constants_1.MTA_FILE_OPERATION_DELAY_MS));
     await (0, mta_config_1.addRoutingConfig)(config, fs);
     await (0, utils_1.updateRootPackage)({ mtaId: config.mtaId, rootPath: config.mtaPath }, fs);
     logger_helper_1.default.logger?.debug((0, i18n_1.t)('debug.capGenerationCompleted'));

package/dist/constants.d.ts

@@ -118,4 +118,11 @@ export declare const rootDeployMTAScript: (args: string[]) => string;
 export declare const undeployMTAScript: (mtaId: string) => string;
 export declare const CDSBinNotFound: string;
 export declare const MTABinNotFound: string;
+export declare const MAX_MTA_ID_LENGTH = 128;
+export declare const MAX_MTA_PREFIX_LENGTH = 100;
+export declare const MAX_MTA_PREFIX_SHORT_LENGTH = 94;
+export declare const MAX_MTA_PREFIX_SHORTER_LENGTH = 96;
+export declare const MAX_ABAP_SERVICE_PREFIX_LENGTH = 24;
+export declare const MAX_ABAP_SERVICE_NAME_LENGTH = 20;
+export declare const MTA_FILE_OPERATION_DELAY_MS = 1000;
 //# sourceMappingURL=constants.d.ts.map

package/dist/constants.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.CDSBinNotFound = exports.undeployMTAScript = exports.rootDeployMTAScript = exports.appDeployMTAScript = exports.MTABuildScript = exports.UI5DeployBuildScript = exports.UI5DeployBuildScriptForCap = exports.HTMLAppBuildParams = exports.ServiceAPIRequires = exports.DestinationServiceConfig = exports.UI5StandaloneModuleDestination = exports.UI5ResourceDestination = exports.CAPAppfrontDestination = exports.UI5AppfrontDestinationParameter = exports.UI5Destination = exports.MTAAPIDestination = exports.CDSDestinationService = exports.CDSHTML5RepoService = exports.CDSXSUAAService = exports.CDSAddMtaParams = exports.UI5PackageVersion = exports.UI5Package = exports.UI5TaskZipperPackageVersion = exports.UI5TaskZipperPackage = exports.MbtPackageVersion = exports.MbtPackage = exports.Rimraf = exports.RimrafVersion = exports.MTAVersion = exports.MTAPackage = exports.MTAExecutable = exports.CDSPackage = exports.CDSDKPackage = exports.CDSExecutable = exports.enableParallelDeployments = exports.deployMode = exports.CloudFoundry = exports.RouterModule = exports.MTADescription = exports.EmptyDestination = exports.DefaultMTADestination = exports.SRV_API = exports.HTML5RepoHost = exports.ManagedDestination = exports.ManagedAppFront = exports.ManagedXSUAA = exports.DefaultServiceURL = exports.MTABuildParams = exports.MTABuildResult = exports.WelcomeFile = void 0;
-exports.MTABinNotFound = void 0;
+exports.MTA_FILE_OPERATION_DELAY_MS = exports.MAX_ABAP_SERVICE_NAME_LENGTH = exports.MAX_ABAP_SERVICE_PREFIX_LENGTH = exports.MAX_MTA_PREFIX_SHORTER_LENGTH = exports.MAX_MTA_PREFIX_SHORT_LENGTH = exports.MAX_MTA_PREFIX_LENGTH = exports.MAX_MTA_ID_LENGTH = exports.MTABinNotFound = void 0;
 const i18n_1 = require("./i18n");
 exports.WelcomeFile = 'welcomeFile';
 exports.MTABuildResult = 'build-result';
@@ -123,4 +123,15 @@ exports.undeployMTAScript = undeployMTAScript;
 const cannotFindBinary = (bin, pkg) => (0, i18n_1.t)('error.cannotFindBinary', { bin, pkg });
 exports.CDSBinNotFound = cannotFindBinary(exports.CDSExecutable, exports.CDSDKPackage);
 exports.MTABinNotFound = cannotFindBinary(exports.MTAExecutable, exports.MTAPackage);
+// MTA ID length limits
+exports.MAX_MTA_ID_LENGTH = 128;
+exports.MAX_MTA_PREFIX_LENGTH = 100;
+exports.MAX_MTA_PREFIX_SHORT_LENGTH = 94;
+exports.MAX_MTA_PREFIX_SHORTER_LENGTH = 96;
+exports.MAX_ABAP_SERVICE_PREFIX_LENGTH = 24;
+exports.MAX_ABAP_SERVICE_NAME_LENGTH = 20;
+// MTA file operation timing
+// Delay in milliseconds to ensure MTA file operations complete before subsequent reads
+// This is necessary as mta-lib requires files to be fully written to disk before access
+exports.MTA_FILE_OPERATION_DELAY_MS = 1000;
 //# sourceMappingURL=constants.js.map

package/dist/i18n.d.ts

@@ -2,6 +2,8 @@ import type { i18n as i18nNext, TOptions } from 'i18next';
 export declare const i18n: i18nNext;
 /**
  * Initialize i18next with the translations for this module.
+ *
+ * @returns {Promise<void>} A promise that resolves when i18n is initialized
  */
 export declare function initI18n(): Promise<void>;
 /**

package/dist/i18n.js

@@ -12,6 +12,8 @@ const NS = 'cf-deploy-config-writer';
 exports.i18n = i18next_1.default.createInstance();
 /**
  * Initialize i18next with the translations for this module.
+ *
+ * @returns {Promise<void>} A promise that resolves when i18n is initialized
  */
 async function initI18n() {
     await exports.i18n.init({
@@ -36,6 +38,8 @@ async function initI18n() {
 function t(key, options) {
     return exports.i18n.t(key, options);
 }
+// Initialize i18n on module load
+// Errors are ignored since the writer will still work (fallback strings will be used)
 initI18n().catch(() => {
     // Ignore any errors since the write will still work
 });

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 export * from './mta-config';
 export * from './cf-writer';
-export { DefaultMTADestination } from './constants';
+export { DefaultMTADestination, MAX_MTA_ID_LENGTH, MAX_MTA_PREFIX_LENGTH, MAX_MTA_PREFIX_SHORT_LENGTH, MAX_MTA_PREFIX_SHORTER_LENGTH, MAX_ABAP_SERVICE_PREFIX_LENGTH, MAX_ABAP_SERVICE_NAME_LENGTH, MTA_FILE_OPERATION_DELAY_MS } from './constants';
 export { CFBaseConfig, CFAppConfig, CAPConfig, RouterModuleType, ApiHubConfig, ApiHubType } from './types';
 //# sourceMappingURL=index.d.ts.map

package/dist/index.js

@@ -14,11 +14,18 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.RouterModuleType = exports.DefaultMTADestination = void 0;
+exports.RouterModuleType = exports.MTA_FILE_OPERATION_DELAY_MS = exports.MAX_ABAP_SERVICE_NAME_LENGTH = exports.MAX_ABAP_SERVICE_PREFIX_LENGTH = exports.MAX_MTA_PREFIX_SHORTER_LENGTH = exports.MAX_MTA_PREFIX_SHORT_LENGTH = exports.MAX_MTA_PREFIX_LENGTH = exports.MAX_MTA_ID_LENGTH = exports.DefaultMTADestination = void 0;
 __exportStar(require("./mta-config"), exports);
 __exportStar(require("./cf-writer"), exports);
 var constants_1 = require("./constants");
 Object.defineProperty(exports, "DefaultMTADestination", { enumerable: true, get: function () { return constants_1.DefaultMTADestination; } });
+Object.defineProperty(exports, "MAX_MTA_ID_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_MTA_ID_LENGTH; } });
+Object.defineProperty(exports, "MAX_MTA_PREFIX_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_MTA_PREFIX_LENGTH; } });
+Object.defineProperty(exports, "MAX_MTA_PREFIX_SHORT_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_MTA_PREFIX_SHORT_LENGTH; } });
+Object.defineProperty(exports, "MAX_MTA_PREFIX_SHORTER_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_MTA_PREFIX_SHORTER_LENGTH; } });
+Object.defineProperty(exports, "MAX_ABAP_SERVICE_PREFIX_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_ABAP_SERVICE_PREFIX_LENGTH; } });
+Object.defineProperty(exports, "MAX_ABAP_SERVICE_NAME_LENGTH", { enumerable: true, get: function () { return constants_1.MAX_ABAP_SERVICE_NAME_LENGTH; } });
+Object.defineProperty(exports, "MTA_FILE_OPERATION_DELAY_MS", { enumerable: true, get: function () { return constants_1.MTA_FILE_OPERATION_DELAY_MS; } });
 var types_1 = require("./types");
 Object.defineProperty(exports, "RouterModuleType", { enumerable: true, get: function () { return types_1.RouterModuleType; } });
 //# sourceMappingURL=index.js.map

package/dist/mta-config/index.d.ts

@@ -9,17 +9,19 @@ import { type Editor } from 'mem-fs-editor';
  */
 export declare function getMtaId(rootPath: string): Promise<string | undefined>;
 /**
- *  Get the MTA configuration from the target folder.
+ * Get the MTA configuration from the target folder.
+ * Retries up to 5 times with delays to handle file system timing issues.
  *
  * @param rootPath Path to the root folder
  * @returns MtaConfig instance if found
  */
 export declare function getMtaConfig(rootPath: string): Promise<MtaConfig | undefined>;
 /**
- *  Generate an MTA ID that is suitable for CF deployment.
+ * Generate an MTA ID that is suitable for CF deployment.
+ * Removes special characters and restricts length to maximum allowed.
  *
- * @param appId Name of the app, like `sap.ux.app` and restrict to 128 characters
- * @returns Name that's acceptable for mta.yaml
+ * @param appId Name of the app, like `sap.ux.app`
+ * @returns Name that's acceptable for mta.yaml (sanitized and length-restricted)
  */
 export declare function toMtaModuleName(appId: string): string;
 /**
@@ -42,6 +44,7 @@ export declare function doesCDSBinaryExist(): void;
  * Validate the writer configuration to ensure all required parameters are present.
  *
  * @param config writer configuration
+ * @throws {Error} If validation fails
  */
 export declare function validateMtaConfig(config: CFBaseConfig): void;
 /**

package/dist/mta-config/index.js

@@ -48,14 +48,16 @@ async function getMtaId(rootPath) {
     return (await getMtaConfig(rootPath))?.prefix;
 }
 /**
- *  Get the MTA configuration from the target folder.
+ * Get the MTA configuration from the target folder.
+ * Retries up to 5 times with delays to handle file system timing issues.
  *
  * @param rootPath Path to the root folder
  * @returns MtaConfig instance if found
  */
 async function getMtaConfig(rootPath) {
     let mtaConfig;
-    for (let retries = 5; retries >= 0; retries--) {
+    const MAX_RETRIES = 5;
+    for (let retries = MAX_RETRIES; retries >= 0; retries--) {
         try {
             mtaConfig = await mta_1.MtaConfig.newInstance(rootPath, logger_helper_1.default.logger);
             if (mtaConfig?.prefix) {
@@ -64,20 +66,25 @@ async function getMtaConfig(rootPath) {
         }
         catch (error) {
             logger_helper_1.default.logger?.debug((0, i18n_1.t)('debug.errorReadingMta', { error: error.message }));
-            await new Promise((resolve) => setTimeout(resolve, 1000));
+            // Delay before retry to allow file system operations to complete
+            await new Promise((resolve) => setTimeout(resolve, constants_1.MTA_FILE_OPERATION_DELAY_MS));
         }
     }
     logger_helper_1.default.logger?.debug((0, i18n_1.t)('debug.mtaReadWithPrefix', { prefix: mtaConfig?.prefix }));
     return mtaConfig;
 }
 /**
- *  Generate an MTA ID that is suitable for CF deployment.
+ * Generate an MTA ID that is suitable for CF deployment.
+ * Removes special characters and restricts length to maximum allowed.
  *
- * @param appId Name of the app, like `sap.ux.app` and restrict to 128 characters
- * @returns Name that's acceptable for mta.yaml
+ * @param appId Name of the app, like `sap.ux.app`
+ * @returns Name that's acceptable for mta.yaml (sanitized and length-restricted)
  */
 function toMtaModuleName(appId) {
-    return appId.replace(/[`~!@#$%^&*()_|+\-=?;:'",.<>]/gi, '').slice(0, 128);
+    // Remove special characters not allowed in MTA module names
+    // MTA IDs must contain only alphanumeric characters, hyphens, underscores, and dots
+    // Using replaceAll for global replacement (Sonar S7781)
+    return appId.replaceAll(/[`~!@#$%^&*()_|+\-=?;:'",.<>]/gi, '').slice(0, constants_1.MAX_MTA_ID_LENGTH);
 }
 /**
  * Create an MTA file in the target folder, needs to be written to disk as subsequent calls are dependent on it being on the file system i.e mta-lib.
@@ -85,7 +92,7 @@ function toMtaModuleName(appId) {
  * @param config writer configuration
  */
 function createMTA(config) {
-    const mtaId = `${config.mtaId.slice(0, 128)}`;
+    const mtaId = `${config.mtaId.slice(0, constants_1.MAX_MTA_ID_LENGTH)}`;
     const mtaTemplate = (0, node_fs_1.readFileSync)((0, utils_1.getTemplatePath)(`app/${project_access_1.FileName.MtaYaml}`), 'utf-8');
     const mtaContents = (0, ejs_1.render)(mtaTemplate, {
         id: mtaId,
@@ -121,6 +128,7 @@ function doesCDSBinaryExist() {
  * Validate the writer configuration to ensure all required parameters are present.
  *
  * @param config writer configuration
+ * @throws {Error} If validation fails
  */
 function validateMtaConfig(config) {
     // We use mta-lib, which in turn relies on the mta executable being installed and available in the path
@@ -128,7 +136,7 @@ function validateMtaConfig(config) {
     if (!config.routerType || !config.mtaId || !config.mtaPath) {
         throw new Error((0, i18n_1.t)('error.missingMtaParameters'));
     }
-    if (config.mtaId.length > 128 || !/^[a-zA-Z_]/.test(config.mtaId)) {
+    if (config.mtaId.length > constants_1.MAX_MTA_ID_LENGTH || !/^[a-zA-Z_]/.test(config.mtaId)) {
         throw new Error((0, i18n_1.t)('error.invalidMtaId'));
     }
     if (!/^[\w\-.]*$/.test(config.mtaId)) {
@@ -153,7 +161,7 @@ function validateMtaConfig(config) {
 async function createCAPMTAAppFrontend(config, fs) {
     const mtaTemplate = (0, node_fs_1.readFileSync)((0, utils_1.getTemplatePath)(`frontend/${project_access_1.FileName.MtaYaml}`), 'utf-8');
     const mtaContents = (0, ejs_1.render)(mtaTemplate, {
-        id: `${config.mtaId.slice(0, 128)}`,
+        id: `${config.mtaId.slice(0, constants_1.MAX_MTA_ID_LENGTH)}`,
         mtaDescription: config.mtaDescription ?? constants_1.MTADescription,
         mtaVersion: config.mtaVersion ?? constants_1.MTAVersion
     });

package/dist/mta-config/mta.js

@@ -135,7 +135,7 @@ class MtaConfig {
         const appHostName = this.resources.get(constants_1.HTML5RepoHost)?.name;
         if (appHostName) {
             const appContentModule = {
-                name: `${this.prefix?.slice(0, 100)}-app-content`,
+                name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-app-content`,
                 type: 'com.sap.application.content',
                 path: '.',
                 requires: [
@@ -158,12 +158,15 @@ class MtaConfig {
     }
     async addUaa() {
         const resource = {
-            name: `${this.prefix?.slice(0, 100)}-uaa`,
+            name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-uaa`,
             type: 'org.cloudfoundry.managed-service',
             parameters: {
                 'service-plan': 'application',
                 service: 'xsuaa',
-                config: { xsappname: `${this.prefix?.slice(0, 100)}` + '-${space-guid}', 'tenant-mode': 'dedicated' }
+                config: {
+                    xsappname: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}` + '-${space-guid}',
+                    'tenant-mode': 'dedicated'
+                }
             }
         };
         await this.mta?.addResource(resource);
@@ -172,7 +175,7 @@ class MtaConfig {
     }
     async addHtml5Runtime() {
         const resource = {
-            name: `${this.prefix?.slice(0, 100)}-html5-repo-runtime`,
+            name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-html5-repo-runtime`,
             type: 'org.cloudfoundry.managed-service',
             parameters: { 'service-plan': 'app-runtime', service: 'html5-apps-repo' }
         };
@@ -191,7 +194,7 @@ class MtaConfig {
         if (resource && !resource.parameters?.['service-name']) {
             resource.parameters = {
                 ...(resource.parameters ?? {}),
-                'service-name': `${this.prefix?.slice(0, 100)}-${serviceName}-service`
+                'service-name': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-${serviceName}-service`
             };
             await this.mta?.updateResource(resource);
             this.resources.set(resourceName, resource);
@@ -218,11 +221,11 @@ class MtaConfig {
     }
     async addAppFrontResource() {
         const resource = {
-            name: `${this.prefix?.slice(0, 94)}-app-front`,
+            name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_SHORT_LENGTH)}-app-front`,
             type: 'org.cloudfoundry.managed-service',
             parameters: {
                 service: 'app-front',
-                'service-name': `${this.prefix?.slice(0, 96)}-app-front-service`,
+                'service-name': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_SHORTER_LENGTH)}-app-front-service`,
                 'service-plan': 'developer'
             }
         };
@@ -231,12 +234,12 @@ class MtaConfig {
         this.dirty = true;
     }
     async addHtml5Host() {
-        const html5host = `${this.prefix?.slice(0, 100)}-repo-host`; // Need to cater for -key being added too!
+        const html5host = `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-repo-host`; // Need to cater for -key being added too!
         const resource = {
             name: html5host,
             type: 'org.cloudfoundry.managed-service',
             parameters: {
-                'service-name': `${this.prefix?.slice(0, 100)}-html5-service`,
+                'service-name': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-html5-service`,
                 'service-plan': 'app-host',
                 service: 'html5-apps-repo'
             }
@@ -251,7 +254,7 @@ class MtaConfig {
      * @param isManagedApp - If the destination service is for a managed app
      */
     async addDestinationResource(isManagedApp = false) {
-        const destinationName = `${this.prefix?.slice(0, 100)}-destination-service`;
+        const destinationName = `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-destination-service`;
         const resource = {
             name: destinationName,
             type: 'org.cloudfoundry.managed-service',
@@ -331,17 +334,17 @@ class MtaConfig {
     async addManagedUAAWithSecurity() {
         this.log?.debug((0, i18n_1.t)('debug.addXsuaaService'));
         const resource = {
-            name: `${this.prefix?.slice(0, 100)}-uaa`,
+            name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-uaa`,
             type: 'org.cloudfoundry.managed-service',
             parameters: {
                 path: './xs-security.json',
                 service: 'xsuaa',
-                'service-name': `${this.prefix?.slice(0, 100)}-xsuaa-service`,
+                'service-name': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-xsuaa-service`,
                 'service-plan': 'application',
                 ...(this.modules.has('nodejs') && this.modules.has('com.sap.application.content:appfront')
                     ? {
                         config: {
-                            xsappname: `${this.prefix?.slice(0, 100)}-\${org}-\${space}`,
+                            xsappname: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-\${org}-\${space}`,
                             'tenant-mode': 'dedicated'
                         }
                     }
@@ -391,7 +394,8 @@ class MtaConfig {
             this.modules.get('com.sap.application.content:destination'),
             this.modules.get('approuter.nodejs')
         ].filter((elem) => elem !== undefined)) {
-            const destinationName = this.resources.get('destination')?.name ?? `${this.prefix?.slice(0, 100)}-destination-service`;
+            const destinationName = this.resources.get('destination')?.name ??
+                `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-destination-service`;
             if (module?.requires?.findIndex((app) => app.name === destinationName) === -1) {
                 if (module.type === 'approuter.nodejs') {
                     module.requires.push({
@@ -436,11 +440,11 @@ class MtaConfig {
     get cloudServiceName() {
         let cloudServiceName;
         this.modules.forEach((contentModule) => {
-            const moduleDestinations = contentModule.parameters?.content?.instance?.destinations || [];
+            const moduleDestinations = contentModule.parameters?.content?.instance?.destinations ?? [];
             if (contentModule.type === 'com.sap.application.content' && moduleDestinations.length) {
                 // In theory, if there is more than one, it should be same!
                 moduleDestinations.some((destination) => {
-                    cloudServiceName = destination['sap.cloud.service'] || undefined;
+                    cloudServiceName = destination['sap.cloud.service'];
                     return !!cloudServiceName;
                 });
             }
@@ -514,7 +518,7 @@ class MtaConfig {
             }
             else {
                 contentModule[constants_1.MTABuildParams].requires.push({
-                    name: appName.slice(0, 128),
+                    name: appName.slice(0, constants_1.MAX_MTA_ID_LENGTH),
                     artifacts: [artifactName],
                     'target-path': `${contentModule[constants_1.MTABuildParams][constants_1.MTABuildResult]}/`.replace(/\/{2,}/g, '/') // Matches two or more consecutive slashes where at least 2 repetitions of /
                 });
@@ -525,7 +529,7 @@ class MtaConfig {
         // Add application module, if not found already
         if (!isHTML5AlreadyExisting && !this.apps.get(appName)) {
             const app = {
-                name: appName.slice(0, 128),
+                name: appName.slice(0, constants_1.MAX_MTA_ID_LENGTH),
                 type: 'html5',
                 path: appPath,
                 'build-parameters': constants_1.HTMLAppBuildParams
@@ -566,7 +570,7 @@ class MtaConfig {
     async addConnectivityResource() {
         const serviceType = 'connectivity';
         const resourceType = types_1.CloudFoundryServiceType.Managed;
-        const resourceName = `${this.prefix?.slice(0, 100)}-connectivity`;
+        const resourceName = `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-connectivity`;
         const router = this.modules.get('approuter.nodejs');
         if (router) {
             if (router.requires?.findIndex((resource) => resource.name === resourceName) === -1) {
@@ -647,7 +651,7 @@ class MtaConfig {
      * @returns {Promise<void>} A promise that resolves when the change request has been processed.
      */
     async addAbapService(serviceName, btpService) {
-        const newResourceName = `${this.prefix?.slice(0, 24)}-abap-${serviceName.slice(0, 20)}`;
+        const newResourceName = `${this.prefix?.slice(0, constants_1.MAX_ABAP_SERVICE_PREFIX_LENGTH)}-abap-${serviceName.slice(0, constants_1.MAX_ABAP_SERVICE_NAME_LENGTH)}`;
         const router = this.modules.get('approuter.nodejs');
         if (router) {
             if (router.requires?.findIndex((resource) => resource.name === newResourceName) === -1) {
@@ -709,7 +713,7 @@ class MtaConfig {
         const destinationName = this.resources.get('destination')?.name;
         if (destinationName && xsuaaName && appRuntimeName) {
             const router = {
-                name: `${this.prefix?.slice(0, 100)}-router`,
+                name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-router`,
                 type: 'approuter.nodejs',
                 path: fromServerGenerator ? `${constants_1.RouterModule}` : `${constants_1.CloudFoundry}/${constants_1.RouterModule}`,
                 parameters: {
@@ -763,7 +767,7 @@ class MtaConfig {
         let destinationServiceName = this.resources.get('destination')?.name;
         if (!destinationServiceName) {
             this.log?.info((0, i18n_1.t)('info.existingDestinationNotFound'));
-            destinationServiceName = `${this.prefix?.slice(0, 100)}-destination-service`;
+            destinationServiceName = `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-destination-service`;
         }
         const appMtaId = this.mtaId;
         const mtaExtFilePath = (0, node_path_1.join)(this.mta.mtaDirPath, project_access_1.FileName.MtaExtYaml);
@@ -922,7 +926,7 @@ class MtaConfig {
             const appHostName = this.resources.get(constants_1.ManagedAppFront)?.name;
             if (appHostName) {
                 const appContentModule = {
-                    name: `${this.prefix?.slice(0, 100)}-app-content`,
+                    name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-app-content`,
                     type: 'com.sap.application.content',
                     path: '.',
                     requires: [
@@ -981,7 +985,7 @@ class MtaConfig {
                 const appHostServiceName = this.getServiceInstanceName(constants_1.HTML5RepoHost);
                 const managedXSUAAServiceName = this.getServiceInstanceName(constants_1.ManagedXSUAA);
                 const router = {
-                    name: `${this.prefix?.slice(0, 100)}-destination-content`,
+                    name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}-destination-content`,
                     type: 'com.sap.application.content',
                     requires: [
                         {
@@ -1012,17 +1016,17 @@ class MtaConfig {
                             instance: {
                                 destinations: [
                                     {
-                                        Name: `${this.prefix?.slice(0, 100)}_html_repo_host`,
+                                        Name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}_html_repo_host`,
                                         ServiceInstanceName: appHostServiceName,
                                         ServiceKeyName: `${appHostName}-key`,
-                                        'sap.cloud.service': `${this.prefix?.slice(0, 100)}`
+                                        'sap.cloud.service': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}`
                                     },
                                     {
                                         Authentication: 'OAuth2UserTokenExchange',
-                                        Name: `${this.prefix?.slice(0, 100)}_uaa`,
+                                        Name: `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}_uaa`,
                                         ServiceInstanceName: managedXSUAAServiceName,
                                         ServiceKeyName: `${managedXSUAAName}-key`,
-                                        'sap.cloud.service': `${this.prefix?.slice(0, 100)}`
+                                        'sap.cloud.service': `${this.prefix?.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH)}`
                                     }
                                 ],
                                 'existing_destinations_policy': 'update'

package/dist/utils.d.ts

@@ -3,13 +3,13 @@ import { type Authentication, type Destinations } from '@sap-ux/btp-utils';
 import { type Manifest } from '@sap-ux/project-access';
 import { type MTABaseConfig, type CFBaseConfig, type CFAppConfig } from './types';
 /**
- *  Read manifest file for processing.
+ * Read manifest file for processing.
  *
  * @param manifestPath Path to the manifest file
  * @param fs reference to a mem-fs editor
  * @returns Manifest object
  */
-export declare function readManifest(manifestPath: string, fs: Editor): Promise<Manifest>;
+export declare function readManifest(manifestPath: string, fs: Editor): Manifest;
 /**
  * Locates template files relative to the dist folder.
  * This helps to locate templates when this module is bundled and the dir structure is flattened, maintaining the relative paths.
@@ -19,10 +19,11 @@ export declare function readManifest(manifestPath: string, fs: Editor): Promise<
  */
 export declare function getTemplatePath(relativeTemplatePath: string): string;
 /**
- *  Convert an app name to an MTA ID that is suitable for CF deployment.
+ * Convert an app name to an MTA ID that is suitable for CF deployment.
+ * Removes special characters that are not allowed in MTA module names.
  *
  * @param id Name of the app, like `sap.ux.app`
- * @returns Name that's acceptable in an mta.yaml
+ * @returns Name that's acceptable in an mta.yaml (special characters removed)
  */
 export declare function toMtaModuleName(id: string): string;
 /**
@@ -143,7 +144,7 @@ export declare function alignCdsVersions(rootPath: string, fs: Editor): Promise<
  * @throws {Error} Throws an error with the provided error message concatenated with the original error if execution fails
  * @example
  * // Execute npm install in the project directory
- * await runCommand('/path/to/project', 'npm', ['install'], 'Failed to install dependencies:');
+ * await runCommand('/path/to/project', 'npm', ['install'], 'Failed to install dependencies');
  */
 export declare function runCommand(cwd: string, cmd: string, args: string[], errorMsg: string): Promise<void>;
 /**

package/dist/utils.js

@@ -26,13 +26,13 @@ const project_access_1 = require("@sap-ux/project-access");
 const constants_1 = require("./constants");
 let cachedDestinationsList = {};
 /**
- *  Read manifest file for processing.
+ * Read manifest file for processing.
  *
  * @param manifestPath Path to the manifest file
  * @param fs reference to a mem-fs editor
  * @returns Manifest object
  */
-async function readManifest(manifestPath, fs) {
+function readManifest(manifestPath, fs) {
     return fs.readJSON(manifestPath);
 }
 /**
@@ -46,13 +46,17 @@ function getTemplatePath(relativeTemplatePath) {
     return (0, node_path_1.join)(__dirname, '../templates', relativeTemplatePath);
 }
 /**
- *  Convert an app name to an MTA ID that is suitable for CF deployment.
+ * Convert an app name to an MTA ID that is suitable for CF deployment.
+ * Removes special characters that are not allowed in MTA module names.
  *
  * @param id Name of the app, like `sap.ux.app`
- * @returns Name that's acceptable in an mta.yaml
+ * @returns Name that's acceptable in an mta.yaml (special characters removed)
  */
 function toMtaModuleName(id) {
-    return id.replace(/[`~!@#$%^&*£()|+=?;:'",.<>]/gi, '');
+    // Remove special characters not allowed in MTA module names
+    // Keep alphanumeric, underscore, hyphen, and dot
+    // Using replaceAll for global replacement (Sonar S7781)
+    return id.replaceAll(/[`~!@#$%^&*£()|+=?;:'",.<>]/gi, '');
 }
 /**
  * Return a consistent file path across different platforms.
@@ -117,7 +121,7 @@ function validateVersion(mtaVersion) {
  */
 function addXSSecurityConfig({ mtaPath, mtaId }, fs, addTenant = true) {
     fs.copyTpl(getTemplatePath(`common/${project_access_1.FileName.XSSecurityJson}`), (0, node_path_1.join)(mtaPath, project_access_1.FileName.XSSecurityJson), {
-        id: mtaId.slice(0, 100),
+        id: mtaId.slice(0, constants_1.MAX_MTA_PREFIX_LENGTH),
         addTenant
     });
 }
@@ -180,7 +184,7 @@ async function generateSupportingConfig(config, fs, addTenant = true) {
  */
 function setMtaDefaults(config) {
     config.mtaPath = config.mtaPath.replace(/\/$/, '');
-    config.addConnectivityService ||= false;
+    config.addConnectivityService ??= false;
     config.mtaId = toMtaModuleName(config.mtaId);
 }
 /**
@@ -260,15 +264,16 @@ async function alignCdsVersions(rootPath, fs) {
  * @throws {Error} Throws an error with the provided error message concatenated with the original error if execution fails
  * @example
  * // Execute npm install in the project directory
- * await runCommand('/path/to/project', 'npm', ['install'], 'Failed to install dependencies:');
+ * await runCommand('/path/to/project', 'npm', ['install'], 'Failed to install dependencies');
  */
 async function runCommand(cwd, cmd, args, errorMsg) {
     const commandRunner = new nodejs_utils_1.CommandRunner();
     try {
         await commandRunner.run(cmd, args, { cwd });
     }
-    catch (e) {
-        throw new Error(`${errorMsg} ${e.message ?? e}`);
+    catch (error) {
+        const errorMessage = error instanceof Error ? error.message : String(error);
+        throw new Error(`${errorMsg}: ${errorMessage}`);
     }
 }
 /**

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sap-ux/cf-deploy-config-writer",
   "description": "Add or amend Cloud Foundry and ABAP deployment configuration for SAP projects",
-  "version": "0.3.63",
+  "version": "0.3.65",
   "repository": {
     "type": "git",
     "url": "https://github.com/SAP/open-ux-tools.git",
@@ -29,7 +29,7 @@
     "mem-fs": "2.1.0",
     "mem-fs-editor": "9.4.0",
     "hasbin": "1.2.3",
-    "@sap-ux/project-access": "1.35.1",
+    "@sap-ux/project-access": "1.35.2",
     "@sap-ux/yaml": "0.17.4",
     "@sap-ux/btp-utils": "1.1.8",
     "@sap-ux/logger": "0.8.1",