@sap-ux/app-config-writer 0.5.28 → 0.5.29

package/dist/preview-config/package-json.d.ts

@@ -1,17 +1,16 @@
 import type { Editor } from 'mem-fs-editor';
 import type { ToolsLogger } from '@sap-ux/logger';
-import type { Package } from '@sap-ux/project-access';
 import type { FlpConfig } from '@sap-ux/preview-middleware';
+import type { Script } from './ui5-yaml';
 /**
  * Ensures that the @sap/ux-ui5-tooling or @sap-ux/preview-middleware dependency exists in the package.json.
  *
  * If none dependency is given, the @sap-ux/preview-middleware will be added as a devDependency.
  *
- * @param packageJson - the package.json file content
  * @param fs - file system reference
- * @param packageJsonPath - the path to the package.json file
+ * @param basePath - base path to be used for the conversion
  */
-export declare function ensurePreviewMiddlewareDependency(packageJson: Package | undefined, fs: Editor, packageJsonPath: string): void;
+export declare function ensurePreviewMiddlewareDependency(fs: Editor, basePath: string): void;
 /**
  * Extracts the URL details from a given script.
  *
@@ -36,12 +35,11 @@ export declare function extractUrlDetails(script: string): {
  * - must not be 'start-variants-management'
  * - must not be 'start-control-property-editor'.
  *
- * @param scriptName - the name of the script from the package.json file
- * @param script - the content of the script from the package.json file
+ * @param script - the script from the package.json file
  * @param convertTests - indicator if test suite and test runner should be included in the conversion (default: false)
  * @returns indicator if the script is valid
  */
-export declare function isValidPreviewScript(scriptName: string, script: string | undefined, convertTests?: boolean): boolean;
+export declare function isValidPreviewScript(script: Script, convertTests?: boolean): boolean;
 /**
  * Updates the variants creation script in package.json if needed.
  *

package/dist/preview-config/package-json.js

@@ -12,11 +12,12 @@ const variants_config_1 = require("../variants-config");
  *
  * If none dependency is given, the @sap-ux/preview-middleware will be added as a devDependency.
  *
- * @param packageJson - the package.json file content
  * @param fs - file system reference
- * @param packageJsonPath - the path to the package.json file
+ * @param basePath - base path to be used for the conversion
  */
-function ensurePreviewMiddlewareDependency(packageJson, fs, packageJsonPath) {
+function ensurePreviewMiddlewareDependency(fs, basePath) {
+    const packageJsonPath = (0, path_1.join)(basePath, 'package.json');
+    const packageJson = fs.readJSON(packageJsonPath);
     if (!packageJson) {
         return;
     }
@@ -67,17 +68,16 @@ function extractUrlDetails(script) {
  * - must not be 'start-variants-management'
  * - must not be 'start-control-property-editor'.
  *
- * @param scriptName - the name of the script from the package.json file
- * @param script - the content of the script from the package.json file
+ * @param script - the script from the package.json file
  * @param convertTests - indicator if test suite and test runner should be included in the conversion (default: false)
  * @returns indicator if the script is valid
  */
-function isValidPreviewScript(scriptName, script, convertTests = false) {
-    const isValidScriptName = scriptName != 'start-variants-management' && scriptName != 'start-control-property-editor';
+function isValidPreviewScript(script, convertTests = false) {
+    const isValidScriptName = script.name != 'start-variants-management' && script.name != 'start-control-property-editor';
     //eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-    const startsWebServer = !!(script?.includes('ui5 serve') || script?.includes('fiori run'));
-    const { path } = extractUrlDetails(script ?? '');
-    const opensTest = (0, ui5_yaml_1.isTestPath)(path);
+    const startsWebServer = !!(script.value.includes('ui5 serve') || script.value.includes('fiori run'));
+    const { path } = extractUrlDetails(script.value);
+    const opensTest = (0, ui5_yaml_1.isTestPath)(script ?? '');
     const opensIndexHtml = path === 'index.html';
     //tests are only relevant if the conversion of test runners is excluded
     return isValidScriptName && startsWebServer && !opensIndexHtml && (convertTests ? true : !opensTest);

package/dist/preview-config/prerequisites.js

@@ -71,6 +71,10 @@ async function checkPrerequisites(basePath, fs, convertTests = false, logger) {
     if (convertTests && (packageJson?.devDependencies?.['karma-ui5'] ?? packageJson?.dependencies?.['karma-ui5'])) {
         logger?.warn("This app seems to use Karma as a test runner. Please note that the converter does not convert any Karma configuration files. Please update your karma configuration ('ui5.configPath' and 'ui5.testpage') according to the new virtual endpoints after the conversion.");
     }
+    if (convertTests &&
+        (packageJson?.devDependencies?.['wdio-qunit-service'] ?? packageJson?.dependencies?.['wdio-qunit-service'])) {
+        logger?.warn('This app seems to use the WebdriverIO QUnit Service as a test runner. Please note that the converter does not convert any WebdriverIO configuration files. Please update your WebdriverIO QUnit Service test paths according to the new virtual endpoints after the conversion.');
+    }
     return prerequisitesMet;
 }
 //# sourceMappingURL=prerequisites.js.map

package/dist/preview-config/ui5-yaml.d.ts

@@ -1,21 +1,40 @@
 import type { CustomMiddleware } from '@sap-ux/ui5-config';
 import type { Editor } from 'mem-fs-editor';
-import type { FlpConfig, MiddlewareConfig as PreviewConfig, TestConfig } from '@sap-ux/preview-middleware';
+import type { MiddlewareConfig as PreviewConfig, TestConfig } from '@sap-ux/preview-middleware';
 import type { PreviewConfigOptions } from '../types';
 import type { ToolsLogger } from '@sap-ux/logger';
 type ArrayElement<ArrayType extends readonly unknown[]> = ArrayType[number];
 type PreviewTestConfig = ArrayElement<Required<PreviewConfig>['test']>;
+export type Script = {
+    name: string;
+    value: string;
+};
 export declare const TEST_CONFIG_DEFAULTS: Record<string, Readonly<Required<PreviewTestConfig>>>;
 /**
  * Check if the path is a test path.
  * 1) path matches pattern '**.qunit.html'
  * 2) path is being used as test configuration path in yaml configuration.
  *
- * @param path - the path
+ * @param script - the script content
  * @param configuration - the preview configuration
  * @returns indicator if the path is a test path
  */
-export declare function isTestPath(path: string | undefined, configuration?: PreviewConfig): boolean;
+export declare function isTestPath(script: Script, configuration?: PreviewConfig): boolean;
+/**
+ * Extracts the test path of a given script name from the related ui5-test-runner script.
+ * The relation is defined as usage in another script that references the given script name directly or via max. one indirection.
+ *
+ * Example:
+ * - 'ui:test-server': 'ui5 serve --config ./ui5-deprecated-tools-preview-theme.yaml'
+ * - 'ui:test-runner': 'ui5-test-runner --port 8081 --url http://localhost:8080/test/testsuite.qunit.html --report-dir ./target/'
+ * - 'ui:test': 'start-server-and-test ui:test-server http://localhost:8080/ ui:test-runner'
+ *
+ * The test path for script 'ui:test-server' is 'http://localhost:8080/test/testsuite.qunit.html' from 'ui:test-runner' as they are connected via one indirection ('ui:test').
+ *
+ * @param scriptName - the name of the script from the package.json file
+ * @returns the related test path
+ */
+export declare function getTestPathForUi5TestRunner(scriptName: string): string | undefined;
 /**
  * Extract the UI5 yaml configuration file name from the script.
  *
@@ -36,21 +55,20 @@ export declare function extractYamlConfigFileName(script: string): string;
  * @param logger logger to report info to the user
  * @param skipPreviewMiddlewareCreation - (default: false) indicator if the preview middleware creation should be skipped if no preview middleware is configured.
  */
-export declare function processUi5YamlConfig(fs: Editor, basePath: string, ui5Yaml: string, script: string, logger?: ToolsLogger, skipPreviewMiddlewareCreation?: boolean): Promise<void>;
+export declare function processUi5YamlConfig(fs: Editor, basePath: string, ui5Yaml: string, script: Script, logger?: ToolsLogger, skipPreviewMiddlewareCreation?: boolean): Promise<void>;
 /**
  * Creates a preview middleware configuration.
  *
  * It will sanitize the given preview middleware configuration and construct the flp configuration out of the given intent and path.
  *
  * @param previewMiddleware - the preview middleware configuration
- * @param intent - the intent
- * @param path - the flp path
+ * @param script - the content of the script from the package.json file
  * @param basePath - the base path
  * @param fs - file system reference
  * @param logger logger to report info to the user
  * @returns the preview middleware configuration
  */
-export declare function updatePreviewMiddlewareConfig(previewMiddleware: CustomMiddleware<PreviewConfigOptions>, intent: FlpConfig['intent'] | undefined, path: string | undefined, basePath: string, fs: Editor, logger?: ToolsLogger): Promise<CustomMiddleware<PreviewConfigOptions>>;
+export declare function updatePreviewMiddlewareConfig(previewMiddleware: CustomMiddleware<PreviewConfigOptions>, script: Script, basePath: string, fs: Editor, logger?: ToolsLogger): Promise<CustomMiddleware<PreviewConfigOptions>>;
 /**
  * Sanitize the test script (*.qunit.[jt]s)
  * If the OPA5 test script uses the JourneyRunner, it will be renamed and added as pattern to the respective UI5 yaml configuration.
@@ -82,6 +100,15 @@ export declare function updateTestConfig(testConfiguration: PreviewConfig['test'
  * @param logger logger to report info to the user
  */
 export declare function updateDefaultTestConfig(fs: Editor, basePath: string, logger?: ToolsLogger): Promise<void>;
+/**
+ * Reads the scripts from the package.json file.
+ * Scripts will be buffered map 'scriptsFromPackageJson' to avoid multiple reads of the package.json file.
+ *
+ * @param fs - file system reference
+ * @param basePath - base path to be used for the conversion
+ * @returns the scripts from the package.json file
+ */
+export declare function getScriptsFromPackageJson(fs: Editor, basePath: string): Map<string, string>;
 /**
  * Updates the preview middleware configurations according to the scripts they are being used in package.json.
  *

package/dist/preview-config/ui5-yaml.js

@@ -2,12 +2,14 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.TEST_CONFIG_DEFAULTS = void 0;
 exports.isTestPath = isTestPath;
+exports.getTestPathForUi5TestRunner = getTestPathForUi5TestRunner;
 exports.extractYamlConfigFileName = extractYamlConfigFileName;
 exports.processUi5YamlConfig = processUi5YamlConfig;
 exports.updatePreviewMiddlewareConfig = updatePreviewMiddlewareConfig;
 exports.sanitizeTestScript = sanitizeTestScript;
 exports.updateTestConfig = updateTestConfig;
 exports.updateDefaultTestConfig = updateDefaultTestConfig;
+exports.getScriptsFromPackageJson = getScriptsFromPackageJson;
 exports.updatePreviewMiddlewareConfigs = updatePreviewMiddlewareConfigs;
 const path_1 = require("path");
 const ui5_yaml_1 = require("../variants-config/ui5-yaml");
@@ -34,6 +36,10 @@ exports.TEST_CONFIG_DEFAULTS = {
         framework: 'Testsuite'
     }
 };
+/**
+ * Map of scripts from the package.json file.
+ */
+const scriptsFromPackageJson = new Map();
 /**
  * Checks if a script can be converted based on the used UI5 yaml configuration file.
  *
@@ -60,21 +66,20 @@ function isUi5YamlToBeConverted(ui5Yaml, scriptName, ui5YamlFileNames, logger) {
  * @param fs - file system reference
  * @param basePath - base path to be used for the conversion
  * @param ui5Yaml - the name of the UI5 yaml configuration file
- * @param scriptName - the name of the script from the package.json file
- * @param script - the content of the script from the package.json file
+ * @param script - the script from the package.json file
  * @param convertTests - indicator if test suite and test runner should be included in the conversion
  * @param logger logger to report info to the user
  * @returns indicator if the UI5 yaml configuration file has already been converted
  */
-async function isUi5YamlFlpPathAlreadyConverted(fs, basePath, ui5Yaml, scriptName, script, convertTests, logger) {
+async function isUi5YamlFlpPathAlreadyConverted(fs, basePath, ui5Yaml, script, convertTests, logger) {
     const yamlConfigAlreadyAdjusted = Object.keys(fs.dump(basePath, (file) => {
         return file.basename === ui5Yaml && file.state === 'modified';
     })).length > 0;
     const flpPath = (await (0, utils_1.getPreviewMiddleware)(undefined, basePath, ui5Yaml, fs))
         ?.configuration?.flp?.path;
-    const { path: scriptPath } = (0, package_json_1.extractUrlDetails)(script);
-    if (yamlConfigAlreadyAdjusted && flpPath != scriptPath && (convertTests ? !isTestPath(scriptPath) : true)) {
-        logger?.warn(`Skipping script '${scriptName}', because another script also refers to UI5 YAML configuration file, '${ui5Yaml}'. Adjust the 'flp.path' property in the UI5 YAML configuration file to the correct endpoint or create a separate UI5 YAML configuration file for script '${scriptName}'. ${ui5Yaml} currently uses ${flpPath ?? DEFAULT_FLP_PATH} whereas script '${scriptName}' uses '${scriptPath}'.`);
+    const { path: scriptPath } = (0, package_json_1.extractUrlDetails)(script.value);
+    if (yamlConfigAlreadyAdjusted && flpPath != scriptPath && (convertTests ? !isTestPath(script) : true)) {
+        logger?.warn(`Skipping script '${script.name}', because another script also refers to UI5 YAML configuration file, '${ui5Yaml}'. Adjust the 'flp.path' property in the UI5 YAML configuration file to the correct endpoint or create a separate UI5 YAML configuration file for script '${script.name}'. ${ui5Yaml} currently uses ${flpPath ?? DEFAULT_FLP_PATH} whereas script '${script.name}' uses '${scriptPath}'.`);
         return true;
     }
     return false;
@@ -82,35 +87,76 @@ async function isUi5YamlFlpPathAlreadyConverted(fs, basePath, ui5Yaml, scriptNam
 /**
  * Checks if the passed path is a FLP path.
  *
- * @param path - the path
+ * @param script - the script content
  * @param configuration - the preview configuration
  * @returns indicator if the path is an FLP path
  */
-function isFlpPath(path, configuration) {
+function isFlpPath(script, configuration) {
+    const { path } = (0, package_json_1.extractUrlDetails)(script.value);
     if (!path) {
         return false;
     }
     const isRtaEditorPath = configuration.rta?.editors?.some((editor) => editor.path === path) ?? false;
-    return !isRtaEditorPath && !isTestPath(path, configuration);
+    return !isRtaEditorPath && !isTestPath(script, configuration);
 }
 /**
  * Check if the path is a test path.
  * 1) path matches pattern '**.qunit.html'
  * 2) path is being used as test configuration path in yaml configuration.
  *
- * @param path - the path
+ * @param script - the script content
  * @param configuration - the preview configuration
  * @returns indicator if the path is a test path
  */
-function isTestPath(path, configuration) {
+function isTestPath(script, configuration) {
+    const { path } = (0, package_json_1.extractUrlDetails)(script.value);
     if (!path) {
-        return false;
+        return !!getTestPathForUi5TestRunner(script.name);
     }
     if (path.includes('.qunit.html')) {
         return true;
     }
     return configuration?.test?.some((testConfig) => testConfig.path === path) ?? false;
 }
+/**
+ * Extracts the test path of a given script name from the related ui5-test-runner script.
+ * The relation is defined as usage in another script that references the given script name directly or via max. one indirection.
+ *
+ * Example:
+ * - 'ui:test-server': 'ui5 serve --config ./ui5-deprecated-tools-preview-theme.yaml'
+ * - 'ui:test-runner': 'ui5-test-runner --port 8081 --url http://localhost:8080/test/testsuite.qunit.html --report-dir ./target/'
+ * - 'ui:test': 'start-server-and-test ui:test-server http://localhost:8080/ ui:test-runner'
+ *
+ * The test path for script 'ui:test-server' is 'http://localhost:8080/test/testsuite.qunit.html' from 'ui:test-runner' as they are connected via one indirection ('ui:test').
+ *
+ * @param scriptName - the name of the script from the package.json file
+ * @returns the related test path
+ */
+function getTestPathForUi5TestRunner(scriptName) {
+    const TEST_RUNNER_COMMAND = 'ui5-test-runner';
+    const extractUrl = (script) => {
+        return / (?:--url|-u|--testsuite) (\S*)/.exec(script)?.[1] ?? undefined;
+    };
+    const findReferencingScriptByScriptName = (scriptName) => {
+        return [...scriptsFromPackageJson.values()].find((tmpScriptValue) => tmpScriptValue.includes(` ${scriptName} `));
+    };
+    const findReferencingUi5TestRunnerScriptByScriptValue = (script) => {
+        for (const scriptPart of script.split(' ')) {
+            const scriptValue = scriptsFromPackageJson.get(scriptPart);
+            if (scriptValue?.includes(TEST_RUNNER_COMMAND)) {
+                return scriptValue;
+            }
+        }
+        return undefined;
+    };
+    let testRunnerScript = findReferencingScriptByScriptName(scriptName);
+    let url = testRunnerScript?.includes(TEST_RUNNER_COMMAND) ? extractUrl(testRunnerScript) : undefined;
+    if (!url) {
+        testRunnerScript = findReferencingUi5TestRunnerScriptByScriptValue(testRunnerScript ?? '');
+        url = extractUrl(testRunnerScript ?? '');
+    }
+    return url ? new URL(url).pathname : undefined;
+}
 /**
  * Sanitizes the preview middleware configuration.
  *
@@ -173,8 +219,7 @@ async function processUi5YamlConfig(fs, basePath, ui5Yaml, script, logger, skipP
     if (!previewMiddleware) {
         previewMiddleware = (0, ui5_yaml_1.createPreviewMiddlewareConfig)(fs, basePath);
     }
-    const { path, intent } = (0, package_json_1.extractUrlDetails)(script);
-    previewMiddleware = await updatePreviewMiddlewareConfig(previewMiddleware, intent, path, basePath, fs, logger);
+    previewMiddleware = await updatePreviewMiddlewareConfig(previewMiddleware, script, basePath, fs, logger);
     ui5YamlConfig.updateCustomMiddleware(previewMiddleware);
     const yamlPath = (0, path_1.join)(basePath, ui5Yaml);
     fs.write(yamlPath, ui5YamlConfig.toString());
@@ -185,20 +230,20 @@ async function processUi5YamlConfig(fs, basePath, ui5Yaml, script, logger, skipP
  * It will sanitize the given preview middleware configuration and construct the flp configuration out of the given intent and path.
  *
  * @param previewMiddleware - the preview middleware configuration
- * @param intent - the intent
- * @param path - the flp path
+ * @param script - the content of the script from the package.json file
  * @param basePath - the base path
  * @param fs - file system reference
  * @param logger logger to report info to the user
  * @returns the preview middleware configuration
  */
-async function updatePreviewMiddlewareConfig(previewMiddleware, intent, path, basePath, fs, logger) {
+async function updatePreviewMiddlewareConfig(previewMiddleware, script, basePath, fs, logger) {
+    const { path, intent } = (0, package_json_1.extractUrlDetails)(script.value);
     const defaultIntent = `${DEFAULT_INTENT.object}-${DEFAULT_INTENT.action}`;
     const newMiddlewareConfig = sanitizePreviewMiddleware(previewMiddleware);
     //copy of configuration to avoid ending up with an empty configuration object in some cases
     const configuration = { ...newMiddlewareConfig.configuration };
     let writeConfig = false;
-    if (isFlpPath(path, configuration)) {
+    if (isFlpPath(script, configuration)) {
         //adjust path but respect defaults
         if (!path?.includes(DEFAULT_FLP_PATH)) {
             configuration.flp = configuration.flp ?? {};
@@ -215,10 +260,17 @@ async function updatePreviewMiddlewareConfig(previewMiddleware, intent, path, ba
             writeConfig = true;
         }
     }
-    else if (isTestPath(path, configuration)) {
+    else if (path && isTestPath(script, configuration)) {
         configuration.test = await updateTestConfig(configuration.test, path, basePath, fs, logger);
         writeConfig = true;
     }
+    else if (!path) {
+        const ui5TestRunnerPath = getTestPathForUi5TestRunner(script.name);
+        if (ui5TestRunnerPath) {
+            configuration.test = await updateTestConfig(configuration.test, ui5TestRunnerPath, basePath, fs);
+            writeConfig = true;
+        }
+    }
     if (writeConfig) {
         newMiddlewareConfig.configuration = configuration;
     }
@@ -246,7 +298,7 @@ async function sanitizeTestScript(fs, basePath, path, newConfig, logger) {
             const filePathRenamed = testScriptPath.replace(/(\.([jt])s)$/, '.custom$1');
             fs.move(testScriptPath, filePathRenamed);
             newConfig.pattern = `/test/**/${(0, path_1.basename)(filePathRenamed)}`;
-            logger?.info(`Renamed '${(0, path_1.basename)(testScriptPath)}' to '${(0, path_1.basename)(filePathRenamed)}'. This file creates the JourneyRunner for OPA5 tests. As the handling of journey runners is not part of the virtual OPA5 test runner endpoint, this file has been renamed and added to the respective UI5 yaml configuration.`);
+            logger?.info(`Renamed '${(0, path_1.basename)(testScriptPath)}' to '${(0, path_1.basename)(filePathRenamed)}'. This file creates the JourneyRunner for OPA5 tests. As the handling of journey runners is not part of the virtual OPA5 test runner endpoint, this file has been renamed and added to the respective UI5 YAML configuration.`);
         }
         else {
             await (0, preview_files_1.deleteFiles)(fs, [testScriptPath]);
@@ -341,6 +393,23 @@ async function updateDefaultTestConfig(fs, basePath, logger) {
     const yamlPath = (0, path_1.join)(basePath, project_access_1.FileName.Ui5Yaml);
     fs.write(yamlPath, ui5YamlConfig.toString());
 }
+/**
+ * Reads the scripts from the package.json file.
+ * Scripts will be buffered map 'scriptsFromPackageJson' to avoid multiple reads of the package.json file.
+ *
+ * @param fs - file system reference
+ * @param basePath - base path to be used for the conversion
+ * @returns the scripts from the package.json file
+ */
+function getScriptsFromPackageJson(fs, basePath) {
+    const packageJsonPath = (0, path_1.join)(basePath, 'package.json');
+    const packageJson = fs.readJSON(packageJsonPath);
+    scriptsFromPackageJson.clear();
+    Object.entries(packageJson?.scripts ?? {}).forEach(([scriptName, scriptContent]) => {
+        scriptsFromPackageJson.set(scriptName, scriptContent ?? '');
+    });
+    return scriptsFromPackageJson;
+}
 /**
  * Updates the preview middleware configurations according to the scripts they are being used in package.json.
  *
@@ -356,16 +425,15 @@ async function updateDefaultTestConfig(fs, basePath, logger) {
 async function updatePreviewMiddlewareConfigs(fs, basePath, convertTests, logger) {
     const ui5YamlFileNames = await (0, project_access_1.getAllUi5YamlFileNames)(basePath, fs);
     const unprocessedUi5YamlFileNames = [...ui5YamlFileNames];
-    const packageJsonPath = (0, path_1.join)(basePath, 'package.json');
-    const packageJson = fs.readJSON(packageJsonPath);
-    for (const [scriptName, script] of Object.entries(packageJson?.scripts ?? {})) {
-        if (!script || !(0, package_json_1.isValidPreviewScript)(scriptName, script, convertTests)) {
+    for (const [scriptName, scriptValue] of getScriptsFromPackageJson(fs, basePath)) {
+        const script = { name: scriptName, value: scriptValue };
+        if (!scriptValue || !(0, package_json_1.isValidPreviewScript)(script, convertTests)) {
             continue;
         }
-        const ui5Yaml = (0, path_1.basename)(extractYamlConfigFileName(script));
+        const ui5Yaml = (0, path_1.basename)(extractYamlConfigFileName(scriptValue));
         unprocessedUi5YamlFileNames.splice(unprocessedUi5YamlFileNames.indexOf(ui5Yaml), 1);
         if (!isUi5YamlToBeConverted(ui5Yaml, scriptName, ui5YamlFileNames, logger) ||
-            (await isUi5YamlFlpPathAlreadyConverted(fs, basePath, ui5Yaml, scriptName, script, convertTests, logger))) {
+            (await isUi5YamlFlpPathAlreadyConverted(fs, basePath, ui5Yaml, script, convertTests, logger))) {
             continue;
         }
         try {
@@ -375,20 +443,21 @@ async function updatePreviewMiddlewareConfigs(fs, basePath, convertTests, logger
             logger?.warn(`Skipping script '${scriptName}', which refers to the UI5 YAML configuration file '${ui5Yaml}'. ${error.message}`);
             continue;
         }
-        const { path } = (0, package_json_1.extractUrlDetails)(script);
+        const { path } = (0, package_json_1.extractUrlDetails)(scriptValue);
         if (path) {
             await (0, preview_files_1.renameSandbox)(fs, basePath, path, logger);
         }
-        (0, package_json_1.ensurePreviewMiddlewareDependency)(packageJson, fs, packageJsonPath);
+        (0, package_json_1.ensurePreviewMiddlewareDependency)(fs, basePath);
         logger?.info(`The UI5 YAML configuration file '${ui5Yaml}', has been updated according to script, '${scriptName}'.`);
     }
     for (const ui5Yaml of unprocessedUi5YamlFileNames) {
         //at least adjust deprecated preview config of unused ui5 yaml configurations
+        const emptyScript = { name: '', value: '' };
         try {
-            await processUi5YamlConfig(fs, basePath, ui5Yaml, '', logger, true);
+            await processUi5YamlConfig(fs, basePath, ui5Yaml, emptyScript, logger, true);
         }
         catch (error) {
-            logger?.warn(`Skipping UI5 yaml configuration file '${ui5Yaml}'. ${error.mesage}`);
+            logger?.warn(`Skipping UI5 YAML configuration file '${ui5Yaml}'. ${error.mesage}`);
         }
         logger?.warn(`The UI5 YAML configuration file '${ui5Yaml}', is not used in any preview script. Outdated preview middleware will be adjusted, if necessary.`);
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sap-ux/app-config-writer",
   "description": "Add or update configuration for SAP Fiori tools application",
-  "version": "0.5.28",
+  "version": "0.5.29",
   "repository": {
     "type": "git",
     "url": "https://github.com/SAP/open-ux-tools.git",
@@ -42,7 +42,7 @@
     "@types/semver": "7.5.8",
     "axios": "1.7.9",
     "nock": "13.4.0",
-    "@sap-ux/preview-middleware": "0.17.26"
+    "@sap-ux/preview-middleware": "0.17.29"
   },
   "engines": {
     "node": ">=18.x"