@sap-ux/adp-tooling 0.18.74 → 0.18.75

package/dist/preview/adp-preview.js

@@ -234,7 +234,7 @@ class AdpPreview {
                     await (0, change_handler_1.addAnnotationFile)(this.util.getProject().getSourcePath(), this.util.getProject().getRootPath(), change, fs, logger, this.provider);
                 }
                 if ((0, change_handler_1.isV4DescriptorChange)(change)) {
-                    (0, descriptor_change_handler_1.addCustomSectionFragment)(this.util.getProject().getSourcePath(), change, fs, logger);
+                    (0, descriptor_change_handler_1.addCustomFragment)(this.util.getProject().getSourcePath(), change, fs, logger);
                 }
                 break;
             default:

package/dist/preview/descriptor-change-handler.d.ts

@@ -7,6 +7,12 @@ export declare const customFragmentConfig: {
         ids: Record<string, string>;
     };
 };
+export declare const customColumnFragmentConfig: {
+    path: string;
+    getData: () => {
+        ids: Record<string, string>;
+    };
+};
 /**
  * Checks if the given object has a 'template' property of type string.
  *
@@ -24,5 +30,5 @@ export declare function hasTemplate(obj: unknown): obj is {
  * @param fs - The mem-fs-editor instance for file operations.
  * @param logger - The logger instance for logging information and errors.
  */
-export declare function addCustomSectionFragment(basePath: string, change: AppDescriptorV4Change, fs: Editor, logger: Logger): void;
+export declare function addCustomFragment(basePath: string, change: AppDescriptorV4Change, fs: Editor, logger: Logger): void;
 //# sourceMappingURL=descriptor-change-handler.d.ts.map

package/dist/preview/descriptor-change-handler.js

@@ -1,8 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.customFragmentConfig = void 0;
+exports.customColumnFragmentConfig = exports.customFragmentConfig = void 0;
 exports.hasTemplate = hasTemplate;
-exports.addCustomSectionFragment = addCustomSectionFragment;
+exports.addCustomFragment = addCustomFragment;
 const node_path_1 = require("node:path");
 const utils_1 = require("./utils");
 const node_crypto_1 = require("node:crypto");
@@ -18,6 +18,17 @@ exports.customFragmentConfig = {
         };
     }
 };
+exports.customColumnFragmentConfig = {
+    path: 'v4/mdc-custom-column-config.xml',
+    getData: () => {
+        const uuid = (0, node_crypto_1.randomBytes)(4).toString('hex');
+        return {
+            ids: {
+                text: `text-${uuid}`
+            }
+        };
+    }
+};
 /**
  * Checks if the given object has a 'template' property of type string.
  *
@@ -27,6 +38,32 @@ exports.customFragmentConfig = {
 function hasTemplate(obj) {
     return typeof obj === 'object' && obj !== null && 'template' in obj && typeof obj.template === 'string';
 }
+/**
+ * Gets config based on change property path.
+ *
+ * @param change - The AppDescriptorV4Change object containing change details.
+ * @returns The configuration object or undefined if no matching config is found.
+ */
+function getConfig(change) {
+    const propertyPath = change.content.entityPropertyChange.propertyPath;
+    const isCustomSectionPropertyPath = propertyPath.startsWith('content/body/sections/');
+    // Pattern matches:
+    // - controlConfiguration/@com.sap.vocabularies.UI.v1.LineItem/columns/columnId
+    // - controlConfiguration/@com.sap.vocabularies.UI.v1.LineItem#qualifier/columns/columnId
+    // - controlConfiguration/navigationPath/@com.sap.vocabularies.UI.v1.LineItem/columns/columnId
+    // - controlConfiguration/navigationPath/@com.sap.vocabularies.UI.v1.LineItem#qualifier/columns/columnId
+    // Safe: propertyPath comes from AppDescriptorV4Change which is validated manifest content.
+    // The pattern is bounded: fixed prefix "controlConfiguration/", optional navigation segment,
+    // annotation term, optional qualifier, "/columns/", and column ID - no nested quantifiers.
+    const isCustomColumnPropertyPath = /^controlConfiguration\/(?:[^/@]+\/)?@[^/]+\.LineItem(?:#[^/]+)?\/columns\/[^/]+$/.test(propertyPath);
+    if (isCustomSectionPropertyPath) {
+        return exports.customFragmentConfig;
+    }
+    else if (isCustomColumnPropertyPath) {
+        return exports.customColumnFragmentConfig;
+    }
+    return undefined;
+}
 /**
  * Adds a custom XML fragment file based on the provided AppDescriptorV4Change and template configuration.
  *
@@ -35,10 +72,10 @@ function hasTemplate(obj) {
  * @param fs - The mem-fs-editor instance for file operations.
  * @param logger - The logger instance for logging information and errors.
  */
-function addCustomSectionFragment(basePath, change, fs, logger) {
+function addCustomFragment(basePath, change, fs, logger) {
     const propertyValue = change.content.entityPropertyChange.propertyValue;
-    const isCustomSectionPropertyPath = change.content.entityPropertyChange.propertyPath.startsWith('content/body/sections/');
-    if (isCustomSectionPropertyPath && hasTemplate(propertyValue)) {
+    const config = getConfig(change);
+    if (hasTemplate(propertyValue) && config) {
         const { template } = propertyValue;
         const path = (0, utils_1.getFragmentPathFromTemplate)(template, change);
         try {
@@ -47,9 +84,17 @@ function addCustomSectionFragment(basePath, change, fs, logger) {
             }
             const fragmentPath = `${path}.fragment.xml`;
             const fullPath = (0, node_path_1.join)(basePath, fragmentPath);
-            const fragmentTemplatePath = (0, node_path_1.join)(__dirname, '../../templates/rta', exports.customFragmentConfig.path);
+            const fragmentTemplatePath = (0, node_path_1.join)(__dirname, '../../templates/rta', config.path);
             const text = fs.read(fragmentTemplatePath);
-            const template = (0, ejs_1.render)(text, exports.customFragmentConfig.getData());
+            // Safe: Template files are from our own codebase (templates/rta/), config.path is from getConfig()
+            // which only returns predefined paths (customFragmentConfig or customColumnFragmentConfig).
+            // Template data comes from controlled config.getData() which only generates UUIDs for IDs.
+            const template = (0, ejs_1.render)(text, {
+                viewName: undefined,
+                controlType: undefined,
+                targetAggregation: undefined,
+                ...config.getData()
+            });
             fs.write(fullPath, template);
             logger.info(`XML Fragment "${fragmentPath}" was created`);
         }

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Aadp-tooling"
   },
-  "version": "0.18.74",
+  "version": "0.18.75",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",

package/templates/rta/v4/mdc-custom-column-config.xml

@@ -0,0 +1,6 @@
+<core:FragmentDefinition xmlns:core="sap.ui.core" xmlns="sap.m" xmlns:table="sap.ui.mdc.table"><% if (targetAggregation && controlType && viewName) { %>
+        <!-- viewName: <%= viewName %> -->
+        <!-- controlType: <%= controlType %> -->
+        <!-- targetAggregation: <%= targetAggregation %> --> <% } %>
+        <Text id="<%- ids.text %>" text="Sample data"/>
+</core:FragmentDefinition>