@sap-ux/adp-tooling 0.15.4 → 0.15.6

package/dist/base/change-utils.d.ts

@@ -16,9 +16,10 @@ interface InboundChange extends ManifestChangeProperties {
  * @param {AnnotationsData} annotation - The annotation data.
  * @param {ManifestChangeProperties} change - The annotation data change that will be written.
  * @param {Editor} fs - The `mem-fs-editor` instance used for file operations.
+ * @param {string} templatesPath - The path to the templates used for generating changes.
  * @returns {void}
  */
-export declare function writeAnnotationChange(projectPath: string, timestamp: number, annotation: AnnotationsData['annotation'], change: ManifestChangeProperties | undefined, fs: Editor): void;
+export declare function writeAnnotationChange(projectPath: string, timestamp: number, annotation: AnnotationsData['annotation'], change: ManifestChangeProperties | undefined, fs: Editor, templatesPath?: string): void;
 /**
  * Writes a given change object to a file within a specified folder in the project's 'changes' directory.
  * If an additional subdirectory is specified, the change file is written there.

package/dist/base/change-utils.js

@@ -24,9 +24,10 @@ const ejs_1 = require("ejs");
  * @param {AnnotationsData} annotation - The annotation data.
  * @param {ManifestChangeProperties} change - The annotation data change that will be written.
  * @param {Editor} fs - The `mem-fs-editor` instance used for file operations.
+ * @param {string} templatesPath - The path to the templates used for generating changes.
  * @returns {void}
  */
-function writeAnnotationChange(projectPath, timestamp, annotation, change, fs) {
+function writeAnnotationChange(projectPath, timestamp, annotation, change, fs, templatesPath) {
     try {
         const changesFolderPath = path_1.default.join(projectPath, project_access_1.DirName.Webapp, project_access_1.DirName.Changes);
         const annotationsFolderPath = path_1.default.join(changesFolderPath, project_access_1.DirName.Annotations);
@@ -36,7 +37,9 @@ function writeAnnotationChange(projectPath, timestamp, annotation, change, fs) {
             writeChangeToFile(changeFilePath, change, fs);
         }
         if (!annotation.filePath) {
-            const annotationsTemplate = path_1.default.join(__dirname, '..', '..', 'templates', 'changes', "annotation.xml" /* TemplateFileName.Annotation */);
+            const annotationsTemplate = templatesPath
+                ? path_1.default.join(templatesPath, 'changes', "annotation.xml" /* TemplateFileName.Annotation */)
+                : path_1.default.join(__dirname, '..', '..', 'templates', 'changes', "annotation.xml" /* TemplateFileName.Annotation */);
             const { namespaces, serviceUrl } = annotation;
             const schemaNamespace = `local_${timestamp}`;
             (0, ejs_1.renderFile)(annotationsTemplate, { namespaces, path: serviceUrl, schemaNamespace }, {}, (err, str) => {

package/dist/base/helper.js

@@ -140,45 +140,17 @@ function filterAndMapInboundsToManifest(inbounds) {
         return undefined;
     }
     const filteredInbounds = inbounds.reduce((acc, inbound) => {
-        // Skip if hideLauncher is not false
-        if (!inbound?.content || inbound.content.hideLauncher !== false) {
+        // Skip if hideLauncher is true
+        if (!inbound?.content || inbound.content.hideLauncher === true) {
             return acc;
         }
-        const { semanticObject, action, signature } = inbound.content;
+        const { semanticObject, action } = inbound.content;
         if (semanticObject && action) {
             const key = `${semanticObject}-${action}`;
-            // Temporary filtration of parameters to avoid issues with merged manifest until release of ABAP Platform Cloud 2508
-            if (signature?.parameters) {
-                filterIboundsParameters(signature);
-            }
             acc[key] = inbound.content;
         }
         return acc;
     }, {});
     return Object.keys(filteredInbounds).length === 0 ? undefined : filteredInbounds;
 }
-/**
- * Filters parameters of the inbound signature to remove invalid or incomplete entries.
- *
- * @param {ManifestNamespace.SignatureDef} inboundSinature - The inbound signature definition to filter.
- */
-function filterIboundsParameters(inboundSinature) {
-    Object.keys(inboundSinature.parameters).forEach((paramKey) => {
-        const param = inboundSinature.parameters[paramKey];
-        if (param.defaultValue && (!param.defaultValue.format || !param.defaultValue.value)) {
-            delete inboundSinature.parameters[paramKey];
-            return;
-        }
-        if (param.filter && !param.filter.format) {
-            delete inboundSinature.parameters[paramKey].filter;
-        }
-        if (param.launcherValue) {
-            Object.keys(param.launcherValue).forEach((launcherKey) => {
-                if (launcherKey !== 'value') {
-                    delete param.launcherValue[launcherKey];
-                }
-            });
-        }
-    });
-}
 //# sourceMappingURL=helper.js.map

package/dist/writer/changes/writer-factory.d.ts

@@ -12,9 +12,10 @@ export declare class WriterFactory {
      * @param type - The type of the change which will be handled by the writer.
      * @param fs - The filesystem editor instance.
      * @param projectPath - The path to the project for which the writer is created.
+     * @param templatesPath - The path to the templates used for generating changes.
      * @returns An instance of the writer associated with the specified generator type.
      * @throws If the specified generator type is not supported.
      */
-    static createWriter<T extends ChangeType>(type: T, fs: Editor, projectPath: string): IWriterData<T>;
+    static createWriter<T extends ChangeType>(type: T, fs: Editor, projectPath: string, templatesPath?: string): IWriterData<T>;
 }
 //# sourceMappingURL=writer-factory.d.ts.map

package/dist/writer/changes/writer-factory.js

@@ -20,14 +20,18 @@ class WriterFactory {
      * @param type - The type of the change which will be handled by the writer.
      * @param fs - The filesystem editor instance.
      * @param projectPath - The path to the project for which the writer is created.
+     * @param templatesPath - The path to the templates used for generating changes.
      * @returns An instance of the writer associated with the specified generator type.
      * @throws If the specified generator type is not supported.
      */
-    static createWriter(type, fs, projectPath) {
+    static createWriter(type, fs, projectPath, templatesPath) {
         const WriterClass = this.writers.get(type);
         if (!WriterClass) {
             throw new Error(`Unsupported generator type: ${type}`);
         }
+        if (type === "appdescr_app_addAnnotationsToOData" /* ChangeType.ADD_ANNOTATIONS_TO_ODATA */) {
+            return new WriterClass(fs, projectPath, templatesPath);
+        }
         return new WriterClass(fs, projectPath);
     }
 }

package/dist/writer/changes/writers/annotations-writer.d.ts

@@ -4,13 +4,15 @@ import { type IWriter, type AnnotationsData } from '../../../types';
  * Handles the creation and writing of annotations data changes for a project.
  */
 export declare class AnnotationsWriter implements IWriter<AnnotationsData> {
-    private fs;
-    private projectPath;
+    private readonly fs;
+    private readonly projectPath;
+    private readonly templatesPath?;
     /**
      * @param {Editor} fs - The filesystem editor instance.
      * @param {string} projectPath - The root path of the project.
+     * @param {string} templatesPath - The path to the templates used for generating changes.
      */
-    constructor(fs: Editor, projectPath: string);
+    constructor(fs: Editor, projectPath: string, templatesPath?: string | undefined);
     /**
      * Constructs the content for an annotation change based on provided data.
      *

package/dist/writer/changes/writers/annotations-writer.js

@@ -42,13 +42,16 @@ const change_utils_1 = require("../../../base/change-utils");
 class AnnotationsWriter {
     fs;
     projectPath;
+    templatesPath;
     /**
      * @param {Editor} fs - The filesystem editor instance.
      * @param {string} projectPath - The root path of the project.
+     * @param {string} templatesPath - The path to the templates used for generating changes.
      */
-    constructor(fs, projectPath) {
+    constructor(fs, projectPath, templatesPath) {
         this.fs = fs;
         this.projectPath = projectPath;
+        this.templatesPath = templatesPath;
     }
     /**
      * Constructs the content for an annotation change based on provided data.
@@ -104,7 +107,7 @@ class AnnotationsWriter {
         if (data.isCommand) {
             change = (0, change_utils_1.getChange)(variant, timestamp, content, "appdescr_app_addAnnotationsToOData" /* ChangeType.ADD_ANNOTATIONS_TO_ODATA */);
         }
-        (0, change_utils_1.writeAnnotationChange)(this.projectPath, timestamp, data.annotation, change, this.fs);
+        (0, change_utils_1.writeAnnotationChange)(this.projectPath, timestamp, data.annotation, change, this.fs, this.templatesPath);
     }
 }
 exports.AnnotationsWriter = AnnotationsWriter;

package/dist/writer/editors.d.ts

@@ -11,8 +11,9 @@ import type { GeneratorData, ChangeType } from '../types';
  * @param {T} type - The type of generator.
  * @param {GeneratorData<T>} data - The data specific to the type of generator, containing information necessary for making changes.
  * @param {Editor | null} [fs] - The `mem-fs-editor` instance used for file operations.
+ * @param {string} templatesPath - The path to the templates used for generating changes.
  * @returns {Promise<Editor>} A promise that resolves to the mem-fs editor instance used for making changes, allowing for further operations or committing changes to disk.
  * @template T - A type parameter extending `ChangeType`, ensuring the function handles a defined set of generator types.
  */
-export declare function generateChange<T extends ChangeType>(projectPath: string, type: T, data: GeneratorData<T>, fs?: Editor | null): Promise<Editor>;
+export declare function generateChange<T extends ChangeType>(projectPath: string, type: T, data: GeneratorData<T>, fs?: Editor | null, templatesPath?: string): Promise<Editor>;
 //# sourceMappingURL=editors.d.ts.map

package/dist/writer/editors.js

@@ -15,14 +15,15 @@ const writer_factory_1 = require("./changes/writer-factory");
  * @param {T} type - The type of generator.
  * @param {GeneratorData<T>} data - The data specific to the type of generator, containing information necessary for making changes.
  * @param {Editor | null} [fs] - The `mem-fs-editor` instance used for file operations.
+ * @param {string} templatesPath - The path to the templates used for generating changes.
  * @returns {Promise<Editor>} A promise that resolves to the mem-fs editor instance used for making changes, allowing for further operations or committing changes to disk.
  * @template T - A type parameter extending `ChangeType`, ensuring the function handles a defined set of generator types.
  */
-async function generateChange(projectPath, type, data, fs = null) {
+async function generateChange(projectPath, type, data, fs = null, templatesPath) {
     if (!fs) {
         fs = (0, mem_fs_editor_1.create)((0, mem_fs_1.create)());
     }
-    const writer = writer_factory_1.WriterFactory.createWriter(type, fs, projectPath);
+    const writer = writer_factory_1.WriterFactory.createWriter(type, fs, projectPath, templatesPath);
     await writer.write(data);
     return fs;
 }

package/package.json

@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/SAP/open-ux-tools/issues?q=is%3Aopen+is%3Aissue+label%3Abug+label%3Aadp-tooling"
   },
-  "version": "0.15.4",
+  "version": "0.15.6",
   "license": "Apache-2.0",
   "author": "@SAP/ux-tools-team",
   "main": "dist/index.js",
@@ -75,7 +75,7 @@
     "format": "prettier --write '**/*.{js,json,ts,yaml,yml}' --ignore-path ../../.prettierignore",
     "lint": "eslint . --ext .ts",
     "lint:fix": "eslint . --ext .ts --fix",
-    "test": "cross-env FIORI_TOOLS_DISABLE_SECURE_STORE=true jest --ci --forceExit --detectOpenHandles --colors --testPathPattern=test/unit",
+    "test": "cross-env FIORI_TOOLS_DISABLE_SECURE_STORE=true jest --ci --forceExit --detectOpenHandles --colors --testPathPatterns=test/unit",
     "test-u": "cross-env FIORI_TOOLS_DISABLE_SECURE_STORE=true jest --ci --forceExit --detectOpenHandles --colors -u",
     "link": "pnpm link --global",
     "unlink": "pnpm unlink --global"