@sanoma-ai/workflows 0.2.0 → 0.4.1

package/src/client.ts

@@ -4,18 +4,50 @@ import { type DBOSClient, Error as DBOSErrors, type WorkflowStatusString } from
 import type { Pool } from "pg";
 import { z } from "zod";
 import { APPROVALS_EVENT, ApprovalMessage, decisionEventOf, messageKeyOf, topicOf } from "./approvals.ts";
+import { beforeOf, decideCall, decideStart, recorded, startHoldOf } from "./call.ts";
+import { collectionsDriver } from "./collection.ts";
 import { type ResolvedConfig, resolveConfig, type SanomaConfig } from "./config.ts";
-import { deleteCredential, storeCredential, storedCredentials } from "./credentials.ts";
+import { deleteCredential, storeCredential, storedCredentials, storedSecrets } from "./credentials.ts";
 import { dbosClient, lazyPool, type LazyPool } from "./db.ts";
 import { type CredentialStatus, credentialsOf } from "./env.ts";
-import { type ApprovalState, notApprover, Principal, type WorkflowDefinition } from "./define.ts";
+import { type ApprovalState, Principal, type WorkflowDefinition } from "./define.ts";
 import { APPLY_WORKFLOW, type ApplyInput, type ApplyReport } from "./apply.ts";
 import { DRIFT_WORKFLOW, type DriftReport } from "./drift.ts";
-import { parseOrThrow, SanomaError } from "./errors.ts";
-import { type LedgerRecord, type OwnedLedger, ownedLedger } from "./ledger.ts";
-import type { Driver } from "./op.ts";
-import type { RunArgs } from "./run.ts";
-import { isEnded, mayDecide, type RunStatus } from "./shared.ts";
+import { isDirect } from "./direct.ts";
+import {
+  ApprovalPendingError,
+  type ErrorInfo,
+  errorCode,
+  errorInfo,
+  parseOrThrow,
+  PolicyDeniedError,
+  SanomaError,
+} from "./errors.ts";
+import { insertRecord, type LedgerRecord, type OwnedLedger, ownedLedger } from "./ledger.ts";
+import type { CallContext, Driver, Op } from "./op.ts";
+import { allowAll, type RecordedDecision } from "./policy.ts";
+import { admit, readPeople } from "./resources.ts";
+import type { RunArgs, StartHold } from "./run.ts";
+import type { Secrets } from "./secret.ts";
+import {
+  BUILT_IN_WORKFLOWS,
+  CALL_WORKFLOW,
+  DATA_VENDOR,
+  errorMessage,
+  isEnded,
+  refusalOf,
+  type RunStatus,
+  WORKFLOW_ACTION,
+} from "./shared.ts";
+
+/** A principal, or its id alone. */
+const PrincipalOrId = z.union([
+  z
+    .string()
+    .regex(/\S/)
+    .transform((id) => ({ id })),
+  Principal,
+]);
 
 /**
  * The run status each DBOS status maps to. `waiting` is PENDING with an approval pending, so
@@ -77,7 +109,7 @@ export interface RunSummary {
   runId: string;
   workflow: string;
   status: RunStatus;
-  /** Who started the run, as passed to `start`. */
+  /** Who started the run, as `start` admitted them. */
   startedBy?: Principal;
   createdAt: number;
   updatedAt?: number;
@@ -88,12 +120,17 @@ export interface RunSummary {
 }
 
 export interface StartOptions {
-  /** Recorded as the run's actor in the ledger and passed to the policy. */
-  startedBy: Principal;
+  /**
+   * Who starts it, by id (`"ada"`, or `{ id: "ada" }`): recorded as the run's actor in the ledger
+   * and passed to the policy. When the data files declare people, the run is started as the
+   * declared principal (`principalOf`: their groups, not any given here), and an id nobody
+   * declares is refused with `not_admitted`.
+   */
+  startedBy: Principal | string;
   /**
    * Use this run id instead of a new one, so a retried start makes one run. Starting an id
    * that exists returns it, without starting another, when the workflow, the input (compared
-   * as JSON), `startedBy` and `sandbox` are the same, and throws `invalid_input` naming what differs
+   * as JSON), `startedBy`'s id and `sandbox` are the same, and throws `invalid_input` naming what differs
    * when they are not. Of two starts racing with one new id, the first's run stands.
    */
   runId?: string;
@@ -105,6 +142,20 @@ export interface StartOptions {
   sandbox?: string;
 }
 
+/** What `SanomaClient.call` takes besides the operation's id and its input. */
+export interface CallOptions {
+  /**
+   * Who calls, by id, admitted as `startedBy` is: the policy decides as them, a write's record
+   * names them, and a save's `updatedBy` is their id.
+   */
+  actor: Principal | string;
+  /**
+   * The call's id, so a retried write is made once: the same id with the same input returns what
+   * the first call returned, with another input is refused (`invalid_input`). A new one by default.
+   */
+  id?: string;
+}
+
 /** Talks to the runtime from another process (the app, a script), through the shared Postgres. */
 export class SanomaClient {
   private readonly dbos: DBOSClient;
@@ -114,6 +165,8 @@ export class SanomaClient {
   private readonly audit: OwnedLedger;
   /** On the config's database, for the credentials table: opened on first use. */
   private readonly credentialsPool: LazyPool;
+  /** What a direct call's driver reads secrets from, as a worker's live driver does. */
+  private readonly storedSecrets: Secrets;
 
   private constructor(dbos: DBOSClient, config: ResolvedConfig, drivers: ReadonlyMap<string, Driver>) {
     this.dbos = dbos;
@@ -121,6 +174,7 @@ export class SanomaClient {
     this.drivers = drivers;
     this.audit = ownedLedger(config);
     this.credentialsPool = lazyPool(config.databaseUrl, "credentials");
+    this.storedSecrets = storedSecrets(() => this.credentialsDb(), "sanoma");
   }
 
   /**
@@ -145,6 +199,13 @@ export class SanomaClient {
     input: z.input<S>,
     options: StartOptions,
   ): Promise<string> {
+    const startedBy = await this.admitted(
+      parseOrThrow(
+        PrincipalOrId,
+        options?.startedBy,
+        '`startedBy` must be a principal, such as "alice" or { id: "alice" }',
+      ),
+    );
     if (typeof workflow === "string") {
       const named = this.config.workflows.get(workflow);
       if (!named) {
@@ -156,19 +217,17 @@ export class SanomaClient {
       }
       workflow = named;
     }
-    parseOrThrow(workflow.input, input, `The input does not match ${workflow.name}'s schema`);
-    const startedBy = parseOrThrow(
-      Principal,
-      options?.startedBy,
-      '`startedBy` must be a principal, such as { id: "alice" }',
-    );
+    // The policy decides the start on the input as parsed, its defaults filled, as the Cedar schema types it.
+    const parsed = parseOrThrow(workflow.input, input, `The input does not match ${workflow.name}'s schema`);
     const { runId } = options;
     const sandbox = parseOrThrow(
       z.string().min(1).optional(),
       options.sandbox,
       "`sandbox` must be the name of a scenario in the config's `scenarios/`",
     );
-    const args: RunArgs = { input, startedBy, ...(sandbox === undefined ? {} : { sandbox }) };
+    const hold = await this.startHold(workflow.name, parsed, startedBy, runId);
+    const args: RunArgs = { input, startedBy, ...(sandbox === undefined ? {} : { sandbox }), ...(hold && { hold }) };
+    const { onBehalfOf } = startedBy;
     // An id DBOS has already returns that run, unless it is another workflow's, which DBOS refuses.
     const handle = await this.dbos
       .enqueue(
@@ -179,8 +238,9 @@ export class SanomaClient {
           applicationName: this.config.appName,
           authenticatedUser: startedBy.id,
           authenticatedRoles: startedBy.groups ?? [],
-          // Kept on the run's status row too, so a listing tells sandbox runs apart without its input.
-          ...(sandbox === undefined ? {} : { attributes: { sandbox } }),
+          // Kept on the run's status row too, so a listing tells sandbox runs apart without its input,
+          // and says whom an agent's run is for (DBOS keeps the principal's id and groups itself).
+          ...((sandbox !== undefined || onBehalfOf !== undefined) && { attributes: { sandbox, onBehalfOf } }),
         },
         args,
       )
@@ -200,6 +260,221 @@ export class SanomaClient {
     return handle.workflowID;
   }
 
+  /**
+   * The policy's answer to starting a run of `workflow` as `startedBy` (`decideStart`), for a
+   * workflow of the config's own: a deny throws `policy_denied`; a hold is what the run waits on
+   * before its body. A run `runId` names already is returned as it is, whatever the policy says now.
+   */
+  private async startHold(
+    workflow: string,
+    input: unknown,
+    startedBy: Principal,
+    runId: string | undefined,
+  ): Promise<StartHold | undefined> {
+    const { policy } = this.config;
+    if (BUILT_IN_WORKFLOWS.has(workflow) || policy === allowAll) return undefined;
+    if (runId !== undefined && (await this.row(runId))) return undefined;
+    const decision = decideStart(policy, workflow, input, startedBy);
+    if (decision.kind === "allow") return undefined;
+    if (decision.kind === "deny") throw new PolicyDeniedError(`${WORKFLOW_ACTION}${workflow}`, decision.reason);
+    return startHoldOf(workflow, decision);
+  }
+
+  /**
+   * Calls an operation directly, outside a run, as `actor`: one that may be (`isDirect`), a
+   * collection's or a vendor's read, never a vendor's write, the runtime's own or a resource
+   * type's (`invalid_input`, as is an unknown id or input its schema refuses). The policy decides
+   * it as the person, in a run `direct:<actor>:<id>` of the workflow `call` with no approvals. A
+   * deny throws `policy_denied` and writes nothing. An allowed call runs the driver once, without
+   * DBOS and without a retry (a driver's failure is `driver_failed`). A read returns its output
+   * and records nothing. A write is recorded as one `op.called` (seq 0) in that run, and with the
+   * default ledger in one transaction with the record it saves, so both are written or neither;
+   * a write with the same id and input returns the output recorded. When the policy asks for an
+   * approval, the call becomes run `call:<actor>:<id>` of the built-in `call` workflow, started
+   * as the person, which makes it once approved, and this throws `approval_pending` with its id.
+   */
+  async call(opId: string, input: unknown, options: CallOptions): Promise<unknown> {
+    const actor = await this.admitted(
+      parseOrThrow(PrincipalOrId, options?.actor, '`actor` must be a principal, such as "alice" or { id: "alice" }'),
+    );
+    const id =
+      parseOrThrow(z.string().min(1).optional(), options.id, "`id` must be a non-empty string") ?? randomUUID();
+    const { ops, types, drivers, policy } = this.config;
+    const op = ops.get(opId);
+    if (!op || !isDirect(op, types)) {
+      const why = op ? "it is a workflow's to call: start one that uses it" : "no connector or collection declares it";
+      throw new SanomaError("invalid_input", `${opId} cannot be called directly: ${why}`, { op: opId });
+    }
+    const fn = drivers.get(op.id);
+    if (!fn) throw new SanomaError("invalid_input", `${op.id} has no driver: the connector package must attach one`);
+    const parsed = parseOrThrow(op.input, input, `The input to ${op.id} does not match its schema`, { op: op.id });
+    const runId = `direct:${actor.id}:${id}`;
+    const heldId = `call:${actor.id}:${id}`;
+    const held: RunArgs = { input: { op: op.id, input }, startedBy: actor };
+    const logged = recorded(op, parsed);
+    const write = op.effect !== "read";
+    // Only an id the caller gave can have been used: a write made, or held, with it settles it.
+    if (write && options.id !== undefined) {
+      const first = (await this.recordedCall(runId, op.id, logged)) ?? (await this.heldCall(op.id, heldId, held));
+      if (first) return first.output;
+    }
+    const before = await beforeOf(policy, op, parsed, this.config.collections, (get, key) =>
+      drivers.get(get)?.(
+        { key },
+        { idempotencyKey: `${runId}:before`, runId, opId: get, attempt: 1, secrets: this.storedSecrets, by: actor.id },
+      ),
+    );
+    const run = { id: runId, workflow: CALL_WORKFLOW, approvals: [] };
+    const decision = decideCall(policy, op, parsed, actor, run, before);
+    if (decision.kind === "deny") throw new PolicyDeniedError(op.id, decision.reason);
+    if (decision.kind === "approve") {
+      await this.start(CALL_WORKFLOW, held.input, { startedBy: actor, runId: heldId });
+      // A read held before, whose run has ended since, answers with that run's result.
+      return (await this.heldCall(op.id, heldId, held))!.output;
+    }
+    const context: CallContext = {
+      idempotencyKey: runId,
+      runId,
+      opId: op.id,
+      attempt: 1,
+      secrets: this.storedSecrets,
+      by: actor.id,
+    };
+    if (!write) return outputOf(op, () => fn(parsed, context));
+    return this.directWrite({ op, fn, parsed, logged, actor, decision, context });
+  }
+
+  /**
+   * A direct write, made once and recorded once: with the default ledger, a collection's write
+   * and its record in one transaction on the database both are in, so both are kept or neither;
+   * otherwise the driver's call, then the record in the config's ledger. The first record of the
+   * call's id stands: a write that finds one already there (two calls with one id at once) is
+   * undone, and answers as `recordedCall` does.
+   */
+  private async directWrite(call: {
+    op: Op;
+    fn: (input: unknown, context: CallContext) => Promise<unknown>;
+    parsed: unknown;
+    logged: unknown;
+    actor: Principal;
+    decision: RecordedDecision;
+    context: CallContext;
+  }): Promise<unknown> {
+    const { op, parsed, logged, actor, decision, context } = call;
+    const { runId } = context;
+    const { dataStore, collections, ledger } = this.config;
+    const conn = op.vendor === DATA_VENDOR && !ledger && dataStore ? await (await dataStore.db()).connect() : undefined;
+    let broken: Error | undefined;
+    try {
+      await conn?.query("BEGIN");
+      // On the transaction's connection, the collection's own driver: it has no `env` to guard.
+      const fn = conn
+        ? collectionsDriver([collections.get(op.resource)!], { db: async () => conn }).ops[`${op.resource}.${op.name}`]!
+        : call.fn;
+      const at = Date.now();
+      const record = (outcome: { output: unknown } | { error: ErrorInfo }): LedgerRecord => ({
+        v: 1,
+        app: this.config.appName,
+        id: `${runId}:op.called:0`,
+        runId,
+        seq: 0,
+        at,
+        actor,
+        workflow: CALL_WORKFLOW,
+        type: "op.called",
+        op: op.id,
+        effect: op.effect,
+        input: logged,
+        decision,
+        ...outcome,
+        durationMs: Date.now() - at,
+      });
+      let output: unknown;
+      try {
+        output = await outputOf(op, () => fn(parsed, context));
+      } catch (err) {
+        // Recorded on the store's own connection; the transaction is rolled back below.
+        await this.audit.store.append(record({ error: errorInfo(err) }));
+        throw err;
+      }
+      const done = record({ output: recorded(op, output) });
+      if (!conn) {
+        await this.audit.store.append(done);
+        return output;
+      }
+      if (await insertRecord(conn, done)) {
+        await conn.query("COMMIT");
+        return output;
+      }
+      await conn.query("ROLLBACK");
+      return (await this.recordedCall(runId, op.id, logged))!.output;
+    } catch (err) {
+      await conn?.query("ROLLBACK").catch((e: Error) => (broken = e));
+      throw err;
+    } finally {
+      conn?.release(broken);
+    }
+  }
+
+  /**
+   * What the direct write recorded as `runId` returned, when one did: refused (`invalid_input`)
+   * when it was of another operation or input, and its failure again (`driver_failed`) when it failed.
+   */
+  private async recordedCall(runId: string, opId: string, input: unknown): Promise<{ output: unknown } | undefined> {
+    const first = (await this.audit.store.read(runId)).find((r) => r.type === "op.called");
+    if (!first) return undefined;
+    const differs = [...(first.op === opId ? [] : ["op"]), ...(sameJson(first.input, input) ? [] : ["input"])];
+    if (differs.length) {
+      throw new SanomaError(
+        "invalid_input",
+        `Call ${runId} was made already with a different ${differs.join(" and ")}; use another id`,
+        { runId, differs },
+      );
+    }
+    if (first.error) {
+      throw new SanomaError(
+        "driver_failed",
+        `${opId} failed when first called as ${runId}: ${first.error.message}; call again with another id`,
+        {
+          runId,
+          op: opId,
+          error: first.error,
+        },
+      );
+    }
+    return { output: first.output };
+  }
+
+  /**
+   * What the held call's run `heldId` returned once it ended (its error, when it failed);
+   * `approval_pending` while it has not; undefined when there is no such run. Refused
+   * (`invalid_input`) when the run was started with another input or by someone else.
+   */
+  private async heldCall(opId: string, heldId: string, args: RunArgs): Promise<{ output: unknown } | undefined> {
+    const [row] = await this.dbos.listWorkflows({ workflowIDs: [heldId], loadInput: false, loadOutput: false });
+    if (!row) return undefined;
+    await this.mustMatch(heldId, args);
+    if (!isEnded(runStatus(row.status, []))) throw new ApprovalPendingError(opId, heldId);
+    return { output: await this.awaitResult(heldId, 30_000) };
+  }
+
+  /**
+   * The newest finished run of the workflow, with its output and when it finished; null when it
+   * has none. One query, whatever the app's runs.
+   */
+  async latest(workflow: string): Promise<{ runId: string; output: unknown; at: number } | null> {
+    const [row] = await this.dbos.listWorkflows({
+      workflowName: workflow,
+      applicationName: this.config.appName,
+      status: "SUCCESS",
+      sortDesc: true,
+      limit: 1,
+      loadInput: false,
+      loadOutput: true,
+    });
+    return row ? { runId: row.workflowID, output: row.output, at: row.updatedAt ?? row.createdAt } : null;
+  }
+
   /** The run's audit record, in order, from the ledger store. */
   async ledger(runId: string): Promise<LedgerRecord[]> {
     await this.mustExist(runId);
@@ -262,7 +537,9 @@ export class SanomaClient {
     approvalId?: string,
     options: { timeoutSeconds?: number } = {},
   ): Promise<ApprovalState> {
-    const msg = parseOrThrow(ApprovalMessage, message, "Not a decision");
+    const given = parseOrThrow(ApprovalMessage, message, "Not a decision");
+    const declared = readPeople(this.config.root);
+    const msg = { ...given, by: admit(given.by, declared) };
     // A run that does not exist has no approvals, so run_not_found never hides already_decided.
     const [all, row] = await Promise.all([this.approvals(runId), this.mustExist(runId)]);
     const target = approvalId ? all.find((a) => a.id === approvalId) : all.find((a) => a.status === "pending");
@@ -283,11 +560,18 @@ export class SanomaClient {
         { runId, ...(approvalId ? { approvalId } : {}) },
       );
     }
-    if (!mayDecide(target, msg.by)) {
-      throw new SanomaError("not_approver", `${notApprover(target, msg.by)} (${target.id})`, {
+    const reason = refusalOf(
+      target,
+      msg.by,
+      { actor: row.authenticatedUser ? { id: row.authenticatedUser } : undefined },
+      declared.people,
+    );
+    if (reason !== undefined) {
+      throw new SanomaError("not_approver", `${reason} (${target.id})`, {
         runId,
         approvalId: target.id,
         approver: target.approver,
+        reason,
       });
     }
     // The id names this message, so the run's answer says whether it decided with it, and is
@@ -315,6 +599,7 @@ export class SanomaClient {
         runId,
         approvalId: target.id,
         approver: target.approver,
+        reason: refused.reason,
       });
     }
     if (now.status !== "pending" && now.decidedWith !== id) throw alreadyDecided(runId, now);
@@ -392,12 +677,13 @@ export class SanomaClient {
    * loads it into its environment, unless its environment sets the variable itself. Refuses
    * (`invalid_input`) a name no driver declares, and a value the variable's schema refuses, with
    * the schema's reason and never the value; an empty value too (`clearCredential` unsets one).
-   * Nothing records the value but its row, which records `by` and when.
+   * Nothing records the value but its row, which records `by` and when. `by` is admitted as
+   * `start`'s `startedBy` is (`not_admitted`).
    */
   async setCredential(name: string, value: string, options: { by: string }): Promise<void> {
+    const setBy = await this.admittedBy(options);
     // Checked against every declaration of the name, as the worker checks it.
     const statuses = this.declared(name, (n) => (n === name ? value : undefined));
-    const setBy = actorOf(options);
     const refused = statuses.find((c) => c.status !== "set");
     if (refused) {
       const problem = refused.problem ?? "it is empty; clear it to unset it";
@@ -412,11 +698,11 @@ export class SanomaClient {
   /**
    * Deletes the stored value of a declared variable, and tells the workers, which unset it unless
    * their environment sets it. `by` is who asks; nothing records it once the row is gone.
-   * Refuses (`invalid_input`) a name no driver declares.
+   * Refuses (`invalid_input`) a name no driver declares, and `by` as `setCredential` does.
    */
   async clearCredential(name: string, options: { by: string }): Promise<void> {
+    await this.admittedBy(options);
     this.declared(name, () => undefined);
-    actorOf(options);
     await deleteCredential(await this.credentialsDb(), name);
   }
 
@@ -430,7 +716,7 @@ export class SanomaClient {
     if ([...credentialsOf(this.drivers, () => undefined).values()].flat().some((c) => c.name === name)) {
       return this.setCredential(name, value, options);
     }
-    const setBy = actorOf(options);
+    const setBy = await this.admittedBy(options);
     const problem = !VARIABLE.test(name) ? "That is not a variable name" : !value ? "Enter a value" : undefined;
     if (problem) {
       const path = VARIABLE.test(name) ? "value" : "name";
@@ -478,7 +764,12 @@ export class SanomaClient {
   }
 
   async close() {
-    await Promise.all([this.dbos.destroy(), this.credentialsPool.close(), this.audit.close()]);
+    await Promise.all([
+      this.dbos.destroy(),
+      this.credentialsPool.close(),
+      this.audit.close(),
+      this.config.dataStore?.close(),
+    ]);
   }
 
   /**
@@ -506,11 +797,28 @@ export class SanomaClient {
     return this.credentialsPool.db();
   }
 
+  /**
+   * The principal as the data files declare it (`admit`): its id alone is taken, never the groups
+   * a caller gives, and an id nobody declares is `not_admitted`.
+   */
+  private async admitted(principal: Principal): Promise<Principal> {
+    return admit(principal, readPeople(this.config.root));
+  }
+
+  /** `options.by`, who sets or clears a credential, admitted (`admitted`): their id. */
+  private async admittedBy(options: { by: string }): Promise<string> {
+    const by = parseOrThrow(z.string().min(1), options?.by, '`by` must name who is asking, such as "alice"');
+    return (await this.admitted({ id: by })).id;
+  }
+
   /** Refuses a run id whose run, as stored, was started with another input, by someone else, or in another sandbox. */
   private async mustMatch(runId: string, args: RunArgs) {
     const [stored] = ((await this.dbos.getWorkflow(runId))?.input ?? []) as [RunArgs?];
+    // Who started it by id alone: their groups are the people files' at the time, which may change.
     const differs = (["input", "startedBy", "sandbox"] as const).filter(
-      (key) => !stored || !sameJson(stored[key], args[key]),
+      (key) =>
+        !stored ||
+        (key === "startedBy" ? stored.startedBy?.id !== args.startedBy.id : !sameJson(stored[key], args[key])),
     );
     if (differs.length) {
       throw new SanomaError(
@@ -521,9 +829,15 @@ export class SanomaClient {
     }
   }
 
-  /** The run's status row, read without its input (and its output, unless asked), or `run_not_found`. */
-  private async mustExist(runId: string, { loadOutput = false } = {}) {
+  /** The run's status row, read without its input (and its output, unless asked), if there is one. */
+  private async row(runId: string, { loadOutput = false } = {}) {
     const [row] = await this.dbos.listWorkflows({ workflowIDs: [runId], loadInput: false, loadOutput });
+    return row;
+  }
+
+  /** The run's status row, as `row` reads it, or `run_not_found`. */
+  private async mustExist(runId: string, options: { loadOutput?: boolean } = {}) {
+    const row = await this.row(runId, options);
     if (!row) throw new SanomaError("run_not_found", `No run ${runId}`, { runId });
     return row;
   }
@@ -559,11 +873,18 @@ export class SanomaClient {
   }): Promise<RunSummary> {
     const approvals = await this.approvals(r.workflowID);
     const groups = r.authenticatedRoles ?? [];
+    const onBehalfOf = r.attributes?.onBehalfOf;
     return {
       runId: r.workflowID,
       workflow: r.workflowName,
       status: runStatus(r.status, approvals),
-      startedBy: r.authenticatedUser ? { id: r.authenticatedUser, ...(groups.length ? { groups } : {}) } : undefined,
+      startedBy: r.authenticatedUser
+        ? {
+            id: r.authenticatedUser,
+            ...(groups.length ? { groups } : {}),
+            ...(typeof onBehalfOf === "string" && { onBehalfOf }),
+          }
+        : undefined,
       createdAt: r.createdAt,
       updatedAt: r.updatedAt,
       approvals,
@@ -573,6 +894,20 @@ export class SanomaClient {
   }
 }
 
+/**
+ * What a direct call's driver returned, as the operation's output schema parses it; a failure
+ * with none of the runtime's codes (a reply the schema refuses, an error the driver let escape)
+ * is `driver_failed`, naming the operation.
+ */
+async function outputOf(op: Op, call: () => Promise<unknown>): Promise<unknown> {
+  try {
+    return op.output.parse(await call());
+  } catch (err) {
+    if (errorCode(err) !== undefined) throw err;
+    throw new SanomaError("driver_failed", `${op.id} failed: ${errorMessage(err)}`, { op: op.id }, { cause: err });
+  }
+}
+
 /** The value as JSON reads it back: a Date as its string, undefined members gone. */
 const asJson = (v: unknown): unknown => (v === undefined ? undefined : JSON.parse(JSON.stringify(v)));
 
@@ -591,10 +926,6 @@ export interface StoredSecret {
 /** What an environment variable's name looks like. */
 const VARIABLE = /^[A-Z_][A-Z0-9_]*$/;
 
-/** `options.by`, who sets or clears a credential: a name, or `invalid_input`. */
-const actorOf = (options: { by: string }): string =>
-  parseOrThrow(z.string().min(1), options?.by, '`by` must name who is asking, such as "alice"');
-
 const alreadyDecided = (runId: string, a: ApprovalState) =>
   new SanomaError("already_decided", `${a.id} on run ${runId} was already ${a.status} by ${a.decidedBy}`, {
     runId,