@sanity/pkg-utils 5.1.1 → 5.1.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sanity/pkg-utils",
-  "version": "5.1.1",
+  "version": "5.1.2",
   "description": "Simple utilities for modern npm packages.",
   "keywords": [
     "sanity-io",
@@ -132,7 +132,7 @@
     "typescript": "5.4.2",
     "vitest": "^1.4.0",
     "vitest-github-actions-reporter": "^0.11.1",
-    "@sanity/pkg-utils": "5.1.1"
+    "@sanity/pkg-utils": "5.1.2"
   },
   "peerDependencies": {
     "typescript": "5.4.2"

package/src/node/build.ts

@@ -33,7 +33,8 @@ export async function build(options: {
   const {cwd, emitDeclarationOnly, strict = false, tsconfig: tsconfigOption} = options
   const logger = createLogger()
 
-  const pkg = await loadPkgWithReporting({cwd, logger})
+  const pkg = await loadPkgWithReporting({cwd, logger, strict})
+
   const config = await loadConfig({cwd})
   const extMap = getPkgExtMap({legacyExports: config?.legacyExports ?? false})
   const tsconfig = tsconfigOption || config?.tsconfig || 'tsconfig.json'

package/src/node/check.ts

@@ -1,10 +1,10 @@
-import esbuild, {BuildFailure} from 'esbuild'
+import esbuild, {type BuildFailure} from 'esbuild'
 import path from 'path'
 
 import {createConsoleSpy} from './consoleSpy'
 import {getPkgExtMap, loadConfig, loadPkgWithReporting} from './core'
 import {fileExists} from './fileExists'
-import {createLogger, Logger} from './logger'
+import {createLogger, type Logger} from './logger'
 import {printPackageTree} from './printPackageTree'
 import {resolveBuildContext} from './resolveBuildContext'
 
@@ -17,7 +17,7 @@ export async function check(options: {
   const {cwd, strict = false, tsconfig: tsconfigOption} = options
   const logger = createLogger()
 
-  const pkg = await loadPkgWithReporting({cwd, logger})
+  const pkg = await loadPkgWithReporting({cwd, logger, strict})
   const config = await loadConfig({cwd})
   const extMap = getPkgExtMap({legacyExports: config?.legacyExports ?? false})
   const tsconfig = tsconfigOption || config?.tsconfig || 'tsconfig.json'

package/src/node/core/pkg/loadPkgWithReporting.ts

@@ -10,13 +10,21 @@ import type {PackageJSON} from './types'
 export async function loadPkgWithReporting(options: {
   cwd: string
   logger: Logger
+  strict: boolean
 }): Promise<PackageJSON> {
-  const {cwd, logger} = options
+  const {cwd, logger, strict} = options
 
   try {
     const pkg = await loadPkg({cwd})
     let shouldError = false
 
+    if (strict && !pkg.type) {
+      shouldError = true
+      logger.error(
+        `the \`type\` field in \`./package.json\` must be either "module" or "commonjs")`,
+      )
+    }
+
     // validate exports
     if (pkg.exports) {
       const _exports = Object.entries(pkg.exports)

package/src/node/core/pkg/parseExports.ts

@@ -30,7 +30,7 @@ export function parseExports(options: {
 
   const errors: string[] = []
 
-  if (strict && !pkg.types && pkg.source?.endsWith('.ts')) {
+  if (strict && !pkg.types && pkg.source?.endsWith('.ts') && pkg.exports) {
     errors.push(
       'package.json: `types` must be declared for the npm listing to show as a TypeScript module.',
     )

package/src/node/watch.ts

@@ -30,7 +30,7 @@ export async function watch(options: {
         throw new Error('missing package.json')
       }
 
-      const pkg = await loadPkgWithReporting({cwd, logger})
+      const pkg = await loadPkgWithReporting({cwd, logger, strict})
       const config = await loadConfig({cwd})
       const extMap = getPkgExtMap({legacyExports: config?.legacyExports ?? false})
       const tsconfig = tsconfigOption || config?.tsconfig || 'tsconfig.json'