@sanity/pkg-utils 3.2.0 → 3.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sanity/pkg-utils",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "Simple utilities for modern npm packages.",
   "keywords": [
     "sanity-io",
@@ -46,24 +46,6 @@
     "!dist/stats.html",
     "src"
   ],
-  "scripts": {
-    "build": "run-s clean build:pkg check:pkg",
-    "build:pkg": "node --loader esbuild-register/loader -r esbuild-register scripts/build",
-    "check:pkg": "node --loader esbuild-register/loader -r esbuild-register scripts/check",
-    "check:types": "tsc --build",
-    "clean": "rimraf dist",
-    "commit": "cz",
-    "extract": "sanity-tsdoc etl --outDir etc/api/@sanity/pkg-utils --tsconfig tsconfig.dist.json",
-    "format": "prettier --write --cache --ignore-unknown . && eslint . --ext .cjs,.js,.ts,.tsx --fix --quiet",
-    "lint": "eslint . --ext .cjs,.js,.ts,.tsx",
-    "playground:build": "pnpm --filter './playground/**' build",
-    "playground:clean": "pnpm --filter './playground/**' --silent clean",
-    "prepublishOnly": "pnpm run build",
-    "test": "run-s playground:clean test:clean vitest:run",
-    "test:clean": "rimraf test/env/__tmp__",
-    "vitest:run": "vitest run",
-    "watch": "node --loader esbuild-register/loader -r esbuild-register scripts/watch"
-  },
   "commitlint": {
     "extends": [
       "@commitlint/config-conventional"
@@ -75,35 +57,6 @@
       "eslint --ext .cjs,.js,.ts,.tsx --fix"
     ]
   },
-  "prettier": {
-    "bracketSpacing": false,
-    "plugins": [
-      "prettier-plugin-packagejson"
-    ],
-    "printWidth": 100,
-    "semi": false,
-    "singleQuote": true,
-    "tabWidth": 2,
-    "overrides": [
-      {
-        "files": [
-          "*.json5"
-        ],
-        "options": {
-          "quoteProps": "preserve",
-          "singleQuote": false
-        }
-      },
-      {
-        "files": [
-          "*.yml"
-        ],
-        "options": {
-          "singleQuote": false
-        }
-      }
-    ]
-  },
   "dependencies": {
     "@babel/core": "^7.23.2",
     "@babel/preset-env": "^7.23.2",
@@ -147,7 +100,6 @@
   "devDependencies": {
     "@commitlint/cli": "^18.0.0",
     "@commitlint/config-conventional": "^18.0.0",
-    "@sanity/pkg-utils": "workspace:*",
     "@types/babel__core": "^7.20.3",
     "@types/cpx": "^1.5.4",
     "@types/find-config": "^1.0.3",
@@ -177,7 +129,8 @@
     "ts-node": "^10.9.1",
     "typescript": "^5.2.2",
     "vitest": "^0.34.6",
-    "vitest-github-actions-reporter": "^0.10.0"
+    "vitest-github-actions-reporter": "^0.10.0",
+    "@sanity/pkg-utils": "3.2.1"
   },
   "peerDependencies": {
     "typescript": "^4.7 || ^5"
@@ -189,9 +142,21 @@
   "publishConfig": {
     "access": "public"
   },
-  "pnpm": {
-    "overrides": {
-      "@sanity/pkg-utils": "workspace:*"
-    }
+  "scripts": {
+    "build": "run-s clean build:pkg check:pkg",
+    "build:pkg": "node -r esbuild-register scripts/build",
+    "check:pkg": "node -r esbuild-register scripts/check",
+    "check:types": "tsc --build",
+    "clean": "rimraf dist test/env/__tmp__",
+    "commit": "cz",
+    "extract": "sanity-tsdoc etl --outDir etc/api/@sanity/pkg-utils --tsconfig tsconfig.dist.json",
+    "format": "prettier --write --cache --ignore-unknown . && eslint . --ext .cjs,.js,.ts,.tsx --fix --quiet",
+    "lint": "eslint . --ext .cjs,.js,.ts,.tsx",
+    "playground:build": "pnpm --filter './playground/**' build",
+    "playground:clean": "pnpm --filter './playground/**' --silent clean",
+    "test": "run-s playground:clean test:clean vitest:run",
+    "test:clean": "rimraf test/env/__tmp__",
+    "vitest:run": "vitest run",
+    "watch": "node -r esbuild-register scripts/watch"
   }
-}
+}

package/src/node/core/pkg/types.ts

@@ -8,9 +8,9 @@ export interface PackageJSON {
   description?: string
   keywords?: string[]
   bin?: Record<string, string>
-  dependencies?: Record<string, string>
-  devDependencies?: Record<string, string>
-  peerDependencies?: Record<string, string>
+  dependencies?: Record<string, string | undefined>
+  devDependencies?: Record<string, string | undefined>
+  peerDependencies?: Record<string, string | undefined>
   exports?: Record<
     string,
     | `./${string}.json`
@@ -40,7 +40,7 @@ export interface PackageJSON {
   module?: string
   types?: string
   files?: string[]
-  scripts?: Record<string, string>
+  scripts?: Record<string, string | undefined>
   browserslist?: string[]
   engines?: {
     node?: string

package/src/node/core/ts/loadTSConfig.ts

@@ -4,13 +4,13 @@ import ts from 'typescript'
 export async function loadTSConfig(options: {
   cwd: string
   tsconfigPath: string
-}): Promise<ts.ParsedCommandLine> {
+}): Promise<ts.ParsedCommandLine | undefined> {
   const {cwd, tsconfigPath} = options
 
   const configPath = ts.findConfigFile(cwd, ts.sys.fileExists, tsconfigPath)
 
   if (!configPath) {
-    throw new Error(`could not find a valid '${tsconfigPath}'`)
+    return undefined
   }
 
   const configFile = ts.readConfigFile(configPath, ts.sys.readFile)

package/src/node/resolveBuildContext.ts

@@ -53,8 +53,8 @@ export async function resolveBuildContext(options: {
 
   const target: Record<PkgRuntime, string[]> = {
     '*': webTarget.concat(nodeTarget),
-    browser: webTarget,
-    node: nodeTarget,
+    'browser': webTarget,
+    'node': nodeTarget,
   }
 
   const parsedExports = parseExports({extMap, pkg, strict}).reduce<PkgExports>((acc, x) => {

package/src/node/tasks/dts/getExtractMessagesConfig.ts

@@ -32,7 +32,7 @@ export function getExtractMessagesConfig(options: {
     },
 
     extractorMessageReporting: {
-      default: {
+      'default': {
         logLevel: 'warning' as ExtractorLogLevel,
         addToApiReportFile: false,
       },
@@ -64,7 +64,7 @@ export function getExtractMessagesConfig(options: {
     },
 
     tsdocMessageReporting: {
-      default: {
+      'default': {
         logLevel: 'warning' as ExtractorLogLevel,
         addToApiReportFile: false,
       },

package/src/node/templates/default/template.ts

@@ -105,6 +105,11 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
         optional: true,
         initial: true,
       },
+      {
+        name: 'prettier',
+        optional: true,
+        initial: true,
+      },
       {
         name: 'typescript',
         optional: true,
@@ -121,69 +126,86 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
           .filter(Boolean)
           .join(' ') ?? undefined
 
-      const prettierConfig: PrettierConfig = {
-        bracketSpacing: false,
-        printWidth: 100,
-        semi: false,
-        singleQuote: true,
-        tabWidth: 2,
-        plugins: ['prettier-plugin-packagejson'],
-        overrides: [
-          {
-            files: ['*.yml'],
-            options: {
-              singleQuote: false,
-            },
-          },
-        ],
-      }
+      const prettierConfig: PrettierConfig | undefined = features.prettier
+        ? {
+            bracketSpacing: false,
+            plugins: ['prettier-plugin-packagejson'],
+            printWidth: 100,
+            quoteProps: 'consistent',
+            semi: false,
+            singleQuote: true,
+            tabWidth: 2,
+            overrides: [
+              {
+                files: ['*.yml'],
+                options: {
+                  singleQuote: false,
+                },
+              },
+            ],
+          }
+        : undefined
 
       const pkgJson: PackageJSON & {
         prettier?: PrettierConfig
         ['lint-staged']?: Record<string, string[]>
       } = {
         name,
-        version: '0.0.0',
-        description: options.description ?? undefined,
-        keywords: [],
-        license: options.license,
+        'version': '0.0.0',
+        'description': options.description ?? undefined,
+        'keywords': [],
+        'homepage': undefined,
+        'bugs': undefined,
+        'repository': undefined,
+        'license': options.license,
         author,
-        type: 'module',
-        exports: {
+        'type': 'module',
+        'exports': {
           '.': {
             types: undefined,
             source: features.typescript ? './src/index.ts' : './src/index.js',
-            require: './dist/index.cjs',
             import: './dist/index.js',
+            require: './dist/index.cjs',
             default: './dist/index.js',
           },
           './package.json': './package.json',
         },
-        main: './dist/index.cjs',
-        module: './dist/index.js',
-        source: features.typescript ? './src/index.ts' : './src/index.js',
-        files: ['dist', 'src'],
-        scripts: {
-          build: 'run-s clean pkg:build pkg:check',
-          clean: 'rimraf dist',
-          format: 'prettier --write --cache --ignore-unknown .',
+        'main': './dist/index.cjs',
+        'module': './dist/index.js',
+        'source': features.typescript ? './src/index.ts' : './src/index.js',
+        'types': undefined,
+        'files': ['dist', 'src'],
+        'scripts': {
+          'build': 'run-s clean pkg:build pkg:check',
+          'clean': 'rimraf dist',
+          'format': features.prettier ? 'prettier --write --cache --ignore-unknown .' : undefined,
           'pkg:build': 'pkg build --strict',
           'pkg:check': 'pkg check --strict',
         },
-        prettier: prettierConfig,
-        'lint-staged': {
-          '*': ['prettier --write --cache --ignore-unknown'],
-        },
-        dependencies: {},
-        devDependencies: {
+        'lint-staged': features.prettier
+          ? {
+              '*': ['prettier --write --cache --ignore-unknown'],
+            }
+          : undefined,
+        // prettier: prettierConfig,
+        'dependencies': {},
+        'devDependencies': {
           '@sanity/pkg-utils': '*',
+          '@typescript-eslint/eslint-plugin': undefined,
+          '@typescript-eslint/parser': undefined,
+          'eslint': undefined,
+          'eslint-config-prettier': undefined,
+          'eslint-plugin-import': undefined,
+          'eslint-plugin-prettier': undefined,
+          'eslint-plugin-simple-import-sort': undefined,
           'lint-staged': '*',
           'npm-run-all': '*',
-          prettier: '*',
-          'prettier-plugin-packagejson': '*',
-          rimraf: '*',
+          'prettier': features.prettier ? '*' : undefined,
+          'prettier-plugin-packagejson': features.prettier ? '*' : undefined,
+          'rimraf': '*',
+          'typescript': undefined,
         },
-        engines: {
+        'engines': {
           node: '>=18.0.0',
         },
       }
@@ -212,21 +234,33 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
         contents: outdent`
         *.local
         *.log
+        *.tgz
 
         .DS_Store
-        etc
         dist
+        etc
         node_modules
         `,
       })
 
-      files.push({
-        name: '.prettierignore',
-        contents: outdent`
-        /dist
-        /pnpm-lock.yaml
-        `,
-      })
+      if (features.prettier) {
+        files.push({
+          name: '.prettierignore',
+          contents: outdent`
+          dist
+          pnpm-lock.yaml
+          `,
+        })
+
+        files.push({
+          name: '.prettierrc',
+          contents: await format(
+            resolve(packagePath, '.prettierrc.json'),
+            JSON.stringify(prettierConfig, null, 2) + '\n',
+            prettierConfig,
+          ),
+        })
+      }
 
       if (repo) {
         pkgJson.repository = {
@@ -250,7 +284,7 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
 
         pkgJson.scripts = {
           ...pkgJson.scripts,
-          ['type:check']: 'tsc --build',
+          ['ts:check']: 'tsc --build',
         }
 
         const devDependencies = pkgJson.devDependencies
@@ -269,23 +303,32 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             es6: true,
             node: true,
           },
-          extends: ['eslint:recommended', 'plugin:prettier/recommended'],
+          extends: [
+            'eslint:recommended',
+            features.prettier ? 'plugin:prettier/recommended' : undefined,
+          ].filter(Boolean),
           parserOptions: {
             ecmaVersion: 2020,
             sourceType: 'module',
           },
-          plugins: ['import', 'prettier'],
+          plugins: [
+            'import',
+            'simple-import-sort',
+            features.prettier ? 'prettier' : undefined,
+          ].filter(Boolean),
           rules: {
             'no-console': 'error',
             'no-shadow': 'error',
             'no-warning-comments': ['warn', {location: 'start', terms: ['todo', 'fixme']}],
+            'quote-props': ['warn', 'consistent-as-needed'],
+            'strict': ['warn', 'global'],
           },
         }
 
         files.push({
           name: '.eslintignore',
           contents: outdent`
-          /dist
+          dist
           `,
         })
 
@@ -298,10 +341,11 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
 
         pkgJson.devDependencies = {
           ...pkgJson.devDependencies,
-          eslint: '*',
-          'eslint-config-prettier': '*',
+          'eslint': '*',
+          'eslint-config-prettier': features.prettier ? '*' : undefined,
+          'eslint-plugin-simple-import-sort': '*',
           'eslint-plugin-import': '*',
-          'eslint-plugin-prettier': '*',
+          'eslint-plugin-prettier': features.prettier ? '*' : undefined,
         }
 
         if (features.typescript) {
@@ -320,11 +364,16 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             },
             extends: [
               'eslint:recommended',
-              'plugin:prettier/recommended',
+              features.prettier ? 'plugin:prettier/recommended' : undefined,
               'plugin:@typescript-eslint/eslint-recommended',
               'plugin:@typescript-eslint/recommended',
             ].filter(Boolean),
-            plugins: ['import', '@typescript-eslint', 'prettier'].filter(Boolean),
+            plugins: [
+              'import',
+              '@typescript-eslint',
+              'simple-import-sort',
+              features.prettier ? 'prettier' : undefined,
+            ].filter(Boolean),
             rules: {
               '@typescript-eslint/explicit-module-boundary-types': 'error',
               '@typescript-eslint/interface-name-prefix': 'off',
@@ -359,32 +408,32 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             outdent`
             {
               "compilerOptions": {
-                "module": "ES2020",
+                // Completeness
+                "skipLibCheck": true,
+
+                // Interop constraints
+                "allowSyntheticDefaultImports": true,
+                "esModuleInterop": true,
+
+                // Language and environment
                 "target": "ES2020",
-                "declaration": true,
-                "declarationMap": true,
-                "sourceMap": true,
 
-                // Strict type-checking
-                "strict": true,
+                // Modules
+                "module": "ES2020",
+                "moduleResolution": "Node",
+
+                // Type checking
+                "alwaysStrict": true,
+                "noFallthroughCasesInSwitch": true,
                 "noImplicitAny": true,
-                "strictNullChecks": true,
-                "strictFunctionTypes": true,
-                "strictPropertyInitialization": true,
+                "noImplicitReturns": true,
                 "noImplicitThis": true,
-                "alwaysStrict": true,
-
-                // Additional checks
                 "noUnusedLocals": true,
                 "noUnusedParameters": true,
-                "noImplicitReturns": true,
-                "noFallthroughCasesInSwitch": true,
-                "skipLibCheck": true,
-
-                // Module resolution
-                "moduleResolution": "node",
-                "allowSyntheticDefaultImports": true,
-                "esModuleInterop": true
+                "strict": true,
+                "strictFunctionTypes": true,
+                "strictNullChecks": true,
+                "strictPropertyInitialization": true
               }
             }
             `,
@@ -400,10 +449,10 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             {
               "extends": "./tsconfig.settings",
               "include": ["./src"],
+              "exclude": ["./src/**/*.test.ts"],
               "compilerOptions": {
                 "rootDir": ".",
                 "outDir": "./dist",
-                "emitDeclarationOnly": true,
                 "resolveJsonModule": true
               }
             }
@@ -419,7 +468,8 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             outdent`
             {
               "extends": "./tsconfig.settings",
-              "include": ["./*.cjs", "./*.ts", "./package.config.ts", "./src"],
+              "include": ["./**/*.cjs", "./**/*.ts", "./**/*.tsx"],
+              "exclude": ["./node_modules"],
               "compilerOptions": {
                 "rootDir": ".",
                 "outDir": "./dist",
@@ -443,14 +493,8 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             outdent`
             import {defineConfig} from '@sanity/pkg-utils'
 
+            // https://github.com/sanity-io/pkg-utils#configuration
             export default defineConfig({
-              extract: {
-                rules: {
-                  // do not require internal members to be prefixed with \`_\`
-                  'ae-internal-missing-underscore': 'off',
-                },
-              },
-
               // the path to the tsconfig file for distributed builds
               tsconfig: 'tsconfig.dist.json',
             })
@@ -536,19 +580,22 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
   }
 }
 
-function format(filepath: string, input: string, prettierOptions: PrettierConfig) {
-  return prettier.format(input, {...prettierOptions, filepath})
+function format(filepath: string, input: string, prettierOptions: PrettierConfig | undefined) {
+  return prettier.format(input, {...prettierOptions, plugins: [], filepath})
 }
 
-async function resolveLatestDeps(deps: Record<string, string>) {
+async function resolveLatestDeps(deps: Record<string, string | undefined>) {
   const depsEntries = Object.entries(deps)
   const latestDeps: Record<string, string> = {}
 
   for (const entry of depsEntries) {
     const [name, version] = entry
-    const latestVersion = await getLatestVersion(name, version)
 
-    latestDeps[name] = latestVersion ? `^${latestVersion}` : version
+    if (version) {
+      const latestVersion = await getLatestVersion(name, version)
+
+      latestDeps[name] = latestVersion ? `^${latestVersion}` : version
+    }
   }
 
   return latestDeps