npm - @sandprivacy/sandgate - Versions diffs - 0.1.6 → 0.1.8 - Mend

@sandprivacy/sandgate 0.1.6 → 0.1.8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/dist/relay/pwa-page.js +3 -1
package/dist/relay/server.js +9 -2
package/dist/test/pwa-browser.test.js +142 -0
package/package.json +3 -1

package/dist/relay/pwa-page.js CHANGED Viewed

@@ -589,7 +589,9 @@ export const PWA_HTML = `<!doctype html>
     who.textContent = (pairs.length > 1 ? p.name + " · " : "") + "agent · approval request";
     card.appendChild(who);
     var h = document.createElement("h2"); h.textContent = req.title; card.appendChild(h);
-    if (req.body) { var p = document.createElement("p"); p.textContent = req.body; card.appendChild(p); }
+    // NOTE: never name this variable p — var is function-scoped and would
+    // shadow the pairing parameter for the rest of addCard (real bug once).
+    if (req.body) { var bodyP = document.createElement("p"); bodyP.textContent = req.body; card.appendChild(bodyP); }
     var timer = document.createElement("div"); timer.className = "timer";
     var left = document.createElement("div"); left.className = "left";

package/dist/relay/server.js CHANGED Viewed

@@ -19,7 +19,10 @@ export async function startRelay(opts) {
         writeFileSync(statePath, JSON.stringify(state), { mode: 0o600 });
     }
     const persist = () => writeFileSync(statePath, JSON.stringify(state), { mode: 0o600 });
-    webpush.setVapidDetails("mailto:relay@sandgate.local", state.vapid.publicKey, state.vapid.privateKey);
+    // Apple's push service rejects invalid VAPID subjects (a .local mailto
+    // qualifies); use a real https URL and log delivery failures instead of
+    // swallowing them.
+    webpush.setVapidDetails("https://sandgate.dev", state.vapid.publicKey, state.vapid.privateKey);
     const pairings = new Map();
     const getPairing = (pairId) => {
         let p = pairings.get(pairId);
@@ -169,7 +172,11 @@ export async function startRelay(opts) {
                 if (pairing.subscription) {
                     webpush
                         .sendNotification(pairing.subscription, JSON.stringify({ type: "approval" }))
-                        .catch(() => { }); // phone offline / stale sub — PWA polls anyway
+                        .catch((err) => {
+                        // Phone offline / stale sub is normal (PWA polls anyway), but
+                        // ops must be able to SEE a push service rejecting us.
+                        console.error(`[push] delivery failed (HTTP ${err?.statusCode ?? "?"}): ${String(err?.body ?? err).slice(0, 200)}`);
+                    });
                 }
                 notifyListeners(pairing, "request");
                 return json(res, 200, { ok: true });

package/dist/test/pwa-browser.test.js ADDED Viewed

@@ -0,0 +1,142 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { webcrypto } from "node:crypto";
+import { JSDOM } from "jsdom";
+import { newPairing } from "../pwacrypto.js";
+import { startRelay } from "../relay/server.js";
+import { PWA_HTML } from "../relay/pwa-page.js";
+import { PwaApprover } from "../pwa-approver.js";
+/**
+ * Browser-level tests: the REAL page script, executed in a DOM, against a
+ * REAL relay — pairing via URL fragment, card rendering, a click on
+ * Approve/Deny, and the legacy-storage migration. This is the layer that
+ * caught nothing while it didn't exist; it exists now.
+ */
+async function loadPage(relayUrl, opts) {
+    const alerts = [];
+    const dom = new JSDOM(PWA_HTML, {
+        url: relayUrl + "/" + (opts.hash ?? ""),
+        runScripts: "outside-only",
+        pretendToBeVisual: true,
+    });
+    const w = dom.window;
+    // The pieces jsdom doesn't ship, wired to the real relay / real crypto.
+    w.fetch = (input, init) => fetch(new URL(input, relayUrl), init);
+    Object.defineProperty(w, "crypto", { value: webcrypto });
+    w.alert = (message) => alerts.push(String(message));
+    w.confirm = () => true;
+    if (opts.localStorage) {
+        for (const [key, value] of Object.entries(opts.localStorage)) {
+            w.localStorage.setItem(key, value);
+        }
+    }
+    // Execute the page's inline script exactly as a browser would. The
+    // decision alert is instrumented to carry the full stack: a one-line
+    // message told us nothing the day this layer was missing.
+    let script = dom.window.document.querySelector("script").textContent;
+    script = script.replace('alert("Could not send your decision: " + (err && err.message ? err.message : err));', 'alert("Could not send your decision: " + (err && err.stack ? err.stack : err));');
+    dom.window.eval(script);
+    // window.close() tears down the page's setIntervals so the test process
+    // can exit; without it the suite hangs forever.
+    return { window: w, alerts, close: () => dom.window.close() };
+}
+// Without EventSource in jsdom the page falls back to its 8s poll, so give
+// waits comfortable room past that boundary.
+function waitFor(fn, ms = 15000) {
+    return new Promise((resolve, reject) => {
+        const started = Date.now();
+        const timer = setInterval(() => {
+            const value = fn();
+            if (value) {
+                clearInterval(timer);
+                resolve(value);
+            }
+            else if (Date.now() - started > ms) {
+                clearInterval(timer);
+                reject(new Error("waitFor timed out"));
+            }
+        }, 50);
+    });
+}
+for (const scenario of ["fragment", "legacy-storage"]) {
+    test(`page pairs (${scenario}), renders the card, and Approve round-trips`, async () => {
+        const relay = await startRelay({
+            port: 0,
+            stateDir: mkdtempSync(join(tmpdir(), "sandgate-relay-")),
+        });
+        const relayUrl = `http://localhost:${relay.port}`;
+        try {
+            const pairing = newPairing();
+            const { window, alerts, close } = await loadPage(relayUrl, {
+                hash: scenario === "fragment" ? `#p=${pairing.pairId}&s=${pairing.secret}` : undefined,
+                localStorage: scenario === "legacy-storage"
+                    ? { sandgate_pair: JSON.stringify({ pairId: pairing.pairId, secret: pairing.secret }) }
+                    : undefined,
+            });
+            try {
+                const approver = new PwaApprover({
+                    relayUrl,
+                    pairId: pairing.pairId,
+                    secret: pairing.secret,
+                });
+                const decision = approver.request({
+                    title: "Browser-level test",
+                    body: "Click approve",
+                    timeoutSec: 15,
+                });
+                const okButton = await waitFor(() => window.document.querySelector(".card button.ok"));
+                assert.match(window.document.querySelector(".card h2").textContent, /Browser-level test/);
+                okButton.click();
+                const result = await decision;
+                assert.deepEqual(alerts, [], `page alerted: ${alerts.join(" | ")}`);
+                assert.deepEqual(result, { approved: true, decision: "approved" });
+                await waitFor(() => window.document.querySelector(".hrow .d.approved"));
+            }
+            finally {
+                close();
+            }
+        }
+        finally {
+            relay.close();
+        }
+    });
+}
+test("Deny works and corrupt stored pairings do not break the page", async () => {
+    const relay = await startRelay({
+        port: 0,
+        stateDir: mkdtempSync(join(tmpdir(), "sandgate-relay-")),
+    });
+    const relayUrl = `http://localhost:${relay.port}`;
+    try {
+        const pairing = newPairing();
+        const { window, alerts, close } = await loadPage(relayUrl, {
+            hash: `#p=${pairing.pairId}&s=${pairing.secret}`,
+            // A broken entry left over from older versions must be ignored, not fatal.
+            localStorage: {
+                sandgate_pairs: JSON.stringify([{ name: "Broken", pairId: "brokenbroken" }]),
+            },
+        });
+        try {
+            const approver = new PwaApprover({
+                relayUrl,
+                pairId: pairing.pairId,
+                secret: pairing.secret,
+            });
+            const decision = approver.request({ title: "Deny me", timeoutSec: 15 });
+            const noButton = await waitFor(() => window.document.querySelector(".card button.no"));
+            noButton.click();
+            const result = await decision;
+            assert.deepEqual(result, { approved: false, decision: "denied" });
+            assert.deepEqual(alerts, [], `page alerted: ${alerts.join(" | ")}`);
+        }
+        finally {
+            close();
+        }
+    }
+    finally {
+        relay.close();
+    }
+});

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@sandprivacy/sandgate",
-  "version": "0.1.6",
+  "version": "0.1.8",
   "description": "The human gateway for AI agents — approvals, 2FA codes and email verification, self-hosted. Your agent asks; you decide; secrets never touch the LLM.",
   "license": "AGPL-3.0-only",
   "type": "module",
@@ -51,10 +51,12 @@
     "zod": "^4.5.4"
   },
   "devDependencies": {
+    "@types/jsdom": "^30.0.0",
     "@types/mailparser": "^3.4.6",
     "@types/node": "^26.4.1",
     "@types/qrcode-terminal": "^0.12.2",
     "@types/web-push": "^3.6.4",
+    "jsdom": "^29.1.1",
     "tsx": "^4.23.13",
     "typescript": "^7.0.2"
   }