@samuelbradshaw/highlight-helper-js 0.7.1 → 0.7.3

package/highlight-helper.js

@@ -263,6 +263,7 @@ function Highlighter(options = hhDefaultOptions) {
       } else {
         // Draw highlights with Custom Highlight API
         if (options.drawingMode === 'highlight-api' && supportsHighlightApi) {
+          let highlightObj;
           if (CSS.highlights.has(highlightId)) {
             highlightObj = CSS.highlights.get(highlightId);
             highlightObj.clear();
@@ -701,7 +702,7 @@ function Highlighter(options = hhDefaultOptions) {
   
   // Long press in annotatable container (triggered by setTimeout() in pointerdown event)
   const respondToLongPress = (event) => {
-    respondToPointerUp(event, isLongPress = true);
+    respondToPointerUp(event, true);
     tapResult = null;
   }
   
@@ -1270,7 +1271,6 @@ function Highlighter(options = hhDefaultOptions) {
     for (const paragraph of paragraphs) {
       const paragraphRect = paragraph.getBoundingClientRect();
       const computedParagraphStyle = window.getComputedStyle(paragraph);
-      const paragraphLineHeight = parseInt((computedParagraphStyle.lineHeight === 'normal' ? computedParagraphStyle.fontSize : computedParagraphStyle.lineHeight).replace('px', ''));
       const paragraphTopPadding = parseInt(computedParagraphStyle.getPropertyValue('padding-top').replace('px', ''));
       
       // Get line positions (bottom edge of each line)
@@ -1278,13 +1278,11 @@ function Highlighter(options = hhDefaultOptions) {
       let lineWalker = document.createTreeWalker(paragraph, NodeFilter.SHOW_TEXT);
       let textNode;
       while (textNode = lineWalker.nextNode()) {
-        const computedStyle = window.getComputedStyle(textNode.parentElement);
-        const lineHeight = parseInt((computedStyle.lineHeight === 'normal' ? computedStyle.fontSize : computedStyle.lineHeight).replace('px', ''));
-        if (lineHeight >= paragraphLineHeight) {
-          const referenceRange = document.createRange();
-          referenceRange.selectNode(textNode);
-          for (const rangeRect of referenceRange.getClientRects()) linePositions.add(rangeRect.bottom);
-        }
+        // Skip text nodes in elements that are higher or lower than surrounding text
+        if (textNode.parentElement.closest('sup, sub, rt')) continue;
+        const referenceRange = document.createRange();
+        referenceRange.selectNode(textNode);
+        for (const rangeRect of referenceRange.getClientRects()) linePositions.add(rangeRect.bottom);
       }
       linePositions = Array.from(linePositions);
       

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@samuelbradshaw/highlight-helper-js",
-  "version": "0.7.1",
+  "version": "0.7.3",
   "description": "JavaScript tool that enables highlighting or underlining text in an HTML page.",
   "type": "module",
   "main": "highlight-helper.mjs",