@samsara-dev/appwright 0.9.9 → 0.9.10

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # appwright
 
+## 0.9.10
+
+### Patch Changes
+
+- 851d551: Fix reporter error when persistent device worker has no session
+
+  Previously, the VideoDownloader reporter threw an error when a worker's info
+  file existed but had no `providerName` or `sessionId` (e.g., when a test was
+  skipped before establishing a BrowserStack session). This caused misleading
+  "Failed to get worker end time" error logs.
+
+  Now gracefully skips video download for workers without sessions instead of
+  throwing.
+
 ## 0.9.9
 
 ### Patch Changes

package/dist/reporter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"reporter.d.ts","sourceRoot":"","sources":["../src/reporter.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,QAAQ,EAAE,UAAU,EAAE,MAAM,2BAA2B,CAAC;AAUhF,cAAM,eAAgB,YAAW,QAAQ;IACvC,OAAO,CAAC,gBAAgB,CAAsB;IAE9C,OAAO;IAQP,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAU9C,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAsGtC,KAAK;YAKG,kCAAkC;IA6ChD,OAAO,CAAC,4BAA4B;IAyBpC,OAAO,CAAC,qBAAqB;CAU9B;AAwHD,eAAe,eAAe,CAAC"}
+{"version":3,"file":"reporter.d.ts","sourceRoot":"","sources":["../src/reporter.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,QAAQ,EAAE,UAAU,EAAE,MAAM,2BAA2B,CAAC;AAUhF,cAAM,eAAgB,YAAW,QAAQ;IACvC,OAAO,CAAC,gBAAgB,CAAsB;IAE9C,OAAO;IAQP,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAU9C,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU;IAuGtC,KAAK;YAKG,kCAAkC;IA6ChD,OAAO,CAAC,4BAA4B;IAyBpC,OAAO,CAAC,qBAAqB;CAU9B;AAwHD,eAAe,eAAe,CAAC"}

package/dist/reporter.js

@@ -70,7 +70,8 @@ class VideoDownloader {
                     }
                     const { providerName, sessionId, endTime } = workerInfo;
                     if (!providerName || !sessionId) {
-                        throw new Error(`Provider name or session id not found for worker: ${workerIndex}`);
+                        logger_1.logger.log(`No provider/session for worker ${workerIndex}, skipping video`);
+                        return;
                     }
                     if (!this.providerSupportsVideo(providerName)) {
                         return; // Nothing to do here

package/dist/tests/reporter.spec.js

@@ -263,4 +263,45 @@ let VideoDownloader;
         (0, vitest_1.expect)(downloadVideoMock).not.toHaveBeenCalled();
         (0, vitest_1.expect)(testResult.attachments).toEqual([]);
     });
+    (0, vitest_1.test)("skips video gracefully when worker has no session (e.g., skipped test)", async () => {
+        vitest_1.vi.useFakeTimers();
+        mockBasePath = await promises_1.default.mkdtemp(path_1.default.join(os_1.default.tmpdir(), "appwright-videos-"));
+        const workerIndex = 1;
+        // Worker info exists but has no providerName or sessionId
+        // (worker was assigned but test was skipped before session creation)
+        await promises_1.default.writeFile(path_1.default.join(mockBasePath, `worker-info-${workerIndex}.json`), JSON.stringify({
+            idx: workerIndex,
+            startTime: {
+                beforeAppiumSession: new Date().toISOString(),
+                afterAppiumSession: new Date().toISOString(),
+            },
+            tests: [],
+        }, null, 2));
+        const { logger } = await import("../logger.js");
+        // Clear any state from previous tests
+        vitest_1.vi.mocked(logger.error).mockClear();
+        vitest_1.vi.mocked(logger.log).mockClear();
+        const reporter = new VideoDownloader();
+        const testCase = {
+            id: "test-skipped",
+            title: "skipped test on worker without session",
+            annotations: [],
+        };
+        const testResult = {
+            workerIndex,
+            duration: 100,
+            startTime: new Date(),
+            attachments: [],
+        };
+        reporter.onTestEnd(testCase, testResult);
+        await vitest_1.vi.advanceTimersByTimeAsync(5000);
+        await reporter.onEnd();
+        // Should not attempt to download any video
+        (0, vitest_1.expect)(downloadVideoMock).not.toHaveBeenCalled();
+        (0, vitest_1.expect)(testResult.attachments).toEqual([]);
+        // Should NOT log an error (previously threw and was caught as error)
+        (0, vitest_1.expect)(logger.error).not.toHaveBeenCalled();
+        // Should log an informational skip message
+        (0, vitest_1.expect)(logger.log).toHaveBeenCalledWith(vitest_1.expect.stringContaining("skipping video"));
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@samsara-dev/appwright",
-  "version": "0.9.9",
+  "version": "0.9.10",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"